Re: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-11-29 Thread Roger Riggs
Kejriwal ; nio-...@openjdk.java.net *Cc:* core-libs-dev *Subject:* Re: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file Hi, In ZipFileSystem.java, at 1071.  - The code will be more readable if you use character literal '/' instead of 47.  - Save making

RE: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-11-29 Thread Deepak Kejriwal
:15 AM To: Deepak Kejriwal ; nio-...@openjdk.java.net Cc: core-libs-dev Subject: Re: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file   Hi, In ZipFileSystem.java, at 1071.  - The code will be more readable if you use character literal '/' instead of 47.  - Save

Re: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-11-27 Thread Lance Andersen
pak Kejriwal > wrote: > > Hi nio-dev team, > > > > Gentle reminder for review of below fix. > > > > Regards, > > Deepak > > > > From: Deepak Kejriwal > Sent: Thursday, November 8, 2018 12:17 AM > To: 'nio-...@openjdk.java.net

Re: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-11-27 Thread Roger Riggs
, 2018 12:17 AM To: 'nio-...@openjdk.java.net' Subject: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file Hi all, Please help review the changes for JDK-8199776 to JDK8u:- Master Bug: https://bugs.openjdk.java.net/browse/JDK-8199776 Webrev: http

RE: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-11-27 Thread Deepak Kejriwal
Hi nio-dev team, Gentle reminder for review of below fix. Regards, Deepak From: Deepak Kejriwal Sent: Thursday, November 8, 2018 12:17 AM To: 'nio-...@openjdk.java.net' Subject: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file Hi all

Re: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-09-25 Thread Seán Coffey
-Original Message- From: Deepak Kejriwal Sent: Friday, September 21, 2018 3:26 PM To: core-libs-dev Subject: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file Hi all, Please help review the changes for JDK-8199776 to JDK8u:- Master Bug: https

RE: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-09-24 Thread Deepak Kejriwal
Hi, Gentle reminder for review below fix. Regards, Deepak -Original Message- From: Deepak Kejriwal Sent: Friday, September 21, 2018 3:26 PM To: core-libs-dev Subject: RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file Hi all, Please help review

RFR: JDK-8197398 (zipfs) OutOfMemoryError when talking contents of empty JAR file

2018-09-21 Thread Deepak Kejriwal
Hi all, Please help review the changes for JDK-8199776 to JDK8u:- Master Bug: https://bugs.openjdk.java.net/browse/JDK-8199776 Webrev: http://cr.openjdk.java.net/~rpatil/8199776/webrev.00/ Background:- We have bug JDK-8197398 fixed in jdk 12 where Files.walkFileTree walk