om>;
core-libs-dev
<mailto:core-libs-dev@openjdk.java.net>;jdk-updates-...@openjdk.java.net
<mailto:jdk-updates-...@openjdk.java.net>
Subject: Re: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi Deepak,
I see the following comment is not addressed yet:
&g
Coffey
*Sent:* Thursday, February 21, 2019 2:11 PM
*To:* Deepak Kejriwal ; Naoto Sato
; core-libs-dev
; jdk-updates-...@openjdk.java.net
*Subject:* Re: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Deepak,
this exception message in new test still needs correction:
166
; core-libs-dev ;
jdk-updates-...@openjdk.java.net
Subject: Re: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Deepak,
this exception message in new test still needs correction:
166 "Character.isLetter(int) failed for codepoint &
for review.
Regards,
Deepak
-Original Message-
From: Naoto Sato
Sent: Wednesday, February 20, 2019 11:06 PM
To: Deepak Kejriwal ; Sean Coffey
; core-libs-dev ;
jdk-updates-...@openjdk.java.net
Subject: Re: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi Deepak,
I see the followi
Kejriwal ; Sean Coffey
; core-libs-dev ;
jdk-updates-...@openjdk.java.net
Subject: Re: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi Deepak,
I see the following comment is not addressed yet:
> - Line 163,198: Exception messages are incorrect. they are for
> isJavaIdentifie
RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi Deepak,
Here are my comments to the webrev (other than what Sean pointed out):
TestIsJavaIdentifierMethods.java
- @summary: "testIsJavaLetter" -> "isJavaLetter", "testIsJavaLetterOrDigit" ->
"isJavaLet
To: Deepak Kejriwal ; core-libs-dev
; jdk-updates-...@openjdk.java.net
Subject: Re: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi Deepak,
Here are my comments to the webrev (other than what Sean pointed out):
TestIsJavaIdentifierMethods.java
- @summary: "testIsJavaL
racter is a connecting punctuation character (such
as '_').
- Line 163,198: Exception messages are incorrect. they are for
isJavaIdentifierStart().
Naoto
On 2/19/19 6:15 AM, Deepak Kejriwal wrote:
Correcting typo for release.
From: Deepak Kejriwal
Sent: Tuesday, February 19, 2019 7:42 P
t: Tuesday, February 19, 2019 7:42 PM
To: 'core-libs-dev' ;
'jdk-updates-...@openjdk.java.net'
Subject: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi All,
Please review the backport of the following bug fixes to jdk11u-dev:
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8206
On 19/02/2019 14:25, Aleksey Shipilev wrote:
Hi Deepak,
Please follow the jdk-updates approval process:
https://openjdk.java.net/projects/jdk-updates/approval.html
You need to put appropriate tags at the issues, explain why they are needed,
how the changes apply
(if changes do not apply
ev' ;
> 'jdk-updates-...@openjdk.java.net'
> Subject: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
>
>
>
> Hi All,
>
> Please review the backport of the following bug fixes to jdk11u-dev:
>
> HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8206120"JDK
Correcting typo for release.
From: Deepak Kejriwal
Sent: Tuesday, February 19, 2019 7:42 PM
To: 'core-libs-dev' ;
'jdk-updates-...@openjdk.java.net'
Subject: RFR: JDK11U JDK-8206120, JDK-8211398, JDK-8218915
Hi All,
Please review the backport of the following bug fixes to jdk11u-dev
Hi All,
Please review the backport of the following bug fixes to jdk8u-dev:
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8206120"JDK-8206120 : Add
test cases for lenient Japanese era parsing
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8211398"JDK-8211398 :
Square character
13 matches
Mail list logo
