Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

Hi Nadeesh, This looks good to me. Best regards, -- daniel On 11/13/15 8:42 PM, nadeesh tv wrote: Hi , Please see the updated webrev http://cr.openjdk.java.net/~ntv/8071919/webrev.02/ Thanks and Regards, Nadeesh On 11/13/2015 9:23 PM, Roger Riggs wrote: Hi Nadeesh, One suggestion:

RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

Hi all, Please review a fix for Bug Id -https://bugs.openjdk.java.net/browse/JDK-8071919 Issue - Add java.time.Clock.tickMillis(ZoneId zone) method webrev - http://cr.openjdk.java.net/~ntv/8071919/webrev.01/

Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

Hi Nadeesh, One suggestion: Replace "This clock will always have the other than milli part of nano-of-second field set to zero." Though similar to the other methods, the "other than milli part" is awkward. With: "This clock will always have the nano-of-second field truncated to

Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

Looks good to me thanks Stephen On 13 November 2015 at 11:00, nadeesh tv wrote: > Hi all, > > Please review a fix for Bug Id > -https://bugs.openjdk.java.net/browse/JDK-8071919 > > Issue - Add java.time.Clock.tickMillis(ZoneId zone) method > > webrev -

Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

Hi Gruss, All of the clocks require a ZoneId to produce a well defined time. The method name uses the same pattern as the existing tickSeconds and tickMinutes methods. Roger On 11/13/2015 10:17 AM, e...@zusammenkunft.net wrote: Hello, I find the name rather confusing. I was wondering

Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

Hi , Please see the updated webrev http://cr.openjdk.java.net/~ntv/8071919/webrev.02/ Thanks and Regards, Nadeesh On 11/13/2015 9:23 PM, Roger Riggs wrote: Hi Nadeesh, One suggestion: Replace "This clock will always have the other than milli part of nano-of-second field set to zero."

Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

;scolebou...@joda.org> > To: core-libs-dev <core-libs-dev@openjdk.java.net> > Sent: Fr., 13 Nov. 2015 16:10 > Subject: Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) > method > > Looks good to me > thanks > Stephen > > On 13 November 2

Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

/bernd.eckenfels.net -Original Message- From: Stephen Colebourne <scolebou...@joda.org> To: core-libs-dev <core-libs-dev@openjdk.java.net> Sent: Fr., 13 Nov. 2015 16:10 Subject: Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method Looks good to me thanks Stephen On 13