Re: RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Hi Shilpi, in that case, please make sure to give the test that already covers the IAE a @bug annotation for this issue. Thanks, Michael > Am 27.06.2016 um 17:18 schrieb "shilpi.rast...@oracle.com" > : > > Thanks Michael and Paul for comments!! > > Yes we already

Re: RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Thanks Michael and Paul for comments!! Yes we already have negative test cases which throws IAE. This test i have added to test the scenario where pos is equal to newTpes.size() and skip is equal to target.type.parameterList.size(). (positive) Best Regards, Shilpi On 6/27/2016 6:42 PM, Paul

Re: RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Hi, > On 27 Jun 2016, at 14:22, shilpi.rast...@oracle.com wrote: > > Hi All, > > Please review fix for > > https://bugs.openjdk.java.net/browse/JDK-8158169 > http://cr.openjdk.java.net/~srastogi/8158169/webrev.00/ > The test you added is not testing the constraints you added to the

Re: RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Hi Shilpi, thumbs up, with one remark (see below). It seems this change would require CCC approval; please take care of the process. I will be happy to sponsor the push thereafter. Remark: how about adding negative tests? The documentation change specifies under what circumstances IAE will be

RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8158169 http://cr.openjdk.java.net/~srastogi/8158169/webrev.00/ Thanks, Shilpi