Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-14 Thread Mandy Chung
> On Apr 14, 2016, at 10:38 AM, Chris Hegarty wrote: > > Mandy, > > The webrev has been updated in-place > http://cr.openjdk.java.net/~chegar/8137058/ > http://cr.openjdk.java.net/~chegar/8137058/jdk_incremental.diffs > Looks good. Thanks for making the change.

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-14 Thread Chris Hegarty
Mandy, The webrev has been updated in-place http://cr.openjdk.java.net/~chegar/8137058/ http://cr.openjdk.java.net/~chegar/8137058/jdk_incremental.diffs All 'core', 'pit', and 'hotspot' testsets have been successfully run on Mac, Linux, Windows, and Solaris. On 13 Apr 2016, at 18:43, Mandy

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Chris Hegarty
> On 13 Apr 2016, at 19:03, Paul Benedict wrote: > > Since getCallerClass will be removed in 10, @Deprecated should also have its > condemned=true `condemned` was renamed to `forRemoval` [1]. getCallerClass, in fact the whole class, will have `forRemoval=true`.

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Kevin Rushforth
Hi, Chris Hegarty wrote: Mandy, On 13/04/16 18:15, Mandy Chung wrote: On Apr 13, 2016, at 8:43 AM, Chris Hegarty wrote: This review is for the second significant part of the changes for JEP 260 [1]. When created, the jdk.unsupported module [2] initially

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Joel Borggrén-Franck
Hi Chris, FWIW changes looks good to me. cheers /Joel On Wed, 13 Apr 2016 at 17:43 Chris Hegarty wrote: > This review is for the second significant part of the changes for JEP > 260 [1]. When created, the jdk.unsupported module [2] initially > contained the sun.misc

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Paul Benedict
Since getCallerClass will be removed in 10, @Deprecated should also have its condemned=true Cheers, Paul On Wed, Apr 13, 2016 at 12:43 PM, Mandy Chung wrote: > > > On Apr 13, 2016, at 10:28 AM, Chris Hegarty > wrote: > > > > Mandy, > > > > On

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Mandy Chung
> On Apr 13, 2016, at 10:28 AM, Chris Hegarty wrote: > > Mandy, > > On 13/04/16 18:15, Mandy Chung wrote: >> >>> On Apr 13, 2016, at 8:43 AM, Chris Hegarty wrote: >>> >>> This review is for the second significant part of the changes for

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Mandy Chung
> On Apr 13, 2016, at 8:43 AM, Chris Hegarty wrote: > > This review is for the second significant part of the changes for JEP > 260 [1]. When created, the jdk.unsupported module [2] initially > contained the sun.misc package. This issue is will move all the >

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Chris Hegarty
On 13/04/16 16:59, Alan Bateman wrote: On 13/04/2016 16:43, Chris Hegarty wrote: This review is for the second significant part of the changes for JEP 260 [1]. When created, the jdk.unsupported module [2] initially contained the sun.misc package. This issue is will move all the non-Critical

Re: RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Alan Bateman
On 13/04/2016 16:43, Chris Hegarty wrote: This review is for the second significant part of the changes for JEP 260 [1]. When created, the jdk.unsupported module [2] initially contained the sun.misc package. This issue is will move all the non-Critical APIs out of sun.reflect, leaving only the

RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

2016-04-13 Thread Chris Hegarty
This review is for the second significant part of the changes for JEP 260 [1]. When created, the jdk.unsupported module [2] initially contained the sun.misc package. This issue is will move all the non-Critical APIs out of sun.reflect, leaving only the critical ones, at which point sun.reflect