Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

All, I'll sponsor this. Best, Michael > Am 19.02.2016 um 12:37 schrieb Paul Sandoz : > > >> On 19 Feb 2016, at 06:32, shilpi.rast...@oracle.com wrote: >> >> Hi All, >> >> Please see the updated webrev >> http://cr.openjdk.java.net/~srastogi/8144931/webrev.03/ >> >

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

> On 19 Feb 2016, at 06:32, shilpi.rast...@oracle.com wrote: > > Hi All, > > Please see the updated webrev > http://cr.openjdk.java.net/~srastogi/8144931/webrev.03/ > +1 Paul.

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Looks good. Best regards, Vladimir Ivanov On 2/19/16 8:32 AM, shilpi.rast...@oracle.com wrote: Please see the updated webrev http://cr.openjdk.java.net/~srastogi/8144931/webrev.03/

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Hi All, Please see the updated webrev http://cr.openjdk.java.net/~srastogi/8144931/webrev.03/ Regards, Shilpi On 2/18/2016 8:33 PM, Paul Sandoz wrote: On 18 Feb 2016, at 15:55, Vladimir Ivanov wrote: P.S.: You could improve the assertion with the Type class,

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

> On 18 Feb 2016, at 15:55, Vladimir Ivanov > wrote: > >> P.S.: You could improve the assertion with the Type class, so it would also >> fail on otherwise broken descriptor strings (missing "L" or missing ";"): > I like how it shapes out with Type. Thanks, Uwe! >

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

P.S.: You could improve the assertion with the Type class, so it would also fail on otherwise broken descriptor strings (missing "L" or missing ";"): I like how it shapes out with Type. Thanks, Uwe! Best regards, Vladimir Ivanov static boolean checkClassName(String cn) { Type

RE: RFR 8144931: Assert class signatures are correct and refer to valid classes

Hi, Thanks! I was expecting something like this. You just want to check the class name in an assertion - that’s fine. Kind regards, Uwe P.S.: You could improve the assertion with the Type class, so it would also fail on otherwise broken descriptor strings (missing "L" or missing ";"):

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Hi Uwe Not a stupid question. We took the conservative approach to preserve the existing costs (avoid linkage and string generation). Paul. > On 18 Feb 2016, at 14:54, Uwe Schindler wrote: > > Hi, > > just a stupid question from somebody outside the OpenJDK

RE: RFR 8144931: Assert class signatures are correct and refer to valid classes

Hi, just a stupid question from somebody outside the OpenJDK developers: You are already using ASM to generate the class files. Why not also use the Type class in ASM to generate the signatures of a class constant?: Instead of: static final String LF_HIDDEN_SIG =

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

> On 18 Feb 2016, at 12:18, shilpi.rast...@oracle.com wrote: > > Thank You Vladimir! > > I have done the changes. Please review the updated patch- > > http://cr.openjdk.java.net/~srastogi/8144931/webrev.02/ > Looking good. There are also a few other cases in InvokerBytecodeGenerator you can

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Reviewed. Best regards, Vladimir Ivanov On 2/18/16 2:18 PM, shilpi.rast...@oracle.com wrote: Thank You Vladimir! I have done the changes. Please review the updated patch- http://cr.openjdk.java.net/~srastogi/8144931/webrev.02/ Regards, Shilpi On 2/18/2016 1:58 PM, Vladimir Ivanov wrote:

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Thank You Vladimir! I have done the changes. Please review the updated patch- http://cr.openjdk.java.net/~srastogi/8144931/webrev.02/ Regards, Shilpi On 2/18/2016 1:58 PM, Vladimir Ivanov wrote: Shilpi, _CLASS suffix looks redundant and you can abbreviate LAMBDA_FORM to LF: LF_HIDDEN_SIG

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Shilpi, _CLASS suffix looks redundant and you can abbreviate LAMBDA_FORM to LF: LF_HIDDEN_SIG LF_COMPILED_SIG FORCEINLINE_SIG DONTINLINE_SIG Otherwise, looks fine. Best regards, Vladimir Ivanov On 2/17/16 5:47 PM, shilpi rastogi wrote: Hi All, Please review fix for the following

RFR 8144931: Assert class signatures are correct and refer to valid classes

Hi All, Please review fix for the following bug- https://bugs.openjdk.java.net/browse/JDK-8144931 http://cr.openjdk.java.net/~srastogi/8144931/webrev.01/ Thanks, Shilpi