Re: Review Request: JDK-8211921,,AssertionError in MethodHandles$Lookup.defineClass

2018-10-10 Thread Mandy Chung
On 10/10/18 1:41 PM, Alan Bateman wrote: On 10/10/2018 21:38, Mandy Chung wrote: : This assertion is not strictly necessary and test/jdk/java/lang/invoke/DefineClassTest.java verifies these properties of the resulting Class.  I propose to remove this assertion. An alternative is to just

Re: Review Request: JDK-8211921,,AssertionError in MethodHandles$Lookup.defineClass

2018-10-10 Thread Alan Bateman
On 10/10/2018 21:38, Mandy Chung wrote: : This assertion is not strictly necessary and test/jdk/java/lang/invoke/DefineClassTest.java verifies these properties of the resulting Class.  I propose to remove this assertion. An alternative is to just drop the PD check from the assertion, the

Review Request: JDK-8211921,,AssertionError in MethodHandles$Lookup.defineClass

2018-10-10 Thread Mandy Chung
The assertion in Lookup::defineClass ensures that the resulting Class is defined with the same loader in the same package in the same protection domain as the lookup class.  When a class is defined to the boot loader, its protection domain is set to null which implies AllPermission but