Re: RFR: 8047724: @since tag cleanup in jaxws

2014-06-30 Thread Alan Bateman
On 30/06/2014 02:30, Henry Jen wrote: Ping. Cheers, Henry Henry - the code in the jaxws repository is maintained upstream. If you change it in the jaxws repository then the changes will likely get overridden at the next sync-up. I'd suggest working with Miroslav (cc'ed) to get the changes

Re: Long valueOf instead of new Long

2014-06-30 Thread Andrej Golovnin
Hi Otávio, About Andrej, is it not possible add two people in Contributed-by: tag? Thanks! But it's not needed. It's your contribution. I just help to review the changes. Best regards, Andrej Golovnin

Re: Streams and Spliterator characteristics confusion

2014-06-30 Thread Paul Sandoz
On Jun 28, 2014, at 5:40 PM, Kasper Nielsen kaspe...@gmail.com wrote: s.distinct().spliterator() - Spliterator.DISTINCT = true but limiting the number of distinct elements makes the stream non distinct s.distinct().limit(10).spliterator() - Spliterator.DISTINCT = false I don't observe

Re: Long valueOf instead of new Long

2014-06-30 Thread Pavel Rappo
I've updated the webrev. It includes all the changes we've discussed so far plus these: http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/macosx/classes/sun/font/CStrike.java.sdiff.html

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

2014-06-30 Thread Lance Andersen
On Jun 30, 2014, at 3:22 PM, huizhe wang huizhe.w...@oracle.com wrote: On 6/30/2014 12:20 PM, Lance Andersen wrote: Looks OK Joe, noticed the @since changed as well? Thanks for review. Yes. The support for DOM L3 was since JDK 1.5. Previously this package file mentioned only DOM

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

2014-06-30 Thread Henry Jen
On 06/30/2014 12:26 PM, Lance Andersen wrote: On Jun 30, 2014, at 3:22 PM, huizhe wang huizhe.w...@oracle.com wrote: On 6/30/2014 12:20 PM, Lance Andersen wrote: Looks OK Joe, noticed the @since changed as well? Thanks for review. Yes. The support for DOM L3 was since JDK 1.5.

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

2014-06-30 Thread huizhe wang
On 6/30/2014 1:16 PM, Lance @ Oracle wrote: Hi joe, Should be a comma at the end of line 8 before the and on line 9 comma added. Looks ok otherwise I committed the change. Thanks again Lance and Henry! -Joe Best Lance http://oracle.com/us/design/oracle-email-sig-198324.gifLance

RFR: 8023276: Java SE should include the full DOM API from JAXP

2014-06-30 Thread huizhe wang
Hi, Three packages are missing from the DOM API documentation in JAXP: org.w3c.dom.views org.w3c.dom.ranges org.w3c.dom.traversal We added org.w3c.dom.views in JAXP 1.6 and fixed JDK-8006843. But since we were too close to the deadline for JAXP 1.6 MR, we left the other

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Christian Thalinger
On Jun 30, 2014, at 1:06 PM, Coleen Phillimore coleen.phillim...@oracle.com wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents

Re: RFR: 8023276: Java SE should include the full DOM API from JAXP

2014-06-30 Thread Mandy Chung
On 6/30/14 2:32 PM, huizhe wang wrote: Hi, Three packages are missing from the DOM API documentation in JAXP: org.w3c.dom.views org.w3c.dom.ranges org.w3c.dom.traversal We added org.w3c.dom.views in JAXP 1.6 and fixed JDK-8006843. But since we were too close to the

Re: RFR: 8023276: Java SE should include the full DOM API from JAXP

2014-06-30 Thread huizhe wang
Thanks Mandy, Lance. The changeset is pushed. -Joe On 6/30/2014 5:02 PM, Mandy Chung wrote: On 6/30/14 2:32 PM, huizhe wang wrote: Hi, Three packages are missing from the DOM API documentation in JAXP: org.w3c.dom.views org.w3c.dom.ranges org.w3c.dom.traversal We

Re: RFR 8048840: File.createTempFile has uninformative failure message

2014-06-30 Thread Jeremy Manson
Oops - forgot to run jtreg. Make that: diff --git a/src/share/classes/java/io/File.java b/src/share/classes/java/io/File.java --- a/src/share/classes/java/io/File.java +++ b/src/share/classes/java/io/File.java @@ -1998,7 +1998,8 @@ throws IOException { if (prefix.length()

Re: RFR 8048840: File.createTempFile has uninformative failure message

2014-06-30 Thread Bernd
Hello, Do you think this fixes the complaints? I can imagine that or ~ is used, and including this in the exception does not really help. Prefix string too short, must be 3 characters would be my choice, but I wonder if the restriction is very usefull anyway? Bernd Am 01.07.2014 03:17 schrieb

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Christian Thalinger
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore coleen.phillim...@oracle.com wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents