Re: RFR:8134928:java.time.Instant.truncatedTo(TemporalUnit unit) is truncating up if the year < 1970

2015-10-19 Thread nadeesh tv
HI all, Please review the updated webrev http://cr.openjdk.java.net/~ntv/8134928/webrev.01/ Regards, Nadeesh On 10/14/2015 4:06 PM, Stephen Colebourne wrote: I'd like to see an additional test case for the cases where rounding is *not* needed. Currently, there are only tests for where rounding

Re: JEP 276: Dynamic Linking of Language-Defined Object Models

2015-10-19 Thread Jochen Theodorou
On 18.10.2015 10:55, Andrew Haley wrote: On 10/18/2015 09:49 AM, Jochen Theodorou wrote: * Invokedynamic (like invokeinterface and invokevirtual) does not like calls with null as receiver, quitting the call right away with a NPE. But languages may allow for calls on null. That again means some

Re: JEP 276: Dynamic Linking of Language-Defined Object Models

2015-10-19 Thread Jochen Theodorou
On 19.10.2015 03:09, John Rose wrote: On Oct 18, 2015, at 1:49 AM, Jochen Theodorou > wrote: * Invokedynamic (like invokeinterface and invokevirtual) does not like calls with null as receiver :-) Jochen, you are one of the few people on the planet

Re: JEP 276: Dynamic Linking of Language-Defined Object Models

2015-10-19 Thread Attila Szegedi
On Oct 19, 2015, at 10:46 AM, Jochen Theodorou wrote: > since it is dynalink there is I guess only one master linker in the end. Can > you point me to some code showing how the composition of linkers is done to > refresh my memory on that? Sure, here’s how Nashorn does it:

Re: JEP 276: Dynamic Linking of Language-Defined Object Models

2015-10-19 Thread Martijn Verburg
Hi Attila, Cool, reached out to a few people (Scala & Clojure in particular) JIC they missed it and pointed them directly at the JEP and this thread. I think the API will be all the richer when it hits its 2nd real enemy (so to speak) :-). Cheers, Martijn On 18 October 2015 at 21:57, Attila

RE: RFC: draft API for JEP 269 Convenience Collection Factories

2015-10-19 Thread Timo Kinnunen
Having one less import-statement that has to be written -- while editing a file -- by Content Assist/IntelliSense/Code Completion is a small improvement, but apart from that going from: ArrayList als = new ArrayList<>(Arrays.asList("a", "b", "c")); to: ArrayList als = new

RE: RFC: draft API for JEP 269 Convenience Collection Factories

2015-10-19 Thread Timo Kinnunen
They are warnings in Eclipse and IntelliJ IDEA: “The static method foo() from the type A should be accessed directly” “The static method foo() from the type A should be accessed in a static way” “The static method foo() from the type A should be accessed directly” “Static method 'foo()' declared

Re: JDK 9 RFR of JDK-8139925 Problem list LFMultiThreadCachingTest.java on windows

2015-10-19 Thread Roger Riggs
+1 On 10/19/2015 3:43 PM, joe darcy wrote: Hello, Please review the fix below to address JDK-8139925: Problem list LFMultiThreadCachingTest.java on windows The test in question, test/java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java suffers from a continuing low-frequency

Re: JDK 9 RFR of JDK-8139925 Problem list LFMultiThreadCachingTest.java on windows

2015-10-19 Thread Chris Hegarty
Looks fine Joe. -Chris. > On 19 Oct 2015, at 8:43 p.m., joe darcy wrote: > > Hello, > > Please review the fix below to address > >JDK-8139925: Problem list LFMultiThreadCachingTest.java on windows > > The test in question, > >

JDK 9 RFR of JDK-8139925 Problem list LFMultiThreadCachingTest.java on windows

2015-10-19 Thread joe darcy
Hello, Please review the fix below to address JDK-8139925: Problem list LFMultiThreadCachingTest.java on windows The test in question, test/java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java suffers from a continuing low-frequency intermittent failure on windows due to

Re: RFR: JDK-8046565: Platform Logger API and Service

2015-10-19 Thread Daniel Fuchs
Hi Mandy, I have updated the links with the modifications we discussed last Friday: - I have removed the tag @apiNote from System.LoggerFinder - I have relaxed the constraint of what happens if several implementations of LoggerFinder are present - the specification no longer mandate

Re: RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-19 Thread Christian Thalinger
> On Oct 19, 2015, at 8:09 AM, Bob Vandette wrote: > > Here’s the updated set of webrev’s that address two issues: > > 1. Move jni_util.h out of jawt.h > 2. Christians concern over using a single variable name for Makefile and > C/C++ logic. Thanks. Looks good to