JDK 10 RFR 8182620, Problem list java/lang/String/nativeEncoding/StringPlatformChars.java for JDK-8182569

Hi there, please review a patch to problem list java/lang/String/nativeEncoding/StringPlatformChars.java temporarily. It has been failing in some test setup with "Error. Use -nativepath to specify the location of native code". Bug: https://bugs.openjdk.java.net/browse/JDK-8182620

Re: [10] RFR: 8182487: Add Unsafe.objectFieldOffset(Class, String)

On 06/20/2017 06:14 AM, Claes Redestad wrote: it felt reasonable to simplify the code to consistently throw InternalError and remove a number of distracting try-catch blocks. With the try-catches gone, it looks like quite a few static fields could now be initialized inline, and the static

Re: [10] RFR: 8182487: Add Unsafe.objectFieldOffset(Class, String)

> On Jun 20, 2017, at 3:14 AM, Claes Redestad wrote: > > Hi, > > as a startup optimization, we can avoid a number of reflective operations on > variouscore classes by adding a specialized objectFieldOffset method taking > Class and String rather than Field: > >

Re: RFR(S) : 8182565 : remove jdk.testlibrary.Utils::tryFindJvmPid and waitForJvmPid methods

Hi Igor, No particular objection to removing these. It would be less overhead to change the tests that use this jdk.testlibrary.Utils to use the top level utils and then just remove the whole file. Whittling away at these will create a lot of intermediate webrevs. Roger On 6/19/17 7:47

Re: RFR(jdk10/jaxp) 8177561: Remove deprecated for removal portions of com.sun.org.apache

Hi Joe, This looks fine. I checked the repository and this seems to be a complete list. are any makefile changes needed? > On Jun 20, 2017, at 1:58 PM, huizhe wang wrote: > > Hi, > > Please review the removal of the internal Catalog packages: > > JBS:

RFR(jdk10/jaxp) 8177561: Remove deprecated for removal portions of com.sun.org.apache

Hi, Please review the removal of the internal Catalog packages: JBS: https://bugs.openjdk.java.net/browse/JDK-8177561 webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8177561/webrev/ Thanks, Joe

Re: JDK 10 RFR of JDK-8181575: Refactor locale related shell test java/nio/charset/spi/basic.sh to java

+1 Paul. > On 20 Jun 2017, at 00:50, Amy Lu wrote: > > webrev updated, waiting for +1 > > http://cr.openjdk.java.net/~amlu/8181575/webrev.01/ > > Thanks, > Amy > > On 6/20/17 2:46 AM, Paul Sandoz wrote: >> Minor stuff below, no need for another round from me. > Thank you

Re: JDK 10 RFR of JDK-8182465: Refactor shell test java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh to java

On 20/06/2017 08:50, Amy Lu wrote: java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8182465 webrev: http://cr.openjdk.java.net/~amlu/8182465/webrev.00/ I think it

Re: JDK 10 RFR of JDK-8182376: Refactor shell test Refactor shell test java/nio/file/Path/MacPathTest.sh to java

On 20/06/2017 09:10, Amy Lu wrote: java/nio/file/Path/MacPathTest.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8182376 webrev: http://cr.openjdk.java.net/~amlu/8182376/webrev.00/ This looks good but we will need to re-visit this

[10] RFR: 8182487: Add Unsafe.objectFieldOffset(Class, String)

Hi, as a startup optimization, we can avoid a number of reflective operations on variouscore classes by adding a specialized objectFieldOffset method taking Class and String rather than Field: Webrev: https://bugs.openjdk.java.net/browse/JDK-8182487 Hotspot:

JDK 10 RFR of JDK-8182376: Refactor shell test Refactor shell test java/nio/file/Path/MacPathTest.sh to java

java/nio/file/Path/MacPathTest.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8182376 webrev: http://cr.openjdk.java.net/~amlu/8182376/webrev.00/ Thanks, Amy

Re: JDK 10 RFR of JDK-8181575: Refactor locale related shell test java/nio/charset/spi/basic.sh to java

webrev updated, waiting for +1 http://cr.openjdk.java.net/~amlu/8181575/webrev.01/ Thanks, Amy On 6/20/17 2:46 AM, Paul Sandoz wrote: Minor stuff below, no need for another round from me. Thank you Paul !

JDK 10 RFR of JDK-8182465: Refactor shell test java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh to java

java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8182465 webrev: http://cr.openjdk.java.net/~amlu/8182465/webrev.00/ (run_tests.sh is a @key intermittent test due to