On 20/11/2018 05:38, Nick Gasson wrote:
Hi,
Could someone please review this small patch?
Bug: https://bugs.openjdk.java.net/browse/JDK-8214078
Webrev: http://cr.openjdk.java.net/~njian/8214078/webrev.0/
This fixes a failure of the java/nio/file/DirectoryStream/SecureDS.java
Jtreg test on
Hi,
Any feedback on improving Java Sort API ?
PS: I improved a lot the Array benchmark accuracy (confidence interval ~
5%). Here are EA results:
https://github.com/bourgesl/nearly-optimal-mergesort-code/blob/master/results/basher-results-partial.out
Does anybody want to help me on this topic ?
Hi Igor,
I have updated the bugs to avoid review confusion, patch is not changed.
Thank you
-Hamlin
On 2018/11/15 9:36 AM, Igor Ignatyev wrote:
Hi Hamlin,
Although I understand your reasoning, I do share Amy's concerns on doing less
than the RFEs ask for (as w/ 8211972). so I'd suggest you
Hi,
Could someone please review this small patch?
Bug: https://bugs.openjdk.java.net/browse/JDK-8214078
Webrev: http://cr.openjdk.java.net/~njian/8214078/webrev.0/
This fixes a failure of the java/nio/file/DirectoryStream/SecureDS.java
Jtreg test on ARM32.
Glibc by design does not expose
From: Andrew Dinn
> I have to ask the obvious: Why does the question matter?
I'm trying to figure out if something is a bug in HashMap in the JDK, or in
Weld :D
The case in question is basically, a HashMap is created, and then the keys are
iterated over concurrently.
The issue here though is
Hi,
Webrev updated in place:
http://cr.openjdk.java.net/~rriggs/webrev-props-only-raw
On 11/16/2018 06:36 PM, Mandy Chung wrote:
Hi Roger,
Looking good. I have a few small comments:
I assume VM.saveAndRemoveProperties will be a separate cleanup.
SystemProps::cmdProperties adds the
Hi Florian,
The performance gain that I reported was over the earlier implementation of
GHASH using clmul instructions (generate_ghash_process_blocks).
Regards,
Smita
-Original Message-
From: Florian Weimer [mailto:fwei...@redhat.com]
Sent: Monday, November 19, 2018 1:55 PM
To:
Hi everybody,
There are already JMH crypto micros in the open corpus (a maven project):
http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/fc4783360f58/src/main/java/org/openjdk/bench/javax/crypto
that should be able to measure the benefit of this webrev against the
existing
Hello,
What is the purpose of setting some of them to 0 twice? (It’s a new array which
should be all-0 anyway.)
+ for (int i = 1; i < 9 ; i++) {
+subkeyHtbl[2*i] = 0;
+subkeyHtbl[2*i+1] = 0;
+}
Also, is the subkeyH no longer be needed (or can be redesigned
Seems OK joe
> On Nov 19, 2018, at 4:04 PM, Joe Wang wrote:
>
> Hi,
>
> Please review a test patch below. The main change is removing the references
> to openjdk.java.net. Since the Catalog feature sits above the default
> resolution of external resources, there is no need for the tests to
* Smita Kamath:
> I'd like to contribute an optimization for GHASH Algorithm using AVX
> Instructions. I have tested this optimization on SKX x86_64 platform
> and it shows ~20-30% performance improvement for larger message sizes
> (for example 8k).
Performance improvement against what? The
On 20/11/2018 6:39 am, Kim Barrett wrote:
On Nov 19, 2018, at 7:56 AM, David Holmes wrote:
On 19/11/2018 5:04 pm, Kim Barrett wrote:
On Nov 19, 2018, at 1:31 AM, David Holmes wrote:
Hi Kim,
On 16/11/2018 12:31 pm, Kim Barrett wrote:
This doesn't strike me as a JEP that actually integrates
Hi,
Please review a test patch below. The main change is removing the
references to openjdk.java.net. Since the Catalog feature sits above the
default resolution of external resources, there is no need for the tests
to depend on a real/live domain to test the feature that
enables/disables
Hi Vladimir,
I'd like to contribute an optimization for GHASH Algorithm using AVX
Instructions. I have tested this optimization on SKX x86_64 platform and it
shows ~20-30% performance improvement for larger message sizes (for example 8k).
I,
> On Nov 19, 2018, at 7:56 AM, David Holmes wrote:
>
> On 19/11/2018 5:04 pm, Kim Barrett wrote:
>>> On Nov 19, 2018, at 1:31 AM, David Holmes wrote:
>>>
>>> Hi Kim,
>>>
>>> On 16/11/2018 12:31 pm, Kim Barrett wrote:
>>>
>>> This doesn't strike me as a JEP that actually integrates anything.
Hi Nishit,
On 11/18/18 10:29 PM, Nishit Jain wrote:
Hi Naoto,
Please check my comments inline.
On 17-11-2018 04:52, naoto.s...@oracle.com wrote:
Hi Nishit,
Here are my comments:
- CLDRConverter: As the compact pattern no more employs List,
can we eliminate stringListEntry/Element, and use
Hi Adam,
could you please include link to the JBS issue and either link to the
patch/webrev or link to the webrev, or at the very least the patch
verbatim?
As for the issue itself: could you please elaborate why this fails with xlc13?
Also, a real patch would be helpful instead here of yet
Hi Adam,
As a convenience to the numerous developers in OpenJDK please include
a link to the issue and the changes when sending a request for review.
It makes things go much smoother. An in-line patch may be more
convenient in this case.
Also note that *only* changes using the OpenJDK aliases
Hi All
Both the problem and the solution appear straight-forward enough.
Details included in the bug description.
Thoughts and opinions welcome.
Best Regards
Adam Farley
IBM Runtimes
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
Thanks Sundar. Here is the CSR:
https://bugs.openjdk.java.net/browse/JDK-8213915
Mandy
On 11/19/18 6:48 AM, Sundararajan Athijegannathan wrote:
Looks good to me.
-Sundar
On 15/11/18, 5:46 AM, Mandy Chung wrote:
This patch improves `jdeps --print-module-deps`, `--list-deps` and
Hi there,
I just read Java 8 - Lambdas, Streams, Default Methods | Baeldung, I've shown
it to some colleagues and we think a collaboration between us could work well.
I represent a digital marketing agency currently working with a leading
technology company who operates in the same
On 19/11/2018 16:01, Michael Rasmussen wrote:
> As the topic asks, should calling computeIfAbsent on a HashMap with
> an existing key be a structural modification?
I have to ask the obvious: Why does the question matter?
Are you just dipping a toe into the cold and briny realm of language
Hi
As the topic asks, should calling computeIfAbsent on a HashMap with an existing
key be a structural modification?
The documentation for HashMap has the following note regarding concurrency:
A structural modification is any operation that adds or deletes one or more
mappings; merely changing
Thanks, Rémi and Alan.
On 11/19/18 12:53 AM, Alan Bateman wrote:
On 18/11/2018 20:00, Richard Hillegas wrote:
I am updating Apache Derby documentation to reflect the recent
modularization of the codeline. While doing this, I have stumbled
across an old piece of advice from the Derby Tuning
Looks good to me.
-Sundar
On 15/11/18, 5:46 AM, Mandy Chung wrote:
This patch improves `jdeps --print-module-deps`, `--list-deps` and
`--list-reduced-deps` to report missing dependences and also do
transitive
dependence analysis as the default.
Webrev at:
On 16/11/2018 07:00, Priya Lakshmi Muthuswamy wrote:
Hi,
Kindly review the fix for
https://bugs.openjdk.java.net/browse/JDK-8213920
webrev: http://cr.openjdk.java.net/~pmuthuswamy/8213920/webrev.00/
This looks good, and I assume the first of many changes to make use of
@systemProperty.
I'm not a big fan of having a class named `Style` as it is commonly used in
business logic. (Yes, its an inner class, but I still think the potential
for annoyance is high). java.time.* has `TextStyle`, but I don't think it
can be reused here. Maybe the class should be honest and called
On 19/11/2018 5:04 pm, Kim Barrett wrote:
On Nov 19, 2018, at 1:31 AM, David Holmes wrote:
Hi Kim,
On 16/11/2018 12:31 pm, Kim Barrett wrote:
On Oct 3, 2018, at 3:13 PM, Kim Barrett wrote:
I've submitted a JEP for
(1) enabling the use of C++14 Language Features when building the JDK,
(2)
On 2018-11-16 21:36, Erik Joelsson wrote:
Thanks, looks good to me now.
And to me.
Looks like a nice cleanup in general!
/Magnus
/Erik
On 2018-11-16 12:02, Roger Riggs wrote:
Hi Erik,
Yes, that is removed.
Webrev updated in place.
Thanks, Roger
Hi Ali,
The fix looks good to me provided it resolves your problem.
I am not a reviewer so you'll have to get OK from reviewers, likely from
build-dev and from core-libs.
Have you submitted the issue in JBS?
You have to sign OCA to be able to contribute to OpenJDK:
On 18/11/2018 20:00, Richard Hillegas wrote:
I am updating Apache Derby documentation to reflect the recent
modularization of the codeline. While doing this, I have stumbled
across an old piece of advice from the Derby Tuning Guide:
"The structure of your classpath can affect Derby startup
On Mon, Nov 19, 2018 at 9:00 AM Kim Barrett wrote:
>
> > On Nov 19, 2018, at 2:04 AM, Kim Barrett wrote:
> >
> >> On Nov 19, 2018, at 1:31 AM, David Holmes wrote:
> >> I think it is important that all the port owners buy into this.
> >
> > At least one port (aix_ppc) presently seems to have no
> On Nov 19, 2018, at 2:04 AM, Kim Barrett wrote:
>
>> On Nov 19, 2018, at 1:31 AM, David Holmes wrote:
>> I think it is important that all the port owners buy into this.
>
> At least one port (aix_ppc) presently seems to have no way to support this
> change, because
> the compiler being used
33 matches
Mail list logo
