Re: [12] RFR JDK-8214241: Problem list com/sun/jndi/ldap/LdapTimeoutTest.java on all platforms

Thank you Vyom and Max for your quick review! Pushed. Thanks, Amy On 2018/11/23 12:39 PM, Weijun Wang wrote: On Nov 23, 2018, at 12:10 PM, vyom tewari wrote: looks OK to me. +1. --Max Vyom On 23/11/18 9:28 AM, Amy Lu wrote: Please review the patch to problem list

Re: [12] RFR JDK-8214241: Problem list com/sun/jndi/ldap/LdapTimeoutTest.java on all platforms

> On Nov 23, 2018, at 12:10 PM, vyom tewari wrote: > > looks OK to me. +1. --Max > > Vyom > > On 23/11/18 9:28 AM, Amy Lu wrote: >> Please review the patch to problem list >> com/sun/jndi/ldap/LdapTimeoutTest.java >> >> This test fails frequently, originally observed on linux-x64 but

Re: [12] RFR JDK-8214241: Problem list com/sun/jndi/ldap/LdapTimeoutTest.java on all platforms

looks OK to me. Vyom On 23/11/18 9:28 AM, Amy Lu wrote: Please review the patch to problem list com/sun/jndi/ldap/LdapTimeoutTest.java This test fails frequently, originally observed on linux-x64 but recently also on other platforms, and should be problem listed before JDK-8151678 fixed.

[12] RFR JDK-8214241: Problem list com/sun/jndi/ldap/LdapTimeoutTest.java on all platforms

Please review the patch to problem list com/sun/jndi/ldap/LdapTimeoutTest.java This test fails frequently, originally observed on linux-x64 but recently also on other platforms, and should be problem listed before JDK-8151678 fixed. bug: https://bugs.openjdk.java.net/browse/JDK-8214241

Re: RFR(XXS): 8214161: java.lang.IllegalAccessError: class jdk.internal.event.X509CertificateEvent (in module java.base) cannot access class jdk.jfr.internal.handlers.EventHandler (in module jdk.jfr)

Hi Markus, Thanks for the explanation of the problem. Reviewed. Thanks, David On 23/11/2018 1:01 am, Markus Gronlund wrote: Greetings, Please review the following small fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8214161 Webrev: http://cr.openjdk.java.net/~mgronlun/8214161/webrev01/

-jar option and the modulepath

Can I scribble something in a jar file manifest which will cause "java -jar" to boot with a modulepath rather than a classpath? I do not see any support for a modulepath attribute in the Java 9 jar file documentation at https://docs.oracle.com/javase/9/docs/specs/jar/jar.html. My sense is

Re: RFR: JDK-8214223: tools/jdeps/listdeps/ListModuleDeps.java failed due to missing Lib2 file

On 22/11/2018 18:11, Mandy Chung wrote: This adds test/langtools/tools/jdeps/listdeps/src/lib2/Lib2.java that is missing in the changeset for JDK-8213909. Looks good.

Re: RFR: JDK-8214223: tools/jdeps/listdeps/ListModuleDeps.java failed due to missing Lib2 file

+1 > On Nov 22, 2018, at 1:11 PM, Mandy Chung wrote: > > This adds test/langtools/tools/jdeps/listdeps/src/lib2/Lib2.java > that is missing in the changeset for JDK-8213909. > > Mandy > > diff --git a/test/langtools/tools/jdeps/listdeps/src/lib2/Lib2.java >

RFR: JDK-8214223: tools/jdeps/listdeps/ListModuleDeps.java failed due to missing Lib2 file

This adds test/langtools/tools/jdeps/listdeps/src/lib2/Lib2.java that is missing in the changeset for JDK-8213909. Mandy diff --git a/test/langtools/tools/jdeps/listdeps/src/lib2/Lib2.java b/test/langtools/tools/jdeps/listdeps/src/lib2/Lib2.java new file mode 100644 --- /dev/null +++

Re: RFR(XXS): 8214161: java.lang.IllegalAccessError: class jdk.internal.event.X509CertificateEvent (in module java.base) cannot access class jdk.jfr.internal.handlers.EventHandler (in module jdk.jfr)

Looks good. Erik > On 22 Nov 2018, at 16:01, Markus Gronlund wrote: > > Greetings, > > Please review the following small fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214161 > Webrev: http://cr.openjdk.java.net/~mgronlun/8214161/webrev01/ > > diff -r 0a77b7e41322 -r cec1604a9b89

RFR(XXS): 8214161: java.lang.IllegalAccessError: class jdk.internal.event.X509CertificateEvent (in module java.base) cannot access class jdk.jfr.internal.handlers.EventHandler (in module jdk.jfr) beca

Greetings, Please review the following small fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8214161 Webrev: http://cr.openjdk.java.net/~mgronlun/8214161/webrev01/ diff -r 0a77b7e41322 -r cec1604a9b89 src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp ---

Re: RFR: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

On Thu, Nov 22, 2018 at 3:00 PM Adam Farley8 wrote: > > Hi Volker, > > 1) Here is the "reasonable" code in the generated > jdk_internal_jimage_NativeImageBuffer.h > > -- > /* DO NOT EDIT THIS FILE - it is machine generated */ > #include > /*

Re: RFR: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

Hi Volker, 1) Here is the "reasonable" code in the generated jdk_internal_jimage_NativeImageBuffer.h -- /* DO NOT EDIT THIS FILE - it is machine generated */ #include /* Header for class jdk_internal_jimage_NativeImageBuffer */ #ifndef

Re: 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java

Looks fine Brian Happy Thanksgiving > On Nov 21, 2018, at 5:43 PM, Brian Burkhalter > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8214195 > http://cr.openjdk.java.net/~bpb/8214195/webrev.00/ > > Print statements are different for float and double but should be the same. > > Thanks, >

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

On 22/11/2018 10:54, Nick Gasson wrote: Have you looked at replacing the remaining usages of stat changed to stat64 instead? I've tried this just now and it also resolves the issue. I can test on some more platforms and update the webrev if this is the preferred solution? I'd say this is

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

> >> Have you looked at replacing the remaining usages of stat changed to > >> stat64 instead? > > I've tried this just now and it also resolves the issue. I can > > test on some more platforms and update the webrev if this is the > > preferred solution? > I'd say this is preferred to adding