On Fri, 3 Jun 2022 18:17:55 GMT, Joe Wang wrote:
> Adjust how XPath operators are counted to improve accuracy. This change does
> not affect how XPath works.
>
> Test:
> Tier2 passed;
> JCK XML tests passed.
This pull request has now been integrated.
Changese
> Adjust how XPath operators are counted to improve accuracy. This change does
> not affect how XPath works.
>
> Test:
> Tier2 passed;
> JCK XML tests passed.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision
On Fri, 3 Jun 2022 21:52:08 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review update
>
> src/java.xml/share/classes/com/sun/org/apache/xpath/internal/compiler/Lex
> Adjust how XPath operators are counted to improve accuracy. This change does
> not affect how XPath works.
>
> Test:
> Tier2 passed;
> JCK XML tests passed.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision
On Fri, 3 Jun 2022 21:11:20 GMT, Naoto Sato wrote:
>> Adjust how XPath operators are counted to improve accuracy. This change does
>> not affect how XPath works.
>>
>> Test:
>> Tier2 passed;
>> JCK XML tests passed.
>
>
On Fri, 3 Jun 2022 21:08:04 GMT, Naoto Sato wrote:
>> Adjust how XPath operators are counted to improve accuracy. This change does
>> not affect how XPath works.
>>
>> Test:
>> Tier2 passed;
>> JCK XML tests passed.
>
>
Adjust how XPath operators are counted to improve accuracy. This change does
not affect how XPath works.
Test:
Tier2 passed;
JCK XML tests passed.
-
Commit messages:
- 8285081: Improve XPath operators count accuracy
Changes:
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
>
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
>
JCK XML tests passed
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
update copyright year and LastModified tag
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8910/files
- new: https://git.openjdk.java.ne
Address some insufficiency of error handling in the XPath implementation. Some
cleanup where appropriate, without attempting to do too much as this is an
component that hasn't had much changes for 15 years, a fairly stable
application.
-
Commit messages:
- 8284400: Improve XPath
On Wed, 25 May 2022 17:15:18 GMT, Naoto Sato wrote:
>> Refactoring the leftover self-calculations of the optimized `HashMap`
>> initial value with `newHashMap()` method. Also replaced some string literals
>> using text blocks for better readability. Confirmed that the output resource
>>
On Tue, 17 May 2022 23:40:04 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should revert any files.
Marked
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
This pull request has n
On Mon, 16 May 2022 21:54:52 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> provider description
>
> test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 4
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
Joe Wang has updated the pull request incrementally with one additional comm
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
Thanks Lance.
Yes, I've not
Update to Xerces 2.12.2.
The update also fixes JDK-8144117. Added a test.
Tests: local XML tests passed. Tier2 running. Two JCK tests failed with this
update. See related issue report.
-
Commit messages:
- 8282280: Update Xerces to Version 2.12.2
Changes:
On Mon, 16 May 2022 18:23:23 GMT, Naoto Sato wrote:
> Do not enclose the skara command within backquotes.
Thanks Naoto! I didn't realize that's what he did :-)
-
PR: https://git.openjdk.java.net/jdk/pull/8318
On Mon, 16 May 2022 16:35:16 GMT, Shruthi wrote:
> `/integrate`
There may be sth. with your input, it's not recognized as Git command. Try
again, or copy this command instead.
-
PR: https://git.openjdk.java.net/jdk/pull/8318
On Mon, 16 May 2022 16:26:41 GMT, Shruthi wrote:
> `integrate`
I think you missed slash, it's slash integrate.
-
PR: https://git.openjdk.java.net/jdk/pull/8318
On Fri, 13 May 2022 18:51:47 GMT, Joe Wang wrote:
>> Shruthi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
&
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8706
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
make/jdk/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java
line 1278:
> 1276: state[numCategories]
On Thu, 12 May 2022 18:02:26 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request,
On Thu, 12 May 2022 18:02:26 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request,
On Wed, 11 May 2022 05:22:22 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Wed, 11 May 2022 20:04:39 GMT, Naoto Sato wrote:
>> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
>> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
>> Corresponding CSR is also being drafted.
>
> Naoto Sato has updated the pull
On Wed, 11 May 2022 17:04:41 GMT, Naoto Sato wrote:
>> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
>> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
>> Corresponding CSR is also being drafted.
>
> Naoto Sato has updated the pull
On Tue, 10 May 2022 06:52:00 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Mon, 9 May 2022 07:00:34 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request, and
On Fri, 6 May 2022 14:33:50 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Thu, 5 May 2022 16:13:59 GMT, Naoto Sato wrote:
> Trivial fix to 3rd party copyright notices.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8558
On Fri, 29 Apr 2022 13:31:30 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Fri, 29 Apr 2022 13:31:30 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Wed, 20 Apr 2022 15:37:13 GMT, Shruthi wrote:
> Removing the Duplicate keys present in XSLTErrorResources.java and
> XPATHErrorResources.java
>
> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
On Wed, 20 Apr 2022 20:08:01 GMT, Joe Wang wrote:
> Patch note:
>
> A previous patch had a bug that missed the boundary check, that will cause
> StringIndexOutOfBoundsException to be thrown instead of
> XPathExpressionException as expected.
>
> Fix: the fix is to
ex".
> Objects.checkIndex is removed as it's redundant.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
add the test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8323/files
- new: https://git.openjdk.jav
Patch note:
A previous patch had a bug that missed the boundary check, that will cause
StringIndexOutOfBoundsException to be thrown instead of
XPathExpressionException as expected.
Fix: the fix is to check the boundaries of the parameter "index".
Objects.checkIndex is removed as it's
On Wed, 20 Apr 2022 17:40:24 GMT, Joe Wang wrote:
> Patch note:
>
> The previous patch changed all literal tokens to use constants. However,
> replacing "." with Token.DOT introduced this bug.
> While tokens with a single char are inherently of type char
t the processing of the short form of the parent axis
> "..". The test verifies that all form of the parent axis shall return the
> same result.
>
> Test: all XML tests passed.
Joe Wang has updated the pull request incrementally with one additional commit
since the last rev
Patch note:
The previous patch changed all literal tokens to use constants. However,
replacing "." with Token.DOT introduced this bug.
While tokens with a single char are inherently of type char, due to the
different implementation of the overloaded method "tokenIs" that takes String
or char,
On Thu, 14 Apr 2022 18:05:48 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>> line 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: */
>>
>> The LastModified
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
Marked as reviewed by
On Thu, 14 Apr 2022 17:05:39 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes on ProcessEnvironment
On Thu, 14 Apr 2022 01:13:18 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java
>> line 1819:
>>
>>> 1817: Map items;
>>> 1818: LargeContainer(int size) {
>>> 1819: items =
On Thu, 14 Apr 2022 01:15:05 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>> line 171:
>>
>>> 169: _current = 0;
>>> 170: _size = size;
>>> 171: _references = HashMap.newHashMap(_size);
>>
>> Not
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
>
On Tue, 12 Apr 2022 20:33:53 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Tue, 12 Apr 2022 20:33:53 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote:
>> This is to upgrade the CLDR data from version 39 to version 41 which was
>> released yesterday. The vast majority of the changes are basically replacing
>> the CLDR data, along with tools/testcase alignments. Here is the link to
>> CLDR
On Tue, 5 Apr 2022 23:05:47 GMT, Joe Wang wrote:
> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
> classes where the checks were really about equality or whether they were the
> exact class types. It was why they worked nonetheless even though some of
&g
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's
On Thu, 7 Apr 2022 01:16:32 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:
>>
>>> 61: Locale.of("it", "IT", "EURO"),
>>> 62: Locale.forLanguageTag("de-AT"),
>>> 63: Locale.forLanguageTag("fr-CH"),
>>
>> Use the
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Thu, 7 Apr 2022 01:16:27 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:
>>
>>> 79:
>>> 80: /**
>>> 81: * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");
>>
>> Locale.France?
>
> The test code parses the input string
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 15:54:30 GMT, Naoto Sato wrote:
> Looks good to me. This would have been a premiere example for switch pattern
> match, but hey.
Yeah, totally understand the urge to use new features.
-
PR: https://git.openjdk.java.net/jdk/pull/8116
On Tue, 5 Apr 2022 23:55:22 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> replace with instanceof
>
> src/java.xml/share/classes/jdk/xml/internal/JdkXmlFeatures.java l
> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
> classes where the checks were really about equality or whether they were the
> exact class types. It was why they worked nonetheless even though some of
> them were backwards.
>
> Test: existing tests
Clean up the usages of isAssignableFrom in a few xpath and jdk/internal classes
where the checks were really about equality or whether they were the exact
class types. It was why they worked nonetheless even though some of them were
backwards.
Test: existing tests passed.
-
On Wed, 30 Mar 2022 11:38:59 GMT, Aleksey Shipilev wrote:
> See bug report for more details. This change improves
> SPECjvm2008:xml.validation for about +3%:
>
>
> baseline: 298.353 ± 1.008 ops/min
> patched: 309.912 ± 1.347 ops/min
>
> Of course, the real improvements might be even
On Tue, 29 Mar 2022 21:41:52 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove variable, check instance instead.
>
> src/java.xml/share/classes/javax/xml/catalog/Gro
5 XML tests passed:
> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove variable, check instance instead.
-
Changes:
- all: https://git.open
On Tue, 29 Mar 2022 18:23:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial fix which addresses a typo in
> src/java.sql/share/classes/java/sql/package-info.java
>
> make docs is clean and I am also running mach5 tier1 as an extra sanity check
> so there are no surprises
Resets state of a Catalog instance on each matching call so that it can be
reused. Adjusts CatalogResolver's resolve routine so that it continues to
observes the PREFER feature in a resolution process. Without the adjustment,
PreferFeatureTest would fail.
Mach5 XML tests passed:
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to b
On Thu, 24 Mar 2022 18:21:05 GMT, Joe Wang wrote:
> The issue was caused by the difference on handling control characters between
> the parser and serializer. The parser rejected control characters while the
> serializer converted them to NCRs. The fix is for the later to b
The issue was caused by the difference on handling control characters between
the parser and serializer. The parser rejected control characters while the
serializer converted them to NCRs. The fix is for the later to be aligned with
the parser, reporting error upon encountering control
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote:
> This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE
> redenomination (removing 3 zeros). Its effective date is 4/1, but I went
> ahead as JDK19 won't be released by 4/1.
Marked as reviewed by joehw (Reviewer).
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote:
>> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary
>> decimal/grouping separator symbols. Fix is straightforward to use the
>> correct symbols depending on the formatter type.
>
> Naoto Sato has updated the pull request
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For the bundles in java.xml:
For files with Oracle copyright, update the year to 2022 and @LastModified Mar
2022. Take XPATHErrorResources_ja.java as an example, the copyright year was
updated to 2021 and
On Mon, 7 Mar 2022 18:20:43 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Mon, 7 Mar 2022 17:07:20 GMT, Ravi Reddy wrote:
> This fix is for violation of XML specification on Attribute-Value
> normalization for external entities having character "\r".
>
> While normalizing entity with '\r', we should be checking if the entity is
> external before changing the
On Mon, 7 Mar 2022 03:00:45 GMT, Roger Riggs wrote:
>> OK, I propose `isIsoBased()` for the name, which I initially thought of. If
>> there is no objection, I will modify the spec/impl.
>
> Is `IsoBased` is fine with me. "isISOLike" is too vague.
That matches the javadoc as well, that it
On Fri, 4 Mar 2022 05:02:37 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote:
> Update BCEL md to include the copyright notice.
This pull request has now been integrated.
Changeset: 8478173d
Author: Joe Wang
URL:
https://git.openjdk.java.net/jdk/commit/8478173d837113bf603aadb614badd461f474250
Stats: 8 li
> Update BCEL md to include the copyright notice.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove the section that's no longer in the notice file
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7681/fi
On Thu, 3 Mar 2022 18:36:32 GMT, Lance Andersen wrote:
> > Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text
> > comes from the NOTICE.txt file in the BCEL 6.5.0 release.
>
> Thank you for the confirmation Joe!
Thanks Lance, and Iris!
-
PR:
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote:
> Update BCEL md to include the copyright notice.
Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text comes
from the NOTICE.txt file in the BCEL 6.5.0 release.
-
PR: https://git.openjdk.java.net/jdk/pull/7681
Update BCEL md to include the copyright notice.
-
Commit messages:
- 8282583: Update BCEL md to include the copyright notice
Changes: https://git.openjdk.java.net/jdk/pull/7681/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7681=00
Issue:
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote:
> Fixing the definition and implementation of the pattern symbol `F`. Although
> it is an incompatible change, I believe it is worth the fix. For that, a CSR
> has been drafted.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote:
> Fixing the definition and implementation of the pattern symbol `F`. Although
> it is an incompatible change, I believe it is worth the fix. For that, a CSR
> has been drafted.
Was the following assessment in the bug report correct?
On Fri, 25 Feb 2022 00:50:49 GMT, Ravi Reddy wrote:
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
Please also update the @LastModified to "Feb 2022"
-
Marked as reviewed by joehw (Reviewer).
PR:
On Tue, 15 Feb 2022 22:31:28 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 595:
>>
>>> 593: divisor = (Long) divisors.get(++compactDataIndex);
>>> 594: iPart = getIntegerPart(number, divisor);
>>> 595: }
On Tue, 15 Feb 2022 22:31:47 GMT, Naoto Sato wrote:
>> Fixing an issue in `CompactNumberFormat` which was caused by
>> BigDecimal.divide() that incremented the number in the resulting format
>> string. Also fixing some typos by taking this opportunity.
>
> Naoto Sato has updated the pull
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote:
> Fixing an issue in `CompactNumberFormat` which was caused by
> BigDecimal.divide() that incremented the number in the resulting format
> string. Also fixing some typos by taking this opportunity.
Marked as reviewed by joehw (Reviewer).
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote:
> Fixing an issue in `CompactNumberFormat` which was caused by
> BigDecimal.divide() that incremented the number in the resulting format
> string. Also fixing some typos by taking this opportunity.
On Tue, 8 Feb 2022 19:08:45 GMT, Naoto Sato wrote:
>> Following the prior discussion [1], here is the PR for the subject
>> enhancement. CSR has also been updated according to the suggestion.
>>
>> [1]
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
>
> Naoto
On Thu, 3 Feb 2022 23:29:54 GMT, Naoto Sato wrote:
> Following the prior discussion [1], here is the PR for the subject
> enhancement. CSR has also been updated according to the suggestion.
>
> [1]
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
Hi Naoto,
Looks good to me, and thanks for the explanation. I agree, AIOOBE would
be a separate bug with ofPattern.
Thanks,
Joe
On 1/25/22 2:30 PM, Naoto Sato wrote:
Hi Joe,
On 1/24/22 5:50 PM, Joe Wang wrote:
The 2nd and 3rd statements defined the requestedTemplate,
does it imply
On Tue, 25 Jan 2022 08:33:21 GMT, Matthias Baesken wrote:
>> After 8270492
>> https://github.com/openjdk/jdk/commit/78b2c8419bc69436873e6fc9c542480949d140c5
>> has been pushed, we should adjust
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java
dPattern(Set
template), but not exactly suffices the need.
Naoto
On 1/20/22 9:52 PM, Joe Wang wrote:
Hi Naoto,
The javadoc points to LDML, it seems to me though it might be useful
to add more information similar to that for the ofPattern methods,
what's under the "Patterns for Formattin
Hi Naoto,
The javadoc points to LDML, it seems to me though it might be useful to
add more information similar to that for the ofPattern methods, what's
under the "Patterns for Formatting and Parsing" section, so that for at
least the common use cases we could rely on the javadoc without
On Thu, 20 Jan 2022 10:55:59 GMT, Matthias Baesken wrote:
> After 8270492
> https://github.com/openjdk/jdk/commit/78b2c8419bc69436873e6fc9c542480949d140c5
> has been pushed, we should adjust
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java
>
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote:
> Please review the changes for upgrading the Unicode support in the JDK, from
> version 13 to version 14. Corresponding CSR has also been drafted.
I like how they changed dizzy face to face with crossed-out eyes. Pistol to
water pistol,
1 - 100 of 897 matches
Mail list logo
