Re: RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-19 Thread Christian Thalinger
> On Oct 19, 2015, at 8:09 AM, Bob Vandette wrote: > > Here’s the updated set of webrev’s that address two issues: > > 1. Move jni_util.h out of jawt.h > 2. Christians concern over using a single variable name for Makefile and > C/C++ logic. Thanks. Looks good to

Re: RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-16 Thread Bob Vandette
> On Oct 16, 2015, at 1:01 PM, Naoto Sato wrote: > > Hi Bob, Alan, > > On 10/16/15 8:11 AM, Bob Vandette wrote: >>> I've skimmed through the patches and the DEF_* macros look okay. The only >>> one that doesn't look right is jawt.h/jawt.c. As jawt.h is shipped by the

Re: RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-16 Thread Alan Bateman
On 15/10/2015 19:07, Bob Vandette wrote: Please review this JDK 9 enhancement which allows a completely static build of the JDK for MacOSX x64 platforms. https://bugs.openjdk.java.net/browse/JDK-8136556 The change involves: 1. Producing

Re: RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-16 Thread Bob Vandette
> On Oct 16, 2015, at 2:28 AM, Alan Bateman wrote: > > On 15/10/2015 19:07, Bob Vandette wrote: >> Please review this JDK 9 enhancement which allows a completely static build >> of the JDK for MacOSX x64 platforms. >> >>

Re: RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-16 Thread Naoto Sato
Hi Bob, Alan, On 10/16/15 8:11 AM, Bob Vandette wrote: I've skimmed through the patches and the DEF_* macros look okay. The only one that doesn't look right is jawt.h/jawt.c. As jawt.h is shipped by the JDK then I think the include of jni_util.h needs to move from jawt.h to jawt.c. Ok, I’ll

Re: RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-15 Thread Christian Thalinger
Copy-pasting the comment I made earlier (internally): >> make/bsd/makefiles/gcc.make: >> >> + ifeq ($(BUILD_STATIC),true) >> + CXXFLAGS += -DSTATIC_BUILD >> + CFLAGS += -DSTATIC_BUILD >> >> Can we use the same name everywhere? > > We were trying to differentiate Makefile options from compile

RFR: 8136556 - Add the ability to perform static builds of MacOSX x64 binaries

2015-10-15 Thread Bob Vandette
Please review this JDK 9 enhancement which allows a completely static build of the JDK for MacOSX x64 platforms. https://bugs.openjdk.java.net/browse/JDK-8136556 The change involves: 1. Producing “.a” archives for each native libraries. 2.