Re: RFR: 8290488: IBM864 character encoding implementation bug

On Thu, 28 Jul 2022 16:18:51 GMT, Naoto Sato wrote: >> Many thanks @naotoj . >> >> I checked the latest IBM-864 mapping table. >> (I assume current OpenJDK's IBM864 may refer older mapping table) >>

RFR: 8291118: [vectorapi] Optimize the implementation of lanewise FIRST_NONZERO

Vector API binary op "`FIRST_NONZERO`" represents the vector operation of "`a != 0 ? a : b`", which can be implemented with existing APIs like "`compare + blend`". The current implementation is more complex especially for the floating point type vectors. The main idea is: 1) mask =

RFR: 8290740: Catalog not used when the handler is null

Patch to make sure the Catalog is used even when the handler is null. - Commit messages: - 8290740: Catalog not used when the handler is null Changes: https://git.openjdk.org/jdk/pull/9682/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9682=00 Issue:

Integrated: 8289511: Improve test coverage for XPath Axes: child

On Wed, 13 Jul 2022 21:04:11 GMT, Bill Huang wrote: > This is a subtask of > [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming to > improve XPath expression test coverage. The goal of this subtask is > validating the XPath child axis specifier in various ways. This

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v3]

On Tue, 26 Jul 2022 20:31:44 GMT, Alisen Chung wrote: >> open l10n msg drop >> All tests passed. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed localized files from base -

Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v4]

On Thu, 28 Jul 2022 20:37:30 GMT, Joe Darcy wrote: >> JDK-8289106: Add model of class file versions to core reflection > > Joe Darcy has updated the pull request incrementally with two additional > commits since the last revision: > > - Finish more precise versioned location support; udpate

Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v5]

> JDK-8289106: Add model of class file versions to core reflection Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Appease jcheck. - Changes: - all: https://git.openjdk.org/jdk/pull/9299/files - new:

Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v4]

> JDK-8289106: Add model of class file versions to core reflection Joe Darcy has updated the pull request incrementally with two additional commits since the last revision: - Finish more precise versioned location support; udpate tests. - Partial implementation of version-depdendent

Coupling in ExtentLocal

Hello core-libs devs, The ExtentLocal proposal adds a new way to transfer arguments to methods, e.g. (taken from project’s loom git

Re: RFR: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable [v4]

> This is a REDO of the Fix that was incompletely implemented earlier: > [8285838: Fix for TZ environment variable DST > rules](https://github.com/openjdk/jdk/pull/8660) > > Offset calculation now accounts all the way upto year in order to avoid > cross-day miscalculations as well as to

[jdk19] Integrated: 8291512: Snippetize modules API examples

On Thu, 28 Jul 2022 17:41:31 GMT, Mark Reinhold wrote: > The specification of the modules API contains several non-normative code > examples. We should convert them to use snippets, per [JEP > 413](https://openjdk.org/jeps/413). This pull request has now been integrated. Changeset: 1d16c91b

Re: [jdk19] RFR: 8291512: Snippetize modules API examples [v2]

On Thu, 28 Jul 2022 17:54:33 GMT, Joe Darcy wrote: > Looks fine; may want to change this issue to be a subtask of JDK-8289774. Thanks. Converted to subtask. - PR: https://git.openjdk.org/jdk19/pull/156

Re: [jdk19] RFR: 8291512: Snippetize modules API examples [v2]

> The specification of the modules API contains several non-normative code > examples. We should convert them to use snippets, per [JEP > 413](https://openjdk.org/jeps/413). Mark Reinhold has updated the pull request incrementally with one additional commit since the last revision: Fix

Withdrawn: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java

Re: RFR: 8290488: IBM864 character encoding implementation bug

On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9661

Re: [jdk19] RFR: 8291512: Snippetize modules API examples

On Thu, 28 Jul 2022 17:41:31 GMT, Mark Reinhold wrote: > The specification of the modules API contains several non-normative code > examples. We should convert them to use snippets, per [JEP > 413](https://openjdk.org/jeps/413). Looks fine; may want to change this issue to be a subtask of

[jdk19] RFR: 8291512: Snippetize modules API examples

The specification of the modules API contains several non-normative code examples. We should convert them to use snippets, per [JEP 413](https://openjdk.org/jeps/413). - Commit messages: - 8291512: Snippetize modules API examples Changes:

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Thu, 28 Jul 2022 14:33:40 GMT, Aleksey Shipilev wrote: > > > It then basically tests just that newly constructed SoftReference is not > > cleared in the next moment after construction. > > Yes, but not really. There is still a 100ms sleep and reference processing > involved, which

Re: RFR: 8290488: IBM864 character encoding implementation bug

On Thu, 28 Jul 2022 10:29:07 GMT, Ichiroh Takiguchi wrote: >> @takiguc Sure. Appreciate it. > > Many thanks @naotoj . > > I checked the latest IBM-864 mapping table. > (I assume current OpenJDK's IBM864 may refer older mapping table) >

Integrated: 8290059: Do not use std::thread in panama tests

On Thu, 21 Jul 2022 18:48:14 GMT, Jorn Vernee wrote: > This patch removes the use of std::thread from the `java.lang.foreign` tests, > and switches to the OS specific thread APIs, in order to change things such > as the stack size on some platforms where this is required in the future (see >

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Wed, 27 Jul 2022 12:30:43 GMT, Aleksey Shipilev wrote: >>> ...I can take this over, unless you want to do it, Aleksey? >> >> I find it dubious to try and guess what GCs would do with non-strong refs, >> but feel free. Don't reassign the bug yet, just see how messy that would be? > >> > ...I

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Wed, 27 Jul 2022 12:30:43 GMT, Aleksey Shipilev wrote: >>> ...I can take this over, unless you want to do it, Aleksey? >> >> I find it dubious to try and guess what GCs would do with non-strong refs, >> but feel free. Don't reassign the bug yet, just see how messy that would be? > >> > ...I

Re: RFR: 8288732: Reduce runtime of java.util.concurrent microbenchmarks

On Mon, 20 Jun 2022 10:47:35 GMT, Claes Redestad wrote: > - Refactor so that various baseline micros are not run repeatedly with > different parameter values that does not affect the baseline > - Tune iteration times, counts, forks.. > > Reduces runtime of java.util.concurrent micros from an

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Wed, 27 Jul 2022 12:30:43 GMT, Aleksey Shipilev wrote: >>> ...I can take this over, unless you want to do it, Aleksey? >> >> I find it dubious to try and guess what GCs would do with non-strong refs, >> but feel free. Don't reassign the bug yet, just see how messy that would be? > >> > ...I

Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote: > CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a > defined, but empty macro in libjli if it is not defined in the build system, > which is incorrect Marked as reviewed by erikj (Reviewer). - PR:

Re: RFR: 8290059: Do not use std::thread in panama tests [v5]

On Wed, 27 Jul 2022 14:34:49 GMT, Jorn Vernee wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the future

RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a defined, but empty macro in libjli if it is not defined in the build system, which is incorrect - Commit messages: - Add missing check in JLI macro definitions Changes:

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

On Fri, 22 Jul 2022 18:44:30 GMT, Thomas Stuefe wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixes > > Hi @JornVernee, > > good job and thanks for doing it so quickly. Looks good, module the > GetLastError

Re: RFR: 8290488: IBM864 character encoding implementation bug

On Thu, 28 Jul 2022 01:46:26 GMT, Naoto Sato wrote: >> Hello @naotoj . >> I'm not reviewer, but I'd like to test this change. >> Could you wait for a moment ? >> Thanks. > > @takiguc Sure. Appreciate it. Many thanks @naotoj . I checked the latest IBM-864 mapping table. (I assume current

Re: RFR: 8288732: Reduce runtime of java.util.concurrent microbenchmarks

On Mon, 20 Jun 2022 10:47:35 GMT, Claes Redestad wrote: > - Refactor so that various baseline micros are not run repeatedly with > different parameter values that does not affect the baseline > - Tune iteration times, counts, forks.. > > Reduces runtime of java.util.concurrent micros from an