Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Jaikiran Pai
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v2]

2022-08-09 Thread Jaikiran Pai
> (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of this change which addresses >

Re: RFR: 8289711: Add container configuration data to mbeans [v10]

2022-08-09 Thread xpbob
> Container configuration information is useful for troubleshooting > problems,Exposing information in MBeans is ideal for monitoring, jConsole, > and other scenarios. > Results the following >

Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v6]

2022-08-09 Thread Joe Darcy
> JDK-8289106: Add model of class file versions to core reflection Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits

Re: RFR: JDK-8289106: Add model of class file versions to core reflection [v5]

2022-08-09 Thread Joe Darcy
On Tue, 2 Aug 2022 21:21:51 GMT, Roger Riggs wrote: > True, many ways to factor the code. Another possibility is add a field to the > enum that holds a `java.util.Function>)` and initialize > it each with a lambda of the code now in the locations(cffv) method that maps > the cffv to the set

Withdrawn: 8282664: Unroll by hand StringUTF16, StringLatin1, and Arrays polynomial hash loops

2022-08-09 Thread duke
On Fri, 4 Mar 2022 15:54:14 GMT, Ludovic Henry wrote: > Despite the hash value being cached for Strings, computing the hash still > represents a significant CPU usage for applications handling lots of text. > > Even though it would be generally better to do it through an enhancement to > the

[jdk19] Integrated: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-08-09 Thread Alisen Chung
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote: > open l10n msg drop > All tests passed. This pull request has now been integrated. Changeset: 0def5316 Author:Alisen Chung Committer: Alexey Semenyuk URL:

Re: RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version

2022-08-09 Thread Leonid Mesnik
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote: > This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh >

RFR: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version

2022-08-09 Thread Bill Huang
This task converts 5 shell tests below to java version. test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh

Re: RFR: 8291916: Unexpected output on Arabic Windows command prompt

2022-08-09 Thread Naoto Sato
On Fri, 5 Aug 2022 02:15:21 GMT, Ichiroh Takiguchi wrote: > To support Windows command prompt's codepage, following charsets should be > moved from jdk.charsets module to java.base module. > > - IBM860 > - IBM861 > - IBM863 > - IBM864 > - IBM865 > - IBM869 I looked at this issue a bit more.

Re: RFR: 8291641: Optimize StackTraceElement.toString() [v7]

2022-08-09 Thread David Schlosnagle
On Mon, 8 Aug 2022 18:55:39 GMT, Max Mielchen wrote: >> David Schlosnagle has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >>

Re: RFR: 8291641: Optimize StackTraceElement.toString() [v7]

2022-08-09 Thread David Schlosnagle
On Tue, 9 Aug 2022 18:35:05 GMT, Mandy Chung wrote: >> David Schlosnagle has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >>

Re: RFR: 8291641: Optimize StackTraceElement.toString() [v8]

2022-08-09 Thread David Schlosnagle
> I would like to contribute an optimized version of > `StackTraceElement#toString()` that uses a single StringBuilder throughout > creation to avoid intermediate `String` allocations. > `StackTraceElement#toString()` is used in a number of JDK code paths > including

Re: RFR: 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java

2022-08-09 Thread Brian Burkhalter
On Tue, 9 Aug 2022 19:16:04 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9812

Integrated: 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java

2022-08-09 Thread Daniel D . Daugherty
On Tue, 9 Aug 2022 19:16:04 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java. This pull request has now been integrated. Changeset: 57e0da15 Author:Daniel D. Daugherty URL:

RFR: 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java

2022-08-09 Thread Daniel D . Daugherty
A trivial fix to ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java. - Commit messages: - 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java Changes: https://git.openjdk.org/jdk/pull/9812/files Webrev:

Re: RFR: 8291641: Optimize StackTraceElement.toString() [v7]

2022-08-09 Thread Max Mielchen
On Sat, 6 Aug 2022 14:55:17 GMT, David Schlosnagle wrote: >> I would like to contribute an optimized version of >> `StackTraceElement#toString()` that uses a single StringBuilder throughout >> creation to avoid intermediate `String` allocations. >> `StackTraceElement#toString()` is used in a

Re: RFR: 8291641: Optimize StackTraceElement.toString() [v7]

2022-08-09 Thread Mandy Chung
On Sat, 6 Aug 2022 14:55:17 GMT, David Schlosnagle wrote: >> I would like to contribute an optimized version of >> `StackTraceElement#toString()` that uses a single StringBuilder throughout >> creation to avoid intermediate `String` allocations. >> `StackTraceElement#toString()` is used in a

Integrated: JDK-8290836 Improve test coverage for XPath functions: String Functions

2022-08-09 Thread Bill Huang
On Thu, 4 Aug 2022 17:40:43 GMT, Bill Huang wrote: > Improve test coverage for XPath functions: > [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836), > [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837), > [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838). This pull

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Lance Andersen
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v4]

2022-08-09 Thread Alexey Semenyuk
On Fri, 29 Jul 2022 18:13:25 GMT, Alisen Chung wrote: >> open l10n msg drop >> All tests passed. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added comments in CurrencyNames root in base, moved US CurrencyNames back >

Integrated: 8290047: (fs) FileSystem.getPathMatcher does not check for ":" at last index

2022-08-09 Thread Brian Burkhalter
On Thu, 21 Jul 2022 15:29:10 GMT, Brian Burkhalter wrote: > For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()` > so change the check > > int pos = syntaxAndInput.indexOf(':'); > if (pos <= 0 || pos == syntaxAndInput.length()) > > to > > if

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Naoto Sato
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v4]

2022-08-09 Thread Alan Bateman
On Tue, 9 Aug 2022 05:51:17 GMT, Alan Bateman wrote: >> The whole paragraph is about thread termination, so I don't think we need to >> say "terminate" again in the last sentence. We could mention isAlive or the >> TERMINATED state, but that brings in Thread.State which which require a >>

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v5]

2022-08-09 Thread Alan Bateman
On Mon, 8 Aug 2022 22:59:33 GMT, Stuart Marks wrote: >> Initial edits to addShutdownHook from Alex. >> >> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036). > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8291966: SwitchBootstrap.typeSwitch could be faster

2022-08-09 Thread Thiago Henrique Hüpner
On Tue, 9 Aug 2022 10:28:02 GMT, Jan Lahoda wrote: > > Would it be possible to add a special case where the labels are all the > > same type? Like all labels are Class.class or Object.class? While testing > > out the pattern matching, I've found myself doing the following > > ```java > >

Re: RFR: 8291966: SwitchBootstrap.typeSwitch could be faster

2022-08-09 Thread Jan Lahoda
On Fri, 5 Aug 2022 16:12:08 GMT, Jan Lahoda wrote: > The pattern matching switches are using a bootstrap method > `SwitchBootstrap.typeSwitch` to implement the jumps in the switch. Basically, > for a switch like: > > switch (obj) { > case String s when s.isEmpty() -> {} > case String

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Chris Hegarty
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Jaikiran Pai
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote: > (This is a recreation of a previous pull request which had received some > reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that > personal branch and recreate it due to some git issues) > > Can I please get a review of

RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Jaikiran Pai
(This is a recreation of a previous pull request which had received some reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that personal branch and recreate it due to some git issues) Can I please get a review of this change which addresses

Withdrawn: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-08-09 Thread Jaikiran Pai
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java`

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-09 Thread ScientificWare
On Tue, 9 Aug 2022 08:38:26 GMT, Jaikiran Pai wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >>

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-09 Thread Jaikiran Pai
On Fri, 5 Aug 2022 08:59:00 GMT, ScientificWare wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by >> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) >> >> Unused imports in DTDBuider.java. >> >>> **Remove unused

Integrated: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-08-09 Thread ScientificWare
On Mon, 4 Jul 2022 07:04:40 GMT, ScientificWare wrote: > This is tracked in JBS as > > [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by > [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) > > Unused imports in DTDBuider.java. > >> **Remove unused imports

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-09 Thread ScientificWare
On Tue, 9 Aug 2022 02:37:21 GMT, Jaikiran Pai wrote: >> Hello @jaikiran, the copyright years were updated by a previous commit. > > @scientificware, please issue the integrate command when you are ready and I > can sponsor this for you. In the meantime, I'll run some tests to be sure > that

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v15]

2022-08-09 Thread Peter Levart
On Sun, 10 Jul 2022 10:20:31 GMT, Laurent Bourgès wrote: >> iaroslavski has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) >> >> * Added JMH > > Here are JMH test results on