On Thu, 11 Aug 2022 00:06:35 GMT, David Holmes wrote:
> Forward port JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 85a60235
Author:David Holmes
URL:
https://git.openjdk.org/jdk/commit/85a602355ff6e92bb468135d712e0b0b41753db4
Stats: 686 lines in 44 files
Forward port JDK 19 -> JDK 20
-
Commit messages:
- Merge remote-tracking branch 'jdk19/master' into Merge_jdk19
- 8288769: Revert unintentional change to deflate.c
- 8291496: Allocating card table before heap causes underflow asserts in
CardTable::addr_for()
- 8290889: JDK 19
On Mon, 8 Aug 2022 02:27:15 GMT, David Holmes wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Runtime.java line 99:
>
>> 97: * >
> The concept of the shutdown sequence needs to be specified more clearly. This
> PR adds text for this into the class specification of `java.lang.Runtime`.
> Also includes adjustments to related areas in `addShutdownHook`, `halt`, and
> in the `System` and `Thread` classes. The changes here
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote:
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of
On Wed, 10 Aug 2022 02:54:37 GMT, Jaikiran Pai wrote:
>> (This is a recreation of a previous pull request which had received some
>> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
>> personal branch and recreate it due to some git issues)
>>
>> Can I please get a
On Wed, 3 Aug 2022 09:18:26 GMT, Alan Bateman wrote:
>> xpbob has updated the pull request incrementally with two additional commits
>> since the last revision:
>>
>> - remove line
>> - add export
>
> What happened with the experiment to move ContainerInfoMXBean to
> jdk.management?
Hi,
On Wed, 10 Aug 2022 22:02:52 GMT, Bill Huang wrote:
>> This task converts 5 shell tests below to java version.
>> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
>> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
>>
On Wed, 10 Aug 2022 02:54:37 GMT, Jaikiran Pai wrote:
>> (This is a recreation of a previous pull request which had received some
>> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
>> personal branch and recreate it due to some git issues)
>>
>> Can I please get a
Hi,
could you please report this at https://bugreport.java.com/bugreport/
(please also first search at
https://bugs.openjdk.org/issues?jql=project%3DJDK%20AND%20issuetype%3DBug
whether it has already been reported).
This also seems to affect the `CheckedEntrySet`; would be good if you could
> This task converts 5 shell tests below to java version.
> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh
>
On Wed, 10 Aug 2022 21:20:38 GMT, Naoto Sato wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixes for bundling with different cultures
>
> That's the expected behavior. Historically, we only support where user's
>
On Wed, 10 Aug 2022 21:09:42 GMT, Leonid Mesnik wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed GC settings.
>
> test/jdk/java/lang/management/MemoryMXBean/MemoryManagement.java line 35:
>
>> 33: *
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Wed, 10 Aug 2022 18:50:51 GMT, Bill Huang wrote:
>> This task converts 5 shell tests below to java version.
>> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
>> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
>>
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based on
On Tue, 9 Aug 2022 00:15:03 GMT, Joe Darcy wrote:
> With the ACC_SUPER information now available from a private
> getClassAccessFlagsRaw() method, the
> Set accessFlags()
> method can properly model that setting.
This pull request has now been integrated.
Changeset: 68af7c13
Author:Joe
On Tue, 9 Aug 2022 00:15:03 GMT, Joe Darcy wrote:
> With the ACC_SUPER information now available from a private
> getClassAccessFlagsRaw() method, the
> Set accessFlags()
> method can properly model that setting.
Looks good to me.
-
Marked as reviewed by mchung (Reviewer).
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Thu, 4 Aug 2022 18:10:18 GMT, Alex Kasko wrote:
> This change adds `ContextMenuCommandLabel` l10n property for file association
> context menu label. It is a follow-up to [this PR
> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>
> Note, non-EN l10n values
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Mon, 8 Aug 2022 19:52:41 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>>
>> Note, non-EN l10n
> This task converts 5 shell tests below to java version.
> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh
>
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote:
> This task converts 5 shell tests below to java version.
> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
>
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote:
> This task converts 5 shell tests below to java version.
> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
>
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote:
> This task converts 5 shell tests below to java version.
> test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh
> test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
>
On 8/9/2022 11:56 PM, Peter Levart wrote:
On Sun, 7 Aug 2022 08:14:58 GMT, Alan Bateman wrote:
Sorry for joining late. I noticed that modsHashCode is a private method and it
takes Iterable as a parameter. But everywhere it is called, a Set is passed to
it. So why not just calling the
On Wed, 27 Jul 2022 22:56:39 GMT, David Schlosnagle wrote:
> I would like to contribute an optimized version of
> `StackTraceElement#toString()` that uses a single StringBuilder throughout
> creation to avoid intermediate `String` allocations.
> `StackTraceElement#toString()` is used in a
On Tue, 9 Aug 2022 20:26:43 GMT, David Schlosnagle wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
On Sun, 7 Aug 2022 07:55:26 GMT, Peter Levart wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of
On Wed, 3 Aug 2022 10:21:43 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this patch to deflate.c which reverts an unintentional change
> that was part of JDK-8284371, which reverted the reworking of (7) deflate.c
> undo (6), replaced withe the official zlib repo fix see#305/#f969409
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based on [this
>
On Wed, 10 Aug 2022 02:54:37 GMT, Jaikiran Pai wrote:
>> (This is a recreation of a previous pull request which had received some
>> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
>> personal branch and recreate it due to some git issues)
>>
>> Can I please get a
On Tue, 14 Jun 2022 19:36:51 GMT, Сергей Цыпанов wrote:
>> Instead of `Executable.getParameterTypes()` we could use
>> `Executable.getSharedParameterTypes()` in trusted code. Same is applicable
>> for `Executable.getExceptionTypes()`.
>
> Сергей Цыпанов has updated the pull request
On Tue, 9 Aug 2022 06:49:53 GMT, Peter Levart wrote:
>> Here are JMH test results on my stable perf laptop (cpu fixed: 4 real cpu
>> cores at 2ghz, HT disabled, i7 6820k):
>> https://github.com/bourgesl/bourgesl.github.io/blob/master/bench-220709-summary-2.log
>>
>> It confirms Vladimir
42 matches
Mail list logo