Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

2022-09-01 Thread Sandhya Viswanathan
On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

2022-09-01 Thread Smita Kamath
> 8289552: Make intrinsic conversions between bit representations of half > precision values and floats Smita Kamath has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all:

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v5]

2022-09-01 Thread Sandhya Viswanathan
On Thu, 1 Sep 2022 18:26:52 GMT, Smita Kamath wrote: >> src/hotspot/cpu/x86/x86_64.ad line 11330: >> >>> 11328: ins_pipe( pipe_slow ); >>> 11329: %} >>> 11330: >> >> For HF2F, good to also add optimized rule with LoadS to benefit from >> vcvtph2ps memory src form of instruction. >>

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v6]

2022-09-01 Thread Sandhya Viswanathan
On Thu, 1 Sep 2022 18:31:07 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v7]

2022-09-01 Thread Sandhya Viswanathan
On Thu, 1 Sep 2022 23:22:46 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Added missing

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v7]

2022-09-01 Thread Smita Kamath
> 8289552: Make intrinsic conversions between bit representations of half > precision values and floats Smita Kamath has updated the pull request incrementally with one additional commit since the last revision: Added missing parantheses - Changes: - all:

Integrated: JDK-8292990 Improve test coverage for XPath Axes: parent

2022-09-01 Thread Bill Huang
On Wed, 31 Aug 2022 20:16:33 GMT, Bill Huang wrote: > The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes This pull

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v6]

2022-09-01 Thread Paul Sandoz
On Thu, 1 Sep 2022 18:31:07 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v6]

2022-09-01 Thread Vladimir Kozlov
On Thu, 1 Sep 2022 18:31:07 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed

Re: RFR: JDK-8292990 Improve test coverage for XPath Axes: parent [v3]

2022-09-01 Thread Bill Huang
> The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes Bill Huang has updated the pull request incrementally with one

Integrated: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties

2022-09-01 Thread Rahul Prabhu
On Mon, 29 Aug 2022 21:25:29 GMT, Rahul Prabhu wrote: > Rewrote javatest.maxOutputSize as maxOutputSize in the TEST.properties file > in test/jdk/jdk/lambda to match the same declarations in other > TEST.properties files. The jtreg specification with the correct syntax for > maxOutputSize is

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v6]

2022-09-01 Thread Vladimir Kozlov
On Thu, 1 Sep 2022 18:31:07 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed

Re: RFR: JDK-8292990 Improve test coverage for XPath Axes: parent [v2]

2022-09-01 Thread Joe Wang
On Thu, 1 Sep 2022 18:28:12 GMT, Bill Huang wrote: >> The goal of this task is validating the parent axis contains the parent of >> the context node. Context nodes include >> - root node >> - element nodes >> - text nodes >> - attribute nodes >> - namespace nodes >> - comment nodes > >

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v6]

2022-09-01 Thread Smita Kamath
> 8289552: Make intrinsic conversions between bit representations of half > precision values and floats Smita Kamath has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments, updated microbenchmark - Changes: -

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v5]

2022-09-01 Thread Smita Kamath
On Thu, 25 Aug 2022 03:15:52 GMT, Sandhya Viswanathan wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated copyright comment > > src/hotspot/cpu/x86/x86_64.ad line 11330: > >> 11328: ins_pipe( pipe_slow );

Re: RFR: JDK-8292990 Improve test coverage for XPath Axes: parent [v2]

2022-09-01 Thread Bill Huang
> The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes Bill Huang has updated the pull request incrementally with one

Integrated: JDK-8289510 : Improve test coverage for XPath Axes: namespace

2022-09-01 Thread Mahendra Chhipa
On Wed, 17 Aug 2022 15:32:49 GMT, Mahendra Chhipa wrote: > Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. This pull request has now been integrated. Changeset: 3d254d3c Author:Mahendra Chhipa URL:

Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v4]

2022-09-01 Thread Joe Wang
On Thu, 1 Sep 2022 11:38:09 GMT, Mahendra Chhipa wrote: >> Added tests for namespace Axis. Tests incluse namspace expressions, >> namespace node counts and namespace node scope. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision:

Re: RFR: JDK-8292990 Improve test coverage for XPath Axes: parent

2022-09-01 Thread Joe Wang
On Wed, 31 Aug 2022 20:16:33 GMT, Bill Huang wrote: > The goal of this task is validating the parent axis contains the parent of > the context node. Context nodes include > - root node > - element nodes > - text nodes > - attribute nodes > - namespace nodes > - comment nodes

Re: RFR: 8292201: serviceability/sa/ClhsdbThreadContext.java fails with "'Thread "Common-Cleaner"' missing from stdout/stderr" [v2]

2022-09-01 Thread Chris Plummer
On Thu, 1 Sep 2022 17:20:33 GMT, Chris Plummer wrote: >> While dumping all registers (and doing a findpc on each), the following >> exception occurred for r8: >> >> >> r8: 0x00750e4fdffc >> Error: java.lang.ArrayIndexOutOfBoundsException: Index 4099 out of bounds >> for length 4096 >>

Re: RFR: 8292201: serviceability/sa/ClhsdbThreadContext.java fails with "'Thread "Common-Cleaner"' missing from stdout/stderr" [v2]

2022-09-01 Thread Chris Plummer
> While dumping all registers (and doing a findpc on each), the following > exception occurred for r8: > > > r8: 0x00750e4fdffc > Error: java.lang.ArrayIndexOutOfBoundsException: Index 4099 out of bounds for > length 4096 > java.lang.ArrayIndexOutOfBoundsException: Index 4099 out of

Re: RFR: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations [v13]

2022-09-01 Thread Joe Darcy
On Thu, 1 Sep 2022 08:12:13 GMT, Volker Simonis wrote: >> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` >> to highlight that it might write more bytes than the returned number of >> inflated bytes into the buffer `b`. >> >> The superclass `java.io.InputStream`

Integrated: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-09-01 Thread Joe Darcy
On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote: > Update to remove support for -source/-target/--release 7 from javac. > > As seen in the PR, many test fails are affected. Further refactorings of > javac's implementation that can be made from dropping 7 support are left as > future work.

RFR: 8292201: serviceability/sa/ClhsdbThreadContext.java fails with "'Thread "Common-Cleaner"' missing from stdout/stderr"

2022-09-01 Thread Chris Plummer
While dumping all registers (and doing a findpc on each), the following exception occurred for r8: r8: 0x00750e4fdffc Error: java.lang.ArrayIndexOutOfBoundsException: Index 4099 out of bounds for length 4096 java.lang.ArrayIndexOutOfBoundsException: Index 4099 out of bounds for length

Integrated: 8293154: TemporalQueries java doc error

2022-09-01 Thread Naoto Sato
On Wed, 31 Aug 2022 17:08:28 GMT, Naoto Sato wrote: > Simple doc fix. This pull request has now been integrated. Changeset: 6a1b0b56 Author:Naoto Sato URL: https://git.openjdk.org/jdk/commit/6a1b0b5649dd4f2a970df0839bf77bdb899fbd6f Stats: 3 lines in 1 file changed: 0 ins; 0

Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v4]

2022-09-01 Thread Bill Huang
On Thu, 1 Sep 2022 11:38:09 GMT, Mahendra Chhipa wrote: >> Added tests for namespace Axis. Tests incluse namspace expressions, >> namespace node counts and namespace node scope. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision:

Integrated: 8291651: CleanerTest.java fails with "Cleanable was cleaned"

2022-09-01 Thread Roger Riggs
On Fri, 26 Aug 2022 19:09:45 GMT, Roger Riggs wrote: > CleanerTest is failing intermittently on Aarch64, with -Xcomp, and using a > VirtualThread for the Cleaner in the test. > The extensively relies on references processing and invokes GC on a very > short cycle. > The existing 10ms delay

Re: RFR: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform

2022-09-01 Thread Ichiroh Takiguchi
On Fri, 26 Aug 2022 18:56:31 GMT, Naoto Sato wrote: >> After `test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java` testcase was >> integrated, it failed on the AIX platform. >> >> Error output >> >> STDERR: >> stdout: []; >> stderr: [Exception in thread "main" java.lang.RuntimeException:

Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v4]

2022-09-01 Thread Mahendra Chhipa
> Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: -

Re: RFR: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations [v13]

2022-09-01 Thread Lance Andersen
On Thu, 1 Sep 2022 08:12:13 GMT, Volker Simonis wrote: >> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` >> to highlight that it might write more bytes than the returned number of >> inflated bytes into the buffer `b`. >> >> The superclass `java.io.InputStream`

Re: RFR: 8293197: Avoid double racy reads from non-volatile fields in SharedSecrets

2022-09-01 Thread Bernd Eckenfels
BTW, after then ensures it looks like a good candidate for a system-assert for not-null for all of those fields, right? Gruss Bernd -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Andrey Turbanov Gesendet: Thursday, September 1, 2022 8:24:58 AM

Integrated: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures

2022-09-01 Thread Aleksey Shipilev
On Tue, 16 Aug 2022 08:23:11 GMT, Aleksey Shipilev wrote: > We have a few reports that existing Weak* VarHandle tests are still flaky, > for example on large AArch64 machines or small RISC-V machines. > > The flakiness is intrinsic to the nature of Weak* operations under tests, > that can

Re: RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v7]

2022-09-01 Thread Aleksey Shipilev
On Tue, 30 Aug 2022 14:18:11 GMT, Aleksey Shipilev wrote: >> We have a few reports that existing Weak* VarHandle tests are still flaky, >> for example on large AArch64 machines or small RISC-V machines. >> >> The flakiness is intrinsic to the nature of Weak* operations under tests, >> that

Re: RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures [v4]

2022-09-01 Thread Martin Doerr
On Wed, 31 Aug 2022 08:05:03 GMT, Aleksey Shipilev wrote: >> It's awkward to manage this across various hardware, esp. if the hardware is >> less mature (perhaps combined with a less mature HotSpot implementation). >> The approach looks reasonable, but it would be nice if we could just >>

Re: RFR: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations [v13]

2022-09-01 Thread Volker Simonis
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to > highlight that it might write more bytes than the returned number of > inflated bytes into the buffer `b`. > > The superclass `java.io.InputStream` specifies that `read(byte[] b, int off, > int len)` will leave

Re: RFR: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations [v12]

2022-09-01 Thread Volker Simonis
On Wed, 31 Aug 2022 21:05:18 GMT, Joe Darcy wrote: >> Volker Simonis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated JavaDoc according to @mbreinhold's suggestions > >

Re: RFR: 8291651: CleanerTest.java fails with "Cleanable was cleaned" [v2]

2022-09-01 Thread Jaikiran Pai
On Tue, 30 Aug 2022 18:33:24 GMT, Roger Riggs wrote: >> CleanerTest is failing intermittently on Aarch64, with -Xcomp, and using a >> VirtualThread for the Cleaner in the test. >> The extensively relies on references processing and invokes GC on a very >> short cycle. >> The existing 10ms

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v7]

2022-09-01 Thread David Holmes
On Mon, 29 Aug 2022 08:21:02 GMT, Alan Bateman wrote: >> I don't think we need to distinguish between platform and virtual threads >> here at all. Isn't it the case that virtual threads also have a run() method >> and they too terminate when run() completes as described (together with >>

Re: RFR: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation [v2]

2022-09-01 Thread Jaikiran Pai
On Wed, 31 Aug 2022 08:40:29 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/java/text/PatternEntry.java line 55: >> >>> 53: * Gets the current extension, quoted >>> 54: */ >>> 55: public void appendQuotedExtension(StringBuilder toAddTo) { >> >> Hello Andrey, this and

RFR: 8293197: Avoid double racy reads from non-volatile fields in SharedSecrets

2022-09-01 Thread Andrey Turbanov
After integration of [JDK-8259021](https://bugs.openjdk.org/browse/JDK-8259021) a few more fields were added to `SharedSecrets` class. It make sense to update their reading code to use the same idiom. - Commit messages: - [PATCH] SharedSecrets should avoid double racy reads from