> Please review this small optimization. As shown in the JBS issue, most of the
> generated LambdaForm classes have a single ClassData, so we can get a small
> footprint/speed improvement.
Ioi Lam has updated the pull request with a new target base due to a merge or a
rebase. The incremental
Hi!
Perhaps core-libs-dev is the more appropriate mailing list, but there are
hundreds of posts a month there. I'm not sure whether the severity of the
problem would require a more fundamental solution. So I will reply here as
well, because I see that Brian Goetz reviewed and endorsed the JEP-400
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
On Tue, 18 Oct 2022 19:53:50 GMT, Mahendra Chhipa wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AssertThrows an exception in InconsistentEntries test.
>
>
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
> "the the" -> "the"
>
> I'll reflow the paragraph before pushing.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Reflow
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10750/files
- new:
On Tue, 18 Oct 2022 19:37:17 GMT, Brent Christian wrote:
>> Good point, will reassign it to one line.
>>
>> "Also, use %s forfirst, as it's a Throwable",
>> I believe I am assigning %d to pass+fail and fail. I pass first as a
>> Throwable to the runtime exception constructor.
>
> Oh, right.
On Tue, 18 Oct 2022 20:27:54 GMT, Joe Darcy wrote:
> "the the" -> "the"
>
> I'll reflow the paragraph before pushing.
This pull request has now been integrated.
Changeset: 95baf83d
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/95baf83dd60cc50d30b6b240618f17d296780548
On Tue, 18 Oct 2022 20:59:41 GMT, Joe Darcy wrote:
>> "the the" -> "the"
>>
>> I'll reflow the paragraph before pushing.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflow
looks looks good good ;-)
-
On Tue, 18 Oct 2022 20:27:54 GMT, Joe Darcy wrote:
> "the the" -> "the"
>
> I'll reflow the paragraph before pushing.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10750
On Tue, 18 Oct 2022 20:27:54 GMT, Joe Darcy wrote:
> "the the" -> "the"
>
> I'll reflow the paragraph before pushing.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10750
"the the" -> "the"
I'll reflow the paragraph before pushing.
-
Commit messages:
- JDK-8295517: Fix stutter typo in JDK-8294539
Changes: https://git.openjdk.org/jdk/pull/10750/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=10750=00
Issue:
On Tue, 18 Oct 2022 17:44:45 GMT, Naoto Sato wrote:
> Plurals were determined only by looking at the integer part of the compact
> number. Changed to consider the fraction digits as well.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10748
On Tue, 18 Oct 2022 14:35:14 GMT, Aggelos Biboudis
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Appease jcheck; reflow paragraphs.
>
> src/java.base/share/classes/java/lang/Double.java line 172:
>
>> 170: *
>>
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
On Mon, 17 Oct 2022 21:48:42 GMT, Ioi Lam wrote:
>> Please review this small optimization. As shown in the JBS issue, most of
>> the generated LambdaForm classes have a single ClassData, so we can get a
>> small footprint/speed improvement.
>
> Ioi Lam has updated the pull request with a new
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
On Tue, 18 Oct 2022 19:48:15 GMT, Justin Lu wrote:
>> So, the above suggestion gives explicit auto-boxing, though some might find
>> it wordier than necessary.
>>
>> Since `v.byteValue()` already returns a `byte`, the `(byte)` cast doesn't
>> seem necessary. I see that L242 does:
>>> `return
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
On Tue, 18 Oct 2022 19:10:00 GMT, Brent Christian wrote:
>> test/jdk/java/util/Formatter/BasicByteObject.java line 232:
>>
>>> 230:
>>> 231: private static Byte negate(Byte v) {
>>> 232: return (byte) -v.byteValue();
>>
>> We want to be returning a `Byte`, so casting to `(byte)`
On Tue, 18 Oct 2022 19:25:01 GMT, Justin Lu wrote:
>> test/jdk/java/util/Formatter/Basic.java line 90:
>>
>>> 88:
>>> 89: if (fail != 0) {
>>> 90: throw new RuntimeException(String.format("%d tests: %d
>>> failure(s)" +
>>
>> You might consider including `", first"` with
On Tue, 18 Oct 2022 19:20:58 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove testing change
>> - Fix formatter in Basic
>
> test/jdk/java/util/Formatter/Basic.java line 90:
>
>> 88:
On Tue, 18 Oct 2022 19:04:29 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within
On Fri, 14 Oct 2022 00:37:53 GMT, Brent Christian wrote:
>> Issue: java/util/Formatter/Basic regression test emits lots of warning
>> messages (~60).
>>
>> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files
>> where the errors originate from are generated from the
On Thu, 13 Oct 2022 01:02:43 GMT, Justin Lu wrote:
> Issue: java/util/Formatter/Basic regression test emits lots of warning
> messages (~60).
>
> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files
> where the errors originate from are generated from the template.
>
>
On Tue, 18 Oct 2022 18:54:58 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within
On Tue, 18 Oct 2022 18:54:03 GMT, Justin Lu wrote:
>> test/jdk/java/util/Formatter/Basic.java line 93:
>>
>>> 91: ", first" , fail+pass, fail), first);
>>> 92: else
>>> 93: System.out.printf("All %s tests passed", pass);
>>
>> %d, yes?
>
> Right, will
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
On Tue, 18 Oct 2022 18:46:16 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust output formating in Basic
>
> test/jdk/java/util/Formatter/Basic.java line 93:
>
>> 91: ",
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
On Tue, 18 Oct 2022 18:24:56 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within
On Tue, 18 Oct 2022 18:03:57 GMT, Lance Andersen wrote:
>> test/jdk/java/util/Formatter/BasicTestLauncher.java line 47:
>>
>>> 45: private static final String TZ_UP = "US/Pacific";
>>> 46: // Asia/Novosibirsk time zone
>>> 47: private static final String TZ_AN = "Asia/Novosibirsk";
On Tue, 18 Oct 2022 17:36:24 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 35:
>
>> 33: *
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
On Tue, 18 Oct 2022 17:28:49 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 47:
>
>> 45:
On Tue, 18 Oct 2022 17:49:01 GMT, Lance Andersen wrote:
>> test/jdk/java/util/Formatter/Basic.java line 93:
>>
>>> 91:+ fail + " failure(s), first",
>>> first);
>>> 92: else
>>> 93: System.out.printf("all " + pass + " tests passed");
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
On Tue, 18 Oct 2022 17:05:08 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within
On Tue, 18 Oct 2022 17:26:52 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/Basic.java line 93:
>
>> 91:
Plurals were determined only by looking at the integer part of the compact
number. Changed to consider the fraction digits as well.
-
Commit messages:
- 8295372: CompactNumberFormat handling of number one with decimal part
Changes: https://git.openjdk.org/jdk/pull/10748/files
On Tue, 18 Oct 2022 05:21:47 GMT, Ioi Lam wrote:
>> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
>> line 346:
>>
>>> 344:
>>> 345: /**
>>> 346: * Returns an object to pass this.classData to the method
>>> of the
>>
>> What about:
>>
>> Suggestion:
>>
On Tue, 18 Oct 2022 17:05:08 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as
On Tue, 18 Oct 2022 08:19:41 GMT, Markus KARG wrote:
> Does "security review" mean, that I shall proof the absence of the problem,
> or does that term mean a formal process in the OpenJDK organization (and how
> do I trigger it)?
I sent a link to this PR to one of the security engineers and
On Mon, 17 Oct 2022 22:22:30 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 99:
>
>> 97:
On Mon, 17 Oct 2022 22:39:22 GMT, Brent Christian wrote:
>> test/jdk/java/util/Formatter/BasicTestLauncher.java line 52:
>>
>>> 50:
>>> 51: @Test
>>> 52: public void testUsPac() throws IOException{
>>
>> You could use a DataProvider
>
> I had the same thought
Thanks Lance and Brent,
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basic unit tests
>
>
> Original output on success
>
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as
This is a continuation of the effort to update all our URLs to the new
top-level domain.
This patch updates (most) URLs in testing code. There still exists references
to openjdk.java.net, but that are not strictly used as normal URLs, which I
deemed need special care, so I left them out of
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
- Original Message -
> From: "Stuart Marks"
> To: "Remi Forax"
> Cc: "core-libs-dev"
> Sent: Sunday, October 16, 2022 12:25:18 AM
> Subject: Re: [External] : Re: New candidate JEP: 431: Sequenced Collections
> Hi Rémi,
>
> On 10/14/22 1:20 AM, Remi Forax wrote:
>> People will again
On Tue, 4 Oct 2022 19:56:21 GMT, Joe Darcy wrote:
>> While the floating-point == operation is *not* an equivalence relation,
>> there are useful equivalence relations that can be defined over
>> floating-point values. Text is added to java.lang.Double to discuss and name
>> those relations.
>
On Mon, 17 Oct 2022 15:32:55 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more
On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote:
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
This pull request has now been integrated.
Changeset: 8c40b7dc
Author:Sean
On Mon, 3 Oct 2022 18:32:29 GMT, Raffaello Giulietti
wrote:
> Completes the spec of [PR 10541](https://github.com/openjdk/jdk/pull/10541)
This pull request has now been integrated.
Changeset: 0b7d811c
Author:Raffaello Giulietti
URL:
On Mon, 17 Oct 2022 15:32:55 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more
On Tue, 18 Oct 2022 08:17:55 GMT, Alan Bateman wrote:
> The test is not the issue, it's that the proposal will require a security
> review. Yes, copying the bytes would remove that concern.
Does "security review" mean, that I shall proof the absence of the problem, or
does that term mean a
On Mon, 3 Oct 2022 05:54:31 GMT, Markus KARG wrote:
>> This PR implements JDK-8294696.
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Checking explicitly -1 instead of < 0
The test is not the issue, it's that the proposal
On Tue, 6 Sep 2022 16:47:03 GMT, Ioi Lam wrote:
>> This PR introduces a system property that creates stable names for the
>> lambda classes in the JDK. Instead of using an atomic counter in the lambda
>> name, we can use a 32-bit hash after `$$Lambda$`. Thus, the name becomes
>>
On Mon, 17 Oct 2022 11:14:35 GMT, Alan Bateman wrote:
>>> > @AlanBateman WDYT? Is such a test mandatory to include this rather simple
>>> > PR?
>>>
>>> I think it means checking that
>>> test/jdk/java/io/BufferedInputStream/TransferTo.java exercises this code
>>> path, I expect it should.
On Thu, 15 Sep 2022 11:50:57 GMT, Strahinja Stanojevic wrote:
>> This PR introduces a system property that creates stable names for the
>> lambda classes in the JDK. Instead of using an atomic counter in the lambda
>> name, we can use a 32-bit hash after `$$Lambda$`. Thus, the name becomes
>>
63 matches
Mail list logo
