Re: RFR: 8296154: [macos] Change "/Applications" to "Applications" in DMG image [v2]

2022-11-04 Thread Alexander Matveev
On Fri, 4 Nov 2022 23:44:15 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8296154: [macos] Change /Applications to Applications in DMG image [v2] > >

Re: RFR: 8296154: [macos] Change "/Applications" to "Applications" in DMG image [v2]

2022-11-04 Thread Alexander Matveev
> Changed names of symbolic links for drag and drop location in DMG image. See > attached images in JBS. > "/Applications" -> "Applications" for app DMG image. > "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime DMG > image. > > Automated test was not added, since

Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v3]

2022-11-04 Thread Bill Huang
On Fri, 4 Nov 2022 15:17:43 GMT, Mahendra Chhipa wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reverted exclusion of nonlocal registry tests. > >

Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v4]

2022-11-04 Thread Bill Huang
> The current non local registry tests require a manual process that runs > rmiregitrty on a different machine and changes the -Dregistry.host property > in the source before running the tests on the local machine. This task is > created to improve this manual process and provide a clearer

Re: RFR: 8296154: [macos] Change /Applications to Applications in DMG image

2022-11-04 Thread Alexey Semenyuk
On Fri, 4 Nov 2022 23:26:00 GMT, Alexander Matveev wrote: > Changed names of symbolic links for drag and drop location in DMG image. See > attached images in JBS. > "/Applications" -> "Applications" for app DMG image. > "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime

RFR: 8296154: [macos] Change /Applications to Applications in DMG image

2022-11-04 Thread Alexander Matveev
Changed names of symbolic links for drag and drop location in DMG image. See attached images in JBS. "/Applications" -> "Applications" for app DMG image. "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime DMG image. Automated test was not added, since DMGsetup.scpt is not

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v2]

2022-11-04 Thread Markus KARG
> This PR implements JDK-8296431 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: fixed wrong bug number - Changes: - all: https://git.openjdk.org/jdk/pull/10999/files - new:

RFR: 8296431 - PushbackInputStream should override transferTo

2022-11-04 Thread Markus KARG
This PR implements JDK-8296431 - Commit messages: - Alternative C + Array.copyOfRange - Draft: Prevent security issues - wrapped long code lines - removed unused import - Writing available unread bytes in the optimized case - PushbackInputStream::transferTo Changes:

Integrated: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set

2022-11-04 Thread Markus KARG
On Sat, 1 Oct 2022 20:29:23 GMT, Markus KARG wrote: > This PR implements JDK-8294696. This pull request has now been integrated. Changeset: 581133a0 Author:Markus Karg Committer: Brian Burkhalter URL: https://git.openjdk.org/jdk/commit/581133a0c8c7d7e98614937c54db3723cd248f07

Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v2]

2022-11-04 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-434 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.org/jeps/434 Maurizio Cimadamore has updated the pull request

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v6]

2022-11-04 Thread Alan Bateman
On Mon, 31 Oct 2022 13:30:13 GMT, Markus KARG wrote: >> This PR implements JDK-8294696. > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Alternative C + Arrays.copyOfRange() Marked as reviewed by alanb (Reviewer).

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v6]

2022-11-04 Thread Brian Burkhalter
On Mon, 31 Oct 2022 13:30:13 GMT, Markus KARG wrote: >> This PR implements JDK-8294696. > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Alternative C + Arrays.copyOfRange() Looks all right. - Marked as

Proposal: track zlib native memory usage with NMT

2022-11-04 Thread Thomas Stüfe
Hi all, I am currently working on https://bugs.openjdk.org/browse/JDK-8296360; I was preparing the final PR [1], but then Alan did ask me to discuss this on core-libs first. Backstory: NMT tracks hotspot native allocations but does not cover the JDK libraries (small exception:

RFR: 8294961: java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes

2022-11-04 Thread Adam Sotona
java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes and this patch converts it to use Classfile API. This pull request suppose to chain on the 8294982: Implementation of Classfile API https://github.com/openjdk/jdk/pull/10982 Please review. Thank you, Adam

Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v3]

2022-11-04 Thread Mahendra Chhipa
On Thu, 27 Oct 2022 19:08:06 GMT, Bill Huang wrote: >> The current non local registry tests require a manual process that runs >> rmiregitrty on a different machine and changes the -Dregistry.host property >> in the source before running the tests on the local machine. This task is >> created

RFR: 8294982: Implementation of Classfile API

2022-11-04 Thread Adam Sotona
This is root pull request with Classfile API implementation, tests and benchmarks initial drop into JDK. Following pull requests consolidating JDK class files parsing, generating, and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to this one. Classfile

Re: RFR: 8295673: Deprecate legacy parallel class loading workaround for non-parallel-capable class loaders

2022-11-04 Thread Coleen Phillimore
On Fri, 4 Nov 2022 02:07:25 GMT, David Holmes wrote: >> This change adds an option **EnableWaitForParallelLoad** to enable the >> legacy behavior where the VM will manage synchronization for multiple >> threads loading the same class using a non-parallel capable class loader >> that have

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-11-04 Thread Rémi Forax
On Thu, 3 Nov 2022 14:37:55 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/template/ProcessorLinkage.java line 60: >> >>> 58: * @throws NullPointerException if any of the arguments are null >>> 59: */ >>> 60: MethodHandle linkage(List fragments, MethodType type);

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v11]

2022-11-04 Thread Rémi Forax
On Wed, 2 Nov 2022 21:53:00 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/jdk/internal/template/TemplateSupport.java line >> 147: >> >>> 145: >>> 146: return support.processWithProcessor(); >>> 147: } >> >> Thinking about this protocol some more: this seems to depend on