Hi Alan,
(replaced hotspot-runtime-dev with hotspot-dev, since its more of a general
topic)
thank you for your time!
I am very happy to talk this through. I think native memory observability
in the JDK (and customer code!) is sorely lacking. Witness the countless
"where did my native memory go"
> This PR implements JDK-8296431
Markus KARG has updated the pull request incrementally with one additional
commit since the last revision:
Removed unused imports
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10999/files
- new:
On Mon, 7 Nov 2022 17:29:15 GMT, Brian Burkhalter wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed typo
>
> test/jdk/java/io/PushbackInputStream/TransferTo.java line 24:
>
>> 22: */
>> 23:
>> 24: import
On Tue, 8 Nov 2022 23:48:22 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
Could I have a review of PR that fixes so unsigned numbers are printed
correctly in the jfr tool.
Testing:
test/jdk/jdk/jfr
test/jdk/jdk/security/logging/
Thanks
Erik
-
Commit messages:
- Initial
Changes: https://git.openjdk.org/jdk/pull/11039/files
Webrev:
On Fri, 4 Nov 2022 17:21:04 GMT, Justin Lu wrote:
> Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to
> Euro (to take place on 1/1/2023).
This pull request has now been integrated.
Changeset: fd837649
Author:Justin Lu
Committer: Naoto Sato
URL:
On Tue, 8 Nov 2022 19:14:25 GMT, Roger Riggs wrote:
>> Claes Redestad has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Merge pull request #2 from luhenry/dev/cl4es/8282664-polyhash
>>
>>Unroll + Reorder BBs
>> - fixup! Handle
On Tue, 25 Oct 2022 16:03:28 GMT, Ludovic Henry wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and
On Tue, 8 Nov 2022 22:08:06 GMT, Coleen Phillimore wrote:
> in the custom class loader must synchronize appending to the class path
I would say:
"in the custom class loader must append to the class path in a thread-safe
manner."
-
PR: https://git.openjdk.org/jdk/pull/11023
On Tue, 8 Nov 2022 14:55:17 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
Pull in linker implementation changes, that include non-trivial changes to VM
code, from the panama-foreign repo into the main JDK.
This is split off from the main JEP integration to make reviewing easier.
This includes the following patches:
1.
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Tue, 8 Nov 2022 17:20:39 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
On Tue, 8 Nov 2022 08:39:39 GMT, Serguei Spitsyn wrote:
>> There is no new changes in the open portion of JDK, but extracting common
>> functionalities in bootstrap Utils to test/lib/Utils which can be used in
>> the closed part.
>
> test/lib/jdk/test/lib/Utils.java line 1007:
>
>> 1005:
> There is no new changes in the open portion of JDK, but extracting common
> functionalities in bootstrap Utils to test/lib/Utils which can be used in the
> closed part.
Bill Huang has updated the pull request incrementally with one additional
commit since the last revision:
Implemented
On Tue, 8 Nov 2022 18:14:21 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Tue, 8 Nov 2022 17:03:05 GMT, Coleen Phillimore wrote:
> Can one create a class loader to override this function, and does one expect
> the JVM to synchronize it on the system class loader object (returned by
> getSystemClassLoader)? This feels too remote to try to explain in a CSR.
>
>
On Fri, 4 Nov 2022 17:21:04 GMT, Justin Lu wrote:
> Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to
> Euro (to take place on 1/1/2023).
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10994
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Tue, 8 Nov 2022 16:30:14 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 8 Nov 2022 13:28:58 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally
On Fri, 21 Oct 2022 06:04:34 GMT, Jaikiran Pai wrote:
>> Process.waitFor() throws IllegalThreadStateException when a process returns
>> an exit code of 259.
>> As described in the bug report, `waitFor()` should not be sensitive to the
>> exit value.
>> Previously, it erroneously threw
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
> Process.waitFor() throws IllegalThreadStateException when a process returns
> an exit code of 259.
> As described in the bug report, `waitFor()` should not be sensitive to the
> exit value.
> Previously, it erroneously threw IllegalStateException.
> Added a test to verify.
Roger Riggs has
On Wed, 12 Oct 2022 16:30:07 GMT, Roger Riggs wrote:
> Process.waitFor() throws IllegalThreadStateException when a process returns
> an exit code of 259.
> As described in the bug report, `waitFor()` should not be sensitive to the
> exit value.
> Previously, it erroneously threw
On Tue, 8 Nov 2022 12:47:29 GMT, Alan Bateman wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Handle non OOM exceptions and rename subgroupsAsArray.
>
> I wonder if the intermediate resource array is needed
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally
On Tue, 8 Nov 2022 13:06:50 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Tue, 8 Nov 2022 12:48:01 GMT, Alan Bateman wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Handle non OOM exceptions and rename subgroupsAsArray.
>
> src/java.base/share/classes/java/lang/ThreadGroup.java
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 8 Nov 2022 00:26:56 GMT, Aleksei Efimov wrote:
>> ### The Proposed Change
>>
>> The proposed change updates JNDI's `DnsClient` internal implementation to
>> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
>> The main motivation behind this change is to make
On Tue, 8 Nov 2022 12:30:37 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request
On Tue, 8 Nov 2022 04:35:48 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Handle non OOM exceptions and rename subgroupsAsArray.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 810:
>
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 8 Nov 2022 00:26:56 GMT, Aleksei Efimov wrote:
>> ### The Proposed Change
>>
>> The proposed change updates JNDI's `DnsClient` internal implementation to
>> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
>> The main motivation behind this change is to make
On Tue, 8 Nov 2022 11:35:17 GMT, Raffaello Giulietti
wrote:
> A small spec change to match established behavior.
As this is a spec change only, please consider reviewing the CSR as well.
-
PR: https://git.openjdk.org/jdk/pull/11038
On Tue, 8 Nov 2022 00:58:44 GMT, Coleen Phillimore wrote:
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
Thanks Alan for your comment - yes, I think doing upcalls
On Tue, 8 Nov 2022 10:05:34 GMT, Alan Bateman wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> src/java.base/share/classes/java/lang/ThreadGroup.java
A small spec change to match established behavior.
-
Commit messages:
- 8296529: Document the default behavior of '$' in regular expressions
correctly
Changes: https://git.openjdk.org/jdk/pull/11038/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11038=00
Issue:
On Tue, 8 Nov 2022 10:42:13 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Tue, 8 Nov 2022 00:58:44 GMT, Coleen Phillimore wrote:
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
src/java.base/share/classes/java/lang/ThreadGroup.java
On Tue, 8 Nov 2022 04:45:17 GMT, David Holmes wrote:
> This is a nice simplification of the VM side of the code! I do have to wonder
> why this was implemented the way it was rather than doing the simple upcall
> as you now do, but I suspect it was just performance,
I don't think JVMTI
On Tue, 8 Nov 2022 00:58:44 GMT, Coleen Phillimore wrote:
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
This looks nice in general.
But I will make another pass.
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote:
> There is no new changes in the open portion of JDK, but extracting common
> functionalities in bootstrap Utils to test/lib/Utils which can be used in the
> closed part.
test/lib/jdk/test/lib/Utils.java line 1007:
> 1005:
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote:
> There is no new changes in the open portion of JDK, but extracting common
> functionalities in bootstrap Utils to test/lib/Utils which can be used in the
> closed part.
I've placed a couple of comments.
Otherwise, it looks okay to me.
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote:
> There is no new changes in the open portion of JDK, but extracting common
> functionalities in bootstrap Utils to test/lib/Utils which can be used in the
> closed part.
test/lib/jdk/test/lib/Utils.java line 980:
> 978:
On Tue, 8 Nov 2022 04:23:13 GMT, David Holmes wrote:
> Note the loader involved need not be our own default platform loader and we
> don't know how a custom system loader might operate. The specification for
> this says nothing about thread-safety, nor that the VM will do any locking,
> so I
60 matches
Mail list logo
