Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Alexander Matveev
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes jpackage changes looks good.

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Chris Plummer
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes `src/jdk.jdi/share/classes/com/sun/tools`

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes @dfuch Could I get a review from you as

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:30:52 GMT, Weijun Wang wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert double quote as well > > src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java > line 75:

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:12:58 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > >

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 00:17:15 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl >> line 2: >> >>> 1: >>> 2: >> xmlns="http://schemas.microsoft.com/wix/2006/localization; Codepage="1252"> >> >> Why "de-de" was changed to

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 01:02:03 GMT, Damon Nguyen wrote: >> Looks like translation is done on files before JDK-8293462 was integrated >> (before Sep 26). See >>

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert old translation. Fix lang codes - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new:

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 00:51:55 GMT, Alexander Matveev wrote: >> I'm not sure for the decisions of change in punctuation and for the missing >> {1} as I didn't do the translation myself. Would this be better to be >> reverted? > > Looks like translation is done on files before JDK-8293462 was

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Alexander Matveev
On Fri, 16 Dec 2022 00:24:26 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties >> line 37: >> >>> 35: >>>

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Alexander Matveev
On Fri, 16 Dec 2022 00:15:51 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties >> line 82: >> >>> 80: >>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in >>> app-image-Verzeichnis ({0}) >>> 82:

Integrated: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86

2022-12-15 Thread Sergey Bylokhov
On Tue, 13 Dec 2022 00:06:00 GMT, Sergey Bylokhov wrote: > The `java/lang/String/StringRepeat.java` test was updated twice after > integration: > > https://bugs.openjdk.org/browse/JDK-8221400 - the xmx4g was replaced by the > xmx2g > https://bugs.openjdk.org/browse/JDK-8265421 - the

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:13:22 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > >

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 22:57:31 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > >

Re: JEP-198 - Lets start talking about JSON

2022-12-15 Thread Ethan McCue
> are pure JSON parsers really the go-to for most people? Depends on what you mean by JSON parsers and it depends on what you mean by people. To the best of my knowledge, both python and Javascript do not include streaming, databinding, or path navigation capabilities in their json parsers. On

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Weijun Wang
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well

Re: JEP-198 - Lets start talking about JSON

2022-12-15 Thread Ethan McCue
> The 95%+ use case for working with JSON for your average java coder is best done with data binding. To be brave yet controversial: I'm not sure this is neccesarily true. I will elaborate and respond to the other points after a hot cocoa, but the last point is part of why I think that

Re: JEP-198 - Lets start talking about JSON

2022-12-15 Thread Johannes Lichtenberger
I'll have to read the whole thing, but are pure JSON parsers really the go-to for most people? I'm a big advocate of providing also something similar to XPath/XQuery and that's IMHO JSONiq (90% XQuery). I might be biased, of course, as I'm working on Brackit[1] in my spare time (which is also a

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Alexander Matveev
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Alexander Matveev
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix https and changed URL back

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well Marked as reviewed by naoto (Reviewer).

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert double quote as well - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new:

Re: JEP-198 - Lets start talking about JSON

2022-12-15 Thread Reinier Zwitserloot
A recent Advent-of-Code puzzle also made me double check the support of JSON in the java core libs and it is indeed a curious situation that the java core libs don’t cater to it particularly well. However, I’m not seeing an easy way forward to try to close this hole in the core library offerings.

Re: Boilerplate to add a new module

2022-12-15 Thread Jonathan Gibbons
No changes or updates are required for jtreg -- Jon On 12/13/22 7:36 PM, Ethan McCue wrote: (jtreg I assume has some extra setup? Anything else?)

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix https and changed URL back Thanks for the update, Damon. Looks good for this

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 18:52:45 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_de.properties > line

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix https and changed URL back - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new:

JEP-198 - Lets start talking about JSON

2022-12-15 Thread Ethan McCue
I'm writing this to drive some forward motion and to nerd-snipe those who know better than I do into putting their thoughts into words. There are three ways to process JSON[1] - Streaming (Push or Pull) - Traversing a Tree (Realized or Lazy) - Declarative Databind (N ways) Of these, JEP-198

Integrated: 8298416: Console should be declared `sealed`

2022-12-15 Thread Naoto Sato
On Fri, 9 Dec 2022 20:14:53 GMT, Naoto Sato wrote: > `Console` class now has a couple of internal subclasses within `java.io` > package. It should be `sealed` and subclasses be declared in the `permits` > clause. The implementation resided in `Console` class is separated into > `ConsoleImpl`

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 02:45:48 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Removed trailing whitespace Changes requested by naoto (Reviewer).

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 02:23:34 GMT, Damon Nguyen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line >> 26: >> >>> 24: # >>> 25: >>> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >>> JMOD-Dateien auflisten >> >> `jlink.description`

Re: RFR: 8298416: Console should be declared `sealed` [v5]

2022-12-15 Thread Alan Bateman
On Thu, 15 Dec 2022 17:59:59 GMT, Naoto Sato wrote: >> `Console` class now has a couple of internal subclasses within `java.io` >> package. It should be `sealed` and subclasses be declared in the `permits` >> clause. The implementation resided in `Console` class is separated into >>

Re: RFR: 8298416: Console should be declared `sealed` [v4]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 17:45:38 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> newUnsupportedOperationException(), cosmetic changes to method descs > >

Re: RFR: 8298416: Console should be declared `sealed` [v5]

2022-12-15 Thread Naoto Sato
> `Console` class now has a couple of internal subclasses within `java.io` > package. It should be `sealed` and subclasses be declared in the `permits` > clause. The implementation resided in `Console` class is separated into > `ConsoleImpl` class. Naoto Sato has updated the pull request

Re: RFR: 8298416: Console should be declared `sealed` [v4]

2022-12-15 Thread Alan Bateman
On Thu, 15 Dec 2022 17:12:33 GMT, Naoto Sato wrote: >> `Console` class now has a couple of internal subclasses within `java.io` >> package. It should be `sealed` and subclasses be declared in the `permits` >> clause. The implementation resided in `Console` class is separated into >>

Re: RFR: 8298808: Check `script` code on detecting the base locales [v2]

2022-12-15 Thread Joe Wang
On Wed, 14 Dec 2022 23:47:43 GMT, Naoto Sato wrote: >> Fixing `CLDRConverter` build tool to not regard [new >> locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731) >> introduced in CLDR 43 as one of the base

Re: RFR: 8298416: Console should be declared `sealed` [v3]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 12:24:34 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moved echo() to ConsoleImpl, clean-ups > > src/java.base/share/classes/java/io/Console.java line 111: > >> 109:

Re: RFR: 8298416: Console should be declared `sealed` [v4]

2022-12-15 Thread Naoto Sato
> `Console` class now has a couple of internal subclasses within `java.io` > package. It should be `sealed` and subclasses be declared in the `permits` > clause. The implementation resided in `Console` class is separated into > `ConsoleImpl` class. Naoto Sato has updated the pull request

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v3]

2022-12-15 Thread Brian Burkhalter
On Thu, 15 Dec 2022 15:01:46 GMT, Alan Bateman wrote: >> Per Minborg has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Improve benchmarks >> - Add benchmark >> - Use Bits instead of custom code > >

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-15 Thread Ismael Juma
On Fri, 11 Nov 2022 13:00:06 GMT, Claes Redestad wrote: >> Continuing the work initiated by @luhenry to unroll and then intrinsify >> polynomial hash loops. >> >> I've rewired the library changes to route via a single `@IntrinsicCandidate` >> method. To make this work I've harmonized how they

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v3]

2022-12-15 Thread Alan Bateman
On Thu, 15 Dec 2022 09:56:37 GMT, Per Minborg wrote: >> This PR suggests improving performance for read and write operations for the >> longer primitives in `RandomAccessFile`. >> >> These improvements would also propagate to other JDK classes relying on >> these improved `RandomAccessFile`

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v3]

2022-12-15 Thread Alan Bateman
On Thu, 15 Dec 2022 09:56:37 GMT, Per Minborg wrote: >> This PR suggests improving performance for read and write operations for the >> longer primitives in `RandomAccessFile`. >> >> These improvements would also propagate to other JDK classes relying on >> these improved `RandomAccessFile`

Re: RFR: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86

2022-12-15 Thread Paul Hohensee
On Tue, 13 Dec 2022 00:06:00 GMT, Sergey Bylokhov wrote: > The `java/lang/String/StringRepeat.java` test was updated twice after > integration: > > https://bugs.openjdk.org/browse/JDK-8221400 - the xmx4g was replaced by the > xmx2g > https://bugs.openjdk.org/browse/JDK-8265421 - the

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v6]

2022-12-15 Thread Adam Sotona
> **This pull request is not intended for immediate integration to JDK > mainline.** > > This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v5]

2022-12-15 Thread Adam Sotona
> **This pull request is not intended for immediate integration to JDK > mainline.** > > This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-15 Thread Ludovic Henry
On Wed, 16 Nov 2022 18:18:55 GMT, Claes Redestad wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missing & 0xff in StringLatin1::hashCode > > I'm getting pulled into other tasks and would request for this to be

Re: RFR: 8298416: Console should be declared `sealed` [v3]

2022-12-15 Thread Alan Bateman
On Wed, 14 Dec 2022 17:35:46 GMT, Naoto Sato wrote: >> `Console` class now has a couple of internal subclasses within `java.io` >> package. It should be `sealed` and subclasses be declared in the `permits` >> clause. The implementation resided in `Console` class is separated into >>

Re: [jdk20] RFR: 8298797: Specification of some restricted methods is incorrect

2022-12-15 Thread Per Minborg
On Thu, 15 Dec 2022 10:43:35 GMT, Maurizio Cimadamore wrote: > This patch fixes some inconsistencies in the javadoc for restricted methods: > > * ModuleLayer.Controller::addEnableNativeAccess has a shorted text in its > `@throws` clause. This shorted text is now used everywhere. > * One

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 01:13:32 GMT, Justin Lu wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties >> line 188: >> >>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >>> 187: >>> 188: main.plugin.category=\u7C7B\u522B >> >> As Naoto pointed out, it looks

Re: [jdk20] RFR: 8298797: Specification of some restricted methods is incorrect

2022-12-15 Thread Jorn Vernee
On Thu, 15 Dec 2022 10:43:35 GMT, Maurizio Cimadamore wrote: > This patch fixes some inconsistencies in the javadoc for restricted methods: > > * ModuleLayer.Controller::addEnableNativeAccess has a shorted text in its > `@throws` clause. This shorted text is now used everywhere. > * One

Re: RFR: 8298416: Console should be declared `sealed` [v3]

2022-12-15 Thread Jaikiran Pai
On Wed, 14 Dec 2022 17:35:46 GMT, Naoto Sato wrote: >> `Console` class now has a couple of internal subclasses within `java.io` >> package. It should be `sealed` and subclasses be declared in the `permits` >> clause. The implementation resided in `Console` class is separated into >>

Re: RFR: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86

2022-12-15 Thread Sergey Bylokhov
On Tue, 13 Dec 2022 00:06:00 GMT, Sergey Bylokhov wrote: > The `java/lang/String/StringRepeat.java` test was updated twice after > integration: > > https://bugs.openjdk.org/browse/JDK-8221400 - the xmx4g was replaced by the > xmx2g > https://bugs.openjdk.org/browse/JDK-8265421 - the

[jdk20] RFR: 8298797: Specification of some restricted methods is incorrect

2022-12-15 Thread Maurizio Cimadamore
This patch fixes some inconsistencies in the javadoc for restricted methods: * ModuleLayer.Controller::addEnableNativeAccess has a shorted text in its `@throws` clause. This shorted text is now used everywhere. * One overload of `MemorySegment::ofAddress` is missing the restricted method

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v3]

2022-12-15 Thread Per Minborg
On Thu, 15 Dec 2022 09:56:37 GMT, Per Minborg wrote: >> This PR suggests improving performance for read and write operations for the >> longer primitives in `RandomAccessFile`. >> >> These improvements would also propagate to other JDK classes relying on >> these improved `RandomAccessFile`

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v3]

2022-12-15 Thread Per Minborg
> This PR suggests improving performance for read and write operations for the > longer primitives in `RandomAccessFile`. > > These improvements would also propagate to other JDK classes relying on these > improved `RandomAccessFile` operations. Per Minborg has updated the pull request