Forwardport JDK 20 -> JDK 21
-
Commit messages:
- Merge remote-tracking branch 'jdk20/master' into Merge_jdk20
- 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE
- 8301863: ObjectInputFilter example incorrectly calls rejectUndecidedClass
The merge
On Tue, 7 Feb 2023 08:27:57 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Tue, 7 Feb 2023 08:27:57 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Wed, 8 Feb 2023 21:37:15 GMT, Joe Darcy wrote:
>> Next up on the FDLIBM porting countdown, the log method.
>>
>> Original C vs transliteration port:
>>
>>
>> $ diff -w Log.c Log.translit.java
>> 1c1
>> < /* __ieee754_log(x)
>> ---
>>> /**
>> 51,58c51,52
>> <
>> < #include "fdlibm.h"
> Next up on the FDLIBM porting countdown, the log method.
>
> Original C vs transliteration port:
>
>
> $ diff -w Log.c Log.translit.java
> 1c1
> < /* __ieee754_log(x)
> ---
>> /**
> 51,58c51,52
> <
> < #include "fdlibm.h"
> <
> < #ifdef __STDC__
> < static const double
> < #else
> <
On Tue, 7 Feb 2023 14:27:49 GMT, Scott Gibbons wrote:
> @sviswa7 Can you please share the test(s) you used to determine the stated
> failures? I've run all of the tier1-3 tests in the suite with no failures.
> Plus, if what you say is true, then the same logic would apply for the
> non-URL
On Tue, 7 Feb 2023 08:27:57 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Mon, 6 Feb 2023 17:39:42 GMT, Paul Sandoz wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add smaller array size for benchmark tests
>
> I think it would be useful to adjust the naming and comments of some
On Thu, 2 Feb 2023 20:09:22 GMT, Mandy Chung wrote:
> `test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java` defines
> hidden classes and verify cases that a class loader is not unloaded using
> `ForceGC::wait`.ForceGC::wait` defaults the timeout to 1000ms * jtreg
> timeout
On Wed, 8 Feb 2023 23:33:20 GMT, Tingjun Yuan wrote:
>> Document `java.util.Arrays.asList` that the list will throw an
>> `ArrayStoreException` when attempting to set an element with a wrong type.
>
> Tingjun Yuan has updated the pull request incrementally with one additional
> commit since
> Document `java.util.Arrays.asList` that the list will throw an
> `ArrayStoreException` when attempting to set an element with a wrong type.
Tingjun Yuan has updated the pull request incrementally with one additional
commit since the last revision:
Update Arrays.java
-
On Wed, 8 Feb 2023 23:17:20 GMT, Mandy Chung wrote:
>> `test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java` defines
>> hidden classes and verify cases that a class loader is not unloaded using
>> `ForceGC::wait`.ForceGC::wait` defaults the timeout to 1000ms * jtreg
>> timeout
> `test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java` defines
> hidden classes and verify cases that a class loader is not unloaded using
> `ForceGC::wait`.ForceGC::wait` defaults the timeout to 1000ms * jtreg
> timeout factor, which is designed to work well to expect an object
> This is an approach to adding a flag to jlink that will allow --compress to
> take the same types of arguments as jmod, thus bringing the two into
> alignment. This likely requires a CSR and a discussion on whether we should
> deprecate or simply remove the original numeric compression
On Mon, 6 Feb 2023 20:40:08 GMT, Roger Riggs wrote:
> The example code in ObjectInputFilter for the FilterInThread filter factory
> does not do what is intended and is poorly described. Clarifies that the
> JVM-wide filter and the thread local filter are merged and will reject
> classes that
On Mon, 6 Feb 2023 22:52:10 GMT, Roger Riggs wrote:
>> The example code in ObjectInputFilter for the FilterInThread filter factory
>> does not do what is intended and is poorly described. Clarifies that the
>> JVM-wide filter and the thread local filter are merged and will reject
>> classes
> Next up on the FDLIBM porting countdown, the log method.
>
> Original C vs transliteration port:
>
>
> $ diff -w Log.c Log.translit.java
> 1c1
> < /* __ieee754_log(x)
> ---
>> /**
> 51,58c51,52
> <
> < #include "fdlibm.h"
> <
> < #ifdef __STDC__
> < static const double
> < #else
> <
On Wed, 8 Feb 2023 13:11:25 GMT, Varada M wrote:
>> 1. test/jdk/jni/nullCaller/NullCallerTest.java
>> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>>
>> The above tests were blocked on AIX
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c
On Wed, 8 Feb 2023 20:30:13 GMT, Mandy Chung wrote:
>> test/lib/jdk/test/lib/util/ForceGC.java line 73:
>>
>>> 71: * if did not complete after the specified waiting time.
>>> 72: */
>>> 73: public static boolean wait(BooleanSupplier booleanSupplier, long
>>> timeout) {
>>
>>
On Thu, 2 Feb 2023 22:19:07 GMT, Roger Riggs wrote:
>> `test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java` defines
>> hidden classes and verify cases that a class loader is not unloaded using
>> `ForceGC::wait`.ForceGC::wait` defaults the timeout to 1000ms * jtreg
>> timeout
On Wed, 8 Feb 2023 17:07:22 GMT, Brian Burkhalter wrote:
>> To help add assurances that the main-line port of FDLIBM to Java is working
>> correctly, added some long-running manual tests to probe that the
>> transliteration port and the corresponding StrictMath method are in
>> agreement on a
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c
On Wed, 8 Feb 2023 18:39:42 GMT, Magnus Ihse Bursie wrote:
>> Hmm. Wouldn't hurt to do so.
>>
>> I was thinking of making a pass over Fdlibm.java at some point to make sure
>> the nested classes had package-level rather than public accessibility and
>> that the classes had private
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c
On Mon, 23 Jan 2023 07:33:21 GMT, Tingjun Yuan wrote:
>> Document `java.util.Arrays.asList` that the list will throw an
>> `ArrayStoreException` when attempting to set an element with a wrong type.
>
> Tingjun Yuan has updated the pull request incrementally with one additional
> commit since
On Tue, 7 Feb 2023 22:25:43 GMT, Mandy Chung wrote:
> A trivial fix. Convert the use of anonymous inner classes in a few
> Permission classes to lambdas to work around JDK-8076596, which has been
> resolved.
This pull request has now been integrated.
Changeset: 10dd98d0
Author:Mandy
On Wed, 8 Feb 2023 18:35:51 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/FdLibm.java line 1215:
>>
>>> 1213: * only sinh(0)=0 is exact for finite x.
>>> 1214: */
>>> 1215: static class Sinh {
>>
>> For clarity, should this not be declared `final`?
>
> Hmm.
On Tue, 7 Feb 2023 16:02:19 GMT, Magnus Ihse Bursie wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct overflow limit in regression test.
>
> src/java.base/share/classes/java/lang/FdLibm.java line 1215:
>
>>
On Wed, 8 Feb 2023 17:58:12 GMT, Mandy Chung wrote:
>> A trivial fix. Convert the use of anonymous inner classes in a few
>> Permission classes to lambdas to work around JDK-8076596, which has been
>> resolved.
>
> Mandy Chung has updated the pull request with a new target base due to a
>
> A trivial fix. Convert the use of anonymous inner classes in a few
> Permission classes to lambdas to work around JDK-8076596, which has been
> resolved.
Mandy Chung has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
On Wed, 8 Feb 2023 03:42:16 GMT, Mandy Chung wrote:
>> A trivial fix. Convert the use of anonymous inner classes in a few
>> Permission classes to lambdas to work around JDK-8076596, which has been
>> resolved.
>
> Mandy Chung has updated the pull request incrementally with one additional
>
On Wed, 8 Feb 2023 17:11:19 GMT, Claes Redestad wrote:
> Great! Extending coverage to provoke the issue on most charsets is good, and
> it should guard UTF-8 from regressing too - no?
It also guards UTFZipCoder from this particular regression, yes.
-
PR:
On Wed, 8 Feb 2023 03:42:16 GMT, Mandy Chung wrote:
>> A trivial fix. Convert the use of anonymous inner classes in a few
>> Permission classes to lambdas to work around JDK-8076596, which has been
>> resolved.
>
> Mandy Chung has updated the pull request incrementally with one additional
>
On Wed, 8 Feb 2023 16:36:16 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
On Mon, 6 Feb 2023 01:50:55 GMT, Joe Darcy wrote:
> To help add assurances that the main-line port of FDLIBM to Java is working
> correctly, added some long-running manual tests to probe that the
> transliteration port and the corresponding StrictMath method are in agreement
> on a large
On Mon, 6 Feb 2023 01:50:55 GMT, Joe Darcy wrote:
> To help add assurances that the main-line port of FDLIBM to Java is working
> correctly, added some long-running manual tests to probe that the
> transliteration port and the corresponding StrictMath method are in agreement
> on a large
On Wed, 8 Feb 2023 15:31:15 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
On Wed, 8 Feb 2023 15:31:15 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
On Wed, 8 Feb 2023 15:31:15 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
On Wed, 8 Feb 2023 13:11:25 GMT, Varada M wrote:
>> 1. test/jdk/jni/nullCaller/NullCallerTest.java
>> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>>
>> The above tests were blocked on AIX
On Wed, 8 Feb 2023 15:21:23 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
On Sat, 4 Feb 2023 08:59:29 GMT, Alan Bateman wrote:
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> -
On Wed, 8 Feb 2023 10:53:22 GMT, Claes Redestad wrote:
>> This patch adds special-cases to `Arrays.copyOf` and `Arrays.copyOfRange` to
>> clone arrays when `newLength` or range inputs span the input array. This
>> helps eliminate range checks and has been verified to help various String
>>
On Thu, 2 Feb 2023 20:09:22 GMT, Mandy Chung wrote:
> `test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java` defines
> hidden classes and verify cases that a class loader is not unloaded using
> `ForceGC::wait`.ForceGC::wait` defaults the timeout to 1000ms * jtreg
> timeout
On Tue, 7 Feb 2023 08:27:57 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Wed, 8 Feb 2023 12:19:35 GMT, Adam Sotona wrote:
>>> `Signature.ThrowableSig` is a `Signature` and it is a common super of
>>> `ClassTypeSig` and `TypeVarSig`.
>>
>> I really don't follow here. ThrowableSig is a piece of a method signature,
>> which starts with "^" and is followed by
On Wed, 8 Feb 2023 00:25:32 GMT, Joe Darcy wrote:
> Next up on the FDLIBM porting countdown, the log method.
>
> Original C vs transliteration port:
>
>
> $ diff -w Log.c Log.translit.java
> 1c1
> < /* __ieee754_log(x)
> ---
>> /**
> 51,58c51,52
> <
> < #include "fdlibm.h"
> <
> <
On Mon, 6 Feb 2023 20:12:09 GMT, Ian Graves wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to
>> take the same types of arguments as jmod, thus bringing the two into
>> alignment. This likely requires a CSR and a discussion on whether we should
>> deprecate
On Wed, 8 Feb 2023 11:33:07 GMT, Varada M wrote:
> I hate to see the code duplication, but we don't have a sharing mechanism for
> the native parts of tests so that can't be helped.
It may be interesting to invest some time to find out if the "don't start on
primordial thread" rule still
On Mon, 6 Feb 2023 20:12:09 GMT, Ian Graves wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to
>> take the same types of arguments as jmod, thus bringing the two into
>> alignment. This likely requires a CSR and a discussion on whether we should
>> deprecate
On Tue, 7 Feb 2023 13:23:26 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
> 1. test/jdk/jni/nullCaller/NullCallerTest.java
> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>
> The above tests were blocked on AIX [@require os.family != "aix"] because
> these tests are
On Wed, 8 Feb 2023 12:25:30 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 12:19:02 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/Thread/virtual/HoldsLock.java line 131:
>>
>>> 129: assertEquals(vthread.getClass().getName(),
>>> info.getLockInfo().getClassName());
>>> 130:
On Wed, 8 Feb 2023 11:37:14 GMT, Alan Bateman wrote:
>> 1. test/jdk/jni/nullCaller/NullCallerTest.java
>> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>>
>> The above tests were blocked on AIX
On Wed, 8 Feb 2023 12:18:12 GMT, Alan Bateman wrote:
> note that it impacts 45+ usages and I had hoped to avoid changing the tests
> too much.
I hadn't realized this construct was used in multiple other places. I see that
you already fixed them in a newer commit in this PR; thank you.
On Wed, 8 Feb 2023 09:39:21 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> - BeforeClass/AfterClass changed to static BeforeAll/AfterAll
On Wed, 8 Feb 2023 03:42:16 GMT, Mandy Chung wrote:
>> A trivial fix. Convert the use of anonymous inner classes in a few
>> Permission classes to lambdas to work around JDK-8076596, which has been
>> resolved.
>
> Mandy Chung has updated the pull request incrementally with one additional
>
On Wed, 8 Feb 2023 11:07:08 GMT, Maurizio Cimadamore
wrote:
>> `TypeParam` is not a signature, because it simply is not a signature.
>> Per spec:
>>
>> TypeParameter:
>> Identifier ClassBound {InterfaceBound}
>
>> `Signature.ThrowableSig` is a `Signature` and it is a common super of
>>
On Wed, 8 Feb 2023 11:57:16 GMT, Claes Redestad wrote:
> > > Seems there's a possible real test failure lurking here, might be
> > > intermittent since it only showed on one platform:
> >
> >
> > Did you get this from GHA somehow? Do you happen to know the platform,
> > timezone and encoding
On Wed, 8 Feb 2023 11:32:02 GMT, Eirik Bjorsnos wrote:
> > Seems there's a possible real test failure lurking here, might be
> > intermittent since it only showed on one platform:
>
> Did you get this from GHA somehow? Do you happen to know the platform,
> timezone and encoding used?
Yes,
On Wed, 8 Feb 2023 09:47:00 GMT, Alan Bateman wrote:
> as the alternative implementation of virtual threads (used on x86_32 and a
> few other ports) don't allow custom schedulers.
Thank you for that detail.
-
PR: https://git.openjdk.org/jdk/pull/12426
On Tue, 31 Jan 2023 05:24:35 GMT, Varada M wrote:
> 1. test/jdk/jni/nullCaller/NullCallerTest.java
> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>
> The above tests were blocked on AIX
On Wed, 8 Feb 2023 11:03:35 GMT, David Holmes wrote:
> I hate to see the code duplication, but we don't have a sharing mechanism for
> the native parts of tests so that can't be helped.
>
> Changes look good.
>
> Please update the Oracle copyright lines so that the second year is 2023 if
>
On Tue, 7 Feb 2023 22:52:13 GMT, Claes Redestad wrote:
> Seems there's a possible real test failure lurking here, might be
> intermittent since it only showed on one platform:
Did you get this from GHA somehow? Do you happen to know the platform, timezone
and encoding used?
-
On Wed, 8 Feb 2023 10:37:16 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing
On Wed, 8 Feb 2023 07:31:15 GMT, Adam Sotona wrote:
> Any reference to an official specification of CharacterRangeInfo is
> appreciated. Thanks.
There's this - which points back to javac code :-)
https://github.com/jacoco/jacoco/wiki/CharacterRangeTable
-
PR:
On Wed, 8 Feb 2023 11:05:34 GMT, Adam Sotona wrote:
> `ofSymbols` is an alternative to `of` when conflicting method parameters. In
> such case `of` refers to CP entries and `ofSymbols` refer to independent
> symbols describing the objects, like for example `ClassDesc`,
> `MethodTypeDesc`,
On Tue, 7 Feb 2023 16:07:00 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent
On Wed, 8 Feb 2023 07:24:05 GMT, Adam Sotona wrote:
>> **Specification:**
>>
>> MethodSignature:
>> [TypeParameters] ( {JavaTypeSignature} ) Result {ThrowsSignature}
>>
>> Result:
>> JavaTypeSignature
>> VoidDescriptor
>>
>> ThrowsSignature:
>> ^ ClassTypeSignature
>> ^
On Tue, 31 Jan 2023 05:24:35 GMT, Varada M wrote:
> 1. test/jdk/jni/nullCaller/NullCallerTest.java
> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>
> The above tests were blocked on AIX
On Tue, 7 Feb 2023 16:09:56 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent
On Wed, 8 Feb 2023 08:16:05 GMT, Francesco Nigro wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minimize, force inline, generalize
>
> test/micro/org/openjdk/bench/java/lang/StringConstructor.java line 40:
>
On Wed, 8 Feb 2023 03:38:24 GMT, David Schlosnagle wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minimize, force inline, generalize
>
> src/java.base/share/classes/java/util/Arrays.java line 4142:
>
>> 4140:
> This patch adds special-cases to `Arrays.copyOf` and `Arrays.copyOfRange` to
> clone arrays when `newLength` or range inputs span the input array. This
> helps eliminate range checks and has been verified to help various String
> operations. Example:
>
> Baseline
>
> Benchmark
On Wed, 8 Feb 2023 01:10:59 GMT, David Schlosnagle wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minimize, force inline, generalize
>
> src/java.base/share/classes/java/util/Arrays.java line 3594:
>
>> 3592:
> This patch adds special-cases to `Arrays.copyOf` and `Arrays.copyOfRange` to
> clone arrays when `newLength` or range inputs span the input array. This
> helps eliminate range checks and has been verified to help various String
> operations. Example:
>
> Baseline
>
> Benchmark
On Tue, 7 Feb 2023 15:59:04 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> - BeforeClass/AfterClass changed to static BeforeAll/AfterAll
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 09:22:36 GMT, Jaikiran Pai wrote:
>> test/jdk/java/lang/Thread/BuilderTest.java line 294:
>>
>>> 292: void testPriority3() {
>>> 293: Thread currentThread = Thread.currentThread();
>>> 294: assumeFalse(currentThread.isVirtual(), "Main test is a virtual
On Tue, 7 Feb 2023 13:30:24 GMT, Tagir F. Valeev wrote:
>> A pure `int`‑only overload doesn’t have to go through the `int` → `long` →
>> `int` conversion.
>
> Is this a real problem?
This should not be a problem with C2, and with the lower compilation levels
this insignificant impact seems to
On Wed, 8 Feb 2023 09:32:49 GMT, Jaikiran Pai wrote:
> I wonder if testng (and junit) can be configured to fail the test if no test
> methods were present, to flag such mistakes.
JUnit's CLI tool has:
`--fail-if-no-tests Fail and return exit status code 2 if no tests are
found.`
We can
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 09:13:37 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Tue, 7 Feb 2023 15:26:12 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent
1 - 100 of 106 matches
Mail list logo