Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v4]

2023-03-03 Thread Joe Darcy
On Fri, 3 Mar 2023 06:56:57 GMT, Joe Darcy wrote: >> Last and certainly not least in the port of FDLIBM to Java, the >> transcendental methods for sin, cos, and tan. >> >> Some more tests are to be written in the StrictMath directory to verify that >> the StrictMath algorihtm for sin/cos/tan

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v5]

2023-03-03 Thread Joe Darcy
> Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is being used rather than a > different one. However, I

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v2]

2023-03-03 Thread Jaikiran Pai
On Sat, 4 Mar 2023 02:18:37 GMT, Naoto Sato wrote: >> test/jdk/java/time/test/java/time/format/TestUTCParse.java line 48: >> >>> 46: // Assuming CLDR's SHORT name for "America/Los_Angeles" >>> 47: // produces "UTC\u212208:00" >>> 48:

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v3]

2023-03-03 Thread Jaikiran Pai
On Sat, 4 Mar 2023 02:22:39 GMT, Naoto Sato wrote: >> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v2]

2023-03-03 Thread Naoto Sato
On Sat, 4 Mar 2023 01:36:11 GMT, Jaikiran Pai wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> now() -> of() to avoid DST > > test/jdk/java/time/test/java/time/format/TestUTCParse.java line 27: > >> 25: * @modules

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v3]

2023-03-03 Thread Naoto Sato
> This change is to fix a regression caused by the fix to > [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix > was simply disabling offset-based parsing if the parser was text-based. > Instead, check if it is an offset or not by explicitly comparing the > character

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v2]

2023-03-03 Thread Jaikiran Pai
On Fri, 3 Mar 2023 21:10:57 GMT, Naoto Sato wrote: >> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v2]

2023-03-03 Thread Jaikiran Pai
On Fri, 3 Mar 2023 21:10:57 GMT, Naoto Sato wrote: >> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v2]

2023-03-03 Thread Iris Clark
On Fri, 3 Mar 2023 21:10:57 GMT, Naoto Sato wrote: >> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is

Re: RFR: 8303604: Passing by-value structs whose size is not power of 2 doesn't work on all platforms (mainline)

2023-03-03 Thread Maurizio Cimadamore
On Fri, 3 Mar 2023 19:27:24 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/806 which fixes an > issue with passing structs whose size is not a power of two on SysV and > AArch64 platforms. Looks good (already reviewed on Panama repo) - Marked

RFR: 8303604: Passing by-value structs whose size is not power of 2 doesn't work on all platforms (mainline)

2023-03-03 Thread Jorn Vernee
Port of: https://github.com/openjdk/panama-foreign/pull/806 which fixes an issue with passing structs whose size is not a power of two on SysV and AArch64 platforms. - Depends on: https://git.openjdk.org/jdk/pull/12856 Commit messages: - 8303017: Passing by-value structs whose

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: Testing no memory leak occurs via references

2023-03-03 Thread Stuart Marks
As Roger mentioned, there is a ForceGC utility in the test library:     test/lib/jdk/test/lib/util/ForceGC.java and it's used in a variety of places in the core libs tests. Essentially it sets up a PhantomReference and a ReferenceQueue and runs System.gc() in a loop. I'd strongly recommend

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v4]

2023-03-03 Thread Brian Burkhalter
On Fri, 3 Mar 2023 06:56:57 GMT, Joe Darcy wrote: >> Last and certainly not least in the port of FDLIBM to Java, the >> transcendental methods for sin, cos, and tan. >> >> Some more tests are to be written in the StrictMath directory to verify that >> the StrictMath algorihtm for sin/cos/tan

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v2]

2023-03-03 Thread Naoto Sato
> This change is to fix a regression caused by the fix to > [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix > was simply disabling offset-based parsing if the parser was text-based. > Instead, check if it is an offset or not by explicitly comparing the > character

RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id

2023-03-03 Thread Naoto Sato
This change is to fix a regression caused by the fix to [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix was simply disabling offset-based parsing if the parser was text-based. Instead, check if it is an offset or not by explicitly comparing the character with

Integrated: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex)

2023-03-03 Thread Raffaello Giulietti
On Thu, 16 Feb 2023 17:16:35 GMT, Raffaello Giulietti wrote: > Add an `indexOf()` variant allowing to specify both a lower and an upper > bound on the search. This pull request has now been integrated. Changeset: 5b2e2e46 Author:Raffaello Giulietti URL:

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v8]

2023-03-03 Thread Roger Riggs
On Fri, 3 Mar 2023 19:38:57 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > git

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-03 Thread Roger Riggs
On Mon, 27 Feb 2023 12:47:03 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger

2023-03-03 Thread Roger Riggs
Runtime.exec and ProcessBuilder.start methods create a new operating system process with the program and arguments. Many applications configure a logging subsystem to monitor application events. Logging a process start message with the program, arguments, and stack trace can identify the caller

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v8]

2023-03-03 Thread Raffaello Giulietti
> Add an `indexOf()` variant allowing to specify both a lower and an upper > bound on the search. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: git commit -m "8302590: Add String.indexOf(int ch, int fromIndex, int

Re: RFR: 8303582: Reduce duplication in test code (mainline)

2023-03-03 Thread Jorn Vernee
On Fri, 3 Mar 2023 15:08:01 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/804 which reduces > duplication in the test code by switching test value generation over to a > common method in `NativeTestHelper`.

RFR: 8303582: Reduce duplication in test code (mainline)

2023-03-03 Thread Jorn Vernee
Port of: https://github.com/openjdk/panama-foreign/pull/804 which reduces duplication in the test code by switching test value generation over to a common method in `NativeTestHelper`. - Commit messages: - remove byteWidthOfPrimitive for now - 8302990: Reduce duplication in test

Re: Testing no memory leak occurs via references

2023-03-03 Thread Albert Yang
I wonder if `WhiteBoxAPI` can be used if the goal is to trigger a (Full) GC cycle. An example is `whitebox.fullGC()` in `test/jdk/java/lang/ref/CleanerTest.java`. /Albert

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v8]

2023-03-03 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Expand test for StringBuffer and illegal code points - Changes: - all:

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v7]

2023-03-03 Thread Alan Bateman
On Fri, 3 Mar 2023 18:04:11 GMT, Alan Bateman wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) > > The latest version looks good. Thanks for

Integrated: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal

2023-03-03 Thread Brian Burkhalter
On Fri, 24 Feb 2023 18:23:06 GMT, Brian Burkhalter wrote: > Deprecate `SensitivityWatchEventModifier` for now instead of directly > removing it as proposed in #12626. This pull request has now been integrated. Changeset: ae290541 Author:Brian Burkhalter URL:

Integrated: JDK-8303587 Remove VMOutOfMemoryError001 test from the problem list after 8303198

2023-03-03 Thread Roger Riggs
On Fri, 3 Mar 2023 16:40:41 GMT, Roger Riggs wrote: > Remove VMOutOfMemoryException001.java from the problem list, after > JDK-8303198. > > The logging of Runtime.exit interfered with out-of-memory exception handling > in this test. > Making the logging more robust in JDK-8303198 by handling

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v7]

2023-03-03 Thread Raffaello Giulietti
On Fri, 3 Mar 2023 18:04:11 GMT, Alan Bateman wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) > > The latest version looks good. Thanks for

Re: Testing no memory leak occurs via references

2023-03-03 Thread Roger Riggs
Hi, There is test library class jdk.test.lib.util.ForceGC that is useful for that case. It uses a PhantomReference to detect that gc has been run. And it can be called with a function that can test for another condition. For an example, look at the tests that use ForceGC in test/jdk/...

Re: RFR: 8303577: [JVMCI] OOME causes crash while translating exceptions

2023-03-03 Thread Vladimir Kozlov
On Fri, 3 Mar 2023 15:40:01 GMT, Doug Simon wrote: > JDK-8297431 added code for special handling of OutOfMemoryError when > translating an exception between libjvmci and HotSpot[1]. > Unfortunately, this code was deleted by JDK-8298099 when moving the exception > translation mechanism to

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v7]

2023-03-03 Thread Alan Bateman
On Thu, 2 Mar 2023 10:24:03 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 6453901: (cal) clean up sun.util.calendar classes

2023-03-03 Thread Lance Andersen
On Wed, 1 Mar 2023 21:58:15 GMT, Justin Lu wrote: > This PR includes cleanup changes to the sun.util.calendar package only. > > The changes include removing unused methods, imports, adjusting incorrect > links, and using newer syntax patterns. Since there are no plans to promote > any of

Testing no memory leak occurs via references

2023-03-03 Thread Aleksei Ivanov
Hello, In clientlibs, there's occasionally a need to verify an object isn't leaked. For this purpose, WeakReference or PhantomReference is used. Then, we need to make the reference object be cleared, so a GC cycle need to be triggered. The common approach is generating OutOfMemoryError,

Re: RFR: 6453901: (cal) clean up sun.util.calendar classes

2023-03-03 Thread Naoto Sato
On Wed, 1 Mar 2023 21:58:15 GMT, Justin Lu wrote: > This PR includes cleanup changes to the sun.util.calendar package only. > > The changes include removing unused methods, imports, adjusting incorrect > links, and using newer syntax patterns. Since there are no plans to promote > any of

RFR: 8303577: [JVMCI] OOME causes crash while translating exceptions

2023-03-03 Thread Doug Simon
JDK-8297431 added code for special handling of OutOfMemoryError when translating an exception between libjvmci and HotSpot[1]. Unfortunately, this code was deleted by JDK-8298099 when moving the exception translation mechanism to VMSupport[2]. This causes the VM to crash when an OOME occurs

Re: RFR: JDK-8303587 Remove VMOutOfMemoryError001 test from the problem list after 8303198

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 16:40:41 GMT, Roger Riggs wrote: > Remove VMOutOfMemoryException001.java from the problem list, after > JDK-8303198. > > The logging of Runtime.exit interfered with out-of-memory exception handling > in this test. > Making the logging more robust in JDK-8303198 by handling

Integrated: 8303472: Display name for region TR

2023-03-03 Thread Justin Lu
On Wed, 1 Mar 2023 21:58:00 GMT, Justin Lu wrote: > This PR changes the English name for the region `TR`, from `Turkey` to > `Türkiye`. Although this change is included in the upcoming CLDR v43, it > should be applied as a spot change so that it can be back-ported properly (As > it is a

RFR: JDK-8303587 Remove VMOutOfMemoryError001 test from the problem list after 8303198

2023-03-03 Thread Roger Riggs
Remove VMOutOfMemoryException001.java from the problem list, after JDK-8303198. The logging of Runtime.exit interfered with out-of-memory exception handling in this test. Making the logging more robust in JDK-8303198 by handling exceptions restores the conditions expected by this test.

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 00:57:35 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > >

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 15:50:33 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/instruction/NewMultiArrayInstruction.java >> line 60: >> >>> 58: static NewMultiArrayInstruction of(ClassEntry arrayTypeEntry, >>> 59:int

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 14:14:55 GMT, Jaikiran Pai wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Signature.TypeArg does not inherit from Signature > >

Integrated: 8303198: System and Runtime.exit() resilience to logging errors

2023-03-03 Thread Roger Riggs
On Mon, 27 Feb 2023 15:41:01 GMT, Roger Riggs wrote: > Consolidate logging and handle exceptions by printing to standard error and > ignoring the exception. > Exceptions while logging will not interfere with Runtime.exit. This pull request has now been integrated. Changeset: 379f2061 Author:

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 20:54:39 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > >

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 20:37:37 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > >

Integrated: 8299807: newStringNoRepl should avoid copying arrays for ASCII compatible charsets

2023-03-03 Thread Glavo
On Fri, 20 Jan 2023 16:47:27 GMT, Glavo wrote: > This is the javadoc of `JavaLangAccess::newStringNoRepl`: > > > /** > * Constructs a new {@code String} by decoding the specified subarray of > * bytes using the specified {@linkplain java.nio.charset.Charset > charset}. > *

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v7]

2023-03-03 Thread Jim Laskey
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Add snippet I agree.

Re: RFR: 8302987: Add uniform and spatially equidistributed bounded float/double streams to RandomGenerator [v4]

2023-03-03 Thread Raffaello Giulietti
> The `default` method `nextDouble(double origin, double bound)` in > `java.util.random.RandomGenerator` aims at generating a uniformly and > spatially equidistributed random `double` in the left-closed and right-open > range [`origin`, `bound`). It does so by applying the affine transform >

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 14:53:19 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/instruction/CharacterRange.java >> line 42: >> >>> 40: * the setting of the {@link Classfile.Option#processDebug(boolean)} >>> option. >>> 41: */ >>> 42: public sealed interface

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 19:31:50 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > >

Re: RFR: 8294982: Implementation of Classfile API [v42]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v7]

2023-03-03 Thread Alan Bateman
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Add snippet The repeat

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v7]

2023-03-03 Thread Tagir F . Valeev
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Add snippet Marked as

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v7]

2023-03-03 Thread Jim Laskey
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Add snippet Can I get

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 19:27:58 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > >

Integrated: 8303516: HFAs with nested structs/unions/arrays not handled correctly on AArch64

2023-03-03 Thread Jorn Vernee
On Thu, 2 Mar 2023 13:48:26 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/780 Which adds tests > for nested structs/unions/arrays, and fixes an issue with nested HFAs on > AArch64. > > This PR also includes https://github.com/openjdk/panama-foreign/pull/765

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Jaikiran Pai
On Fri, 3 Mar 2023 13:50:15 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors [v2]

2023-03-03 Thread Alan Bateman
On Wed, 1 Mar 2023 16:59:51 GMT, Roger Riggs wrote: >> Consolidate logging and handle exceptions by printing to standard error and >> ignoring the exception. >> Exceptions while logging will not interfere with Runtime.exit. > > Roger Riggs has updated the pull request incrementally with one

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v7]

2023-03-03 Thread David M . Lloyd
On Mon, 21 Nov 2022 16:46:43 GMT, Strahinja Stanojevic wrote: >> This PR introduces an option to output stable names for the lambda classes >> in the JDK. A stable name consists of two parts: The first part is the >> predefined value `$$Lambda$` appended to the lambda capturing class, and the

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors [v2]

2023-03-03 Thread Jaikiran Pai
On Wed, 1 Mar 2023 16:59:51 GMT, Roger Riggs wrote: >> Consolidate logging and handle exceptions by printing to standard error and >> ignoring the exception. >> Exceptions while logging will not interfere with Runtime.exit. > > Roger Riggs has updated the pull request incrementally with one

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Integrated: 8303499: [s390x] ProblemList StressStackOverflow

2023-03-03 Thread Amit Kumar
On Thu, 2 Mar 2023 16:22:24 GMT, Amit Kumar wrote: > This PR adds StressStackOverflow.java test to ProblemList. The feature Scope > Value is not yet implemented on s390x-arch which is Incubating state. > Whenever fix will be given to >

Integrated: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning

2023-03-03 Thread Afshin Zafari
On Thu, 2 Mar 2023 12:15:21 GMT, Afshin Zafari wrote: > ### Description > The use of `ThreadDeath` is replaced with checking the exception be of type > `Error` and the thread is `TERMINATED`. > > > ### Test > local and mach5 tier1 This pull request has now been integrated. Changeset:

Integrated: 8297955: LDAP CertStore should use LdapName and not String for DNs

2023-03-03 Thread Sean Mullan
On Thu, 23 Feb 2023 16:42:17 GMT, Sean Mullan wrote: > The LDAPCertStore implementation passes Distinguished Names in CRL and > Certificate URLs as Strings to JNDI APIs such as > LdapContext.getAttributes(String), which then treats them as CompositeNames. > This causes issues with URLs that

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Fri, 3 Mar 2023 10:09:27 GMT, Claes Redestad wrote: > Yes, iff means if-and-only-if and is used for extra precision in formal > logic, mathematics. I've never come across it before. With your explanations, it makes perfect sense. - PR: https://git.openjdk.org/jdk/pull/12826

Re: RFR: 8303409: Add Windows AArch64 ABI support to the Foreign Function & Memory API

2023-03-03 Thread Maurizio Cimadamore
On Mon, 27 Feb 2023 17:04:28 GMT, Saint Wesonga wrote: > There are 2 primary differences between the Windows ARM64 ABI and the > macOS/Linux ARM64 ABI: variadic floating point arguments are passed in > general purpose registers on Windows (instead of the vector registers). In > addition to

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-03-03 Thread Martin Doerr
On Wed, 1 Mar 2023 06:26:20 GMT, Martin Doerr wrote: >> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java >> line 293: >> >>> 291: } else { >>> 292: overlappingReg = new >>> VMStorage(StorageType.STACK_AND_FLOAT, >>> 293:

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v7]

2023-03-03 Thread Thomas Wuerthinger
On Mon, 21 Nov 2022 16:46:43 GMT, Strahinja Stanojevic wrote: >> This PR introduces an option to output stable names for the lambda classes >> in the JDK. A stable name consists of two parts: The first part is the >> predefined value `$$Lambda$` appended to the lambda capturing class, and the

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v9]

2023-03-03 Thread Martin Doerr
> Implementation of "Foreign Function & Memory API" for linux on Power (Little > Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". > > This PR does not include code for VaList support because it's supposed to get > removed by

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Claes Redestad
On Fri, 3 Mar 2023 09:38:13 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java >> line 257: >> >>> 255: >>> 256: /** >>> 257: * @return true iff the BSM method type exactly matches >> >> I assume “iff” should “if”? > > Here and

Re: RFR: 8303516: HFAs with nested structs/unions/arrays not handled correctly on AArch64

2023-03-03 Thread Maurizio Cimadamore
On Thu, 2 Mar 2023 13:48:26 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/780 Which adds tests > for nested structs/unions/arrays, and fixes an issue with nested HFAs on > AArch64. > > This PR also includes https://github.com/openjdk/panama-foreign/pull/765

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Fri, 3 Mar 2023 08:15:49 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Thu, 2 Mar 2023 16:23:17 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect

Integrated: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles

2023-03-03 Thread Pavel Rappo
On Wed, 1 Mar 2023 18:47:14 GMT, Pavel Rappo wrote: > Please review this trivial fix for _comments_. While some affected comments > aren't doc comments and none of the affected comments partake in the API > Documentation, it seems reasonable to be consistent. This pull request has now been

Re: RFR: 8294982: Implementation of Classfile API [v40]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8294982: Implementation of Classfile API [v39]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8294982: Implementation of Classfile API [v37]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8294982: Implementation of Classfile API [v38]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote: > Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the

Re: RFR: 8303499: [s390x] ProblemList StressStackOverflow

2023-03-03 Thread Alan Bateman
On Fri, 3 Mar 2023 05:23:00 GMT, Amit Kumar wrote: > Alan I'm attaching JTR file could you confirm the same probably provide more > insights, as test you mentioned `ScopeValueAPI.java` and `ManyBindings.java` > are passing. >

Re: RFR: 8303499: [s390x] ProblemList StressStackOverflow

2023-03-03 Thread Amit Kumar
On Thu, 2 Mar 2023 16:22:24 GMT, Amit Kumar wrote: > This PR adds StressStackOverflow.java test to ProblemList. The feature Scope > Value is not yet implemented on s390x-arch which is Incubating state. > Whenever fix will be given to >

RFR: 8303499: [s390x] ProblemList StressStackOverflow

2023-03-03 Thread Amit Kumar
This PR adds StressStackOverflow.java test to ProblemList. The feature Scope Value is not yet implemented on s390x-arch which is Incubating state. Whenever fix will be given to [JDK-8303498](https://bugs.openjdk.org/browse/JDK-8303498) then we will remove it. - Commit messages: -

Re: RFR: 8303499: [s390x] ProblemList StressStackOverflow

2023-03-03 Thread Alan Bateman
On Thu, 2 Mar 2023 16:22:24 GMT, Amit Kumar wrote: > This PR adds StressStackOverflow.java test to ProblemList. The feature Scope > Value is not yet implemented on s390x-arch which is Incubating state. > Whenever fix will be given to >