Integrated: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries

2023-04-12 Thread Eirik Bjorsnos
On Tue, 7 Mar 2023 07:46:25 GMT, Eirik Bjorsnos wrote: > ZipOutputStream currently writes directory entries using the DEFLATED > compression method. This does not strictly comply with the APPNOTE.TXT > specification and is also about 10x slower than using the STORED compression > method. > >

Re: Draft: Deprecate toLowerCase()/toUpperCase() and provide locale insensitive alternative

2023-04-12 Thread Eirik Bjørsnøs
On Wed, Apr 12, 2023 at 10:27 PM Roger Riggs wrote: > Hi, > > The status quo takes a balance between trying do the right thing and > creating a headache for lots of developers. > Deprecating the existing methods would cause lots of warnings and > provide little actual improvement. > It is a

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v57]

2023-04-12 Thread Andrey Turbanov
On Wed, 12 Apr 2023 19:02:22 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v57]

2023-04-12 Thread Andrey Turbanov
On Wed, 12 Apr 2023 19:02:22 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: Draft: Deprecate toLowerCase()/toUpperCase() and provide locale insensitive alternative

2023-04-12 Thread Roger Riggs
Hi, The status quo takes a balance between trying do the right thing and creating a headache for lots of developers. Deprecating the existing methods would cause lots of warnings and provide little actual improvement. Except in a few locales, the output would be the same as today. If you're

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v57]

2023-04-12 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]

2023-04-12 Thread Martin Doerr
On Wed, 12 Apr 2023 17:31:49 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64,

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v56]

2023-04-12 Thread Jim Laskey
On Sat, 8 Apr 2023 15:51:36 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v20]

2023-04-12 Thread Jorn Vernee
On Tue, 11 Apr 2023 17:59:32 GMT, Vladimir Ivanov wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8305369: Issues in zero-length memory segment javadoc section >> - 8305087: MemoryLayout API checks should be

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v12]

2023-04-12 Thread Roger Riggs
On Wed, 12 Apr 2023 09:07:34 GMT, Martin Doerr wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct mapping and test of ppc64 > > Works on PPC64 Big Endian, now. However, little Endian fails: > STARTED

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v56]

2023-04-12 Thread Chen Liang
On Sat, 8 Apr 2023 15:51:36 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: 8300818: Reduce complexity of padding with DateTimeFormatter [v3]

2023-04-12 Thread Roger Riggs
On Mon, 10 Apr 2023 14:01:53 GMT, Sergey Tsypanov wrote: >> Currently it's O(n) - we do `n` shifts of bytes within `StringBuilder`. This >> can be reduced to O(1) improving the code like: >> >> DateTimeFormatter dtf = new DateTimeFormatterBuilder() >> .appendLiteral("Date:") >>

Re: RFR: 8300818: Reduce complexity of padding with DateTimeFormatter [v2]

2023-04-12 Thread Roger Riggs
On Fri, 24 Mar 2023 19:28:57 GMT, Sergey Tsypanov wrote: >> Meant that you should verify that something like this, which just add a >> little padding, doesn't regress with your changes: >> >> DateTimeFormatter dtf = new DateTimeFormatterBuilder() >> .appendLiteral("Year:") >>

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]

2023-04-12 Thread Roger Riggs
> Define an internal jdk.internal.util.Architecture enumeration and static > methods to replace uses of the system property `os.arch`. > The enumeration values are defined to match those used in the build. > The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64` > Note that `amd64` and

RFR: 8305762: FileInputStream and FileOutputStream implSpec should be corrected or removed

2023-04-12 Thread Brent Christian
With the removal of the AltFinalizer mechanism from `FileInputStream` and `FileOutputStream` in [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of the Implementation Requirement in the class JavaDoc is no longer true: > If this FileOutputStream has been subclassed and

RFR: 8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories.

2023-04-12 Thread Mahendra Chhipa
Following tests read the unicode data files (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests, these files should be in test directories. No source code is using these files. Only tests are using these files. Tests are : java/lang/Character/CharPropTest.java

Integrated: JDK-8295859 Update Manual Test Groups

2023-04-12 Thread Bill Huang
On Thu, 2 Mar 2023 21:34:28 GMT, Bill Huang wrote: > The purpose of this task is to add the difference between -manual jdk_core > and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order > to streamline the manual test execution process, a new test group called >

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-12 Thread Eric Liu
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >>

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v56]

2023-04-12 Thread Chen Liang
On Sat, 8 Apr 2023 15:51:36 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: Draft: Deprecate toLowerCase()/toUpperCase() and provide locale insensitive alternative

2023-04-12 Thread Bernd
While we are at it, is Locale.ROOT character types guaranteed to only touch ASCII for case conversion, or could it use latin1 ranges, anyway? (Especially if we think compact strings). How about unassigned or illegal Code units?GrussBernd-- http://bernd.eckenfels.net

Re: RFR: JDK-8295859 Update Manual Test Groups [v3]

2023-04-12 Thread Mark Sheppard
On Tue, 11 Apr 2023 22:06:30 GMT, Bill Huang wrote: >> The purpose of this task is to add the difference between -manual jdk_core >> and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order >> to streamline the manual test execution process, a new test group called >>

String Template reviews

2023-04-12 Thread Jim Laskey
As we head toward PTT for JEP 430 String Templates (Preview) it would be nice to get some final reviews of the following; Implementation API CSR https://bugs.openjdk.org/browse/JDK-8286021 Implementation PR https://github.com/openjdk/jdk/pull/10889 Thank you. — Jim

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v10]

2023-04-12 Thread Lutz Schmidt
On Wed, 12 Apr 2023 03:44:45 GMT, Amit Kumar wrote: > Another remark: Old JDK on s390 used "os.arch = zArch_64", current one > "os.arch = s390x". @offamitkumar: You probably want to take a look. zArch_64 is not relevant/not used in the OpenJDK port to IBM System z. As noted elsewhere in the

Re: RFR: 8240567: SystemModulesPlugin: Keep stack clean

2023-04-12 Thread Oliver Kopp
On Wed, 12 Apr 2023 09:43:11 GMT, Alan Bateman wrote: > I think you've got the wrong JBS issue, JDK-8240567 is about changing the > SystemModulesPlugin to avoid the 64k limit on method size. For me, it's the correct one. I was not sure which one to link. I can also drop the reference. More

Re: RFR: 8240567: SystemModulesPlugin: Keep stack clean

2023-04-12 Thread Alan Bateman
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote: > This refs [https://bugs.openjdk.org/browse/JDK-82405679](8240567). Does NOT > fix it, but cleanup `SystemModulesPlugin` a bit to ease working on the bug > itself. > > Although this change is rather small, I think, it's good to have a

RFR: 8240567: SystemModulesPlugin: Keep stack clean

2023-04-12 Thread Oliver Kopp
This refs [https://bugs.openjdk.org/browse/JDK-82405679](8240567). Does NOT fix it, but cleanup `SystemModulesPlugin` a bit to ease working on the bug itself. Although this change is rather small, I think, it's good to have a "more clean" SystemModulesPlugin available. - Commit

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v12]

2023-04-12 Thread Martin Doerr
On Tue, 11 Apr 2023 21:09:43 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64,

Re: RFR: 8305486: Add split() variants that keep the delimiters to String and j.u.r.Pattern [v2]

2023-04-12 Thread Raffaello Giulietti
On Tue, 11 Apr 2023 20:42:38 GMT, Roger Riggs wrote: >> The choice of multi-character delimiter is deliberate, to show that the >> regex really absorbs all the delimiter characters. >> The `":+"` examples are followed by the `"o"` examples, where the delimiters >> are single characters. > > I

Re: RFR: JDK-8170945: Collectors$Partition should override more Map methods [v2]

2023-04-12 Thread Viktor Klang
> Adds overrides for common Map operations to avoid having to allocate the > entrySet for Collectors$Partition maps. Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Let auto-boxing do its thing for Collectors.get(key) -

Re: RFR: JDK-8170945: Collectors$Partition should override more Map methods [v2]

2023-04-12 Thread Viktor Klang
On Wed, 12 Apr 2023 07:55:28 GMT, Viktor Klang wrote: >> Adds overrides for common Map operations to avoid having to allocate the >> entrySet for Collectors$Partition maps. > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8305092: Improve Thread.sleep(millis, nanos) for sub-millisecond granularity

2023-04-12 Thread Alan Bateman
On Wed, 29 Mar 2023 11:28:53 GMT, Aleksey Shipilev wrote: > Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The > documentation for that method clearly says the precision and accuracy are > dependent on the underlying system behavior. However, it always rounds up >

Re: RFR: 8305875: Test TraceVirtualThreadLocals should be run with continuations only

2023-04-12 Thread Alan Bateman
On Tue, 11 Apr 2023 23:38:23 GMT, Leonid Mesnik wrote: > Test TraceVirtualThreadLocals verifies that thread locals are dumped for > virtual threads. It fails when continuations are not available and virtual > threads are emulated. > > The test failed on linux-x86 so I just want to mark it to

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v20]

2023-04-12 Thread Per Minborg
On Tue, 11 Apr 2023 17:48:37 GMT, Jorn Vernee wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8305369: Issues in zero-length memory segment javadoc section >> - 8305087: MemoryLayout API checks should be more

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v22]

2023-04-12 Thread Per Minborg
> API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html Per Minborg has updated the pull request incrementally

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v4]

2023-04-12 Thread Julian Waters
On Wed, 12 Apr 2023 07:12:10 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request incrementally with four additional > commits since

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v4]

2023-04-12 Thread Julian Waters
> C11 has been stable for a long time on all platforms, so native code can use > the standard alignas operator for alignment requirements Julian Waters has updated the pull request incrementally with four additional commits since the last revision: - Restore visCPP - Restore gcc attribute -

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v21]

2023-04-12 Thread Per Minborg
> API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html Per Minborg has updated the pull request with a new

Re: RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v7]

2023-04-12 Thread Quan Anh Mai
On Tue, 11 Apr 2023 17:47:56 GMT, Jatin Bhateja wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> special case iotaShuffle > > Marked as reviewed by jbhateja (Reviewer). @jatin-bhateja @iwanowww Thanks a lot for

Re: RFR: 8305734: Fixes bug in get(int, int)

2023-04-12 Thread Alan Bateman
On Fri, 7 Apr 2023 12:22:03 GMT, Andy-Tatman wrote: > See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734 The BitSet API requires that the logical size fit in an int so I think you'll end up changing the set methods to disallow an index of MAX_VALUE. Can you change the title of the

Re: RFR: 8305875: Test TraceVirtualThreadLocals should be run with continuations only

2023-04-12 Thread Alan Bateman
On Wed, 12 Apr 2023 06:13:04 GMT, David Holmes wrote: > Sorry, have to ask, but why does the test fail without continuations? IIRC > the emulated VTs use a carrier-per-VT so I would expect the ThreadLocal test > to work just fine. The debugging option is for the VirtualThread implementation

Re: RFR: 8305875: Test TraceVirtualThreadLocals should be run with continuations only

2023-04-12 Thread Leonid Mesnik
On Tue, 11 Apr 2023 23:38:23 GMT, Leonid Mesnik wrote: > Test TraceVirtualThreadLocals verifies that thread locals are dumped for > virtual threads. It fails when continuations are not available and virtual > threads are emulated. > > The test failed on linux-x86 so I just want to mark it to

Re: RFR: 8305875: Test TraceVirtualThreadLocals should be run with continuations only

2023-04-12 Thread David Holmes
On Tue, 11 Apr 2023 23:38:23 GMT, Leonid Mesnik wrote: > Test TraceVirtualThreadLocals verifies that thread locals are dumped for > virtual threads. It fails when continuations are not available and virtual > threads are emulated. > > The test failed on linux-x86 so I just want to mark it to