On Fri, 24 Mar 2023 22:16:54 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Add missing @throws and @since tags.
>> - Convert code samples to snippets.
>> - Various editorial changes.
>>
On Fri, 24 Mar 2023 22:13:29 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Add missing @throws and @since tags.
>> - Convert code samples to snippets.
>> - Various editorial changes.
>>
On Fri, 24 Mar 2023 22:01:11 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Add missing @throws and @since tags.
>> - Convert code samples to snippets.
>> - Various editorial changes.
>>
> PR for Sequenced Collections implementation.
Stuart Marks has updated the pull request incrementally with four additional
commits since the last revision:
- Add missing @throws and @since tags.
- Convert code samples to snippets.
- Various editorial changes.
- Fix up toArray(T[]) on
On Wed, 19 Apr 2023 10:29:48 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
>> line 409:
>>
>>> 407: * {@inheritDoc}
>>> 408: */
>>> 409: public E getFirst() {
>>
>> Javadoc will automatically copy the specification from the
> I fixed File.listRoots description.
> * remove "the insertion or ejection of removable media"
> * change "available" to "existing"
>
> Please review this change.
Nagata-Haruhito has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will
On Wed, 22 Mar 2023 22:52:19 GMT, Chen Liang wrote:
>> Without this patch, the Classfile API tries to encode PrimitiveClassDesc as
>> CONSTANT_Class_info and error in `toInternalName`.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last
> I fixed File.listRoots description.
> * remove "the insertion or ejection of removable media"
> * change "available" to "existing"
>
> Please review this change.
Nagata-Haruhito has updated the pull request incrementally with one additional
commit since the last revision:
8306431: The
On Wed, 19 Apr 2023 07:34:30 GMT, Nagata-Haruhito wrote:
> I fixed File.listRoots description.
> * remove "the insertion or ejection of removable media"
> * change "available" to "existing"
>
> Please review this change.
Thanks for your comment.
I added @implNote and moved descriptions.
On Wed, 19 Apr 2023 19:55:38 GMT, Aleksey Shipilev wrote:
>> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
>> documentation for that method clearly says the precision and accuracy are
>> dependent on the underlying system behavior. However, it always rounds up
>>
On Fri, 14 Apr 2023 14:34:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the `java.compiler`
>> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>>
>> A CSR has been filed for this change and is available at
>>
On Fri, 14 Apr 2023 12:19:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the `java.compiler`
> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>
> A CSR has been filed for this change and is available at
>
On Thu, 20 Apr 2023 00:40:44 GMT, Jorn Vernee wrote:
>> Also, isn't it the case that, for structs, we want the size of the layout to
>> be a multiple of its alignment constraint?
>
> The third item in the list is for group size needing to be a multiple of the
> alignment constraint, the forth
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request incrementally with
On Wed, 19 Apr 2023 16:00:18 GMT, Doug Simon wrote:
>> Doug Simon has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - added breadcrumb in AnnotationParser about considering JVMCI should new
>> annotation element types be added
>> -
On Tue, 18 Apr 2023 22:32:17 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
On Tue, 18 Apr 2023 22:26:03 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/Linker.java line 202:
>>
>>> 200: * Due to limited ABI specification coverage, all the native linker
>>> implementations limit the function
>>> 201: * descriptors that they support
On Tue, 18 Apr 2023 22:17:02 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
On Wed, 19 Apr 2023 14:41:59 GMT, Nir Lisker wrote:
>> Stuart Marks has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove unnecessary 'final' from a couple places.
>> - Clarify ordering of Collection.addAll and Map.putAll; add
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are
On Wed, 19 Apr 2023 20:07:32 GMT, Justin Lu wrote:
>> Update the registry and accompanying tests with the **IANA 4/13/2022**
>> update.
>>
>> This update introduces the case where an IANA entry can have a preferred
>> value, but that preferred value has a preferred value as well.
>>
>> This
> Update the registry and accompanying tests with the **IANA 4/13/2022** update.
>
> This update introduces the case where an IANA entry can have a preferred
> value, but that preferred value has a preferred value as well.
>
> This causes unexpected failures in JDK tests because of how locale
Update the registry and accompanying tests with the **IANA 4/13/2022** update.
This update introduces the case where an IANA entry can have a preferred value,
but that preferred value has a preferred value as well.
This causes unexpected failures in JDK tests because of how locale
On Wed, 19 Apr 2023 18:50:27 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Windows fixes: align(...) is only for power-of-two alignments
>
> test/jdk/java/lang/Thread/SleepSanity.java line
> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
> documentation for that method clearly says the precision and accuracy are
> dependent on the underlying system behavior. However, it always rounds up
> `nanos` to 1ms when doing the actual sleep. This means users
On Wed, 19 Apr 2023 17:32:49 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> closed file handlers.
Looks good overall
On Wed, 19 Apr 2023 16:47:33 GMT, Volker Simonis wrote:
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream.
On Wed, 19 Apr 2023 16:02:08 GMT, Aleksey Shipilev wrote:
>> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
>> documentation for that method clearly says the precision and accuracy are
>> dependent on the underlying system behavior. However, it always rounds up
>>
> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
> documentation for that method clearly says the precision and accuracy are
> dependent on the underlying system behavior. However, it always rounds up
> `nanos` to 1ms when doing the actual sleep. This means users
On Wed, 19 Apr 2023 16:32:05 GMT, ExE Boss wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Windows fixes: align(...) is only for power-of-two alignments
>
> src/java.base/share/classes/java/lang/Thread.java
On Wed, 19 Apr 2023 13:57:43 GMT, Aleksey Shipilev wrote:
> Someone^W I did commit a test in the OpenJDK repo that has Amazon copyright
> notice in the form that is not inline with the preferred one (intentionally
> without copyright year):
>
> "Copyright Amazon.com Inc. or its affiliates.
On Wed, 19 Apr 2023 13:57:43 GMT, Aleksey Shipilev wrote:
> Someone^W I did commit a test in the OpenJDK repo that has Amazon copyright
> notice in the form that is not inline with the preferred one (intentionally
> without copyright year):
>
> "Copyright Amazon.com Inc. or its affiliates.
On Wed, 19 Apr 2023 12:27:41 GMT, Nir Lisker wrote:
>> Stuart Marks has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove unnecessary 'final' from a couple places.
>> - Clarify ordering of Collection.addAll and Map.putAll; add
On Wed, 19 Apr 2023 14:19:01 GMT, Nir Lisker wrote:
>> Stuart Marks has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove unnecessary 'final' from a couple places.
>> - Clarify ordering of Collection.addAll and Map.putAll; add
On Wed, 19 Apr 2023 10:06:38 GMT, Nir Lisker wrote:
>> Stuart Marks has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove unnecessary 'final' from a couple places.
>> - Clarify ordering of Collection.addAll and Map.putAll; add
On Wed, 19 Apr 2023 09:43:44 GMT, Nir Lisker wrote:
>> Stuart Marks has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove unnecessary 'final' from a couple places.
>> - Clarify ordering of Collection.addAll and Map.putAll; add
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Wed, 19 Apr 2023 05:51:11 GMT, Nir Lisker wrote:
>> Stuart Marks has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove unnecessary 'final' from a couple places.
>> - Clarify ordering of Collection.addAll and Map.putAll; add
On Wed, 19 Apr 2023 17:04:07 GMT, Joe Darcy wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length in the deserialization stream.
On Tue, 18 Apr 2023 18:49:54 GMT, Sergey Tsypanov wrote:
>> Currently it's O(n) - we do `n` shifts of bytes within `StringBuilder`. This
>> can be reduced to O(1) improving the code like:
>>
>> DateTimeFormatter dtf = new DateTimeFormatterBuilder()
>> .appendLiteral("Date:")
>>
On Wed, 22 Mar 2023 11:59:30 GMT, Thiago Henrique Hüpner
wrote:
>> 8304148: Remapping a class with Invokedynamic constant loses static
>> bootstrap arguments
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
closed file handlers.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
- new:
The jdk.internal.classfile.components package's interfaces have implementations
in their nested classes, which are implicitly public and exported with the
package. They are now moved to the impl package to avoid unwanted exposures.
Fixed a few minor javadoc issues in the interfaces as well.
In
On Wed, 19 Apr 2023 13:44:47 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file
On Wed, 19 Apr 2023 16:47:33 GMT, Volker Simonis wrote:
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream.
On Wed, 19 Apr 2023 13:44:47 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file
On Wed, 19 Apr 2023 07:08:53 GMT, Peter Hofer wrote:
>> Store `Charset` object in `jnuEncoding` and use `String(byte[], Charset)`
>> and `String.getBytes(Charset)` instead of passing the charset name.
>
> Peter Hofer has updated the pull request with a new target base due to a
> merge or a
On Wed, 19 Apr 2023 06:50:45 GMT, Peter Hofer wrote:
>> src/java.base/share/native/libjava/jni_util.c line 757:
>>
>>> 755: jnuEncoding = (*env)->NewGlobalRef(env, charset.l);
>>> 756: (*env)->DeleteLocalRef(env, charset.l);
>>> 757: break;
>>
>>
This issue was reported by: Yakov Shafranovich
([yako...@amazon.com](mailto:yako...@amazon.com))
Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
negative array length in the deserialization stream. Instead it calls
`j.l.r.Array::newInstance(..)` with the negative
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are
On Wed, 19 Apr 2023 16:02:08 GMT, Aleksey Shipilev wrote:
>> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
>> documentation for that method clearly says the precision and accuracy are
>> dependent on the underlying system behavior. However, it always rounds up
>>
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64,
On Wed, 19 Apr 2023 13:22:54 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'master' into 8304915-arch-enum
>> - ArchTest on Debian RISC-V 64 confirmed
On Wed, 19 Apr 2023 13:57:43 GMT, Aleksey Shipilev wrote:
> Someone^W I did commit a test in the OpenJDK repo that has Amazon copyright
> notice in the form that is not inline with the preferred one (intentionally
> without copyright year):
>
> "Copyright Amazon.com Inc. or its affiliates.
On Tue, 18 Apr 2023 18:40:03 GMT, Naoto Sato wrote:
> The upgrade to CLDR v43 was missing the license-related file updates. Here
> are the supplemental updates.
This pull request has now been integrated.
Changeset: 85de01e6
Author:Naoto Sato
URL:
> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
> documentation for that method clearly says the precision and accuracy are
> dependent on the underlying system behavior. However, it always rounds up
> `nanos` to 1ms when doing the actual sleep. This means users
On Wed, 1 Mar 2023 18:07:34 GMT, Doug Simon wrote:
> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for accessing
> annotations. The main differences from `java.lang.reflect.AnnotatedElement`
> are:
> * All methods in the `Annotated` interface explicitly specify requested
>
On Tue, 18 Apr 2023 07:27:47 GMT, Doug Simon wrote:
>> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for
>> accessing annotations. The main differences from
>> `java.lang.reflect.AnnotatedElement` are:
>> * All methods in the `Annotated` interface explicitly specify requested
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote:
> This refs [8306038](https://bugs.openjdk.org/browse/JDK-8306038)
>
> (Before this referenced 8240567)
>
> Although this change is rather small, I think, it's good to have a "more
> clean" SystemModulesPlugin available.
This pull request
Test is updated to create the binary files during test execution.
-
Commit messages:
- JDK-8077371: Binary files in JAXP test should be removed
Changes: https://git.openjdk.org/jdk/pull/13537/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13537=00
Issue:
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are
On Wed, 19 Apr 2023 13:50:49 GMT, Aleksey Shipilev wrote:
> @AlanBateman, @apangin, @ExE-Boss, @liach, @pavelrappo -- you had comments on
> this PR, could you please see if those are still relevant or not addressed?
> If you are good with the current version, can you please formally approve
On Wed, 19 Apr 2023 13:59:09 GMT, Volker Simonis wrote:
> Looks good.
>
> Thanks for fixing!
Thanks! Trivial, right?
-
PR Comment: https://git.openjdk.org/jdk/pull/13534#issuecomment-1514871013
On Wed, 19 Apr 2023 03:37:05 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Remove unnecessary 'final' from a couple places.
> - Clarify
On Mon, 17 Apr 2023 16:42:38 GMT, olivergillespie wrote:
>> Improve the speed of Enum.hashCode by caching the identity hashcode on first
>> use. I've seen an application where Enum.hashCode is a hot path, and this is
>> fairly simple speedup. The memory overhead is low; in enums with no extra
Spotted the typo for BootstrapMethods, and another review over the API exposed
the typo on PermittedSubclasses.
-
Commit messages:
- 8306455: Wrong majorVersion for multiple attributes in Classfile API
Changes: https://git.openjdk.org/jdk/pull/13536/files
Webrev:
On Mon, 17 Apr 2023 16:42:38 GMT, olivergillespie wrote:
>> Improve the speed of Enum.hashCode by caching the identity hashcode on first
>> use. I've seen an application where Enum.hashCode is a hot path, and this is
>> fairly simple speedup. The memory overhead is low; in enums with no extra
Someone^W I did commit a test in the OpenJDK repo that has Amazon copyright
notice in the form that is not inline with the preferred one (intentionally
without copyright year):
"Copyright Amazon.com Inc. or its affiliates. All Rights Reserved."
These should be fixed.
-
Commit
On Wed, 19 Apr 2023 13:57:43 GMT, Aleksey Shipilev wrote:
> Someone^W I did commit a test in the OpenJDK repo that has Amazon copyright
> notice in the form that is not inline with the preferred one (intentionally
> without copyright year):
>
> "Copyright Amazon.com Inc. or its affiliates.
On Mon, 17 Apr 2023 16:42:38 GMT, olivergillespie wrote:
>> Improve the speed of Enum.hashCode by caching the identity hashcode on first
>> use. I've seen an application where Enum.hashCode is a hot path, and this is
>> fairly simple speedup. The memory overhead is low; in enums with no extra
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Wed, 19 Apr 2023 09:56:44 GMT, Aleksey Shipilev wrote:
>> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
>> documentation for that method clearly says the precision and accuracy are
>> dependent on the underlying system behavior. However, it always rounds up
>>
> API changes for the FFM API (third preview)
>
> ### Specdiff
> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>
> ### Javadoc
> https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html
>
> ### Tests
>
> - [X]
On Wed, 19 Apr 2023 13:06:20 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file
On Wed, 19 Apr 2023 13:06:20 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64,
On Tue, 10 Jan 2023 10:32:34 GMT, Per Minborg wrote:
> `java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
> updated to reflect the current state of Java and can be modernized:
>
> * Add `@Serial` annotations
> * Seal classes and restrict subclassing for internal
On Wed, 19 Apr 2023 09:51:48 GMT, Aleksey Shipilev wrote:
>> src/hotspot/os/posix/os_posix.cpp line 1545:
>>
>>> 1543:
>>> 1544: int PlatformEvent::park_nanos(jlong nanos) {
>>> 1545: assert(0 <= nanos, "nanos are in range");
>>
>> `nanos` should never be zero else you call the untimed
On Wed, 19 Apr 2023 09:56:44 GMT, Aleksey Shipilev wrote:
>> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
>> documentation for that method clearly says the precision and accuracy are
>> dependent on the underlying system behavior. However, it always rounds up
>>
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64,
On Tue, 21 Mar 2023 13:53:27 GMT, Chen Liang wrote:
>> It is possible but this keeps the mapper more local and only accessible
>> where it is supposed to be used. For testing purposed, it might be better to
>> have the class as you propose.
>
> If we want it local, I suppose we can convert the
On Thu, 9 Feb 2023 13:46:14 GMT, Per Minborg wrote:
>> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for
>> values in the range [-18h, 18h] for each second that is on an even quarter
>> of an hour (i.e. at most 2*18*4+1 = 145 values).
>>
>> Instead of using a
On Tue, 18 Apr 2023 19:42:23 GMT, Mandy Chung wrote:
> I ran tier1-tier3 tests with your patch and all passed.
Good. @koppor You can edit the PR title to match the JBS issue, then enter
"/integrate" and one of us will sponsor.
-
PR Comment:
On Wed, 19 Apr 2023 04:36:28 GMT, Chen Liang wrote:
> Javadoc will automatically copy the specification from the overridden method,
> so the javadoc block is not necessary and can be replaced by an `@Override`
> to indicate inheritance.
I guess, this PR has converged enough for us to discuss
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are
On Wed, 19 Apr 2023 06:07:04 GMT, David Holmes wrote:
> You seemed to have missed:
>
> ```
> ./cpu/x86/rdtsc_x86.cpp:JavaThread::current()->sleep(FT_SLEEP_MILLISECS);
> ./share/compiler/compileBroker.cpp: sleep(DeoptimizeObjectsALotInterval);
> ```
>
> so not sure how this is building ???
On Wed, 19 Apr 2023 09:27:49 GMT, Alan Bateman wrote:
> You might need to check that
> test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/OwnedMonitorsStackDepthInfo/ownedMonitorsStackDepthInfo001/ownedMonitorsStackDepthInfo001a.java
> is passing. I haven't tried your changes but I
> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
> documentation for that method clearly says the precision and accuracy are
> dependent on the underlying system behavior. However, it always rounds up
> `nanos` to 1ms when doing the actual sleep. This means users
On Wed, 19 Apr 2023 06:14:37 GMT, David Holmes wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtests
>
> src/hotspot/os/posix/os_posix.cpp line 1545:
>
>> 1543:
>> 1544: int
On Wed, 19 Apr 2023 05:58:11 GMT, David Holmes wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtests
>
> src/hotspot/os/windows/os_windows.cpp line 5253:
>
>> 5251:
>> 5252: int
On Thu, 13 Apr 2023 06:36:51 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> ### Specdiff
>> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html
>>
>> ### Javadoc
>>
On Wed, 19 Apr 2023 05:58:35 GMT, David Holmes wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtests
>
> src/hotspot/os/windows/os_windows.cpp line 5259:
>
>> 5257: // any positive requested nanos as a
On Wed, 19 Apr 2023 06:12:02 GMT, David Holmes wrote:
>> Hmmm I changed that comment ...
>
> My actual comment was changed to:
>> I suggest extending the comment to add
>
> This is how Thread.sleep(millis, nanos) has always behaved with only
> millisecond granularity.
Reworded, added comment.
On Tue, 18 Apr 2023 19:38:12 GMT, Aleksey Shipilev wrote:
>> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
>> documentation for that method clearly says the precision and accuracy are
>> dependent on the underlying system behavior. However, it always rounds up
>>
On Wed, 19 Apr 2023 08:15:44 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 576:
>>
>>> 574: long millis = NANOSECONDS.toMillis(nanos);
>>> 575: nanos -= MILLISECONDS.toNanos(millis);
>>> 576: sleep(millis, (int)nanos);
>>
>> This
On Wed, 19 Apr 2023 05:50:00 GMT, David Holmes wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtests
>
> test/jdk/java/lang/Thread/SleepSanity.java line 75:
>
>> 73: }
>> 74:
>> 75: private
On Wed, 19 Apr 2023 05:43:19 GMT, David Holmes wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtests
>
> src/java.base/share/classes/java/lang/Thread.java line 576:
>
>> 574: long millis =
On Wed, 19 Apr 2023 07:34:30 GMT, Nagata-Haruhito wrote:
> I fixed File.listRoots description.
> * remove "the insertion or ejection of removable media"
> * change "available" to "existing"
>
> Please review this change.
The text you are proposing to change goes back a long way, it pre-dates
I fixed File.listRoots description.
* remove "the insertion or ejection of removable media"
* change "available" to "existing"
Please review this change.
-
Commit messages:
- 8306431: The documentation of File.listRoots should be modifid after
JDK-8208077
Changes:
1 - 100 of 108 matches
Mail list logo
