On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote:
> Adjust the specification of the `SequencedMap` sequenced-view methods, and
> adjust implementations to match.
Marked as reviewed by darcy (Reviewer).
-
PR Review:
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote:
> Adjust the specification of the `SequencedMap` sequenced-view methods, and
> adjust implementations to match.
src/java.base/share/classes/java/util/AbstractMap.java line 908:
> 906: public boolean add(E t) { throw uoe(); }
> 907:
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote:
> Adjust the specification of the `SequencedMap` sequenced-view methods, and
> adjust implementations to match.
src/java.base/share/classes/java/util/SequencedMap.java line 268:
> 266: * Its {@link SequencedSet#reversed reversed}
> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
> TEST=gc/TestAllocHumongousFragment.java
> error info:
>
> Caused by: java.lang.NullPointerException: Cannot invoke
> "sun.util.locale.BaseLocale.getVariant()" because "base" is null
> at
On Mon, 5 Jun 2023 21:48:23 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/sun/util/locale/BaseLocale.java line 369:
>>
>>> 367: BaseLocale l = key.holder;
>>> 368: BaseLocale locale = new BaseLocale(l.getLanguage(),
>>> l.getScript(), l.getRegion(),
On Mon, 5 Jun 2023 21:39:49 GMT, Iris Clark wrote:
> The decimal integer should be unsigned and without leading zeros. A regex
> similar to that provided by Runtime.Version would make things clear. I think
> that Mandy's suggestion would be a reasonable alternative as the Java class
> file
On Tue, 6 Jun 2023 00:37:18 GMT, Chen Liang wrote:
>> This patch aims to improve the performance of MethodTypeDesc in general, as
>> it is currently a performance bottleneck in the Classfile API. A previous
>> revision changed the parameter storage from an array to a list; this is
>> dropped
> This patch aims to improve the performance of MethodTypeDesc in general, as
> it is currently a performance bottleneck in the Classfile API. A previous
> revision changed the parameter storage from an array to a list; this is
> dropped now. Sorry for the force push.
>
>
> Benchmark
On Mon, 5 Jun 2023 23:38:11 GMT, Chen Liang wrote:
>> This patch aims to improve the performance of MethodTypeDesc in general, as
>> it is currently a performance bottleneck in the Classfile API. A previous
>> revision changed the parameter storage from an array to a list; this is
>> dropped
On Fri, 2 Jun 2023 01:12:32 GMT, Stuart Marks wrote:
> Create and use new NullableKeyValueHolder class to accommodate map entries
> whose key or value might be null.
This pull request has now been integrated.
Changeset: 6d155a47
Author:Stuart Marks
URL:
On Fri, 2 Jun 2023 01:12:32 GMT, Stuart Marks wrote:
> Create and use new NullableKeyValueHolder class to accommodate map entries
> whose key or value might be null.
Thanks for looking at this.
Yeah, the serializability of various Entry objects that are exposed through the
APIs is all over
> This patch aims to improve the performance of MethodTypeDesc in general, as
> it is currently a performance bottleneck in the Classfile API. A previous
> revision changed the parameter storage from an array to a list; this is
> dropped now. Sorry for the force push.
>
>
> Benchmark
On Sun, 4 Jun 2023 23:52:37 GMT, Chen Liang wrote:
>> This patch aims to improve the performance of MethodTypeDesc in general, as
>> it is currently a performance bottleneck in the Classfile API. A previous
>> revision changed the parameter storage from an array to a list; this is
>> dropped
On Mon, 5 Jun 2023 22:34:23 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java line
>> 84:
>>
>>> 82: paramTypes = new ClassDesc[paramCount];
>>> 83: for (int i = 0; i < paramCount; i++) {
>>> 84:
On Mon, 5 Jun 2023 17:27:19 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains two commits:
>>
>> - Forgot to upload latest micro
>> - general optimizations to MTD, no longer change backing
On Fri, 2 Jun 2023 01:12:32 GMT, Stuart Marks wrote:
> Create and use new NullableKeyValueHolder class to accommodate map entries
> whose key or value might be null.
Changes look good.
An observation:
`TreeMap` implements `SequencedMap`, and I see that its `firstEntry()` and
related
On Fri, 2 Jun 2023 01:07:27 GMT, SUN Guoyun wrote:
>> SUN Guoyun has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit
On Mon, 5 Jun 2023 21:34:04 GMT, Mandy Chung wrote:
>> Update PR and CSR to use the wording:
>>
>> "Latest Java class file format version recognized by the Java runtime as
>> "MAJOR.MINOR" where MAJOR and MINOR are both formatted as decimal integers"
>>
>> While it wouldn't be unreasonable to
On Mon, 5 Jun 2023 18:02:34 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/System.java line 758:
>>
>>> 756: * Greatest Java class file format version recognized by
>>> the runtime as {@code "MAJOR.MINOR"}
>>> 757: * where {@link
>>>
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all:
On Wed, 31 May 2023 14:05:56 GMT, Jan Lahoda wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Reflecting review feedback.
>> - Merge branch 'master' into JDK-8291966
>> - Adding
On Fri, 26 May 2023 02:06:55 GMT, Joe Darcy wrote:
> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/14165
On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy wrote:
>> Explain in java.lang.Class how unnamed classes are modeled in core
>> reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update reflective support.
The changes
On Mon, 5 Jun 2023 19:12:52 GMT, Tom Rodriguez wrote:
> This allows bin/idea.sh to properly see the JVMCI files again.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14318#pullrequestreview-1463324474
On Thu, 1 Jun 2023 13:43:33 GMT, Alan Bateman wrote:
>> This is the implementation of:
>>
>> - JEP 453: Structured Concurrency (Preview)
>> - JEP 446: Scoped Values (Preview)
>>
>> For the most part, this is just moving code and tests. StructuredTaskScope
>> moves to j.u.concurrent as a
On Mon, 5 Jun 2023 15:10:18 GMT, Alan Bateman wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/ThreadController.java
>> line 660:
>>
>>> 658: expectedMethods.add(Thread.class.getName() + ".sleep");
>>> 659: expectedMethods.add(Thread.class.getName() +
On Mon, 5 Jun 2023 19:12:52 GMT, Tom Rodriguez wrote:
> This allows bin/idea.sh to properly see the JVMCI files again.
Marked as reviewed by dnsimon (Committer).
Finally ;-)
-
PR Review: https://git.openjdk.org/jdk/pull/14318#pullrequestreview-1463296723
PR Comment:
On Mon, 5 Jun 2023 17:25:43 GMT, Aleksey Shipilev wrote:
> I think we need to delay this until
> [JDK-8309361](https://bugs.openjdk.org/browse/JDK-8309361) is resolved, in
> case we would like to revert
> [JDK-8305092](https://bugs.openjdk.org/browse/JDK-8305092).
Okay, I won't integrate
Lookup.findSpecial fails on Object method call from an interface because of a
bug in the implementation calling `Class::getSuperclass` on an interface which
has no superclass. The implementation should only search the method from its
superclass only if it's a class. This patch is trivial
This allows bin/idea.sh to properly see the JVMCI files again.
-
Commit messages:
- 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout
Changes: https://git.openjdk.org/jdk/pull/14318/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14318=00
Issue:
On Fri, 2 Jun 2023 20:32:14 GMT, Doug Simon wrote:
> This PR improves the startup time for libgraal by speeding up how
> `VM.savedProps` is copied into libgraal. This data structure is now
> serialized to a native buffer directly from C++ and the native buffer is then
> directly decoded by
This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
enabling re-introduction of spin control from the previous version, removing
anomalies like this one.
-
Commit messages:
- Use Thread.isVirtual to distinguish spin vs immediate block cases
Changes:
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 27 Apr 2023 12:38:11 GMT, Jim Laskey wrote:
> Add flexible main methods and anonymous main classes to the Java language.
This pull request has now been integrated.
Changeset: 98b53c06
Author:Jim Laskey
URL:
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote:
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
>
> Based on
On Mon, 5 Jun 2023 15:14:35 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 50:
>
>> 48: /**
>>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 5 Jun 2023 06:05:14 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>>
On Mon, 22 May 2023 07:27:00 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request incrementally with
On Sun, 4 Jun 2023 23:52:37 GMT, Chen Liang wrote:
>> This patch aims to improve the performance of MethodTypeDesc in general, as
>> it is currently a performance bottleneck in the Classfile API. A previous
>> revision changed the parameter storage from an array to a list; this is
>> dropped
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull
On Mon, 5 Jun 2023 16:30:16 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolBuilder.java
>
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote:
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> settled down now
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
-Xprint unnamed classes to use e.getSimpleName()
-
Changes:
- all:
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
>
> Based on previous discussions we decided to consolidate on
>
On Mon, 5 Jun 2023 14:42:32 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
>
> Based on previous discussions we decided to consolidate on
>
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 55 commits:
- Merge branch 'master' into 8306112
- Final clean up
- Merge branch 'master' into
On Mon, 5 Jun 2023 15:03:01 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits
On Mon, 5 Jun 2023 07:26:57 GMT, David Holmes wrote:
>> Thread.sleep has had quite a bit of churn recently to support virtual
>> threads, add sleep(Duration), a JFR event, and the change the underlying
>> implementation to support sub-millis precision. I think the changes have
>> settled down
On Mon, 5 Jun 2023 14:38:47 GMT, Adam Sotona wrote:
>> Class-File API actually throws wide variety of exceptions based on the
>> actual situation. Complete error handling code must cover
>> `IndexOutOfBoundsException`, `IllegalStateException` and
>> `IllegalArgumentException`.
>>
>> Based
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
>
> Based on previous discussions we decided to consolidate on
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
failed with "InterruptedException: sleep interrupted" and related issues.
This is a major ForkJoin update (and hard to review -- sorry) that finally
addresses incompatibilities between ExecutorService and ForkJoinPool
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 53 commits:
- Merge branch 'master' into 8306112
- Requested clean ups
- Source code launcher
On Mon, 5 Jun 2023 10:17:01 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 216:
>
>> 214: * {@linkplain
On Mon, 5 Jun 2023 10:11:17 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 1881:
>
>> 1879: * @since 21
>>
On Mon, 5 Jun 2023 10:08:59 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 29:
>
>> 27:
>> 28: import
On Sat, 3 Jun 2023 01:53:41 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the specification for TypeElement#getQualifiedName and
>> TypeElement#getSimpleName
>
>
On Fri, 26 May 2023 15:57:15 GMT, Brian Burkhalter wrote:
> > Would you please review this PR ?
>
> We are in the last two weeks before JDK 21 rampdown phase 1 and so are rather
> busy. This PR has not been forgotten. Thanks for your patience.
Yeah, this is docs only so okay to do after the
On Fri, 5 Aug 2022 16:12:08 GMT, Jan Lahoda wrote:
> The pattern matching switches are using a bootstrap method
> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch. Basically,
> for a switch like:
>
> switch (obj) {
> case String s when s.isEmpty() -> {}
> case String
On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy wrote:
>> Explain in java.lang.Class how unnamed classes are modeled in core
>> reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update reflective support.
Will this
On Mon, 5 Jun 2023 09:02:06 GMT, Aleksandar Pejovic
wrote:
>> src/java.base/linux/classes/jdk/internal/platform/CgroupInfo.java line 110:
>>
>>> 108: */
>>> 109: static CgroupInfo fromCgroupsLine(String line) {
>>> 110: String[] tokens = line.split("\t");
>>
>> With this
On Thu, 1 Jun 2023 09:47:29 GMT, Severin Gehwolf wrote:
>> The current code for cgroup support in the JDK has large and expensive
>> dependencies: it uses NIO, streams, and regular expressions. This leads to
>> unnecessary class loading and slows down startup, especially when the code
>> is
On Thu, 1 Jun 2023 08:50:33 GMT, Severin Gehwolf wrote:
>> The current code for cgroup support in the JDK has large and expensive
>> dependencies: it uses NIO, streams, and regular expressions. This leads to
>> unnecessary class loading and slows down startup, especially when the code
>> is
On Wed, 31 May 2023 13:49:46 GMT, Aleksandar Pejovic
wrote:
>>> I guess I'll have to wait for OCA verification.
>>
>> Yes.
>>
>>> One failure is due to a lack of reviewers, so would you be able to do a
>>> review?
>>
>> Yes, I'll try to do a review later today or tomorrow.
>>
>> Thanks!
>
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote:
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> settled down now
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote:
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> settled down now
Thread.sleep has had quite a bit of churn recently to support virtual threads,
add sleep(Duration), a JFR event, and the change the underlying implementation
to support sub-millis precision. I think the changes have settled down now so
we can do some small cleanups that came up in PR
On Mon, 5 Jun 2023 01:11:54 GMT, Joe Darcy wrote:
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
src/java.base/share/classes/java/lang/System.java line 758:
> 756: * Greatest Java class file format version recognized by the
>
71 matches
Mail list logo
