Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2]

2023-06-11 Thread Oliver Kopp
On Mon, 12 Jun 2023 05:02:07 GMT, Alan Bateman wrote: > Do you mind fixing all the comments as these 160+ lines Done. I copied the (for me) important comments to the GitHub reply https://github.com/openjdk/jdk/pull/14408#issuecomment-1586615579. > You had fixed that in the original PR but it

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image

2023-06-11 Thread Oliver Kopp
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote: > Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2]

2023-06-11 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods >

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-11 Thread Chen Liang
On Mon, 12 Jun 2023 04:52:57 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 103: >> >>> 101: } >>> 102: return descOrInternalName.substring(1, >>> descOrInternalName.length() - 1).replace('/', '.'); >>> 103: }

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v11]

2023-06-11 Thread Chen Liang
On Thu, 8 Jun 2023 01:32:20 GMT, Chen Liang wrote: >> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`. >> >> A few implementation-detail methods in VarHandle are now documented with the >> implied constraints to avoid subtle problems in the future. Changed >>

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image

2023-06-11 Thread Alan Bateman
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote: > Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-11 Thread Chen Liang
On Mon, 12 Jun 2023 02:41:02 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 14 commits: >> >> - Review changes, fixed tests >> - Merge branch 'master' into hierarchy-resolve >> - 1. Moved

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v3]

2023-06-11 Thread Tom Rodriguez
On Sun, 11 Jun 2023 17:26:28 GMT, Doug Simon wrote: >> This PR reduces the amount of code executed during libgraal initialization. >> This not only improves VM startup overall but all fixes a number of JDK test >> failures that are caused by Java code executing "too early". For example, >>

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-11 Thread ExE Boss
On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v9]

2023-06-11 Thread Jiangli Zhou
> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for >

Re: RFR: 8305104: Remove the old core reflection implementation [v3]

2023-06-11 Thread Mandy Chung
On Sun, 11 Jun 2023 20:42:49 GMT, ExE Boss wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review feedback > > src/java.base/share/classes/jdk/internal/reflect/MethodHandleAccessorFactory.java > line 314: > >>

Re: RFR: 8305104: Remove the old core reflection implementation [v4]

2023-06-11 Thread Mandy Chung
> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has > been reported. Those issues were related with exception being thrown with > invalid arguments. We propose to remove the old core reflection > implementation in JDK 22. The

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image

2023-06-11 Thread Christoph
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote: > Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split

RFR: 8240567: MethodTooLargeException thrown while creating a jlink image

2023-06-11 Thread Oliver Kopp
Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): "MethodTooLargeException thrown while creating a jlink image". Java still has a 64kb limit: A method may not be longer than 64kb. The idea of the fix is to split up the generated methods in several smaller methods This is a

Re: RFR: 8305104: Remove the old core reflection implementation [v3]

2023-06-11 Thread ExE Boss
On Thu, 8 Jun 2023 16:46:55 GMT, Mandy Chung wrote: >> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has >> been reported. Those issues were related with exception being thrown with >> invalid arguments. We propose to remove the old core reflection >>

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v3]

2023-06-11 Thread Doug Simon
> This PR improves the startup time for libgraal by speeding up how > `VM.savedProps` is copied into libgraal. This data structure is now > serialized to a native buffer directly from C++ and the native buffer is then > directly decoded by libgraal. > > ## Times > > The basic benchmarking

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

2023-06-11 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - update -

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-06-11 Thread Artem Semenov
On Tue, 6 Jun 2023 17:47:02 GMT, Weijun Wang wrote: >> This is rarely used in the code and is not the essence of the current >> changes. >> If you introduce such changes, then throughout the code. >> Moreover, this can lead to problems, such as, for example, here: >>

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-11 Thread Chris Hegarty
On Fri, 9 Jun 2023 19:44:32 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit > [cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

2023-06-11 Thread Viktor Klang
On Fri, 9 Jun 2023 16:53:05 GMT, Alan Bateman wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Decresing the number of iterations proportional to the increase in the max >> memory size > > This looks okay to me