Updated the version to 22-ea and year to 2024.
The following unpublished changes will also be included in this update:
- [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
contains a special character
- [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update
On Wed, 14 Jun 2023 01:57:53 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a binary name instead. Class::getName was a partial
On Wed, 14 Jun 2023 01:26:25 GMT, Chen Liang wrote:
>> This method was added prior to `MethodTypeDesc`.
>> MethodTypeDesc::ofDescriptor` and `MethodTypeDesc::resolveConstantDesc`
>> would be the alternative way to get back the method type. I tend to think
>> that `descriptorString` would
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a binary name instead. Class::getName was a partial
On Wed, 14 Jun 2023 01:08:51 GMT, Mandy Chung wrote:
>> Should we consolidate this distinct class loader note into
>> `descriptorString` too?
>
> This method was added prior to `MethodTypeDesc`.
> MethodTypeDesc::ofDescriptor` and `MethodTypeDesc::resolveConstantDesc` would
> be the
On Tue, 13 Jun 2023 10:11:28 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search
On Wed, 14 Jun 2023 00:10:08 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodType.java line 1233:
>>
>>> 1231: * will appear identical when viewed within descriptor strings.
>>> 1232: * In addition, the result string is not a bytecode descriptor if
>>>
On Tue, 13 Jun 2023 23:24:46 GMT, Stuart Marks wrote:
> I reviewed the changes in java.base. They look fine. I support the notion of
> keeping these changes minimal, with the narrow goal of keeping the resulting
> javadoc output the same. There are many opportunities for improving the
>
On Sun, 12 Feb 2023 15:41:55 GMT, Eirik Bjorsnos wrote:
> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
> number of compressed or uncompressed bytes read from the inflater is larger
> than the Zip64 magic value.
>
> While the ZIP format mandates that the data
On Tue, 13 Jun 2023 21:54:10 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/classes/java/lang/Class.java
>>
>> Co-authored-by: Mandy Chung
>
>
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a binary name instead. Class::getName was a partial
On Tue, 13 Jun 2023 22:09:40 GMT, Justin Lu wrote:
>> Please review this PR which updates the JDK's localized resources since the
>> previous L10n translation drop (1/26).
>>
>> To help with reviewing the changes, @jonathan-gibbons created a tool which
>> displays the localized changes next
On Tue, 13 Jun 2023 23:14:29 GMT, Chen Liang wrote:
> Hello,
>
> This pull request contains a git cherry-pick of commit
> openjdk/jdk@75dcc4ef94d90e4aa7f8ca5eccc97c91492d6eed, which fixed an NPE in
> IndirectVarHandle.isAccessModeSupported, reproducible via the return value of
>
On Tue, 13 Jun 2023 10:11:28 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search
Hello,
This pull request contains a git cherry-pick of commit
openjdk/jdk@75dcc4ef94d90e4aa7f8ca5eccc97c91492d6eed, which fixed an NPE in
IndirectVarHandle.isAccessModeSupported, reproducible via the return value of
MethodHandles.filterCoordinates.
The commit being backported was reviewed by
On Tue, 13 Jun 2023 20:56:31 GMT, Weijun Wang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> Some comments:
>
> -
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the original file's changes in UTF-8
> native. Those
On Mon, 12 Jun 2023 07:58:29 GMT, Chen Liang wrote:
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a
On Tue, 13 Jun 2023 19:42:44 GMT, Aleksey Shipilev wrote:
>> Man Cao has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>>
On Tue, 13 Jun 2023 20:20:32 GMT, Stuart Marks wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [e1386856](https://github.com/openjdk/jdk/commit/e138685648fb7a756a05f314af2883ce408abdd2)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the original file's changes in UTF-8
> native. Those
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote:
>> Please review this PR which updates the JDK's localized resources since the
>> previous L10n translation drop (1/26).
>>
>> To help with reviewing the changes, @jonathan-gibbons created a tool which
>> displays the localized changes next
On Tue, 13 Jun 2023 20:20:32 GMT, Stuart Marks wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [e1386856](https://github.com/openjdk/jdk/commit/e138685648fb7a756a05f314af2883ce408abdd2)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request incrementally with one additional commit
since the last revision:
Switch to using
Hi all,
This pull request contains a backport of commit
[e1386856](https://github.com/openjdk/jdk/commit/e138685648fb7a756a05f314af2883ce408abdd2)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Stuart Marks on 13 Jun 2023 and was
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote:
>> Please review this PR which updates the JDK's localized resources since the
>> previous L10n translation drop (1/26).
>>
>> To help with reviewing the changes, @jonathan-gibbons created a tool which
>> displays the localized changes next
On Tue, 13 Jun 2023 19:24:08 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request with a new target base due to a
On Wed, 7 Jun 2023 21:29:34 GMT, Mandy Chung wrote:
> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has
> been reported. Those issues were related with exception being thrown with
> invalid arguments. We propose to remove the old core reflection
> implementation
On Thu, 8 Jun 2023 15:51:22 GMT, Pavel Rappo wrote:
>> Copying an individual doc element using `{@inheritDoc}` never adds meta
>> information on the generated HTML page to indicate where that doc element
>> was copied from. It so happens in this particular case that the doc
>> element's
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request with a new target base due to a merge or a
rebase. The incremental webrev excludes the
On Tue, 13 Jun 2023 18:55:20 GMT, Raffaello Giulietti
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [bfef3c3e](https://github.com/openjdk/jdk/commit/bfef3c3e80d4df98bdb0d853c2e2711cdd8252ce)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The
Hi all,
This pull request contains a backport of commit
[bfef3c3e](https://github.com/openjdk/jdk/commit/bfef3c3e80d4df98bdb0d853c2e2711cdd8252ce)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Raffaello Giulietti on 13 Jun 2023
and
On Tue, 13 Jun 2023 18:55:20 GMT, Raffaello Giulietti
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [bfef3c3e](https://github.com/openjdk/jdk/commit/bfef3c3e80d4df98bdb0d853c2e2711cdd8252ce)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The
On Tue, 13 Jun 2023 18:13:12 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
>
On Tue, 13 Jun 2023 18:08:55 GMT, Raffaello Giulietti
wrote:
> Trivial fix to working but unsupported use of {@inheritDoc}
This pull request has now been integrated.
Changeset: bfef3c3e
Author:Raffaello Giulietti
URL:
On Tue, 13 Jun 2023 10:11:28 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote:
>> Please review this PR which updates the JDK's localized resources since the
>> previous L10n translation drop (1/26).
>>
>> To help with reviewing the changes, @jonathan-gibbons created a tool which
>> displays the localized changes next
On Tue, 13 Jun 2023 18:08:55 GMT, Raffaello Giulietti
wrote:
> Trivial fix to working but unsupported use of {@inheritDoc}
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14452#pullrequestreview-1477810928
Trivial fix to working but unsupported use of {@inheritDoc}
-
Commit messages:
- 8309955: Matcher uses @since {@inheritDoc}
Changes: https://git.openjdk.org/jdk/pull/14452/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14452=00
Issue:
On Tue, 13 Jun 2023 13:09:49 GMT, Andrey Turbanov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing comments (test grouping, synchronization), minor optimization
>> on loop lookup
>
>
On Tue, 13 Jun 2023 11:22:11 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing comments (test grouping, synchronization), minor optimization
>> on loop lookup
>
>
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where
> aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the
> in-house cache with WeakHashMap, and removed the Key class as it is no longer
> needed (thus the original NPE will no longer be possible).
On Tue, 13 Jun 2023 17:09:30 GMT, Jorn Vernee wrote:
>> Update the make/autoconf/lib-ffi.m4 script to support using libffi on
>> Windows and Mac.
>>
>> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
>> an import of `stdint.h` missing, and since it was using
On Tue, 13 Jun 2023 17:09:30 GMT, Jorn Vernee wrote:
>> Update the make/autoconf/lib-ffi.m4 script to support using libffi on
>> Windows and Mac.
>>
>> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
>> an import of `stdint.h` missing, and since it was using
On Tue, 13 Jun 2023 12:48:12 GMT, Jorn Vernee wrote:
> Update the make/autoconf/lib-ffi.m4 script to support using libffi on Windows
> and Mac.
>
> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
> an import of `stdint.h` missing, and since it was using
> Update the make/autoconf/lib-ffi.m4 script to support using libffi on Windows
> and Mac.
>
> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
> an import of `stdint.h` missing, and since it was using `WSAGetLastError` it
> needed to link against `ws2_32.lib`.
>
>
On Mon, 12 Jun 2023 05:27:35 GMT, Chen Liang wrote:
> Fixes the NPE in IndirectVarHandle.isAccessModeSupported by delegating to the
> target var handle. In addition, simplified the MH caching in Indirect VH and
> removed redundant overrides (already available via var form). This was split
>
On Tue, 13 Jun 2023 16:35:33 GMT, Mandy Chung wrote:
> This is a test-only fix.
>
> This pull request contains a backport of commit
> [679a6d89](https://github.com/openjdk/jdk/commit/679a6d89358eb36c596e3ffa9a86869402c9beb9)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Tue, 13 Jun 2023 16:05:07 GMT, Erik Joelsson wrote:
>> Update the make/autoconf/lib-ffi.m4 script to support using libffi on
>> Windows and Mac.
>>
>> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
>> an import of `stdint.h` missing, and since it was using
This is a test-only fix.
This pull request contains a backport of commit
[679a6d89](https://github.com/openjdk/jdk/commit/679a6d89358eb36c596e3ffa9a86869402c9beb9)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Mandy Chung on
On Mon, 5 Jun 2023 18:52:00 GMT, Doug Lea wrote:
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
> enabling re-introduction of spin control from the previous version, removing
> anomalies like this one.
StructuredTaskScope's class description introduces the join method as waiting
for all subtasks to finish but the API docs for join/joinUntil are phrased in
terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil
inherit this description but would be clearer if their description
On Tue, 13 Jun 2023 15:53:07 GMT, Andrew Haley wrote:
>> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>>
>> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
>> error occurs it can not recover scoped values.
>>
>> Moving `runWith()` into the common
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass of both `VirtualThread` and
> `BoundVirtualThread`
On Thu, 1 Jun 2023 12:11:29 GMT, Alan Bateman wrote:
> It's easy to introduce a new change to this code which accidentally drags in
> some of those (unwanted) dependencies again.
We (as the Native Image team) are OK with this. Our testing will detect that
pretty quickly, and then the new code
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote:
> Make `putMode` be a transient field.
This pull request has now been integrated.
Changeset: e1386856
Author:Stuart Marks
URL:
https://git.openjdk.org/jdk/commit/e138685648fb7a756a05f314af2883ce408abdd2
Stats: 1 line in 1
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
On Mon, 12 Jun 2023 14:26:40 GMT, Alan Bateman wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove ScopedValue/StressStackOverflow.java.
>> - Cleanup
>
> test/jdk/ProblemList-Virtual.txt line 48:
>
>> 46:
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass of both `VirtualThread` and
> `BoundVirtualThread`
On Fri, 2 Jun 2023 20:32:14 GMT, Doug Simon wrote:
> This PR reduces the amount of code executed during libgraal initialization.
> This not only improves VM startup overall but all fixes a number of JDK test
> failures that are caused by Java code executing "too early". For example,
>
On Mon, 12 Jun 2023 18:55:42 GMT, Doug Simon wrote:
>> This PR reduces the amount of code executed during libgraal initialization.
>> This not only improves VM startup overall but all fixes a number of JDK test
>> failures that are caused by Java code executing "too early". For example,
>>
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass of both `VirtualThread` and
> `BoundVirtualThread`
This PR proposes adding `@sealedGraph` to `GroupLayout` so the latter will be
rendered in the javadocs the same way the other layouts that has public
sub-interfaces.
-
Commit messages:
- Add @sealedGraph to GroupLayout
Changes: https://git.openjdk.org/jdk/pull/14449/files
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote:
> Make `putMode` be a transient field.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14433#pullrequestreview-1477284507
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase.
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Thanks for the feedback to date. I've pushed new changes to reflect requested
changes. I've changed the default` -XshowSettings
Update the make/autoconf/lib-ffi.m4 script to support using libffi on Windows
and Mac.
For Windows I had to tweak `fallbackLinker.c` to be able to build: there was an
import of `stdint.h` missing, and since it was using `WSAGetLastError` it
needed to link against `ws2_32.lib`.
This PR also
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 330:
> 328: if
On Tue, 13 Jun 2023 09:34:17 GMT, Chen Liang wrote:
>StackMapsOption doesn't fit in with other options, they should be
>ALWAYS_STACK_MAPS, NEVER_STACK_MAPS, etc.)
What about `STACK_MAPS_WHEN_REQUIRED`, `GENERATE_STACK_MAPS` and
`DROP_STACK_MAPS`?
-
PR Comment:
On Tue, 13 Jun 2023 11:32:59 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
On Tue, 13 Jun 2023 09:15:13 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ClassHierarchyResolver.DEFAULT_RESOLVER gets info from system class loader
>> and does not cache
>> method-level
On Tue, 13 Jun 2023 09:19:00 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 38 commits:
>>
>> - Merge branch 'master' into JDK-8308899-context
>> - Revert of
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 12 Jun 2023 17:33:11 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 8 Jun 2023 14:47:13 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
> Please review this long-awaited change to documentation inheritance.
>
> This change improves "methods comment algorithm" and introduces directed
> documentation inheritance. While "methods comment algorithm" -- automatic
> search for inheritable documentation -- has been improved, it still
On Mon, 12 Jun 2023 15:55:49 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
On Mon, 12 Jun 2023 15:55:49 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote:
> Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the
> typos you pointed out and removed other redundancies in classfile Util as
> well.
This pull request has now been integrated.
Changeset: 1a9edb8d
Author:Chen
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote:
> This PR proposes adding `@Stable` to certain wrapper classes' cache arrays
> (e.g. `Integer` and `Long`).
>
> Comments are welcome as to how to improve the VM's handling now that the
> backing cache array is `@Stable`. Are there
On Mon, 12 Jun 2023 14:25:42 GMT, Per Minborg wrote:
> This PR proposes adding `@Stable` to certain wrapper classes' cache arrays
> (e.g. `Integer` and `Long`).
>
> Comments are welcome as to how to improve the VM's handling now that the
> backing cache array is `@Stable`. Are there
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote:
> Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the
> typos you pointed out and removed other redundancies in classfile Util as
> well.
It looks good
-
Marked as reviewed by asotona (Reviewer).
PR
84 matches
Mail list logo
