Hi,
While trying to run jshell in qemu-user-static using binfmt_misc
(specifically, using this docker based tool [1]), I ran into an issue.
Jshell would fail to start and print `This command is not for general
use and should only be run as the result of a call to
ProcessBuilder.start() or
On Fri, 16 Jun 2023 12:14:49 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Pass
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last
On Fri, 16 Jun 2023 23:18:48 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comment
>
> src/java.base/share/classes/java/lang/Class.java line 443:
>
>> 441: * If {@code name} denotes
On Fri, 16 Jun 2023 17:18:38 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/sun/util/locale/BaseLocale.java line 175:
>>
>>> 173:
>>> LocaleUtils.toLowerString(b.getLanguage()).intern(),
>>> 174:
>>>
On Fri, 16 Jun 2023 21:33:44 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull
On Fri, 16 Jun 2023 17:18:33 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/sun/util/locale/BaseLocale.java line 168:
>>
>>> 166: // BaseLocale as the key. The returned "normalized" instance
>>> 167: // can subsequently be used by the Locale instance which
>>> 168:
On Fri, 16 Jun 2023 22:12:43 GMT, Roger Riggs wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative" and
On Fri, 16 Jun 2023 22:12:43 GMT, Roger Riggs wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative" and
On Fri, 16 Jun 2023 22:08:19 GMT, Daniel D. Daugherty
wrote:
> GHA is failing on windows; is this related to this PR or something else?
The windows build failures occur with other PRs as well, e.g.
https://github.com/openjdk/jdk21/pull/24/checks?check_run_id=14317258603. They
should be
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
GHA is failing on windows; is this related to this PR or something else?
@erikj - You did a round of
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater
> than zero" in
On Fri, 16 Jun 2023 21:33:44 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last
On Fri, 16 Jun 2023 21:23:17 GMT, Roger Riggs wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarify for an array class of primitive type
>
> src/java.base/share/classes/java/lang/Class.java line 448:
>
>> 446:
On Fri, 16 Jun 2023 21:24:17 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull
On Fri, 16 Jun 2023 20:15:25 GMT, Roger Riggs wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarify for an array class of primitive type
>
> src/java.base/share/classes/java/lang/Class.java line 444:
>
>> 442:
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Fri, 16 Jun 2023 20:52:13 GMT, Kevin Rushforth wrote:
> As a P4 enhancement, this doesn't meet the criteria for integration into JDK
> 21 during [Rampdown Phase
> 1](https://mail.openjdk.org/pipermail/jdk-dev/2023-June/007911.html). You
> could request late approval to get this enhancement
On Fri, 16 Jun 2023 04:39:42 GMT, Justin Lu wrote:
>> Please review this PR which updates the JDK's localized resources since the
>> previous L10n translation drop (1/26).
>>
>> To help with reviewing the changes, @jonathan-gibbons created a tool which
>> displays the localized changes next
On Fri, 16 Jun 2023 20:51:42 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/time/Duration.java line 1422:
>>
>>> 1420: *
>>> 1421: * @param otherDuration the other duration to compare to, not null
>>> 1422: * @return the comparator value is less than zero if the
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
As a P4 enhancement, this doesn't meet the criteria for integration into JDK 21
during [Rampdown Phase
On Fri, 16 Jun 2023 20:47:39 GMT, Lance Andersen wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative"
On Wed, 14 Jun 2023 20:35:54 GMT, Roger Riggs wrote:
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and
8307858: [REDO] JDK-8307194 Add make target for optionally building a complete
set of all JDK and hotspot libjvm static libraries
-
Commit messages:
- Backport 45414fc2dfa41cbbfc6de7fec15eb47f41cf8986
Changes: https://git.openjdk.org/jdk21/pull/26/files
Webrev:
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because
On Wed, 14 Jun 2023 20:35:54 GMT, Roger Riggs wrote:
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and
Hi,
I need a code review for moving the contents of the jdk.crypto.ec module into
java.base. This moves the SunEC JCE Provider (Elliptic Curve) into java.base.
EC has always been separate from the base module/pkg because of its dependence
on a native library. That library was removed in JDK
On Fri, 16 Jun 2023 19:58:08 GMT, Mandy Chung wrote:
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
On Thu, 15 Jun 2023 02:38:08 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>>
This PR clarifies the spec of the 3-arg Class::forName regarding the format of
the name for an array type which is of the form: one or more of "[" + binary
name of the element type + ";'.
-
Commit messages:
- 8310242: Clarify the name parameter to Class::forName
Changes:
> The internal enum jdk.internal.util.Architecture does not provide information
> about the big or little endianness or the address size (64 or 32 bits). The
> endian-ness and address size are intrinsic to the architecture.
>
> The values of the enum are extended to separately identify the big
In java.time packages, clarify timeline order javadoc to mention "before" and
"after" in the value of the `compareTo` method return values.
Add javadoc @see tags to isBefore and isAfter methods
Replace use of "negative" and positive with "less than zero" and "greater than
zero" in javadoc
On Thu, 15 Jun 2023 02:38:08 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>>
On Fri, 16 Jun 2023 11:59:39 GMT, Matthias Baesken wrote:
>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
>> the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
>>
>>
On Fri, 16 Jun 2023 15:30:55 GMT, Roger Riggs wrote:
>> Can I get a preliminary review of the wording for Deque.reversed()? If the
>> text is good, I'll make corresponding changes to the implSpecs of the other
>> reversed() default methods, namely those in List, SortedMap, and SortedSet
>>
On Wed, 14 Jun 2023 16:54:55 GMT, Andrew Haley wrote:
>> The implementation changes look good.
>>
>> The update to test looks okay too although I would like to see if we can do
>> better in SVC and STS when there is a SO. In passing, I think all usages of
>> tlr should be replaced with
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty
wrote:
> A trivia fix for
> serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java
> failing.
This pull request has now been integrated.
Changeset: 16134f44
Author:Daniel D. Daugherty
URL:
On Fri, 16 Jun 2023 17:26:38 GMT, Mikael Vidstedt wrote:
>> A trivia fix for
>> serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java
>> failing.
>
> Marked as reviewed by mikael (Reviewer).
@vidmik - Thanks for the review!
It appears that the bots are running very, very
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty
wrote:
> A trivia fix for
> serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java
> failing.
This fix is being tested with an urgent Mach5 Tier1.
macosx-aarch64-debug has passed the test when it failed before.
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty
wrote:
> A trivia fix for
> serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java
> failing.
Marked as reviewed by mikael (Reviewer).
-
PR Review:
A trivia fix for
serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java
failing.
-
Commit messages:
- 8310211:
serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
Changes: https://git.openjdk.org/jdk/pull/14524/files
Webrev:
On Fri, 16 Jun 2023 12:46:01 GMT, Brett Okken wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/sun/util/locale/BaseLocale.java line 168:
>
>> 166:
On Fri, 16 Jun 2023 15:06:30 GMT, Jonathan Gibbons wrote:
>> Left some comments on the translations mainly in Japanese. It is now very
>> easy to look at the l10n changes in the generated HTML. One small comment to
>> the tool is that it would be nice if the order in HTML (alphabetically
>>
On Thu, 15 Jun 2023 22:38:43 GMT, Stuart Marks wrote:
> Can I get a preliminary review of the wording for Deque.reversed()? If the
> text is good, I'll make corresponding changes to the implSpecs of the other
> reversed() default methods, namely those in List, SortedMap, and SortedSet
> and
On Fri, 16 Jun 2023 12:14:49 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Pass
On Fri, 16 Jun 2023 01:53:29 GMT, Jorn Vernee wrote:
>> This patch changes the implementation of `MethodHandles::collectCoordinates`
>> to allow using filters that return `void`. This brings the behavior in line
>> with the previously existing `MethodHandles::collectArgument` which operates
> This patch changes the implementation of `MethodHandles::collectCoordinates`
> to allow using filters that return `void`. This brings the behavior in line
> with the previously existing `MethodHandles::collectArgument` which operates
> on MethodHandles rather than VarHandles.
>
> Testing:
On Fri, 16 Jun 2023 15:15:07 GMT, Jorn Vernee wrote:
>> This patch changes the implementation of `MethodHandles::collectCoordinates`
>> to allow using filters that return `void`. This brings the behavior in line
>> with the previously existing `MethodHandles::collectArgument` which operates
On Tue, 13 Jun 2023 18:38:28 GMT, Naoto Sato wrote:
> Left some comments on the translations mainly in Japanese. It is now very
> easy to look at the l10n changes in the generated HTML. One small comment to
> the tool is that it would be nice if the order in HTML (alphabetically sorted
>
On Thu, 15 Jun 2023 11:45:04 GMT, Andrew Haley wrote:
>> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>>
>> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
>> error occurs it can not recover scoped values.
>>
>> Moving `runWith()` into the common
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Tue, 13 Jun 2023 17:56:57 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer
On Fri, 16 Jun 2023 11:54:52 GMT, Matthias Baesken wrote:
> Hi Alan, I adjusted / simplified the coding.
Thanks for taking the suggestion.
-
PR Comment: https://git.openjdk.org/jdk/pull/14515#issuecomment-1594595016
On Fri, 16 Jun 2023 11:59:39 GMT, Matthias Baesken wrote:
>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
>> the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
>>
>>
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote:
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Pass PrintStream to security helper
-
Changes:
- all:
On Tue, 13 Jun 2023 17:56:57 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Fri, 16 Jun 2023 10:44:47 GMT, Matthias Baesken wrote:
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
> the following test started to fail on AIX :
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
>
> java.lang.RuntimeException:
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
> the following test started to fail on AIX :
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
>
> java.lang.RuntimeException: 'WARNING: A JVM TI agent has been loaded
> dynamically' found
On Tue, 13 Jun 2023 14:13:42 GMT, Per Minborg wrote:
> This PR proposes adding `@sealedGraph` to `GroupLayout` so the latter will be
> rendered in the javadocs the same way the other layouts that has public
> sub-interfaces.
This pull request has now been integrated.
Changeset: b412fc79
> The current implementation for testing generational ZGC with jtreg is
> implemented with a filter on the mode flag `ZGenerational`. Because of this
> only environments which set this flag explicitly will run most of the tests.
> So they get missed in Github Actions and for developers running
On Tue, 13 Jun 2023 14:13:42 GMT, Per Minborg wrote:
> This PR proposes adding `@sealedGraph` to `GroupLayout` so the latter will be
> rendered in the javadocs the same way the other layouts that has public
> sub-interfaces.
Marked as reviewed by mcimadamore (Reviewer).
-
PR
On Fri, 16 Jun 2023 10:44:47 GMT, Matthias Baesken wrote:
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
> the following test started to fail on AIX :
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
>
> java.lang.RuntimeException:
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Fri, 16 Jun 2023 11:09:23 GMT, Sean Coffey wrote:
> Logged https://bugs.openjdk.org/browse/JDK-8310201 to track the Locale
> changes Alan.
Thanks, probably should treat this as a bug for JDK 21 so that a new addition
doesn't change behavior between 21 and 22.
-
PR Review
On Fri, 16 Jun 2023 11:14:38 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> -
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 14 Jun 2023 14:06:33 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 424:
>>
>>> 422:if (!services.isEmpty()) {
>>> 423:services.stream()
>>> 424:
>>>
On Thu, 15 Jun 2023 06:32:06 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183:
>>
>>> 181: case "locale":
>>> 182: printLocale();
>>> 183: break;
>>
>> printLocale might need the same treatment to
On Wed, 14 Jun 2023 12:46:36 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
>
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Refactor out security code to helper class
- Print aliases. Order
After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , the
following test started to fail on AIX :
com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
java.lang.RuntimeException: 'WARNING: A JVM TI agent has been loaded
dynamically' found in stderr
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
The current implementation for testing generational ZGC with jtreg is
implemented with a filter on the mode flag `ZGenerational`. Because of this
only environments which set this flag explicitly will run most of the tests.
So they get missed in Github Actions and for developers running jtreg
Clean backport from latest jdk repo to jdk21 for the test change:
8303916: ThreadLists.java inconsistent results
-
Commit messages:
- Backport 8c9b85a990d955487f9141207cc83d0051defc57
Changes: https://git.openjdk.org/jdk21/pull/24/files
Webrev:
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote:
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> settled down now
81 matches
Mail list logo
