Re: RFR: 8312522: Implementation of Foreign Function & Memory API

2023-08-09 Thread David Holmes
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote: > This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The

Re: RFR: 8041488: Locale-Dependent List Patterns [v7]

2023-08-09 Thread Joe Wang
On Wed, 9 Aug 2023 00:46:58 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >>

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v6]

2023-08-09 Thread Claes Redestad
On Wed, 9 Aug 2023 22:54:28 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> equals, hashCode, and compareTo for BigInteger. If you have any performance >> concerns, please raise them. >> >> This PR is cherry-picked from a bigger,

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v6]

2023-08-09 Thread Pavel Rappo
> Please review this PR to use modern APIs and language features to simplify > equals, hashCode, and compareTo for BigInteger. If you have any performance > concerns, please raise them. > > This PR is cherry-picked from a bigger, not-yet-published PR, to test the > waters. That latter PR will

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v3]

2023-08-09 Thread Serguei Spitsyn
On Wed, 9 Aug 2023 11:06:04 GMT, Matthias Baesken wrote: >> There is coding e.g. in >> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 >> that deals with shared lib naming on different OS. >> This code should be simplified. > > Matthias

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v5]

2023-08-09 Thread Pavel Rappo
> Please review this PR to use modern APIs and language features to simplify > equals, hashCode, and compareTo for BigInteger. If you have any performance > concerns, please raise them. > > This PR is cherry-picked from a bigger, not-yet-published PR, to test the > waters. That latter PR will

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v3]

2023-08-09 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v3]

2023-08-09 Thread Chris Plummer
On Wed, 9 Aug 2023 11:06:04 GMT, Matthias Baesken wrote: >> There is coding e.g. in >> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 >> that deals with shared lib naming on different OS. >> This code should be simplified. > > Matthias

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v5]

2023-08-09 Thread Vyom Tewari
On Wed, 9 Aug 2023 12:52:35 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug

Re: RFR: 8298095: Refine implSpec for SegmentAllocator [v4]

2023-08-09 Thread Maurizio Cimadamore
On Tue, 8 Aug 2023 08:35:51 GMT, Per Minborg wrote: >> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate >> methods as well as clarifying the docs a bit more. Also, a local variable is >> renamed. > > Per Minborg has updated the pull request with a new target base

[jdk21] Integrated: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16

2023-08-09 Thread Jim Laskey
On Wed, 9 Aug 2023 14:41:51 GMT, Jim Laskey wrote: > 8313809: String template fails with java.lang.StringIndexOutOfBoundsException > if last fragment is UTF16 This pull request has now been integrated. Changeset: c746fc01 Author:Jim Laskey URL:

Re: [jdk21] RFR: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16

2023-08-09 Thread Claes Redestad
On Wed, 9 Aug 2023 14:41:51 GMT, Jim Laskey wrote: > 8313809: String template fails with java.lang.StringIndexOutOfBoundsException > if last fragment is UTF16 Marked as reviewed by redestad (Reviewer). - PR Review:

[jdk21] RFR: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16

2023-08-09 Thread Jim Laskey
8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16 - Commit messages: - Backport 6864441163f946d0bec7380a2a120e31b812a6dc Changes: https://git.openjdk.org/jdk21/pull/170/files Webrev:

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v4]

2023-08-09 Thread Weibing Xiao
On Wed, 9 Aug 2023 00:21:55 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug

Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v5]

2023-08-09 Thread Weibing Xiao
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v2]

2023-08-09 Thread Matthias Baesken
On Wed, 9 Aug 2023 08:42:35 GMT, Matthias Baesken wrote: >> There is coding e.g. in >> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 >> that deals with shared lib naming on different OS. >> This code should be simplified. > > Matthias

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v3]

2023-08-09 Thread Matthias Baesken
> There is coding e.g. in > https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 > that deals with shared lib naming on different OS. > This code should be simplified. Matthias Baesken has updated the pull request incrementally with one

RFR: 8313899: JVMCI exception Translation can fail in TranslatedException.

2023-08-09 Thread Doug Simon
In a test that stresses metaspace (such as `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in `TranslatedException.` due to exhausted metaspace: java.lang.OutOfMemoryError: Metaspace at

Re: RFR: 8313899: JVMCI exception Translation can fail in TranslatedException.

2023-08-09 Thread Tom Rodriguez
On Tue, 8 Aug 2023 20:52:29 GMT, Doug Simon wrote: > In a test that stresses metaspace (such as > `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also > uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in > `TranslatedException.` due to exhausted metaspace: >

Re: [jdk21] RFR: 8313312: Add missing classpath exception copyright header

2023-08-09 Thread Adam Sotona
On Tue, 8 Aug 2023 15:55:10 GMT, Roger Riggs wrote: > The same copyright updates are needed in JDK21. Marked as reviewed by asotona (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/166#pullrequestreview-1569051344

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v2]

2023-08-09 Thread Matthias Baesken
> There is coding e.g. in > https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 > that deals with shared lib naming on different OS. > This code should be simplified. Matthias Baesken has updated the pull request incrementally with one

Re: RFR: 8313768: Reduce interaction with volatile field in j.u.l.StreamHandler

2023-08-09 Thread Jaikiran Pai
On Fri, 4 Aug 2023 14:51:35 GMT, Sergey Tsypanov wrote: > In `publish0()`, `flush0()` and `flushAndClose()`methods of `StreamHandler` > we read multiple times from volatile writer. The access number can be reduced > by reading the field into local variable once. The change looks fine to me.