Use of javadoc search index feature; I'll re-flow paragraphs before pushing
once the wording is agreed to.
-
Commit messages:
- JDK-8314489: Add javadoc index entries for java.lang.Math terms
Changes: https://git.openjdk.org/jdk/pull/15322/files
Webrev:
On Fri, 4 Nov 2022 15:21:27 GMT, Adam Sotona wrote:
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
This pull request has been closed without being integrated.
On Wed, 16 Aug 2023 23:11:11 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs
On Wed, 16 Aug 2023 23:11:11 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs
On Wed, 16 Aug 2023 23:11:11 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs
On Wed, 16 Aug 2023 23:10:02 GMT, Weibing Xiao wrote:
>> test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeFailureTest.java line 173:
>>
>>> 171: public void run() {
>>> 172: try (Socket socket = serverSocket.accept()) {
>>> 173: Thread.sleep(1);
>>
>> What's
On Wed, 16 Aug 2023 22:49:24 GMT, Mark Sheppard wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the test code
>
> test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeFailureTest.java line 173:
>
>> 171:
On Wed, 16 Aug 2023 23:11:11 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs
On Wed, 16 Aug 2023 17:24:57 GMT, Aleksei Efimov wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated the code according to the review
>
> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line
> Please refer to JDK-8314063.
>
> The failure scenario is due to the setting of connection timeout. It is
> either too small or not an optimal value for the system. When the client
> tries to connect to the server with LDAPs protocol. It requires the handshake
> after the socket is created
On Wed, 16 Aug 2023 18:10:04 GMT, Aleksei Efimov wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the test code
>
> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 369:
>
>> 367:
On Wed, 16 Aug 2023 19:12:54 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs
On Tue, 15 Aug 2023 09:51:40 GMT, Aleksey Shipilev wrote:
>> Nikita Sakharin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8314236: change bug number and summary
>
> test/jdk/java/util/Collections/RotateHuge.java line 27:
>
>> 25: *
On Wed, 16 Aug 2023 09:11:34 GMT, Cristian Vat wrote:
>> Reduces excessive allocation of Matcher.groups array when the original
>> Pattern has no groups or less than 9 groups.
>>
>> Original clamping to 10 possibly due to documented behavior from javadoc:
>> "In this class, \1 through \9 are
On Wed, 19 Jul 2023 12:03:40 GMT, Matthew Donovan wrote:
> This PR refactors the SSLSocketParametersTest by removing
> redundant/unnecessary classes and cleans up the logic around expected
> exceptions.
I'm still looking for a reviewer for this PR. Thanks!
-
PR Comment:
> Please refer to JDK-8314063.
>
> The failure scenario is due to the setting of connection timeout. It is
> either too small or not an optimal value for the system. When the client
> tries to connect to the server with LDAPs protocol. It requires the handshake
> after the socket is created
On Wed, 16 Aug 2023 13:36:38 GMT, Matthias Baesken wrote:
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
>
Clarify the spec of `ModuleDescriptor::mainClass`, `ModuleDescriptor::uses`,
`ModuleDescriptor.Provides::service` and `ModuleDescriptor.Provides::providers`
to return a binary name.
This PR also fixes JDK-8314449 to update the spec of
`StackTraceElement::getClassName` and the `declaringClass`
On Wed, 16 Aug 2023 09:11:34 GMT, Cristian Vat wrote:
>> Reduces excessive allocation of Matcher.groups array when the original
>> Pattern has no groups or less than 9 groups.
>>
>> Original clamping to 10 possibly due to documented behavior from javadoc:
>> "In this class, \1 through \9 are
On Thu, 10 Aug 2023 09:54:43 GMT, Christoph Langer wrote:
> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
> as user that is member of the Administrators group. In that case new files
> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
On Tue, 15 Aug 2023 20:56:43 GMT, Christoph wrote:
>> Add new test case with sample modules that contains some
>> requires/exports/uses/provides.
>>
>> We are just unsure if and how we should add some last step of verificaiton
>> with the extracted and decompiled class.
>>
>> Follow up task
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Tue, 15 Aug 2023 17:30:54 GMT, Weibing Xiao wrote:
> Please refer to JDK-8314063.
>
> The failure scenario is due to the setting of connection timeout. It is
> either too small or not an optimal value for the system. When the client
> tries to connect to the server with LDAPs protocol. It
On Wed, 16 Aug 2023 00:14:47 GMT, Leonid Mesnik wrote:
> The test helper which spawn new jvms is updated to start them using VM flags
> for testing.
This pull request has now been integrated.
Changeset: 7b28d360
Author:Leonid Mesnik
URL:
> The test helper which spawn new jvms is updated to start them using VM flags
> for testing.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
fixed imports.
-
Changes:
- all:
On Mon, 3 Jul 2023 20:53:34 GMT, Glavo wrote:
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
This pull request has now been integrated.
Changeset: b32d6411
Author:Glavo
Committer: Naoto Sato
URL:
On Tue, 15 Aug 2023 10:48:29 GMT, Glavo wrote:
>> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
>
> Glavo has updated the pull request with a new target base due to a merge or a
> rebase. The pull request now contains four commits:
>
> - Merge remote-tracking branch
On Wed, 16 Aug 2023 15:36:53 GMT, Alan Bateman wrote:
>As I think has already been said, we can't engage with you in this PR on the
>reasons why additional checking was added in a security update.
I think you have an assumption that this check for exact size(8/16/24) bytes
are related to the
On Tue, 15 Aug 2023 20:41:13 GMT, Mandy Chung wrote:
>> Christoph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove obsolete jimage and decompile methods
>
> Marked as reviewed by mchung (Reviewer).
@mlchung Thanks again for your
On Tue, 15 Aug 2023 10:48:29 GMT, Glavo wrote:
>> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
>
> Glavo has updated the pull request with a new target base due to a merge or a
> rebase. The pull request now contains four commits:
>
> - Merge remote-tracking branch
On Fri, 28 Jul 2023 20:33:01 GMT, Alan Bateman wrote:
> This is a small issue with StructuredTaskScope. If the owner attempts to fork
> a subtask and the task scope is shutdown then the implementation doesn't
> currently force the owner to join when it's the first fork in a new round of
>
On Tue, 15 Aug 2023 16:21:55 GMT, Alan Bateman wrote:
> This is a docs only change. The specification for
> StructuredTaskScope.shutdown should make it clear that the state of subtasks
> that are completing (with a result or exception) at around the time of
> shutdown is not defined. The
On Tue, 15 Aug 2023 20:13:18 GMT, Andrey Turbanov wrote:
> A field `char mAttrIdx` in the `jdk.internal.util.xml.impl.Attrs` class is
> unused and can be removed.
Marked as reviewed by bpb (Reviewer).
-
PR Review:
On Tue, 15 Aug 2023 15:39:37 GMT, Lance Andersen wrote:
>> I think I agree with Volker that it would be better if
>> isZip64ExtBlockSizeValid continued to return false for block size 0.
>
> OK, I have made the suggest change that you both prefer.
>
> Thank you for your input
I'm also happy to
On Mon, 14 Aug 2023 14:52:00 GMT, Lance Andersen wrote:
> This PR updates the extra field validation added as part of
> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
> issues seen with 3rd party tools/libraries where a ZipException may be
> encountered when opening
On Wed, 16 Aug 2023 14:45:25 GMT, Sergey Bylokhov wrote:
> I disagree for a few reasons, using that property will completely disable the
> appropriate patch for a fix in the CPU, and it will be possible to
> have/accept some malicious zip files which may trigger some unfortunate
> behavior.
On Wed, 16 Aug 2023 14:44:23 GMT, Matthias Baesken wrote:
> Hi Alan, I am not sure what 'interesting file path' you are referring to. I
> only added an integer (errno/errcode) and at one place fix strings
> shared/nonshared to the exception message.
Oh I see, I thought you wanted to include
On Wed, 16 Aug 2023 04:16:52 GMT, Sergey Bylokhov wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Cleaned up spacing and added missing comma
>
> My overall point is that it will be unfortunate if users will be
On Wed, 16 Aug 2023 13:36:38 GMT, Matthias Baesken wrote:
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
>
On Wed, 16 Aug 2023 13:36:38 GMT, Matthias Baesken wrote:
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
>
I guess that the cost for an array element access is more expensive than
accessing a field, regardless of volatile. The offset is computed at
runtime for an array element and might need to be checked to be in the
range of valid indices, while the offset of a field is known and can be
a
+ core-libs-dev@ I meant relation between in-loop and hoisted access. In Java 19 when we take count = 100 for volatile array and hoist it from the loop then the average time decreases from 146 to 33 ns. And if we take the same count for "plain" field and hoist it from the loop then the average
I meant relation between in-loop and hoisted access.
In Java 19 when we take count = 100 for volatile array and hoist it from the
loop then the average time decreases from 146 to 33 ns.
And if we take the same count for "plain" field and hoist it from the loop then
the average time decreases
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejovic
wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
We run into some BackingStoreException: Couldn't get file lock. e.g. here :
[JShell] Exception in thread "main" java.lang.IllegalStateException:
java.util.prefs.BackingStoreException: Couldn't get file lock.
[JShell] at
If I read the data correctly, for the count=100 case in jdk 20 it takes
109 ns/op for the array and 74 ns/op for the field.
To me this looks like a field access is _less_ expensive.
Am I missing something?
On 2023-08-16 13:37, Сергей Цыпанов wrote:
Hello,
I was measuring costs of hoisting
On Wed, 16 Aug 2023 00:14:47 GMT, Leonid Mesnik wrote:
> The test helper which spawn new jvms is updated to start them using VM flags
> for testing.
Marked as reviewed by jvernee (Reviewer).
test/jdk/java/foreign/UpcallTestHelper.java line 25:
> 23:
> 24: import
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejovic
wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
On Tue, 15 Aug 2023 18:43:36 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when
Hello,
I was measuring costs of hoisting volatile access out of the loop and found
out, that there's a difference in numbers for arrays and "plain" references.
Here's the benchmark for array:
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@Warmup(time = 2, iterations =
On Thu, 1 Jun 2023 10:25:49 GMT, Severin Gehwolf wrote:
> I'm concerned about the hard-coding of delimiter values and the added
> accidential complexity in order to avoid the Regex engine. Note that this
> test fails due to the delimiter hard-coding:
>
> ```
>
On Thu, 15 Jun 2023 09:21:13 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
On Wed, 16 Aug 2023 10:09:26 GMT, Andrew Haley wrote:
> These benchmarks are all small arrays. We need to check for possible
> regressions here.
The JMH ArraysSort tests arrays of length 800 to 2 million elements.
Is it not enough for smaller or larger arrays ?
> Also, I'm rather concerned
On Tue, 15 Aug 2023 14:19:29 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 45 additional commits
>>
On Thu, 15 Jun 2023 09:21:13 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
On Thu, 13 Jul 2023 08:57:05 GMT, Andrey Turbanov wrote:
> Made a few fields `final` in java.util.Scanner.
> Also made `digits`, `non0Digit`, `SIMPLE_GROUP_INDEX` as `static.`
Marked as reviewed by alanb (Reviewer).
-
PR Review:
> Reduces excessive allocation of Matcher.groups array when the original
> Pattern has no groups or less than 9 groups.
>
> Original clamping to 10 possibly due to documented behavior from javadoc:
> "In this class, \1 through \9 are always interpreted as back references, "
>
> Only with
On Wed, 16 Aug 2023 08:07:05 GMT, Raffaello Giulietti
wrote:
> Please review this trivial typo.
> TIA
This pull request has now been integrated.
Changeset: b80001de
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/b80001de0c0aeedeb412430660a4727fc26be98b
Stats:
On Wed, 16 Aug 2023 08:07:05 GMT, Raffaello Giulietti
wrote:
> Please review this trivial typo.
> TIA
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15303#pullrequestreview-1580051924
Please review this trivial typo.
TIA
-
Commit messages:
- 8314209: Wrong @since tag for RandomGenerator::equiDoubles
Changes: https://git.openjdk.org/jdk/pull/15303/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15303=00
Issue: https://bugs.openjdk.org/browse/JDK-8314209
On Tue, 15 Aug 2023 23:13:00 GMT, Volker Simonis wrote:
> That file is accepted by zip, by the latest JDK8u382, by the JDK20 GA, and
> rejected by the 20.0.2. That is a regression in the latest update of JDK11+
> which we trying to solve here.
Have you tested your ZIP file with
On Tue, 15 Aug 2023 20:13:18 GMT, Andrey Turbanov wrote:
> A field `char mAttrIdx` in the `jdk.internal.util.xml.impl.Attrs` class is
> unused and can be removed.
Looks OK to me.
-
Marked as reviewed by vtewari (Committer).
PR Review:
On Tue, 15 Aug 2023 20:13:18 GMT, Andrey Turbanov wrote:
> A field `char mAttrIdx` in the `jdk.internal.util.xml.impl.Attrs` class is
> unused and can be removed.
Marked as reviewed by alanb (Reviewer).
-
PR Review:
On Tue, 15 Aug 2023 18:43:36 GMT, Lance Andersen wrote:
>> This PR updates the extra field validation added as part of
>> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with
>> issues seen with 3rd party tools/libraries where a ZipException may be
>> encountered when
This is a small issue with StructuredTaskScope. If the owner attempts to fork a
subtask and the task scope is shutdown then the implementation doesn't
currently force the owner to join when it's the first fork in a new round of
forking. The result is that broken code calling Subtask::get throws
This is a docs only change. The specification for StructuredTaskScope.shutdown
should make it clear that the state of subtasks that are completing (with a
result or exception) at around the time of shutdown is not defined. The state
of a completing subtask may transition to a terminal state, it
66 matches
Mail list logo
