Can I please get a review of this change which removes unused (internal) method
from the `private` `URLClassPath$JarLoader`?
The `validIndex` method which is being removed here was being used when JAR
index was supported. We removed support for JAR index in
Unexpected behaviour is too common phrase - got it
As i sad i’ve experienced it in
https://github.com/spring-projects/spring-framework/blob/main/spring-aop/src/main/java/org/springframework/aop/interceptor/ExposeInvocationInterceptor.java
Error on ThreadLocal#set in finally section there lead
On 29/09/2023 6:33 am, Егор Зиборов wrote:
Hello, Alan
I’ve experienced SO in ThreadLocal#set on my production instance
(more than that it‘s happened in Spring’s ExposeInvocationInterceptor
that uses TL as context storage)As a result of SO in ThreadLocal
we’ve experienced unexpected errors with
On Fri, 29 Sep 2023 00:21:52 GMT, Mourad Abbay wrote:
> Are you referring to the expand of lambdas and the extra whitespaces ?
Yes, sometimes the IDE just does it automatically!
-
PR Comment: https://git.openjdk.org/jdk/pull/15936#issuecomment-1740160022
On Fri, 29 Sep 2023 00:35:08 GMT, Paul Sandoz wrote:
> > Are you referring to the expand of lambdas and the extra whitespaces ?
>
> Yes, sometimes the IDE just does it automatically!
Is there a way I can make the IDE respect the code style?
-
PR Comment:
On Fri, 29 Sep 2023 00:37:16 GMT, Mourad Abbay wrote:
> > > Are you referring to the expand of lambdas and the extra whitespaces ?
> >
> >
> > Yes, sometimes the IDE just does it automatically!
>
> Is there a way I can make the IDE respect the code style?
I doubt it, since 1) there is no
On Thu, 28 Sep 2023 23:38:51 GMT, Alexey Semenyuk wrote:
> - Don't run osx specific checks on Linux and Windows
> - Rework checks output from
>
> [17:31:52.845] TRACE: assertTrue(): Unexptected value in app image file for
>
> [17:31:52.860] TRACE: assertTrue(): Unexptected value in app
On Thu, 28 Sep 2023 22:05:15 GMT, Paul Sandoz wrote:
> Looks good. Note a general rule to mostly follow is to try and stick to the
> prevailing style in source being modified and not make additional and
> unrelated changes (no matter how tempting it might be). In this case i don't
> have
On Wed, 20 Sep 2023 23:20:43 GMT, Justin Lu wrote:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
- Don't run osx specific checks on Linux and Windows
- Rework checks output from
[17:31:52.845] TRACE: assertTrue(): Unexptected value in app image file for
[17:31:52.860] TRACE: assertTrue(): Unexptected value in app image file for
to
[22:07:46.519] TRACE: assertEquals(false): Check for
On Thu, 28 Sep 2023 17:20:47 GMT, Eamonn McManus wrote:
> It looks to have been an oversight that `final` was omitted. The fields are
> never assigned after initialization. `final` leads to shorter bytecode.
This pull request has now been integrated.
Changeset: ecb5e8a0
Author:Eamonn
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
On Wed, 27 Sep 2023 17:45:58 GMT, Mourad Abbay wrote:
> Remove unused imports in the java.util.stream package.
This pull request has now been integrated.
Changeset: f2c221de
Author:Mourad Abbay
Committer: Paul Sandoz
URL:
On Wed, 27 Sep 2023 22:44:52 GMT, Mourad Abbay wrote:
>> Remove unused imports in the java.util.stream package.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by psandoz
On Wed, 27 Sep 2023 22:47:43 GMT, Mourad Abbay wrote:
>> Remove redundant type cast in the java.util.stream package.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by psandoz
On Wed, 27 Sep 2023 22:44:07 GMT, Mourad Abbay wrote:
>> Remove cases of redundant type arguments in the java.util.stream package.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Looks good. Note a
On Sun, 24 Sep 2023 02:46:38 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request
On Thu, 28 Sep 2023 20:39:13 GMT, Eamonn McManus wrote:
>> It looks to have been an oversight that `final` was omitted. The fields are
>> never assigned after initialization. `final` leads to shorter bytecode.
>
> Eamonn McManus has updated the pull request with a new target base due to a
>
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Thu, 28 Sep 2023 21:12:37 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Thu, 28 Sep 2023 20:58:30 GMT, Alexey Semenyuk wrote:
> Don't use JDK image from `$JAVA_HOME` as a value of `--runtime-image`
> jpackage cli option. Use jlink to create a runtime in test work dir if the
> default runtime is not specified and pass the location of jlink output.
Looks good.
Don't use JDK image from `$JAVA_HOME` as a value of `--runtime-image` jpackage
cli option. Use jlink to create a runtime in test work dir if the default
runtime is not specified and pass the location of jlink output.
-
Commit messages:
- 8303959:
On Tue, 17 May 2022 15:53:05 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720)
> which refines the spec of `equals()` and `hashCode()` in `java.text.Format`
> related classes.
>
> The current spec for most of these methods is either "_Overrides
> _" or are incomplete/wrong (i.e. see
> It looks to have been an oversight that `final` was omitted. The fields are
> never assigned after initialization. `final` leads to shorter bytecode.
Eamonn McManus has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated
Hello, Alan
I’ve experienced SO in ThreadLocal#set on my production instance (more than
that it‘s happened in Spring’s ExposeInvocationInterceptor that uses TL as
context storage)As a result of SO in ThreadLocal we’ve experienced unexpected
errors with Spring AOP, but I’m sure that it could
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote:
> Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
> Windows time zones to Java time zones according to the region. Since `001`
> means world, no region-specific entries are needed if those time zones are
> the
On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote:
> Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
> Windows time zones to Java time zones according to the region. Since `001`
> means world, no region-specific entries are needed if those time zones are
> the
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally
On Mon, 25 Sep 2023 15:52:12 GMT, Aleksei Voitylov
wrote:
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
>
> Please review this PR which removes the i18n related testing base classes
> `IntlTest` and `CollatorTest` and converts all the tests that use them,
>
> IntlTest and CollatorTest are testing classes which are extended by tests in
> `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`.
On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote:
> Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
> Windows time zones to Java time zones according to the region. Since `001`
> means world, no region-specific entries are needed if those time zones are
> the
Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
Windows time zones to Java time zones according to the region. Since `001`
means world, no region-specific entries are needed if those time zones are the
same. The diff of the generated tzmappings files, before and
It looks to have been an oversight that `final` was omitted. The fields are
never assigned after initialization. `final` leads to shorter bytecode.
-
Commit messages:
- In `Pattern.Bound`, make some constants `static final`.
Changes: https://git.openjdk.org/jdk/pull/15967/files
On Thu, 28 Sep 2023 16:46:11 GMT, Aggelos Biboudis
wrote:
>> This is the first draft of a patch for Primitive types in patterns,
>> instanceof, and switch (Preview).
>>
>> Draft spec here:
>> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
>
>
On Wed, 27 Sep 2023 14:13:05 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
On Thu, 28 Sep 2023 15:36:30 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the
> Please review this PR which removes the i18n related testing base classes
> `IntlTest` and `CollatorTest` and converts all the tests that use them,
>
> IntlTest and CollatorTest are testing classes which are extended by tests in
> `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`.
On Thu, 28 Sep 2023 16:46:11 GMT, Aggelos Biboudis
wrote:
>> This is the first draft of a patch for Primitive types in patterns,
>> instanceof, and switch (Preview).
>>
>> Draft spec here:
>> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
>
>
On 28/09/2023 17:21, Егор Зиборов wrote:
Hello, everyone
I'm new there and writing this letter during advice of Dalibor Topic
I faced an issue with SOE in ThreadLocal and want to add this java9 annotation
on ThreadLocal#set. Does anyone have any concerns about it?
This annotation is for very
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one
Hello, everyone
I'm new there and writing this letter during advice of Dalibor Topic
I faced an issue with SOE in ThreadLocal and want to add this java9 annotation
on ThreadLocal#set. Does anyone have any concerns about it?
Thank you in advance
On Tue, 26 Sep 2023 21:49:11 GMT, Naoto Sato wrote:
> Some CLDR locales have partial list patterns, such as only the "end" pattern,
> and expect "start" and "middle" patterns to be inherited from parent locales.
> Made the code capable of the inheritance.
This pull request has now been
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Thu, 28 Sep 2023 15:36:30 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the
> This patch adds a new lint warning category, namely `-Xlint:restricted` to
> enable warnings on restricted method calls.
>
> The patch is relatively straightforward: javac marks methods that are marked
> with the `@Restricted` annotation with a corresponding internal flag. This is
> done
On Thu, 28 Sep 2023 13:13:31 GMT, Maurizio Cimadamore
wrote:
> This patch adds a new lint warning category, namely `-Xlint:restricted` to
> enable warnings on restricted method calls.
>
> The patch is relatively straightforward: javac marks methods that are marked
> with the `@Restricted`
On Wed, 27 Sep 2023 21:26:46 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Wed, 27 Sep 2023 19:51:25 GMT, Raffaello Giulietti
wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> fix : the exception thrown when the input does not include conversion is
>> different from baselne.
>
> You might
On Thu, 28 Sep 2023 13:13:31 GMT, Maurizio Cimadamore
wrote:
> This patch adds a new lint warning category, namely `-Xlint:restricted` to
> enable warnings on restricted method calls.
>
> The patch is relatively straightforward: javac marks methods that are marked
> with the `@Restricted`
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Thu, 28 Sep 2023 13:13:31 GMT, Maurizio Cimadamore
wrote:
> This patch adds a new lint warning category, namely `-Xlint:restricted` to
> enable warnings on restricted method calls.
>
> The patch is relatively straightforward: javac marks methods that are marked
> with the `@Restricted`
This patch adds a new lint warning category, namely `-Xlint:restricted` to
enable warnings on restricted method calls.
The patch is relatively straightforward: javac marks methods that are marked
with the `@Restricted` annotation with a corresponding internal flag. This is
done both in
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Wed, 27 Sep 2023 19:13:02 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Wed, 27 Sep 2023 21:26:46 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Wed, 27 Sep 2023 16:09:01 GMT, Maurizio Cimadamore
wrote:
> This patch adds a new internal annotation that is used to mark all restricted
> me
> thods in the FFM API. The new annotation is similar to the one we used for
> preview API methods.
>
> We plan to use the new annotation for
On Thu, 28 Sep 2023 08:38:27 GMT, Aggelos Biboudis
wrote:
>> I agree. Also, this is not helped by the fact that in this particular
>> message, the `_` does not appear in a variable declaration. Maybe we should
>> use two distinct messages for when `_` is found as an "expression" (e.g. an
>>
On Thu, 28 Sep 2023 08:40:20 GMT, Aggelos Biboudis
wrote:
>> This PR finalizes the feature of unnamed variables and patterns.
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> -
On Tue, 26 Sep 2023 10:21:06 GMT, Maurizio Cimadamore
wrote:
>> test/langtools/tools/javac/lambda/IdentifierTest9.out line 33:
>>
>>> 31: IdentifierTest.java:152:17: compiler.err.use.of.underscore.not.allowed
>>> 32: IdentifierTest.java:158:16:
>>>
> This PR finalizes the feature of unnamed variables and patterns.
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit
On Wed, 27 Sep 2023 16:50:33 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
65 matches
Mail list logo
