Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v5]

> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on

RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal

Add informative notes to BigInteger and BigDecimal about possible running times, etc. - Commit messages: - Appease jcheck. - JDK-8318476: Add resource consumption note to BigInteger and BigDecimal Changes: https://git.openjdk.org/jdk/pull/16298/files Webrev:

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases

On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote: > A new paper > > "Accuracy of Mathematical Functions in Single, Double, Double Extended, and > Quadruple Precision" > by Brian Gladman, Vincenzo Innocente and Paul Zimmermann > https://members.loria.fr/PZimmermann/papers/accuracy.pdf > >

Re: RFR: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout [v3]

> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout Phil Race has updated the pull request incrementally with one additional commit since the last revision: Use new arrayElementVarHandle method - Changes: - all: https://git.openjdk.org/jdk/pull/15476/files

Re: RFR: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout [v2]

> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout Phil Race has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge remote-tracking branch 'upstream/master' into harfbuzz_panama Merge - remove

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v53]

> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and

Re: RFR: 8318569: Add getter methods for Locale and Patterns in ListFormat

On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote: > Proposing adding getter methods for `locale` and `patterns` fields in the > `ListFormat` instances. Those fields are used for `equals()`, but without the > public getter methods, users cannot tell the reasoning of the equality of two >

Re: RFR: 8318569: Add getter methods for Locale and Patterns in ListFormat

On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote: > Proposing adding getter methods for `locale` and `patterns` fields in the > `ListFormat` instances. Those fields are used for `equals()`, but without the > public getter methods, users cannot tell the reasoning of the equality of two >

Re: RFR: 8318569: Add getter methods for Locale and Patterns in ListFormat

On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote: > Proposing adding getter methods for `locale` and `patterns` fields in the > `ListFormat` instances. Those fields are used for `equals()`, but without the > public getter methods, users cannot tell the reasoning of the equality of two >

Re: RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild [v3]

> On Oct 20, 2023, at 3:42 PM, Alexander Matveev wrote: > > On Fri, 20 Oct 2023 04:23:22 GMT, Alexander Matveev > wrote: > >>> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` >>> CLI options to jpackage to provide signing identity

Re: RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild [v3]

On Fri, 20 Oct 2023 04:23:22 GMT, Alexander Matveev wrote: >> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` >> CLI options to jpackage to provide signing identity directly to `codesign` >> and `productbuild` tools as per CSR >>

Re: RFR: 8316969: Improve CDS module graph support for --module option [v4]

> Please review this changeset for adding support for `--module` (-m) option > for CDS. > Changes in the `ModuleBootstrap.java` are needed so that the > `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if > the main module is specified. The module name will be stored in

Re: RFR: 8316969: Improve CDS module graph support for --module option [v3]

On Fri, 20 Oct 2023 14:34:52 GMT, Alan Bateman wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> simplify some code in modules.cpp > > src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line 472:

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v52]

> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v51]

> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

RFR: 8318569: Add getter methods for Locale and Patterns in ListFormat

Proposing adding getter methods for `locale` and `patterns` fields in the `ListFormat` instances. Those fields are used for `equals()`, but without the public getter methods, users cannot tell the reasoning of the equality of two instances. A corresponding CSR has also been drafted.

Integrated: JDK-7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field

On Thu, 19 Oct 2023 21:31:13 GMT, Justin Lu wrote: > Please review this PR which adjusts the specification of > `DateFormat.Field::getCalendarField` to conform to the implementation. > > `getCalendarField()` claims that it will return -1 if there is no > corresponding `Calendar` constant. >

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v12]

On Thu, 19 Oct 2023 11:43:57 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Added indentation to generate the properly

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v8]

On Wed, 18 Oct 2023 15:59:13 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Integrated: 8318421 : AbstractPipeline.sourceStageSpliterator() chases pointers needlessly

On Wed, 18 Oct 2023 10:14:08 GMT, Viktor Klang wrote: > Removes a few unnecessary dereferences of `sourceStage`. This pull request has now been integrated. Changeset: 21215753 Author:Viktor Klang Committer: Paul Sandoz URL:

Integrated: 8318420 : AbstractPipeline invokes overridden method in constructor

On Wed, 18 Oct 2023 09:45:53 GMT, Viktor Klang wrote: > This PR corrects so that `opIsStateful()` is not invoked as a part of the > java.util.stream.AbstractPipeline constructor—as `opIsStateful()` is intended > to be overridden by subclasses, and as their own constructors have not run > when

Re: RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild [v3]

On Fri, 20 Oct 2023 04:23:56 GMT, Alexander Matveev wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8311877: [macos] Add CLI options to provide signing identity directly to >> codesign and productbuild [v2]

Integrated: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

On Wed, 20 Sep 2023 03:32:55 GMT, yaqsun wrote: > on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test > tools/jpackage/linux/LinuxResourceTest.java. > It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121. > But after 8314121,

Re: RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild [v3]

On Fri, 20 Oct 2023 04:23:22 GMT, Alexander Matveev wrote: >> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` >> CLI options to jpackage to provide signing identity directly to `codesign` >> and `productbuild` tools as per CSR >>

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318598: FFM stylistic cleanups

On Fri, 20 Oct 2023 13:35:59 GMT, Jorn Vernee wrote: > Port over stylistic changes from the panama-foreign repo. The following PRs > are included: > > - https://github.com/openjdk/panama-foreign/pull/863 > - https://github.com/openjdk/panama-foreign/pull/888 > -

Integrated: 8318598: FFM stylistic cleanups

On Fri, 20 Oct 2023 13:35:59 GMT, Jorn Vernee wrote: > Port over stylistic changes from the panama-foreign repo. The following PRs > are included: > > - https://github.com/openjdk/panama-foreign/pull/863 > - https://github.com/openjdk/panama-foreign/pull/888 > -

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v2]

On Fri, 20 Oct 2023 15:32:55 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v2]

On Fri, 20 Oct 2023 15:32:55 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

> The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this requires a JDK change. The > core of the issue is

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v2]

> The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this requires a JDK change. The > core of the issue is

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comment. > > Thanks for your review comments. I will implement them and push again. >

Re: RFR: 8316969: Improve CDS module graph support for --module option [v3]

On Thu, 19 Oct 2023 15:21:55 GMT, Calvin Cheung wrote: >> Please review this changeset for adding support for `--module` (-m) option >> for CDS. >> Changes in the `ModuleBootstrap.java` are needed so that the >> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if >>

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

Re: RFR: 8316969: Improve CDS module graph support for --module option [v3]

On Thu, 19 Oct 2023 15:21:55 GMT, Calvin Cheung wrote: >> Please review this changeset for adding support for `--module` (-m) option >> for CDS. >> Changes in the `ModuleBootstrap.java` are needed so that the >> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if >>

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

On Fri, 20 Oct 2023 14:27:43 GMT, Vladimir Kozlov wrote: > Why you replaced pair of copyright years with one year in module-info.Java > files? Instead of updating last year only. Why also update 'since' there? > Even if you changed location these files existed already. The files may be

Re: RFR: 8316969: Improve CDS module graph support for --module option [v3]

On Thu, 19 Oct 2023 15:21:55 GMT, Calvin Cheung wrote: >> Please review this changeset for adding support for `--module` (-m) option >> for CDS. >> Changes in the `ModuleBootstrap.java` are needed so that the >> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if >>

Integrated: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics

On Fri, 13 Oct 2023 15:36:56 GMT, Ilya Gavrilin wrote: > Hi all, please review this changes into risc-v floating point copysign and > signum intrinsics. > CopySign - returns first argument with the sign of second. On risc-v we have > `fsgnj.x` instruction, which can implement this intrinsic. >

Integrated: 8318601: Remove javadoc text about restricted methods

On Fri, 20 Oct 2023 13:59:16 GMT, Maurizio Cimadamore wrote: > This simple PR removes the extra verbiage from the javadoc of all the > restricted methods. > Since now javadoc will automatically generate better "bubbles" for restricted > methods, this wording is no longer necessary. This pull

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

Re: RFR: 8318601: Remove javadoc text about restricted methods

On Fri, 20 Oct 2023 13:59:16 GMT, Maurizio Cimadamore wrote: > This simple PR removes the extra verbiage from the javadoc of all the > restricted methods. > Since now javadoc will automatically generate better "bubbles" for restricted > methods, this wording is no longer necessary. Marked as

RFR: 8318601: Remove javadoc text about restricted methods

This simple PR removes the extra verbiage from the javadoc of all the restricted methods. Since now javadoc will automatically generate better "bubbles" for restricted methods, this wording is no longer necessary. - Commit messages: - Initial push Changes:

Re: RFR: 8318598: FFM stylistic cleanups

On Fri, 20 Oct 2023 13:35:59 GMT, Jorn Vernee wrote: > Port over stylistic changes from the panama-foreign repo. The following PRs > are included: > > - https://github.com/openjdk/panama-foreign/pull/863 > - https://github.com/openjdk/panama-foreign/pull/888 > -

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v3]

On Fri, 20 Oct 2023 11:04:28 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/util/FormatProcessor.java line 247: >> >>> 245: throw new MissingFormatArgumentException(group + " is >>> not immediately followed by an embedded expression"); >>> 246: } else {

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v10]

On Fri, 20 Oct 2023 08:38:22 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and

RFR: 8318598: FFM stylistic cleanups

Port over stylistic changes from the panama-foreign repo. The following PRs are included: - https://github.com/openjdk/panama-foreign/pull/863 - https://github.com/openjdk/panama-foreign/pull/888 - https://github.com/openjdk/panama-foreign/pull/889 -

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

Re: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809

Hi Nico, I've filed a bug at https://bugs.openjdk.org/browse/JDK-8318599. Will look into it. Thanks, Max > On Oct 19, 2023, at 10:39 PM, Nico Williams > wrote: > > Also, a colleague informs me that 17.0.5 (as packaged by Debian) w/o > `-Djdk.spnego.cache=false` doesn't exhibit the

RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

The Graal code base has [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) its module to `jdk.compiler.graal` as part of preparations for Project Galahad. Due to the way Java modules work, this requires a JDK change. The core of the issue is that the

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comment. > > Thanks for your review comments. I will implement them and push again.

Re: RFR: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics [v6]

> Hi all, please review this changes into risc-v floating point copysign and > signum intrinsics. > CopySign - returns first argument with the sign of second. On risc-v we have > `fsgnj.x` instruction, which can implement this intrinsic. > Signum - returns input value if it is +/- 0.0 or NaN,

Integrated: JDK-8077371: Binary files in JAXP test should be removed

On Wed, 19 Apr 2023 15:51:01 GMT, Mahendra Chhipa wrote: > Test is updated to create the binary files during test execution. This pull request has now been integrated. Changeset: 40106422 Author:Mahendra Chhipa URL:

Re: RFR: 8315585: Optimization for decimal to string [v10]

> I submitted PR #1 before, and there were too many changes. I split it > into multiple PRs with small changes. This one is one of them. > > this PR removed the duplicate code for getChars in > BigDecimal#StringBuilderHelper, i also make performance faster. > Please review and don't

Withdrawn: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException

On Mon, 16 Oct 2023 22:27:34 GMT, Shaojin Wen wrote: > When calling String::newStringNoRepl and String::getBytesNoRepl, we need to > use try...catch to handle CharacterCodingException and throw > IllegalArgumentException instead of CharacterCodingException to make the > calling code cleaner.

Integrated: 8318457: Use prefix-less prepend methods directly to reduce branches in String concat expressions

On Wed, 18 Oct 2023 11:56:14 GMT, Claes Redestad wrote: > In #16006 using `StringConcatFactory` seem to induce a run-to-run variance. > One idea to reduce this is to generate expression trees with fewer branches > by looking up and using the prefix-less `prepend` methods directly for cases >

Re: RFR: 8318457: Use prefix-less prepend methods directly to reduce branches in String concat expressions [v3]

On Thu, 19 Oct 2023 15:59:54 GMT, Claes Redestad wrote: >> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance. >> One idea to reduce this is to generate expression trees with fewer branches >> by looking up and using the prefix-less `prepend` methods directly for cases

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v4]

> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on

Re: RFR: 8318457: Use prefix-less prepend methods directly to reduce branches in String concat expressions [v3]

On Thu, 19 Oct 2023 15:59:54 GMT, Claes Redestad wrote: >> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance. >> One idea to reduce this is to generate expression trees with fewer branches >> by looking up and using the prefix-less `prepend` methods directly for cases

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v3]

On Fri, 20 Oct 2023 08:52:04 GMT, Raffaello Giulietti wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix FormatterBuilder testcase handle lineSeparator on windows > >

Re: RFR: 8318538: Add a way to obtain a strided var handle from a layout [v3]

> The 21 iteration of the FFM API used to contain a method, namely > `ValueLayout::arrayElementVarHandle`. This var handle factory was useful when > accessing elements in a flat array of variable size. > > In 22, this method has been removed because: > * It was not general enough (it only

Integrated: 8318538: Add a way to obtain a strided var handle from a layout

On Thu, 19 Oct 2023 16:52:53 GMT, Maurizio Cimadamore wrote: > The 21 iteration of the FFM API used to contain a method, namely > `ValueLayout::arrayElementVarHandle`. This var handle factory was useful when > accessing elements in a flat array of variable size. > > In 22, this method has

Integrated: 8317819: Scope should reflect lifetime of underying resource (mainline)

On Fri, 13 Oct 2023 14:21:49 GMT, Maurizio Cimadamore wrote: > This PR is based on a port of: openjdk/panama-foreign#898 > > Some additional changes are contained in this PR: > > * instead of using a different "always alive" scope for zero-length memory > segments, we now use the global

Re: RFR: 8317819: Scope should reflect lifetime of underying resource (mainline) [v4]

> This PR is based on a port of: openjdk/panama-foreign#898 > > Some additional changes are contained in this PR: > > * instead of using a different "always alive" scope for zero-length memory > segments, we now use the global scope > * the javadoc for `MemorySegment::ofArray`,

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v3]

On Thu, 19 Oct 2023 06:38:35 GMT, Shaojin Wen wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v8]

On Fri, 20 Oct 2023 07:59:25 GMT, Jorn Vernee wrote: > > Why is 84 the maximum? That would result in 170 Java parameters at most, > > which is well within the 255 limit imposed by the VM spec. > > Ah, right, longs take up 2 slots. So, we get 84*3 = 252 + 4 (target address & > return buffer) +

Re: Request for JCK17 tests exclusion

Hi Dalibor, Thank you for your suggestions. I have realized my mistake. I will discuss this further in JCK group and look for a conclusion. Apologies for posting this topic here and wasting your time. Please consider this thread as closed. Regards, Ramdas

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v10]

> Add the ability to pass heap segments to native code. This requires using > `Linker.Option.critical(true)` as a linker option. It has the same > limitations as normal critical calls, namely: upcalls into Java are not > allowed, and the native function should return relatively quickly. Heap >

Re: RFR: 8315097: Rename createJavaProcessBuilder [v5]

On Thu, 19 Oct 2023 15:16:13 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >>

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v8]

On Thu, 19 Oct 2023 22:21:33 GMT, Martin Doerr wrote: >> Jorn Vernee has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - add stub size stress test for allowHeap >> - RISC-V impl >> - remove leftover debug log line > > This is probably

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v8]

On Fri, 20 Oct 2023 07:55:45 GMT, Jorn Vernee wrote: > Why is 84 the maximum? That would result in 170 Java parameters at most, > which is well within the 255 limit imposed by the VM spec. Ah, right, longs take up 2 slots. So, we get 84*3 = 252 + 4 (target address & return buffer) + 2

Re: RFR: 8308753: Class-File API transition to Preview [v22]

> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR

Integrated: 8316587: Use ArraysSupport.vectorizedHashCode in Utf8EntryImpl

On Wed, 20 Sep 2023 09:17:24 GMT, Chen Liang wrote: > Like #12077, this uses JDK's internal utilities to speed up ASCII reading in > Class files, where most identifiers, from conventions to attribute names, are > ASCII. See the JBS issue for more in-depth explanations. > > Before: (Master) >

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v9]

> Add the ability to pass heap segments to native code. This requires using > `Linker.Option.critical(true)` as a linker option. It has the same > limitations as normal critical calls, namely: upcalls into Java are not > allowed, and the native function should return relatively quickly. Heap >

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v7]

On Thu, 19 Oct 2023 18:15:45 GMT, Sidraya Jayagond wrote: >> @feilongjiang Thanks, I've added it to the PR >> >> @TheRealMDoerr Note that `reg_offset` is filtered out, and not handled by >> `arg_shuffle`. So, it becomes the question whether shuffling a register, or >> adding an offset to an

Re: RFR: 8316587: Use ArraysSupport.vectorizedHashCode in Utf8EntryImpl [v2]

On Thu, 21 Sep 2023 02:38:08 GMT, Chen Liang wrote: >> Like #12077, this uses JDK's internal utilities to speed up ASCII reading in >> Class files, where most identifiers, from conventions to attribute names, >> are ASCII. See the JBS issue for more in-depth explanations. >> >> Before:

Re: RFR: 8318538: Add a way to obtain a strided var handle from a layout [v2]

On Thu, 19 Oct 2023 20:49:13 GMT, Maurizio Cimadamore wrote: >> The 21 iteration of the FFM API used to contain a method, namely >> `ValueLayout::arrayElementVarHandle`. This var handle factory was useful >> when accessing elements in a flat array of variable size. >> >> In 22, this method