On Fri, 6 Oct 2023 18:07:37 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317630)
>> which makes the implications of overriding _ChoiceFormat::applyPattern_ and
>> _MessageFormat::applyPattern_ apparent by adding a implSpec tag to the
>> method.
On Mon, Oct 23, 2023 at 04:26:42PM +0100, Michael McMahon wrote:
> Thanks for bringing this to our attention. You are right that this is a
> misuse of the authentication cache in the case of Kerberos (Negotiate)
> authentication. Though that is not the case for other auth schemes, because
>
On Mon, 23 Oct 2023 23:16:42 GMT, Justin Lu wrote:
>> Please review this PR which adds a test for ChoiceFormat intended to test a
>> wide range of ChoiceFormat patterns.
>>
>> The existing test _Bug4387255_ only tests a singular basic pattern and does
>> not test for incorrect patterns
> Please review this PR which adds a test for ChoiceFormat intended to test a
> wide range of ChoiceFormat patterns.
>
> The existing test _Bug4387255_ only tests a singular basic pattern and does
> not test for incorrect patterns either.
>
> The new test checks
>
> - both correct and
On Mon, 23 Oct 2023 22:19:15 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> implement feedback
>
> test/jdk/java/text/Format/ChoiceFormat/PatternsTest.java line 59:
>
>> 57:
On Mon, 23 Oct 2023 21:15:44 GMT, Justin Lu wrote:
> Please review this PR which adds a test for ChoiceFormat intended to test a
> wide range of ChoiceFormat patterns.
>
> The existing test _Bug4387255_ only tests a singular basic pattern and does
> not test for incorrect patterns either.
>
On Mon, 23 Oct 2023 18:26:51 GMT, Raffaello Giulietti
wrote:
>> Please review this simple fix to restore the original exception message that
>> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
>
> Raffaello Giulietti has updated the pull request incrementally with one
>
On Sat, 21 Oct 2023 00:56:21 GMT, Joe Darcy wrote:
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
This pull request has now been integrated.
Changeset: 1b150117
Author:Joe Darcy
URL:
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Re-flow paragraph.
- Fix a typo.
-
Changes:
- all:
Please review this PR which adds a test for ChoiceFormat intended to test a
wide range of ChoiceFormat patterns.
The existing test _Bug4387255_ only tests a singular basic pattern and does not
test for incorrect patterns either.
The new test checks
- both correct and incorrect patterns
- the
Hi Hans,
Giving some additional context, we'll occasionally get bug reports that
amount to an observation equivalent to the following:
"I have two Big{Foo} variables and in a loop I assign larger and larger
values to them. As the values get large, bigFoo1.add(bigFoo2) runs much
faster than
On Mon, 23 Oct 2023 20:26:00 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 302:
>>
>>> 300: * scale. For example, an {@linkplain BigDecimal#multiply(BigDecimal)
>>> 301: * exact multiply} of two {@code BigDecimal} values is subject to the
>>> 302: * same
On Mon, 23 Oct 2023 20:47:42 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback, fix
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback, fix typos.
-
Changes:
- all:
On Mon, 23 Oct 2023 20:07:07 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo.
>
> src/java.base/share/classes/java/math/BigInteger.java line 137:
>
>> 135: * results indicate a
On Mon, 23 Oct 2023 20:05:50 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 302:
>
>> 300: * scale. For example, an
On Mon, 23 Oct 2023 03:50:50 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo.
On Mon, 23 Oct 2023 18:26:51 GMT, Raffaello Giulietti
wrote:
>> Please review this simple fix to restore the original exception message that
>> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
>
> Raffaello Giulietti has updated the pull request incrementally with one
>
On Mon, 23 Oct 2023 18:26:51 GMT, Raffaello Giulietti
wrote:
>> Please review this simple fix to restore the original exception message that
>> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
>
> Raffaello Giulietti has updated the pull request incrementally with one
>
On Mon, 23 Oct 2023 11:50:02 GMT, Shaojin Wen wrote:
> Can I add scale2 method to StringLatin1?
I'd strongly advice against this.
> I think this is more readable than using MethodHandle.
View the `MethodHandle`s you add to use `StringConcatFactory` here as a
temporary workaround before the
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> - We have a valid size for the Zip64 extra header but we are
On Mon, 23 Oct 2023 18:26:51 GMT, Raffaello Giulietti
wrote:
>> Please review this simple fix to restore the original exception message that
>> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
>
> Raffaello Giulietti has updated the pull request incrementally with one
>
Spec clarification of `ListFormat.equals()` method, utilizing newly introduced
`getLocale()` and `getPatterns()`. A corresponding CSR has also been drafted.
-
Depends on: https://git.openjdk.org/jdk/pull/16293
Commit messages:
- Fixing typo
- Removed redundant wording
- initial
On Mon, 23 Oct 2023 18:26:51 GMT, Raffaello Giulietti
wrote:
>> Please review this simple fix to restore the original exception message that
>> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
>
> Raffaello Giulietti has updated the pull request incrementally with one
>
> Please review this simple fix to restore the original exception message that
> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Remove 2 extraneous files
Hello,
I have a problem with JShell, I don’t know if it should go in this mailing list.
On JDK 21 (should be the same for any JDK version 9+), Windows 11, with this
following code :
```
var jshell = JShell.create() ;
jshell.sourceCodeAnalysis().analyzeCompletion("println(").source() // null
```
Please review this simple fix to restore the original exception message that
existed before [16050](https://github.com/openjdk/jdk/pull/16050).
-
Commit messages:
- Merge branch 'master' into 8318646
- 8318646: Integer#parseInt("") throws empty NumberFormatException message
-
On Mon, 23 Oct 2023 17:16:08 GMT, Justin Lu wrote:
> Please review this PR which clarifies inconsistency between
> `ChoiceFormat::applyPattern` and `ChoiceFormat::setChoices`.
>
> A `ChoiceFormat` is composed of limits and formats. `applyPattern()` will
> throw an exception if limits are not
The existing logic uses nanosecond arithmetic to compute Duration.between.
Since that can overflow for durations greater than 292 years, it has a
try/catch that falls back to computing the seconds part and adjusting that for
nanoseconds. However, exception handling is typically very expensive,
Please review this PR which clarifies inconsistency between
`ChoiceFormat::applyPattern` and `ChoiceFormat::setChoices`.
A `ChoiceFormat` is composed of limits and formats. `applyPattern()` will throw
an exception if limits are not in ascending order, while `setChoices()` will
not. This should
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
This pull request has now been integrated.
Changeset: 8d9a4b43
Author:Sean Coffey
URL:
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
Since I think this is about asymptotic complexity, which is determined by
behavior on large inputs, is there a reason to talk about switching to
other algorithms on smaller inputs? We certainly don't want to get into the
habit of listing "easy case" optimizations everywhere.
I'm unclear about the
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
@AlanBateman @stuart-marks Does any of you have any cycles to review this
one-word PR? :)
-
PR Comment:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Update jmh test comments
-
Changes:
- all:
On Sun, 15 Oct 2023 20:20:48 GMT, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of an enhancement that replaces the use of ASM with the
> new Class-File API. This change only deals with bytecode that writes event
> data into buffers. Bytecode transformations carried out by classes in
>
On Mon, 23 Oct 2023 03:50:50 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo.
I suggest taking a
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
Yes, looks good to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/16313#issuecomment-1775517786
Resolves a visibility issue in SubmissionPublisher by making the `waiter`
member of BufferedSubscription *volatile*.
-
Commit messages:
- Addresses JDK-8293713 by making the waiter thread member volatile
Changes: https://git.openjdk.org/jdk/pull/16313/files
Webrev:
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
Discussed this change with @DougLea
-
PR Comment:
Hi,
Thanks for bringing this to our attention. You are right that this is a
misuse of the authentication cache in the case of Kerberos (Negotiate)
authentication. Though that is not the case for other auth schemes,
because normally what gets cached are credentials, rather than security
On Mon, 23 Oct 2023 11:37:08 GMT, Jorn Vernee wrote:
> See JBS issue. We don't need to save xmm16+ on x64 platforms (which are
> currently saved in FFM upcall stubs). This is achieved simply by adding these
> registers to the volatile register lists of both ABIs.
>
> Related:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote:
> The Graal code base has
> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
> its module to `jdk.compiler.graal` as part of preparations for Project
> Galahad. Due to the way Java modules work, this
On Sat, 21 Oct 2023 10:56:01 GMT, Doug Simon wrote:
>> The Graal code base has
>> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
>> its module to `jdk.compiler.graal` as part of preparations for Project
>> Galahad. Due to the way Java modules work,
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 11:37:08 GMT, Jorn Vernee wrote:
> See JBS issue. We don't need to save xmm16+ on x64 platforms (which are
> currently saved in FFM upcall stubs). This is achieved simply by adding these
> registers to the volatile register lists of both ABIs.
>
> Related:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Incorporate test review comments from Jai
-
See JBS issue. We don't need to save xmm16+ on x64 platforms (which are
currently saved in FFM upcall stubs). This is achieved simply by adding these
registers to the volatile register lists of both ABIs.
Related: https://github.com/openjdk/jdk/pull/15688
Testing: `jdk_foreign`
-
On Sat, 21 Oct 2023 10:56:01 GMT, Doug Simon wrote:
>> The Graal code base has
>> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
>> its module to `jdk.compiler.graal` as part of preparations for Project
>> Galahad. Due to the way Java modules work,
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 10:39:11 GMT, Sean Coffey wrote:
> ZipFile behaviour in the scenario where a file is re-opened and edited
> while references to the old ZipFile exist. A "invalid LOC header" needs to be
> thrown in cases where an old zip file mapping is still in use.
This PR doesn't do any
On Thu, 19 Oct 2023 11:58:26 GMT, Claes Redestad wrote:
>> @cl4es
>>
>>> Good, narrows it down to what's going on in `prepend(long, byte[],
>>> String)`. Might boil down to `System.arraycopy`. This method might not be
>>> optimized for tiny arrays on all platforms. Specializing for
On Mon, 23 Oct 2023 11:29:28 GMT, Jorn Vernee wrote:
> We could add a line to `donwcallHandle` that says that the returned handle
> throws an `IllegalArgumentException` if a heap segment is passed, unless heap
> segments are explicitly allowed through the `critical(true)` option.
Something
On Sat, 21 Oct 2023 12:04:10 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
On Wed, 19 Jul 2023 12:03:40 GMT, Matthew Donovan wrote:
> This PR refactors the SSLSocketParametersTest by removing
> redundant/unnecessary classes and cleans up the logic around expected
> exceptions.
This pull request has now been integrated.
Changeset: 704c6ea1
Author:Matthew Donovan
On Sat, 21 Oct 2023 12:04:10 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 08:17:43 GMT, Uwe Schindler wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Using compareUnsigned() rather than open logic.
>
> This caused issue sin Apache Lucene, as it should not
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 23 Oct 2023 03:46:54 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
On Mon, 23 Oct 2023 09:55:16 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/math/BigInteger.java line 127:
>
>> 125: * the
On Mon, 23 Oct 2023 08:17:43 GMT, Uwe Schindler wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Using compareUnsigned() rather than open logic.
>
> This caused issue sin Apache Lucene, as it should not
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Update code comments
-
Changes:
- all:
On Fri, 6 Oct 2023 16:26:42 GMT, Raffaello Giulietti
wrote:
>> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the
>> details.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Using
On Wed, 11 Oct 2023 07:52:54 GMT, Per Minborg wrote:
> This PR proposes to Add @sealedGraph to `Thread.Builder`.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/16138
On Wed, 11 Oct 2023 07:52:54 GMT, Per Minborg wrote:
> This PR proposes to Add @sealedGraph to `Thread.Builder`.
I will close this PR as the taglet was not deemed to be helpful here.
-
PR Comment: https://git.openjdk.org/jdk/pull/16138#issuecomment-1774522674
On Wed, 11 Oct 2023 05:29:22 GMT, ANUPAM DEV wrote:
>> Hello,
>>
>> I have fixed the typo in the comment for the constructor
>> IdentityHashMap(Map m)
>>
>> before: Constructs a new identity hash map containing the keys-value
>> mappings in the specified map.
>> after: Constructs a new
On Wed, 11 Oct 2023 07:45:17 GMT, Per Minborg wrote:
> This PR proposes to add @sealedGraph to MethodHandleDesc and descendants.
This pull request has now been integrated.
Changeset: ffadd635
Author:Per Minborg
URL:
76 matches
Mail list logo
