Re: RFR: 8318650: Optimized subword gather for x86 targets.

2023-10-24 Thread Jatin Bhateja
On Wed, 25 Oct 2023 04:34:59 GMT, Jatin Bhateja wrote: > Hi All, > > This patch optimizes sub-word gather operation for x86 targets with AVX2 and > AVX512 features. > > Following is the summary of changes:- > > 1) Intrinsify sub-word gather with high performance backend implementation >

RFR: 8318650: Optimized subword gather for x86 targets.

2023-10-24 Thread Jatin Bhateja
Hi All, This patch optimizes sub-word gather operation for x86 targets with AVX2 and AVX512 features. Following is the summary of changes:- 1) Intrinsify sub-word gather with high performance backend implementation based on hybrid algorithm which initially partially unrolls scalar loop to

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v3]

2023-10-24 Thread Roger Riggs
On Tue, 24 Oct 2023 22:57:59 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v3]

2023-10-24 Thread Brian Burkhalter
On Tue, 24 Oct 2023 22:57:59 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v3]

2023-10-24 Thread Brian Burkhalter
> Windows 11 does not reserve as many names as prior versions of Windows so do > not expect exceptions for COM7 and LPT1. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8274122: Use internal OperatingSystem and OSVersion

Integrated: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild

2023-10-24 Thread Alexander Matveev
On Fri, 6 Oct 2023 22:15:00 GMT, Alexander Matveev wrote: > - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` > CLI options to jpackage to provide signing identity directly to `codesign` > and `productbuild` tools as per CSR >

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v53]

2023-10-24 Thread Joe Darcy
On Fri, 20 Oct 2023 21:26:51 GMT, Doug Lea wrote: >> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java >> failed with "InterruptedException: sleep interrupted" and related issues. >> >> This is a major ForkJoin update (and hard to review -- sorry) that finally >>

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Roger Riggs
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

2023-10-24 Thread Iris Clark
On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request incrementally with one

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

2023-10-24 Thread Lance Andersen
On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request incrementally with one

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

2023-10-24 Thread Roger Riggs
On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request incrementally with one

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

2023-10-24 Thread Joe Wang
On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request incrementally with one

Integrated: 8318051: Duration.between uses exceptions for control flow

2023-10-24 Thread Eamonn McManus
On Mon, 23 Oct 2023 17:33:48 GMT, Eamonn McManus wrote: > The existing logic uses nanosecond arithmetic to compute Duration.between. > Since that can overflow for durations greater than 292 years, it has a > try/catch that falls back to computing the seconds part and adjusting that > for

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v2]

2023-10-24 Thread Brian Burkhalter
On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8318051: Duration.between uses exceptions for control flow

2023-10-24 Thread Roger Riggs
On Mon, 23 Oct 2023 17:33:48 GMT, Eamonn McManus wrote: > The existing logic uses nanosecond arithmetic to compute Duration.between. > Since that can overflow for durations greater than 292 years, it has a > try/catch that falls back to computing the seconds part and adjusting that > for

Re: RFR: 8318051: Duration.between uses exceptions for control flow

2023-10-24 Thread Eamonn McManus
On Mon, 23 Oct 2023 17:33:48 GMT, Eamonn McManus wrote: > The existing logic uses nanosecond arithmetic to compute Duration.between. > Since that can overflow for durations greater than 292 years, it has a > try/catch that falls back to computing the seconds part and adjusting that > for

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v2]

2023-10-24 Thread Brian Burkhalter
On Tue, 24 Oct 2023 17:40:34 GMT, Lance Andersen wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274122: Make value of exceptionExpected more robust to Windows version > > Marked as reviewed by lancea

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-24 Thread amittoranainc
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v2]

2023-10-24 Thread Roger Riggs
On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v2]

2023-10-24 Thread Daniel JeliƄski
On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

2023-10-24 Thread Naoto Sato
On Tue, 24 Oct 2023 17:04:25 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflecting review comments > > Looks fine to me. > > Alternatively (or more explicitly), it could be: Compares the

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

2023-10-24 Thread Naoto Sato
> Spec clarification of `ListFormat.equals()` method, utilizing newly > introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also > been drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Reflecting review

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v2]

2023-10-24 Thread Lance Andersen
On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v2]

2023-10-24 Thread Naoto Sato
> Spec clarification of `ListFormat.equals()` method, utilizing newly > introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also > been drafted. Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v2]

2023-10-24 Thread Joe Wang
On Tue, 24 Oct 2023 17:05:29 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request with a new target base due to a

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Leonid Mesnik
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It

Integrated: 8318569: Add getter methods for Locale and Patterns in ListFormat

2023-10-24 Thread Naoto Sato
On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote: > Proposing adding getter methods for `locale` and `patterns` fields in the > `ListFormat` instances. Those fields are used for `equals()`, but without the > public getter methods, users cannot tell the reasoning of the equality of two >

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v12]

2023-10-24 Thread Maurizio Cimadamore
On Tue, 24 Oct 2023 15:09:57 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-10-24 Thread iaroslavski
On Wed, 20 Sep 2023 16:33:56 GMT, Paul Sandoz wrote: >>> > Alan, you mentioned that DualPivotQuicksort will need detailed review. >>> > Can we go ahead and start reviewing? Laurent checked performance, JMH >>> > results look fine. >>> >>> As before, I think the main question with this change

Re: RFR: 8317980: Optimization for Integer.parseInt and Long.parseLong [v2]

2023-10-24 Thread Shaojin Wen
> By extracting the code that creates the exception, the CodeSize of these > methods is less than the default FreqInlineSize 325. and for the scenario > where the most commonly used radix is not specified and the String coder is > LATIN1, fast-path can improves the performance 10% of >

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v12]

2023-10-24 Thread Jorn Vernee
> Add the ability to pass heap segments to native code. This requires using > `Linker.Option.critical(true)` as a linker option. It has the same > limitations as normal critical calls, namely: upcalls into Java are not > allowed, and the native function should return relatively quickly. Heap >

RFR: 8318586: Explicitly handle upcall stub allocation failure

2023-10-24 Thread Jorn Vernee
Explicitly handle UpcallStub allocation failures by terminating. We currently might try to use the returned `nullptr` which would fail sooner or later. This patch just makes the termination explicit. - Commit messages: - Merge branch 'master' into UpcallStubAllocFailure - remove

Re: RFR: JDK-8317612: ChoiceFormat and MessageFormat constructors call non-final public method [v2]

2023-10-24 Thread Roger Riggs
On Fri, 6 Oct 2023 18:07:37 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317630) >> which makes the implications of overriding _ChoiceFormat::applyPattern_ and >> _MessageFormat::applyPattern_ apparent by adding a implSpec tag to the >> method.

Re: RFR: 8318051: Duration.between uses exceptions for control flow

2023-10-24 Thread Roger Riggs
On Mon, 23 Oct 2023 17:33:48 GMT, Eamonn McManus wrote: > The existing logic uses nanosecond arithmetic to compute Duration.between. > Since that can overflow for durations greater than 292 years, it has a > try/catch that falls back to computing the seconds part and adjusting that > for

Integrated: 8316046: x64 platforms unecessarily save xmm16-31 when UseAVX >= 3

2023-10-24 Thread Jorn Vernee
On Mon, 23 Oct 2023 11:37:08 GMT, Jorn Vernee wrote: > See JBS issue. We don't need to save xmm16+ on x64 platforms (which are > currently saved in FFM upcall stubs). This is achieved simply by adding these > registers to the volatile register lists of both ABIs. > > Related:

Re: RFR: 8318646: Integer#parseInt("") throws empty NumberFormatException message [v2]

2023-10-24 Thread Uwe Schindler
On Mon, 23 Oct 2023 22:15:48 GMT, Uwe Schindler wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove 2 extraneous files from commit > > Marked as reviewed by uschindler (Author). > @uschindler You may

Integrated: 8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

2023-10-24 Thread Viktor Klang
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote: > Resolves a visibility issue in SubmissionPublisher by making the `waiter` > member of BufferedSubscription *volatile*. This pull request has now been integrated. Changeset: 5224e979 Author:Viktor Klang Committer: Alan Bateman URL:

Re: RFR: 8318646: Integer#parseInt("") throws empty NumberFormatException message [v2]

2023-10-24 Thread Raffaello Giulietti
On Mon, 23 Oct 2023 22:15:48 GMT, Uwe Schindler wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove 2 extraneous files from commit > > Marked as reviewed by uschindler (Author). @uschindler You may want

Integrated: 8318646: Integer#parseInt("") throws empty NumberFormatException message

2023-10-24 Thread Raffaello Giulietti
On Mon, 23 Oct 2023 18:04:35 GMT, Raffaello Giulietti wrote: > Please review this simple fix to restore the original exception message that > existed before [16050](https://github.com/openjdk/jdk/pull/16050). This pull request has now been integrated. Changeset: 9bfa0829 Author:Raffaello

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Stefan Karlsson
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >>

Re: RFR: 8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

2023-10-24 Thread Alan Bateman
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote: > Resolves a visibility issue in SubmissionPublisher by making the `waiter` > member of BufferedSubscription *volatile*. Marked as reviewed by alanb (Reviewer). - PR Review:

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Leo Korinth
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >>

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually