On Mon, 6 Nov 2023 21:05:58 GMT, Per Minborg wrote:
> This PR proposes to remove two `permits` declarations where the line
> overflows the stipulated maximum column with. Also, it proposes to harmonize
> the layout of `permit` formatting so they are the the same throughout the API.
>
> This
On Wed, 8 Nov 2023 05:13:04 GMT, David Holmes wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename field from tracing to jfrTracing
>
> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 62:
On Wed, 8 Nov 2023 02:33:29 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to
> Test thread factory is a mode similar to VM flags and should not be used in
> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
> createTestJavaProcessBuilder() should use it like jtreg VM options.
>
> Adding the test thread factory requires the injection of arguments in the
> middle
On Wed, 8 Nov 2023 00:30:05 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify the transformation code and easier to read
>
> test/jdk/jdk/lambda/separate/ClassToInterfaceConverter.java line
> Test thread factory is a mode similar to VM flags and should not be used in
> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
> createTestJavaProcessBuilder() should use it like jtreg VM options.
>
> Adding the test thread factory requires the injection of arguments in the
> middle
> j.u.Formatter now prints "%tF" (iso standard date) and the result is
> incorrect when processing year < 0 or year >
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Use minus sign from cached DecimalFormatSymbols and improved
On Tue, 7 Nov 2023 19:10:18 GMT, ExE Boss wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify the transformation code and easier to read
>
> test/jdk/jdk/lambda/separate/ClassToInterfaceConverter.java line 53:
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to
On Tue, 7 Nov 2023 19:17:03 GMT, Raffaello Giulietti
wrote:
>> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`,
>> throwing `OutOfMemoryError` instead to indicate that the resulting `String`
>> would be too large.
>
> Raffaello Giulietti has updated the pull request
On Mon, 6 Nov 2023 22:25:46 GMT, Bill Huang wrote:
> Updated jdk_core_manual test groups.
Marked as reviewed by msheppar (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16531#pullrequestreview-1719065392
On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote:
> Please review this PR which clarifies the definition of a _cancelled_ task in
> _j.util.Timer::purge_ and _j.util.Timer::cancel_.
>
> Timer::purge claims that its return value is the number of tasks in the queue
> that were cancelled. This
On Tue, 7 Nov 2023 19:17:03 GMT, Raffaello Giulietti
wrote:
>> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`,
>> throwing `OutOfMemoryError` instead to indicate that the resulting `String`
>> would be too large.
>
> Raffaello Giulietti has updated the pull request
On Thu, 2 Nov 2023 11:58:23 GMT, Jim Laskey wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove .orig files
>
> Re .orig. Thank you Alan.
@JimLaskey , please "/issue add JDK-8319133" to include the annotation
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote:
> This test requires certain methods to be compiled, but without `-Xbatch` the
> compiler races against the test code, which can lead to intermittent failures.
This pull request has now been integrated.
Changeset: a290256b
Author:Gergö
On Mon, 6 Nov 2023 22:52:47 GMT, Joe Wang wrote:
> Xalan 2.7.3: merge minor changes from the upstream project.
>
> Test: existing XML tests pass
This pull request has now been integrated.
Changeset: b1625af6
Author:Joe Wang
URL:
On Tue, 7 Nov 2023 18:22:08 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Using repeat() instead of loop.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 3518:
>
>> 3516:
> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`,
> throwing `OutOfMemoryError` instead to indicate that the resulting `String`
> would be too large.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to
> early experimental version of the bytecode library is bundled under:
> test/jdk/lib/testlibrary/bytecode
>
> following tests reference it:
> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
> test/jdk/java/lang/invoke/condy/CondyWithGarbageTest.java
>
On Wed, 1 Nov 2023 17:40:04 GMT, Raffaello Giulietti
wrote:
> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`,
> throwing `OutOfMemoryError` instead to indicate that the resulting `String`
> would be too large.
src/java.base/share/classes/java/math/BigDecimal.java line
> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
> mechanically convert a classfile for a Class into an in-memory class
> representation of an equivalent Interface. `testPrivateMethodCall` tests to
> invoke a private method. Before nestmates, invoking a private
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep455-20231030/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one additional
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Tue, 7 Nov 2023 17:45:36 GMT, Paul Sandoz wrote:
>> This test requires certain methods to be compiled, but without `-Xbatch` the
>> compiler races against the test code, which can lead to intermittent
>> failures.
>
> Marked as reviewed by psandoz (Reviewer).
> @PaulSandoz do you see any
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote:
> This test requires certain methods to be compiled, but without `-Xbatch` the
> compiler races against the test code, which can lead to intermittent failures.
Marked as reviewed by psandoz (Reviewer).
-
PR Review:
On Tue, 7 Nov 2023 16:19:33 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Tue, 7 Nov 2023 05:43:06 GMT, Joe Wang wrote:
>> Xalan 2.7.3: merge minor changes from the upstream project.
>>
>> Test: existing XML tests pass
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove commented out block in
> early experimental version of the bytecode library is bundled under:
> test/jdk/lib/testlibrary/bytecode
>
> following tests reference it:
> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
> test/jdk/java/lang/invoke/condy/CondyWithGarbageTest.java
>
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
This pull request has now been integrated.
Changeset: e9eb8b98
Author:Alexey Semenyuk
URL:
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16535#pullrequestreview-1718248698
On Mon, 6 Nov 2023 19:12:28 GMT, Mandy Chung wrote:
> This is a regression caused by JDK-8302791. IAE should be thrown when an
> interface is not visible to the given class loader but NPE is thrown instead
> when the loader is null. The boot loader has no name and so the fix will
> print
On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen wrote:
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> -
On Tue, 7 Nov 2023 06:21:24 GMT, Alan Bateman wrote:
> Can you confirm that debug builds are passing with -XX:+UseZGC now?
Yes, I can
-
PR Comment: https://git.openjdk.org/jdk/pull/16535#issuecomment-1799203733
On Mon, 6 Nov 2023 22:25:46 GMT, Bill Huang wrote:
> Updated jdk_core_manual test groups.
LGTM
-
PR Comment: https://git.openjdk.org/jdk/pull/16531#issuecomment-1799175261
On Tue, 7 Nov 2023 15:15:19 GMT, Shaojin Wen wrote:
>> Within java.util.Formatter, the year formatter supports only the range
>> [0,].
>> Only ISO_STANDARD_DATE has a ISO 8601 format defined for numbers outside
>> that range.
>> The formatting in java.time is defined over the full range
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Tue, 7 Nov 2023 16:32:43 GMT, Per Minborg wrote:
>> This PR proposes to remove two `permits` declarations where the line
>> overflows the stipulated maximum column with. Also, it proposes to harmonize
>> the layout of `permit` formatting so they are the the same throughout the
>> API.
>>
> This PR proposes to remove two `permits` declarations where the line
> overflows the stipulated maximum column with. Also, it proposes to harmonize
> the layout of `permit` formatting so they are the the same throughout the API.
>
> This PR might be perceived as over worked but I think it
On Tue, 7 Nov 2023 15:51:22 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 899:
>>
>>> 897: /*
>>> 898: * Return type so that launcher invokes the correct main
>>> 899: */
>>
>> If you are doing anymore edits then I think this method
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
On Tue, 7 Nov 2023 15:11:25 GMT, Per Minborg wrote:
> Hrmm. I reformatted all classes of the same category where at least one of
> them needed reformatting to make it more consistent. For example: `OfBoolean`
> overflows but not `OfByte`. So, all of the of* were consistently reformatted.
>
On Tue, 7 Nov 2023 15:45:02 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 additional
>> commits
On Tue, 7 Nov 2023 12:29:12 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Fri, 3 Nov 2023 19:14:18 GMT, Raffaello Giulietti
wrote:
>> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by
>> improving guarantees of internal invariants.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
On Sat, 21 Oct 2023 01:22:04 GMT, Shaojin Wen wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Tue, 7 Nov 2023 15:04:16 GMT, Roger Riggs wrote:
>> While it might be reasonable to localize using `getMinusSign()` this will
>> introduce a new inconsistency with `DateTimeFormatter` (which *does not*
>> localize minus signs in front of years):
>>
>> int minus =
On Tue, 7 Nov 2023 11:41:06 GMT, Per Minborg wrote:
>> This PR proposes to remove two `permits` declarations where the line
>> overflows the stipulated maximum column with. Also, it proposes to harmonize
>> the layout of `permit` formatting so they are the the same throughout the
>> API.
>>
On Tue, 7 Nov 2023 11:41:06 GMT, Per Minborg wrote:
>> This PR proposes to remove two `permits` declarations where the line
>> overflows the stipulated maximum column with. Also, it proposes to harmonize
>> the layout of `permit` formatting so they are the the same throughout the
>> API.
>>
On Mon, 6 Nov 2023 21:00:10 GMT, Per Minborg wrote:
> This PR proposes to reformat some method parameters in the FFM API. The
> proposed changes are a bit opinion based eve though there are some underlying
> principles.
This pull request has now been integrated.
Changeset: 134c382d
Author:
On Tue, 7 Nov 2023 13:45:54 GMT, Claes Redestad wrote:
>> test/jdk/java/util/Formatter/BasicDateTime.java line 473:
>>
>>> 471: "%tF",
>>> 472:
>>> DecimalFormatSymbols.getInstance(localeEuES).getMinusSign() + "2023-01-13",
>>> 473:
> This PR proposes to reformat some method parameters in the FFM API. The
> proposed changes are a bit opinion based eve though there are some underlying
> principles.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two
On Tue, 7 Nov 2023 09:31:11 GMT, Per Minborg wrote:
> This PR proposes to improve the language used in the FFM specification. There
> is a relatively small number of corrections.
>
> One peculiarity with the English language is the distinction between "that"
> (to be used in a restrictive
> Consider code like:
>
> void test(Object o) {
> switch (o) {
> case X1 -> {}
> case X2 -> {}
> ...(about 100 cases)
> ```
>
> javac will compile the switch into a switch whose selector is an indy
> invocation to `SwitchBootstraps.typeSwitch`, with static arguments being
On Tue, 7 Nov 2023 13:28:06 GMT, Naoto Sato wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use DecimalFormatSymbols#getMinusSign
>
> test/jdk/java/util/Formatter/BasicDateTime.java line 473:
>
>> 471:
On Tue, 7 Nov 2023 01:31:03 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote:
> This test requires certain methods to be compiled, but without `-Xbatch` the
> compiler races against the test code, which can lead to intermittent failures.
@PaulSandoz do you see any problem with this change? Adding `-Xbatch` does not
On Mon, 6 Nov 2023 22:25:46 GMT, Bill Huang wrote:
> Updated jdk_core_manual test groups.
LGTM
-
PR Comment: https://git.openjdk.org/jdk/pull/16531#issuecomment-1798412093
> Update String Templates for a second preview. With the addition of
>
> - Expression type and throws are determined from the `process` method of the
> processor type and not the processor type.
>
> - Qualified `STR` and `RAW` are treated the same as unqualified `STR` and
> `RAW` .
>
> - Raw
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
On Mon, 6 Nov 2023 06:00:20 GMT, Chen Liang wrote:
> Observed this erroneous implementation while browsing, and included a quick
> test against javac output class file to confirm the correct implementation.
> @asotona Please take a look.
This pull request has now been integrated.
Changeset:
On Tue, 7 Nov 2023 11:04:14 GMT, Ryan Wallace wrote:
> the issue with the current functionality on the mainline is that the jar
> tool is still processing and creating the temp jar file, it just doesn't move
> it to the working directory where the tool was ran from because there was a
>
On Fri, 3 Nov 2023 16:26:49 GMT, Jan Lahoda wrote:
> For code like:
>
> enum E {A {}, B {} }
> Object o = E.A;
> switch (o) {
> case E.A -> System.err.println(o);
> default -> System.err.println("default");
> }
>
>
> The result is `default`, not `A`, due to incorrect classes being
> early experimental version of the bytecode library is bundled under:
> test/jdk/lib/testlibrary/bytecode
>
> following tests reference it:
> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
> test/jdk/java/lang/invoke/condy/CondyWithGarbageTest.java
>
On Mon, 6 Nov 2023 21:07:22 GMT, Per Minborg wrote:
> This PR proposes to reformat a small number of code line for better
> appearance.
This pull request has now been integrated.
Changeset: 42f43c52
Author:Per Minborg
URL:
> This PR proposes to remove two `permits` declarations where the line
> overflows the stipulated maximum column with. Also, it proposes to harmonize
> the layout of `permit` formatting so they are the the same throughout the API.
>
> This PR might be perceived as over worked but I think it
On Mon, 6 Nov 2023 21:07:22 GMT, Per Minborg wrote:
> This PR proposes to reformat a small number of code line for better
> appearance.
Marked as reviewed by mcimadamore (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16529#pullrequestreview-1717461495
> This PR proposes to improve the language used in the FFM specification. There
> is a relatively small number of corrections.
>
> One peculiarity with the English language is the distinction between "that"
> (to be used in a restrictive clause) and "which" (to be used in a
> non-restrictive
On Mon, 6 Nov 2023 21:05:58 GMT, Per Minborg wrote:
> This PR proposes to remove two `permits` declarations where the line
> overflows the stipulated maximum column with. Also, it proposes to harmonize
> the layout of `permit` formatting so they are the the same throughout the API.
>
> This
On Mon, 6 Nov 2023 21:00:10 GMT, Per Minborg wrote:
> This PR proposes to reformat some method parameters in the FFM API. The
> proposed changes are a bit opinion based eve though there are some underlying
> principles.
Marked as reviewed by mcimadamore (Reviewer).
-
PR Review:
On Tue, 7 Nov 2023 11:23:58 GMT, Per Minborg wrote:
>> This PR proposes to improve the language used in the FFM specification.
>> There is a relatively small number of corrections.
>>
>> One peculiarity with the English language is the distinction between "that"
>> (to be used in a
On Tue, 7 Nov 2023 05:43:06 GMT, Joe Wang wrote:
>> Xalan 2.7.3: merge minor changes from the upstream project.
>>
>> Test: existing XML tests pass
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove commented out block in
On Tue, 7 Nov 2023 09:31:11 GMT, Per Minborg wrote:
> This PR proposes to improve the language used in the FFM specification. There
> is a relatively small number of corrections.
>
> One peculiarity with the English language is the distinction between "that"
> (to be used in a restrictive
On Tue, 7 Nov 2023 09:31:11 GMT, Per Minborg wrote:
> This PR proposes to improve the language used in the FFM specification. There
> is a relatively small number of corrections.
>
> One peculiarity with the English language is the distinction between "that"
> (to be used in a restrictive
On Tue, 7 Nov 2023 10:36:00 GMT, Per Minborg wrote:
> This PR proposes to fix a compilation error in the TestLoadSegmentVarious
> class
This pull request has now been integrated.
Changeset: ac0ee20a
Author:Per Minborg
URL:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
Erik Gahlin has updated the pull request incrementally with one additional
commit since the last revision:
Rename field from tracing to jfrTracing
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing
On Tue, 7 Nov 2023 10:36:00 GMT, Per Minborg wrote:
> This PR proposes to fix a compilation error in the TestLoadSegmentVarious
> class
The change looks OK to me.
-
Marked as reviewed by jpai (Reviewer).
PR Review:
This PR proposes to fix a compilation error in the TestLoadSegmentVarious class
-
Commit messages:
- Fix compiler error in benchmark
Changes: https://git.openjdk.org/jdk/pull/16537/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16537=00
Issue:
On Tue, 7 Nov 2023 10:36:00 GMT, Per Minborg wrote:
> This PR proposes to fix a compilation error in the TestLoadSegmentVarious
> class
Marked as reviewed by stefank (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16537#pullrequestreview-1717370876
On Tue, 7 Nov 2023 09:27:51 GMT, Alan Bateman wrote:
>> I filed an issue to investigate if there is a problem with SOE, or if the
>> OOM check is really needed now.
>> https://bugs.openjdk.org/browse/JDK-8319579
>>
>> Regardless of outcome, It would be good to document the results of the
>>
On Tue, 7 Nov 2023 09:24:20 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove SecurityException and IllegalArgumentException from throws clause
>
>
On Wed, 25 Oct 2023 13:08:06 GMT, Per Minborg wrote:
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
This pull request
This PR proposes to improve the language used in the FFM specification. There
is a relatively small number of corrections.
One peculiarity with the English language is the distinction between "that" (to
be used in a restrictive clause) and "which" (to be used in a non-restrictive
clause). Here
On Tue, 7 Nov 2023 02:10:29 GMT, Erik Gahlin wrote:
> I filed an issue to investigate if there is a problem with SOE, or if the OOM
> check is really needed now. https://bugs.openjdk.org/browse/JDK-8319579
>
> Regardless of outcome, It would be good to document the results of the
>
On Mon, 6 Nov 2023 22:52:50 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
> This PR adds an internal method to calculate hash code from the provided
> integer array, offset and length into that array, and the initial hash code
> value.
>
> Current options for calculating a hash code for int[] are inflexible. It's
> either ArraysSupport.vectorizedHashCode with an
92 matches
Mail list logo
