Re: Integrated: 8319123: Implement JEP 461: Stream Gatherers (Preview)

2023-12-01 Thread Svein Otto Solem
Hi, I did some testing where one gatherer (doNothingReturnTrue) does not handle the downStream.push(element) returning false correctly.  The stream processing is terminated in one case and not in the two other.Especially see the difference between output from handling «efgh» and «EFGH» below. Is

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v3]

2023-12-01 Thread jmehrens
On Thu, 30 Nov 2023 11:12:36 GMT, Sergey Tsypanov wrote: >> It looks like we can skip copying of `byte[]` in >> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in >> `java.io`. >> >> See comment by @vlsi in >>

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v3]

2023-12-01 Thread jmehrens
On Thu, 30 Nov 2023 11:12:36 GMT, Sergey Tsypanov wrote: >> It looks like we can skip copying of `byte[]` in >> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in >> `java.io`. >> >> See comment by @vlsi in >>

Re: RFR: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted [v2]

2023-12-01 Thread jmehrens
On Fri, 1 Dec 2023 23:21:35 GMT, Brian Burkhalter wrote: >> The case of `Channels.newOutputStream(AsynchronousByteChannel)` could be >> handled by changing the return value of that method. For example, >> `sun.nio.ch.Streams` could have a method `OutputStream >> of(AsynchronousByteChannel)`

Integrated: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX

2023-12-01 Thread Leonid Mesnik
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik wrote: > Description of problem and propsed fix from @plummercj > ' > In test/failure_handler/src/share/conf/mac.properties we have: > > process.top.app=top > process.top.args=-l 1 > > So top is run with the "-l 1" args, causing it to do one

Re: RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX

2023-12-01 Thread Jaikiran Pai
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik wrote: > Description of problem and propsed fix from @plummercj > ' > In test/failure_handler/src/share/conf/mac.properties we have: > > process.top.app=top > process.top.args=-l 1 > > So top is run with the "-l 1" args, causing it to do one

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]

2023-12-01 Thread Jaikiran Pai
On Fri, 1 Dec 2023 20:01:42 GMT, Leonid Mesnik wrote: > Technically, the volatile is not enough to avoid racy writing into exitValue. > However, it doesn't affect logic. Agreed. - PR Comment: https://git.openjdk.org/jdk/pull/16919#issuecomment-1836981670

Re: RFR: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted [v2]

2023-12-01 Thread Brian Burkhalter
On Fri, 1 Dec 2023 22:26:51 GMT, Brian Burkhalter wrote: >> I see the problem that unless we have an explicit whitelist, we do open the >> risk of accidentially adding another wrapper stream in future to the JDK >> somewhere and forget to add it to the blacklist. So for safety, I would >>

Re: RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v2]

2023-12-01 Thread Justin Lu
On Fri, 1 Dec 2023 22:16:33 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/MessageFormat.java line 299: >> >>> 297: * the string produced by a {@code ChoiceFormat} in {@code >>> MessageFormat} is >>> 298: * treated as special; occurrences of '{' are used to indicate >>>

Re: RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v3]

2023-12-01 Thread Justin Lu
> Please review this PR which updates an incorrect code example in > _java/text/ChoiceFormat_. > > ChoiceFormat (and MessageFormat) provide an example of how to produce a > pattern that supports singular and plural forms. The ChoiceFormat example is > incorrect, as recursive MessageFormats

Re: RFR: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted [v2]

2023-12-01 Thread Brian Burkhalter
On Fri, 1 Dec 2023 13:46:59 GMT, Markus KARG wrote: >> @bplb You did it right. The reason it works is because the >> ChannelOutputStream is in the "sun." package and not the "java." package. >> That is not the case for Channels.newOutputStream(AsynchronousByteChannel >> ch) as that wrapper

Re: RFR: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted [v2]

2023-12-01 Thread Brian Burkhalter
On Fri, 1 Dec 2023 13:33:01 GMT, Markus KARG wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8321053: Trust non-FilterOutputStreams in "java." packages > >

Re: RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine [v2]

2023-12-01 Thread Iris Clark
On Fri, 1 Dec 2023 21:24:47 GMT, Naoto Sato wrote: >> This is the fix to JLine, which makes it on par with the built-in Console >> fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)). > > Naoto Sato has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8321124: java/util/stream/GatherersTest.java times out [v2]

2023-12-01 Thread Viktor Klang
On Fri, 1 Dec 2023 22:06:14 GMT, Viktor Klang wrote: >> Renames GatherersTest to BuiltInGatherersTest for easier deduplication of >> GathererTest. >> >> Fixes a test ordering issue in testMapConcurrentAPIandContract(). >> >> Adding increased maxOutputSize for Gatherer-related tests to improve

Re: RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v2]

2023-12-01 Thread Naoto Sato
On Fri, 1 Dec 2023 21:53:06 GMT, Justin Lu wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clarify limitations > > src/java.base/share/classes/java/text/MessageFormat.java line 299: > >> 297: * the string produced

Re: RFR: 8321124: java/util/stream/GatherersTest.java times out [v2]

2023-12-01 Thread Viktor Klang
> Renames GatherersTest to BuiltInGatherersTest for easier deduplication of > GathererTest. > > Fixes a test ordering issue in testMapConcurrentAPIandContract(). > > Adding increased maxOutputSize for Gatherer-related tests to improve > debuggability. > > Lowering the composition threshold of

Re: RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v2]

2023-12-01 Thread Justin Lu
On Fri, 1 Dec 2023 21:51:14 GMT, Justin Lu wrote: >> Please review this PR which updates an incorrect code example in >> _java/text/ChoiceFormat_. >> >> ChoiceFormat (and MessageFormat) provide an example of how to produce a >> pattern that supports singular and plural forms. The ChoiceFormat

Re: RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v2]

2023-12-01 Thread Justin Lu
> Please review this PR which updates an incorrect code example in > _java/text/ChoiceFormat_. > > ChoiceFormat (and MessageFormat) provide an example of how to produce a > pattern that supports singular and plural forms. The ChoiceFormat example is > incorrect, as recursive MessageFormats

Re: RFR: JDK-8319626: Override toString() for ZipFile [v7]

2023-12-01 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) > which overrides and provides an implementation of `toString()` in > _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). Justin Lu has updated the pull request incrementally with one additional

Re: RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine [v2]

2023-12-01 Thread Naoto Sato
> This is the fix to JLine, which makes it on par with the built-in Console fix > ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)). Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: moved instance fields at the top of the

Re: RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine [v2]

2023-12-01 Thread Naoto Sato
On Fri, 1 Dec 2023 19:40:39 GMT, Iris Clark wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> moved instance fields at the top of the class > >

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]

2023-12-01 Thread Leonid Mesnik
On Fri, 1 Dec 2023 12:44:17 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change to the test library's >> `OutputAnalyzer` class, which proposes to remove some unnecessary logging >> from the `getExitValue()` call? >> >> As noted in

Re: RFR: 8321131: Console read line with zero out should zero out underlying buffer in JLine

2023-12-01 Thread Iris Clark
On Fri, 1 Dec 2023 18:24:48 GMT, Naoto Sato wrote: > This is the fix to JLine, which makes it on par with the built-in Console fix > ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)). Marked as reviewed by iris (Reviewer).

Re: RFR: 8303866: Allow ZipInputStream.readEnd to parse small Zip64 ZIP files [v8]

2023-12-01 Thread Eirik Bjorsnos
On Wed, 15 Nov 2023 20:10:53 GMT, Eirik Bjorsnos wrote: >> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the >> number of compressed or uncompressed bytes read from the inflater is larger >> than the Zip64 magic value. >> >> While the ZIP format mandates that the data

Re: RFR: JDK-8319626: Override toString() for ZipFile [v6]

2023-12-01 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) > which overrides and provides an implementation of `toString()` in > _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). Justin Lu has updated the pull request incrementally with one additional

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-01 Thread Vicente Romero
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files to JDK 22 b26. looks good to me - Marked

Re: RFR: JDK-8319626: Override toString() for ZipFile [v5]

2023-12-01 Thread Lance Andersen
On Fri, 1 Dec 2023 08:49:34 GMT, Alan Bateman wrote: >> Thanks Jai, that makes sense. Replaced full path with just the base name in >> latest commit. > > I think the second paragraph of the method description is problematic. > Documenting the representation and then saying it is subject to

Re: RFR: 8310644: Make panama memory segment close use async handshakes [v5]

2023-12-01 Thread Uwe Schindler
On Fri, 24 Nov 2023 18:30:17 GMT, Erik Österlund wrote: >> The current logic for closing memory in panama today is susceptible to live >> lock if we have a closing thread that wants to close the memory in a loop >> that keeps failing, and a bunch of accessing threads that want to perform >>

Integrated: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray

2023-12-01 Thread Naoto Sato
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote: > Removing the unnecessary array assignments. This pull request has now been integrated. Changeset: f6be7fdf Author:Naoto Sato URL: https://git.openjdk.org/jdk/commit/f6be7fdf22eede767a0ac29b4f1cb770cfdc0b0f Stats: 8 lines in

Re: RFR: 8320798: Console read line with zero out should zero out underlying buffer [v3]

2023-12-01 Thread Naoto Sato
On Thu, 30 Nov 2023 17:39:30 GMT, Naoto Sato wrote: >> It is best practice to zero out the underlying buffer after use. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > remove ensureOpen() Thanks all for the reviews!

Integrated: 8320798: Console read line with zero out should zero out underlying buffer

2023-12-01 Thread Naoto Sato
On Tue, 28 Nov 2023 19:12:50 GMT, Naoto Sato wrote: > It is best practice to zero out the underlying buffer after use. This pull request has now been integrated. Changeset: d5685629 Author:Naoto Sato URL: https://git.openjdk.org/jdk/commit/d568562966e9a2020704eee3d67b8a106f647d9c

RFR: 8321124: java/util/stream/GatherersTest.java times out

2023-12-01 Thread Viktor Klang
Renames GatherersTest to BuiltInGatherersTest for easier deduplication of GathererTest. Fixes a test ordering issue in testMapConcurrentAPIandContract(). Adding increased maxOutputSize for Gatherer-related tests to improve debuggability. Lowering the composition threshold of

Re: RFR: 8321124: java/util/stream/GatherersTest.java times out

2023-12-01 Thread Viktor Klang
On Fri, 1 Dec 2023 17:00:48 GMT, Viktor Klang wrote: > Renames GatherersTest to BuiltInGatherersTest for easier deduplication of > GathererTest. > > Fixes a test ordering issue in testMapConcurrentAPIandContract(). > > Adding increased maxOutputSize for Gatherer-related tests to improve >

Re: RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX

2023-12-01 Thread Leonid Mesnik
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik wrote: > Description of problem and propsed fix from @plummercj > ' > In test/failure_handler/src/share/conf/mac.properties we have: > > process.top.app=top > process.top.args=-l 1 > > So top is run with the "-l 1" args, causing it to do one

Re: Revisiting JDK-4512189: ZipConstants leaking into public APIs

2023-12-01 Thread Eirik Bjørsnøs
On Tue, Nov 28, 2023 at 6:16 PM Alan Bateman wrote: > This is a JDK 1.1 era mistake. It would a source incompatible change to > "remove" the constants. It would require corpus searches to gauge the > impact. Alan, I've tried to assess the impact by using Github's Code Search. As far as I can

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2023-12-01 Thread Andrew Haley
On Fri, 1 Dec 2023 10:19:01 GMT, Andrew Haley wrote: >> Xiaohong Gong has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >> commits

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2023-12-01 Thread Magnus Ihse Bursie
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

2023-12-01 Thread Magnus Ihse Bursie
On Fri, 1 Dec 2023 16:35:31 GMT, Magnus Ihse Bursie wrote: >> Yes. It still failed. > > You need to expand this logic to cover more instances. See e.g. lib-ffi.m4 > for inspiration. > > Basic flow: > * if user has specified libsleef root with argument, check both lib/ and > lib64/ under that

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

2023-12-01 Thread Magnus Ihse Bursie
On Fri, 1 Dec 2023 10:02:35 GMT, Andrew Haley wrote: >> Did you try to find the libsleef by passing `--with-libsleef=` ? Currently >> `--with-libsleef=` can only work for people manually built from sleef source >> code. > > Yes. It still failed. You need to expand this logic to cover more

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2023-12-01 Thread Magnus Ihse Bursie
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v13]

2023-12-01 Thread Roger Riggs
On Thu, 30 Nov 2023 08:00:12 GMT, Damon Fenacci wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use byte off branches in char_array_compress >> Verified by manual tests with "-XX:AVX3Threshold=0" >> And test in

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v14]

2023-12-01 Thread Claes Redestad
On Thu, 30 Nov 2023 15:51:46 GMT, Roger Riggs wrote: >> Strings, after construction, are immutable but may be constructed from >> mutable arrays of bytes, characters, or integers. >> The string constructors should guard against the effects of mutating the >> arrays during construction that

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2023-12-01 Thread Magnus Ihse Bursie
On Fri, 1 Dec 2023 10:19:01 GMT, Andrew Haley wrote: >> Xiaohong Gong has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >> commits

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-12-01 Thread Viktor Klang
On Fri, 1 Dec 2023 14:30:12 GMT, Christian Stein wrote: >> A trivial fix to ProblemList java/util/stream/GatherersTest.java. > > Seems to be a different issue with "linux-x86" (32-bit host) and > `GathererTest::testMassivelyComposedGatherers`. > >

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v6]

2023-12-01 Thread Markus KARG
On Wed, 29 Nov 2023 22:55:41 GMT, Brian Burkhalter wrote: > > As Alan pointed out, it is a bug (actually even a security risk), so BAIS > > should get fixed, too. > > I am going to file an issue on this. Thank you, I just planned to fix this today when I saw your existing PR!  -

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-12-01 Thread Christian Stein
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/stream/GatherersTest.java. Seems to be a different issue with "linux-x86" (32-bit host) and `GathererTest::testMassivelyComposedGatherers`.

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v2]

2023-12-01 Thread Bernd
On Fri, 1 Dec 2023 14:05:37 GMT, Bernd wrote: >> Did you review if all Java.* streams are safe? >> >> There are a few stream adapters in sun.nio.ch, which would benefit this >> optimization too, unfortunately they wrap the arrays with ByteBuffer.wrap, I >> guess that’s not safe, so the

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v2]

2023-12-01 Thread Vladimir Sitnikov
On Fri, 1 Dec 2023 14:05:37 GMT, Bernd wrote: >> Did you review if all Java.* streams are safe? >> >> There are a few stream adapters in sun.nio.ch, which would benefit this >> optimization too, unfortunately they wrap the arrays with ByteBuffer.wrap, I >> guess that’s not safe, so the

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v2]

2023-12-01 Thread Bernd
On Thu, 30 Nov 2023 09:36:01 GMT, Bernd wrote: >> Sergey Tsypanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8320971: Trust any OutputStream from java.* > > Did you review if all Java.* streams are safe? > > There are a few stream

Re: RFR: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted [v2]

2023-12-01 Thread Markus KARG
On Fri, 1 Dec 2023 04:01:42 GMT, jmehrens wrote: >> I might have done this incorrectly, but with this version of the above >> `wolf` I do not see any corruption: >> >> java.nio.channels.WritableByteChannel wolf = >> new java.nio.channels.WritableByteChannel() { >>

Re: RFR: 8308753: Class-File API transition to Preview [v33]

2023-12-01 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR

Re: RFR: JDK-8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information

2023-12-01 Thread Christoph Langer
On Fri, 1 Dec 2023 13:46:14 GMT, Matthias Baesken wrote: > On Windows we recently run into this error rather often in the test > LdapPoolTimeoutTest.java : > > MSG RTE: javax.naming.CommunicationException: example.com:1234 [Root > exception is java.net.ConnectException: Connection timed out:

RFR: JDK-8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information

2023-12-01 Thread Matthias Baesken
On Windows we recently run into this error rather often in the test LdapPoolTimeoutTest.java : MSG RTE: javax.naming.CommunicationException: example.com:1234 [Root exception is java.net.ConnectException: Connection timed out: no further information] MSG: Connect timed out MSG: Timeout exceeded

Re: RFR: 8321053: Use ByteArrayInputStream.buf directly when parameter of transferTo() is trusted [v2]

2023-12-01 Thread Markus KARG
On Thu, 30 Nov 2023 23:30:20 GMT, Brian Burkhalter wrote: >> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of >> `BAIS.transferTo` only if the target stream is in the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with one >

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-12-01 Thread Adam Sotona
On Wed, 29 Nov 2023 08:46:46 GMT, Per Minborg wrote: >> This is explicit list of supported class file versions, so I don't see any >> other way. > > Would it not be possible to expose an immutable `Map` that > maps from Java version to major class version? This is actually out of scope of

Integrated: 8321130: Microbenchmarks do not build any more after 8254693 on 32 bit platforms

2023-12-01 Thread Jorn Vernee
On Thu, 30 Nov 2023 20:59:01 GMT, Jorn Vernee wrote: > Need to use `jlong_to_ptr` instead of raw cast. > > I've also fixed another latent issue in `CLayouts` where we were initializing > `C_LONG_LONG` with the `long` layout. This was resulting in a class cast > exception when running the

Re: RFR: 8320798: Console read line with zero out should zero out underlying buffer [v3]

2023-12-01 Thread Matthias Baesken
On Thu, 30 Nov 2023 17:39:30 GMT, Naoto Sato wrote: >> It is best practice to zero out the underlying buffer after use. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > remove ensureOpen() Marked as reviewed by mbaesken

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]

2023-12-01 Thread Stefan Karlsson
On Fri, 1 Dec 2023 12:44:17 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change to the test library's >> `OutputAnalyzer` class, which proposes to remove some unnecessary logging >> from the `getExitValue()` call? >> >> As noted in

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]

2023-12-01 Thread Jaikiran Pai
On Fri, 1 Dec 2023 12:09:14 GMT, Stefan Karlsson wrote: >> Hello Stefan, this is just for a tiny optimization to prevent multiple reads >> (in the same thread) on the `volatile` field `processExitCode` in this >> method. > > I don't think such an optimization is needed here. This is not >

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]

2023-12-01 Thread Jaikiran Pai
> Can I please get a review for this change to the test library's > `OutputAnalyzer` class, which proposes to remove some unnecessary logging > from the `getExitValue()` call? > > As noted in https://bugs.openjdk.org/browse/JDK-8321163, right now this > method logs: > > >

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v2]

2023-12-01 Thread Stefan Karlsson
On Fri, 1 Dec 2023 11:14:04 GMT, Jaikiran Pai wrote: >> test/lib/jdk/test/lib/process/OutputBuffer.java line 150: >> >>> 148: @Override >>> 149: public int getExitValue() { >>> 150: Integer exitCode = this.processExitCode; >> >> Do we really need the local `exitCode` variable?

Re: RFR: 8321130: Microbenchmarks do not build any more after 8254693 on 32 bit platforms

2023-12-01 Thread Thomas Schatzl
On Thu, 30 Nov 2023 20:59:01 GMT, Jorn Vernee wrote: > Need to use `jlong_to_ptr` instead of raw cast. > > I've also fixed another latent issue in `CLayouts` where we were initializing > `C_LONG_LONG` with the `long` layout. This was resulting in a class cast > exception when running the

Re: RFR: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better [v2]

2023-12-01 Thread Jim Laskey
On Fri, 1 Dec 2023 11:22:33 GMT, Pavel Rappo wrote: >> Please review this PR to correctly rename "Unnamed Class" to "Implicitly >> Declared Class", not "Implicit Class". >> >> Renaming is fixed where it affects documentation or the end-user. Renaming >> is not fixed where it only affects

Integrated: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better

2023-12-01 Thread Pavel Rappo
On Thu, 30 Nov 2023 15:00:00 GMT, Pavel Rappo wrote: > Please review this PR to correctly rename "Unnamed Class" to "Implicitly > Declared Class", not "Implicit Class". > > Renaming is fixed where it affects documentation or the end-user. Renaming is > not fixed where it only affects code:

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed

2023-12-01 Thread Jaikiran Pai
On Fri, 1 Dec 2023 11:07:06 GMT, Stefan Karlsson wrote: >> Can I please get a review for this change to the test library's >> `OutputAnalyzer` class, which proposes to remove some unnecessary logging >> from the `getExitValue()` call? >> >> As noted in

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v2]

2023-12-01 Thread Jaikiran Pai
On Fri, 1 Dec 2023 11:10:16 GMT, Stefan Karlsson wrote: >> test/lib/jdk/test/lib/process/OutputBuffer.java line 158: >> >>> 156: boolean aborted = true; >>> 157: try { >>> 158: this.processExitCode = exitCode = p.waitFor(); >> >> According to the `waitFor`

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v2]

2023-12-01 Thread Jaikiran Pai
> Can I please get a review for this change to the test library's > `OutputAnalyzer` class, which proposes to remove some unnecessary logging > from the `getExitValue()` call? > > As noted in https://bugs.openjdk.org/browse/JDK-8321163, right now this > method logs: > > >

Re: RFR: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better [v2]

2023-12-01 Thread Pavel Rappo
On Thu, 30 Nov 2023 16:11:01 GMT, Jim Laskey wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove a comment typo introduced in JEP 445 > > LGTM @JimLaskey please re-review this PR due to a newly pushed

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-12-01 Thread Christian Stein
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/stream/GatherersTest.java. Off by one "s"? Or does `java/util/stream/GathererTest` (without "s") fail in addition?

Re: RFR: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better [v2]

2023-12-01 Thread Pavel Rappo
> Please review this PR to correctly rename "Unnamed Class" to "Implicitly > Declared Class", not "Implicit Class". > > Renaming is fixed where it affects documentation or the end-user. Renaming is > not fixed where it only affects code: it's perfectly okay to derive an > internal element name

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed

2023-12-01 Thread Stefan Karlsson
On Fri, 1 Dec 2023 11:09:30 GMT, Stefan Karlsson wrote: >> Can I please get a review for this change to the test library's >> `OutputAnalyzer` class, which proposes to remove some unnecessary logging >> from the `getExitValue()` call? >> >> As noted in

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed

2023-12-01 Thread Stefan Karlsson
On Fri, 1 Dec 2023 09:48:23 GMT, Jaikiran Pai wrote: > Can I please get a review for this change to the test library's > `OutputAnalyzer` class, which proposes to remove some unnecessary logging > from the `getExitValue()` call? > > As noted in https://bugs.openjdk.org/browse/JDK-8321163,

Re: RFR: 8316141: Improve CEN header validation checking

2023-12-01 Thread Eirik Bjorsnos
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote: > Please review this PR which enhances the existing CEN header validation > checking to ensure that the > size of the CEN Header + name length + comment length + extra length do not > exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10,

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2023-12-01 Thread Andrew Haley
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2023-12-01 Thread Andrew Haley
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

2023-12-01 Thread Andrew Haley
On Fri, 1 Dec 2023 01:13:37 GMT, Xiaohong Gong wrote: >> make/autoconf/lib-sleef.m4 line 56: >> >>> 54: AC_MSG_CHECKING([for the specified LIBSLEEF]) >>> 55: if test -e ${with_libsleef}/lib/libsleef.so && >>> 56:test -e ${with_libsleef}/include/sleef.h; then >> >>

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

2023-12-01 Thread Andrew Haley
On Fri, 1 Dec 2023 01:19:12 GMT, Xiaohong Gong wrote: > > Not having a build time dependency on libsleef means you cannot really > > verify that the functions you want to call are correct, but maybe you feel > > secure that they will never change? > > I'm not sure. The main reason that we add

Withdrawn: 8316649: JMX connection timeout cannot be changed and uses the default of 0 (infinite)

2023-12-01 Thread Kevin Walls
On Tue, 21 Nov 2023 17:57:32 GMT, Kevin Walls wrote: > RMI Connections (in general) should use a timeout on the Socket connect call > by default. > > JMX connections use RMI and some connection failures never terminate. The > hang described in 8316649 is hard to reproduce manually: the

Re: RFR: 8316649: JMX connection timeout cannot be changed and uses the default of 0 (infinite)

2023-12-01 Thread Kevin Walls
On Tue, 21 Nov 2023 17:57:32 GMT, Kevin Walls wrote: > RMI Connections (in general) should use a timeout on the Socket connect call > by default. > > JMX connections use RMI and some connection failures never terminate. The > hang described in 8316649 is hard to reproduce manually: the

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

2023-12-01 Thread Andrew Haley
On Fri, 1 Dec 2023 09:59:58 GMT, Andrew Haley wrote: > Not having a build time dependency on libsleef means you cannot really verify > that the functions you want to call are correct, but maybe you feel secure > that they will never change? We can still have SLEEF tests, but they will require

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v5]

2023-12-01 Thread Andrew Haley
On Thu, 30 Nov 2023 14:50:24 GMT, Andrew Haley wrote: >> Do this, but with the name vect_math.S. Don't use SLEEF headers in the >> build. I think you can do this with no build-time dependency on SLEEF at all >> if you load the library lazily at runtime. >> >>

Re: RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX

2023-12-01 Thread Jaikiran Pai
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik wrote: > Description of problem and propsed fix from @plummercj > ' > In test/failure_handler/src/share/conf/mac.properties we have: > > process.top.app=top > process.top.args=-l 1 > > So top is run with the "-l 1" args, causing it to do one

RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed

2023-12-01 Thread Jaikiran Pai
Can I please get a review for this change to the test library's `OutputAnalyzer` class, which proposes to remove some unnecessary logging from the `getExitValue()` call? As noted in https://bugs.openjdk.org/browse/JDK-8321163, right now this method logs: [2023-11-24T11:47:54.557561Z] Waiting

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-01 Thread Alan Bateman
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files to JDK 22 b26. Good good. I assume you'll bump the

Re: RFR: JDK-8319626: Override toString() for ZipFile [v5]

2023-12-01 Thread Alan Bateman
On Thu, 30 Nov 2023 21:08:35 GMT, Justin Lu wrote: >> Hello Justin, >> >>> I am not sure if you have a preference one way or another regarding >>> providing the full path versus just the file name, but I can switch the >>> full path for just the file name if need be. >> >> My opinion is that

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v6]

2023-12-01 Thread Xiaohong Gong
> Currently the vector floating-point math APIs like > `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, > which causes large performance gap on AArch64. Note that those APIs are > optimized by C2 compiler on X86 platforms by calling Intel's SVML code [1]. > To close