On Mon, 4 Dec 2023 20:16:12 GMT, Brian Burkhalter wrote:
>> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
>> `BAIS.transferTo` only if the target stream is in the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
>
On Fri, 1 Dec 2023 16:36:18 GMT, Magnus Ihse Bursie wrote:
>> You need to expand this logic to cover more instances. See e.g. lib-ffi.m4
>> for inspiration.
>>
>> Basic flow:
>> * if user has specified libsleef root with argument, check both lib/ and
>> lib64/ under that root.
>> * if user
> This PR proposes to reject paths provided to the
> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
> in the default file system.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Change @throws
On Tue, 5 Dec 2023 01:48:14 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 15 commits:
>
> - Merge branch 'master' into JDK-8319413
> - Add
On Sat, 2 Dec 2023 20:40:57 GMT, Andrey Turbanov wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update symbol files to JDK 22 b26.
>
> test/langtools/tools/javac/versions/Versions.java line 97:
>
>> 95:
On Wed, 22 Nov 2023 20:48:05 GMT, Viktor Klang wrote:
> We've seen some rare failures of the CLQ Whitebox test on "less-strong"
> architectures, and the only thing which -- given my research -- could be the
> culprit is spuriously failing weakCAS (which is correct in terms of the
>
On Wed, 22 Nov 2023 20:48:05 GMT, Viktor Klang wrote:
> We've seen some rare failures of the CLQ Whitebox test on "less-strong"
> architectures, and the only thing which -- given my research -- could be the
> culprit is spuriously failing weakCAS (which is correct in terms of the
>
On Mon, 4 Dec 2023 21:30:44 GMT, Tom Rodriguez wrote:
> I guess that sort of makes sense. The default timeout factor is 4 I think so
> I guess I descale the existing total wait of 1000 ms so that the total wait
> is now Utils.adjustTimeout(250)? Maybe others might offer an opinion? Since
>
On Mon, 4 Dec 2023 08:31:17 GMT, Xiaohong Gong wrote:
>> The final thing we need to resolve properly is the SVE compiler test.
>>
>> @theRealAph says:
>>> arm_sve.h is part of GCC. It was added to GCC in 2019.
>>
>> A more relevant question is what version of gcc it was added, and if that
>>
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 15 commits:
- Merge branch 'master' into JDK-8319413
- Add symbol files.
- Merge branch 'master' into JDK-8319413
- Merge
On Mon, 4 Dec 2023 22:15:24 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX2 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Fri, 21 Jul 2023 22:40:00 GMT, Brian Burkhalter wrote:
> Limit native memory allocation and move write loop from the native layer into
> Java. This change should make the OOME reported in the issue much less likely.
This pull request has been closed without being integrated.
-
On Mon, 4 Dec 2023 22:15:24 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX2 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Mon, 4 Dec 2023 21:25:41 GMT, Martin Doerr wrote:
> I'd like to clean this up: Use the canonical layouts which are available in
> JDK22. Use try-with-resources for `Arena.ofConfined()`.
Marked as reviewed by jvernee (Reviewer).
-
PR Review:
On Sat, 2 Dec 2023 15:42:18 GMT, fabioromano1 wrote:
>> A faster and simpler way to generate random BigIntegers, avoiding eventually
>> trimming of leading zeros in magnitude array.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x
On Mon, 4 Dec 2023 11:48:44 GMT, Magnus Ihse Bursie wrote:
>>> But you are saying that you want to skip building this library unless you
>>> have a gcc version that supports c++17?
>>>
>> Yes, the request is to skip building the simdsort library if GCC version is
>> < 8 as only GCC >= 8
On Mon, 4 Dec 2023 16:08:32 GMT, Alan Bateman wrote:
> When a virtual thread continues after Thread.yield it currently consumes
> thread's parking permit. This is an oversight, the parking permit should only
> be consumed when continuing after park.
>
> The changes are straight-forward. The
On Mon, 4 Dec 2023 20:08:15 GMT, Alexey Semenyuk wrote:
> 8294699: Launcher causes lingering busy cursor
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16958#pullrequestreview-1763517307
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x
On Wed, 22 Nov 2023 20:48:05 GMT, Viktor Klang wrote:
> We've seen some rare failures of the CLQ Whitebox test on "less-strong"
> architectures, and the only thing which -- given my research -- could be the
> culprit is spuriously failing weakCAS (which is correct in terms of the
>
On Mon, 4 Dec 2023 20:51:20 GMT, Joe Darcy wrote:
>> This slightly increases the wait for reference processing to complete to
>> accommodate long Xcomp compile times. Testing is underway.
>
> test/jdk/java/lang/Object/FinalizationOption.java line 92:
>
>> 90: System.gc();
>> 91:
I'd like to clean this up: Use the canonical layouts which are available in
JDK22. Use try-with-resources for `Arena.ofConfined()`.
-
Commit messages:
- 8321300: Cleanup TestHFA
Changes: https://git.openjdk.org/jdk/pull/16959/files
Webrev:
On Mon, 4 Dec 2023 16:08:32 GMT, Alan Bateman wrote:
> When a virtual thread continues after Thread.yield it currently consumes
> thread's parking permit. This is an oversight, the parking permit should only
> be consumed when continuing after park.
>
> The changes are straight-forward. The
We've seen some rare failures of the CLQ Whitebox test on "less-strong"
architectures, and the only thing which -- given my research -- could be the
culprit is spuriously failing weakCAS (which is correct in terms of the
implementation of CLQ).
After discussion with @DougLea, it was decided as
On Wed, 22 Nov 2023 20:48:05 GMT, Viktor Klang wrote:
> We've seen some rare failures of the CLQ Whitebox test on "less-strong"
> architectures, and the only thing which -- given my research -- could be the
> culprit is spuriously failing weakCAS (which is correct in terms of the
>
On Wed, 22 Nov 2023 20:48:05 GMT, Viktor Klang wrote:
> We've seen some rare failures of the CLQ Whitebox test on "less-strong"
> architectures, and the only thing which -- given my research -- could be the
> culprit is spuriously failing weakCAS (which is correct in terms of the
>
On Mon, 4 Dec 2023 17:46:18 GMT, Tom Rodriguez wrote:
> This slightly increases the wait for reference processing to complete to
> accommodate long Xcomp compile times. Testing is underway.
test/jdk/java/lang/Object/FinalizationOption.java line 92:
> 90: System.gc();
> 91:
On Sat, 2 Dec 2023 15:42:18 GMT, fabioromano1 wrote:
>> A faster and simpler way to generate random BigIntegers, avoiding eventually
>> trimming of leading zeros in magnitude array.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8321053: instanceof -> ==
8294699: Launcher causes lingering busy cursor
-
Commit messages:
- Make sure worker thread terminates before the main thread does.
- 8294699: Launcher causes lingering busy cursor
Changes: https://git.openjdk.org/jdk/pull/16958/files
Webrev:
On Mon, 4 Dec 2023 10:39:05 GMT, Darragh Clarke wrote:
> Updated tests to use vm.flagless as they already ignore Vm flags
Marked as reviewed by lmesnik (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16946#pullrequestreview-1763304819
On Tue, 28 Nov 2023 22:00:33 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions
On Thu, 30 Nov 2023 17:22:49 GMT, Mandy Chung wrote:
>> Happy to change the prefix. Having a (unique) prefix seems useful, though,
>> since it eases filtering. Note: that file is not only there for the hash
>> sums, but also to keep track of the path to the files in the filesystem,
>> which
When a virtual thread continues after Thread.yield it currently consumes
thread's parking permit. This is an oversight, the parking permit should only
be consumed when continuing after park.
The changes are straight-forward. The internal "RUNNABLE" state is replaced
with UNPARKED and YIELDED
On Thu, 30 Nov 2023 19:07:50 GMT, Severin Gehwolf wrote:
>> Yes it's fine. We can wait for more feedback and consider this future
>> enhancement if desirable. I just wanted to understand the reason. Good to
>> add a comment to explain.
>
> Makes sense.
comment added.
-
PR
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8321053: Constrain trusted
On Sat, 2 Dec 2023 03:48:46 GMT, jmehrens wrote:
>> I think that a sufficiently future-proof deny list could be had by changing
>>
>> 211 if (out.getClass().getPackageName().startsWith("java.") &&
>>
>> back to
>>
>> 211 if
On Tue, 28 Nov 2023 23:16:07 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions
On Fri, 1 Dec 2023 18:24:48 GMT, Naoto Sato wrote:
> This is the fix to JLine, which makes it on par with the built-in Console fix
> ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
This pull request has now been integrated.
Changeset: bd04f91e
Author:Naoto Sato
URL:
On Tue, 28 Nov 2023 21:46:58 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions
On Sat, 2 Dec 2023 21:57:01 GMT, Naoto Sato wrote:
>> This is the fix to JLine, which makes it on par with the built-in Console
>> fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 4 Dec 2023 15:34:34 GMT, Eirik Bjorsnos wrote:
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name
This slightly increases the wait for reference processing to complete to
accommodate long Xcomp compile times. Testing is underway.
-
Commit messages:
- 8320198: some reference processing tests don't wait long enough for
reference processing to complete
Changes:
On Mon, 4 Dec 2023 14:58:34 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/invoke/X-VarHandleByteArrayView.java.template
>> line 594:
>>
>>> 592: @ForceInline
>>> 593: static int indexRO(ByteBuffer bb, int index) {
>>> 594: if (bb.isReadOnly())
>>
Please consider this PR which suggests we rename `ZipEntry.extraAttributes` to
`ZipEntry.externalAttributes`.
This field was introduced in
[JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
the name `ZipEntry.posixPerms`.
On Sat, 2 Dec 2023 21:57:01 GMT, Naoto Sato wrote:
>> This is the fix to JLine, which makes it on par with the built-in Console
>> fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the
On Mon, 4 Dec 2023 15:00:56 GMT, Jorn Vernee wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add fail statement
>
> src/java.base/share/classes/java/lang/foreign/SymbolLookup.java line 288:
>
>> 286: *
> Discovered while writing a test for #16513 that
> `ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet
> [JVM
> Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100)
> requires it to be one. This patch adds such a requirement to the
On Mon, 4 Dec 2023 09:10:07 GMT, Per Minborg wrote:
>> This PR proposes to reject paths provided to the
>> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
>> in the default file system.
>
> Per Minborg has updated the pull request incrementally with one additional
On Mon, 4 Dec 2023 14:49:39 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jdk into
>> cleanup/vh-template-share
>>
On Mon, 6 Nov 2023 08:19:19 GMT, Chen Liang wrote:
>> VarHandle implementations have many static fields and methods that can be
>> pulled to the common superclass to avoid repeated initialization and code
>> duplication.
>>
>> In addition, the Unsafe-based Buffer field access are replaced by
> Splits GatherersTest out to distinct files per built-in gatherer
>
> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
> the ProblemList.
>
> Adding increased maxOutputSize for Gatherer-related tests to improve
> debuggability.
>
> Lowering the composition
On Mon, 4 Dec 2023 14:11:34 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to
> Renames GatherersTest to BuiltInGatherersTest for easier deduplication of
> GathererTest.
>
> Fixes a test ordering issue in testMapConcurrentAPIandContract().
>
> Adding increased maxOutputSize for Gatherer-related tests to improve
> debuggability.
>
> Lowering the composition threshold of
On Mon, 4 Dec 2023 13:58:45 GMT, Alan Bateman wrote:
>The backing array is not frozen so a read-only view doesn't address the second
>part of the concern where the target keeps a reference.
The users outside of OpenJDK would not have a reference to `byte[]`.
Do you mean a reference to
On Mon, 4 Dec 2023 13:30:02 GMT, Vladimir Sitnikov
wrote:
> > it doesn't solve the second part of the concern which is read-only view on
> > the internal buffer.
>
> I think `ByteBuffer.asReadOnlyBuffer()` should resolve the issues regarding
> naked byte access. At least `ByteBuffer#array()`
> This update cascades timeouts to trim subsequent workers after the first
> keepAlive inactive period.
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull
On Mon, 4 Dec 2023 13:16:25 GMT, Alan Bateman wrote:
>it doesn't solve the second part of the concern which is read-only view on the
>internal buffer.
I think `ByteBuffer.asReadOnlyBuffer()` should resolve the issues regarding
naked byte access. At least `ByteBuffer#array()` returns `null`
On Thu, 30 Nov 2023 17:24:47 GMT, Brian Burkhalter wrote:
>> What do you think of adding `OutputStream extends WritableByteChannel`, so
>> `transferTo` could be implemented with `if (target instanceof
>> WritableByteChannel) { target.write(ByteBuffer.wrap(buf, off,
>> len).asReadOnly()); }`?
On Mon, 4 Dec 2023 08:31:17 GMT, Xiaohong Gong wrote:
>> The final thing we need to resolve properly is the SVE compiler test.
>>
>> @theRealAph says:
>>> arm_sve.h is part of GCC. It was added to GCC in 2019.
>>
>> A more relevant question is what version of gcc it was added, and if that
>>
On Fri, 1 Dec 2023 16:49:28 GMT, Andrew Haley wrote:
>> Oh, and:
>>
>> If we can't trust SLEEF not to break the ABI we're using, we should not be
>> using SLEEF.
>
>> @theRealAph You are making good points.
>>
>> You are basically saying: "we don't need any configure support for libsleef,
>>
On Thu, 30 Nov 2023 20:19:56 GMT, Srinivas Vamsi Parasa
wrote:
>> Raising the minimum gcc version is not done willy-nilly. (I feel a "You just
>> don't ..." meme coming up)
>>
>> But you are saying that you want to skip building this library unless you
>> have a gcc version that supports
ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an
optional argument and does not respect `ClassFile.ClassHierarchyResolverOption`
of the actual context.
Parsing, building and transforming take options from the actual `ClassFile`
context and verification should follow the
Updated tests to use vm.flagless as they already ignore Vm flags
-
Commit messages:
- ignore vm flags
Changes: https://git.openjdk.org/jdk/pull/16946/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16946=00
Issue: https://bugs.openjdk.org/browse/JDK-8319647
Stats: 14 lines
On Mon, 4 Dec 2023 09:10:07 GMT, Per Minborg wrote:
>> This PR proposes to reject paths provided to the
>> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
>> in the default file system.
>
> Per Minborg has updated the pull request incrementally with one additional
> This PR proposes to reject paths provided to the
> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
> in the default file system.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add fail statement
> This PR proposes to reject paths provided to the
> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
> in the default file system.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Improve after comments
On Sun, 3 Dec 2023 09:50:53 GMT, Alan Bateman wrote:
>> test/jdk/java/util/stream/BuiltInGatherersTest.java line 331:
>>
>>> 329: case Integer n when n ==
>>> config.streamSize - 1 -> {
>>> 330:
On Sun, 3 Dec 2023 09:20:50 GMT, Alan Bateman wrote:
>> test/jdk/java/util/stream/BuiltInGatherersTest.java line 257:
>>
>>> 255: // Test cancellation after exception during processing
>>> 256: // Only use reasonably sized streams to avoid excessive thread
>>> creation
>>> 257:
On Sun, 3 Dec 2023 09:26:45 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Only run the cancellation tests for mapConcurrent for the shorter streams
>> to conserve resources
>
>
On Fri, 1 Dec 2023 16:45:49 GMT, Magnus Ihse Bursie wrote:
> The final thing we need to resolve properly is the SVE compiler test.
>
> @theRealAph says:
>
> > arm_sve.h is part of GCC. It was added to GCC in 2019.
>
> A more relevant question is what version of gcc it was added, and if that
On Wed, 15 Nov 2023 07:48:28 GMT, Eric Liu wrote:
> Vector API defines zero-extend operations [1], which are going to be
> intrinsified and generated to `VectorUCastNode` by C2. This patch adds
> backend implementation for `VectorUCastNode` on AArch64.
>
> The micro benchmark shows
On Fri, 1 Dec 2023 13:46:14 GMT, Matthias Baesken wrote:
> On Windows we recently run into this error rather often in the test
> LdapPoolTimeoutTest.java :
>
> MSG RTE: javax.naming.CommunicationException: example.com:1234 [Root
> exception is java.net.ConnectException: Connection timed out:
On Fri, 1 Dec 2023 13:46:14 GMT, Matthias Baesken wrote:
> On Windows we recently run into this error rather often in the test
> LdapPoolTimeoutTest.java :
>
> MSG RTE: javax.naming.CommunicationException: example.com:1234 [Root
> exception is java.net.ConnectException: Connection timed out:
77 matches
Mail list logo
