Re: RFR: 8320786: Remove ThreadGroup.stop [v2]

2023-12-07 Thread Alan Bateman
> ThreadGroup.stop was deprecated since JDK 1.2, deprecated for removal in Java > 18, and re-specified/degraded to throw UnsupportedOperationException > unconditionally in Java 20. Early in Java 23 seems a fine time to finally > remove this method. Corpus analysis of 176 million classes in 485k

Integrated: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-12-07 Thread Alan Bateman
On Thu, 23 Nov 2023 09:18:44 GMT, Alan Bateman wrote: > The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since > JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to > throw UnsupportedOperationException unconditionally in Java 19/20. Early in > Java

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume [v2]

2023-12-07 Thread Jaikiran Pai
On Fri, 8 Dec 2023 06:39:59 GMT, Alan Bateman wrote: >> The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since >> JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to >> throw UnsupportedOperationException unconditionally in Java 19/20. Early in >>

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume [v2]

2023-12-07 Thread Alan Bateman
> The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since > JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to > throw UnsupportedOperationException unconditionally in Java 19/20. Early in > Java 23 seems a fine time to finally remove these methods. >

Re: RFR: 8310994: Add JFR event for selection operations

2023-12-07 Thread Alan Bateman
On Wed, 22 Nov 2023 12:08:08 GMT, Daniel Fuchs wrote: > It could also be interesting to provide the `timeout` that was given to the > selection operation. I've tried to work through issues, esp. around selector spinning, and being able to distinguish select from selectNow is important for all

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases

2023-12-07 Thread Joe Darcy
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote: > A new paper > > "Accuracy of Mathematical Functions in Single, Double, Double Extended, and > Quadruple Precision" > by Brian Gladman, Vincenzo Innocente and Paul Zimmermann > https://members.loria.fr/PZimmermann/papers/accuracy.pdf > >

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-12-07 Thread Srinivas Vamsi Parasa
On Thu, 7 Dec 2023 22:06:14 GMT, Vladimir Yaroslavskiy wrote: >> > xmlns:o="urn:schemas-microsoft-com:office:office" >> xmlns:x="urn:schemas-microsoft-com:office:excel" >> xmlns="http://www.w3.org/TR/REC-html40;> >> >> >> >> >> >> >

Re: RFR: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable [v2]

2023-12-07 Thread Serguei Spitsyn
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1 > time frame. > It is fixing a deadlock issue between `VirtualThread` class critical sections > with the `interruptLock` (in methods: `unpark()`, `interrupt()`, > `getAndClearInterrupt()`, `threadState()`,

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2023-12-07 Thread Xiaohong Gong
On Thu, 7 Dec 2023 09:30:01 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v12]

2023-12-07 Thread Vladimir Kozlov
On Fri, 8 Dec 2023 00:33:49 GMT, Srinivas Vamsi Parasa wrote: > > Testing have only one failure in closed tests and I need to fix it before > > this can be pushed. > > Thanks Vladimir for the update. Is the test failure because of this PR? Yes. One of our test, which checks integrity of built

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v12]

2023-12-07 Thread Vladimir Kozlov
On Wed, 6 Dec 2023 23:12:13 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX2 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v12]

2023-12-07 Thread Srinivas Vamsi Parasa
On Fri, 8 Dec 2023 00:31:26 GMT, Vladimir Kozlov wrote: > Testing have only one failure in closed tests and I need to fix it before > this can be pushed. Thanks Vladimir for the update. Is the test failure because of this PR? - PR Comment:

Re: RFR: 8321480: ISO 4217 Amendment 176 Update

2023-12-07 Thread Naoto Sato
On Thu, 7 Dec 2023 19:43:14 GMT, Justin Lu wrote: > Please review this PR which incorporates the ISO 4217 Amendment 176 Update. > As the replacement of `ANG` to `XCG` won't occur until 2025, this change does > not need to go into JDK22. `HR` was also updated to remove the past cutover >

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-12-07 Thread Vladimir Yaroslavskiy
On Tue, 28 Nov 2023 00:35:48 GMT, Srinivas Vamsi Parasa wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add @SuppressWarnings (serial) > > xmlns:o="urn:schemas-microsoft-com:office:office" >

Re: RFR: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats [v4]

2023-12-07 Thread Justin Lu
> Please review this PR which updates an incorrect code example in > _java/text/ChoiceFormat_. > > ChoiceFormat (and MessageFormat) provide an example of how to produce a > pattern that supports singular and plural forms. The ChoiceFormat example is > incorrect, as recursive MessageFormats

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-12-07 Thread Srinivas Vamsi Parasa
On Thu, 7 Dec 2023 22:06:14 GMT, Vladimir Yaroslavskiy wrote: >> > xmlns:o="urn:schemas-microsoft-com:office:office" >> xmlns:x="urn:schemas-microsoft-com:office:excel" >> xmlns="http://www.w3.org/TR/REC-html40;> >> >> >> >> >> >> >

RFR: 8321480: ISO 4217 Amendment 176 Update

2023-12-07 Thread Justin Lu
Please review this PR which incorporates the ISO 4217 Amendment 176 Update. As the replacement of `ANG` to `XCG` won't occur until 2025, this change does not need to go into JDK22. `HR` was also updated to remove the past cutover dates. An existing test in _ValidateISO4217.java_ checked that

Integrated: 8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)

2023-12-07 Thread Naoto Sato
On Wed, 6 Dec 2023 21:12:40 GMT, Naoto Sato wrote: > This is an additional fix to JDK-8321131, where more clearing is required in > JLine. This pull request has now been integrated. Changeset: 4ed38f5a Author:Naoto Sato URL:

Re: RFR: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java

2023-12-07 Thread Eirik Bjorsnos
On Thu, 7 Dec 2023 18:14:59 GMT, Lance Andersen wrote: > Eirik, Could you add a reference to [PR > 12959](https://github.com/openjdk/jdk/pull/12959/) or to > [JDK-8303920](https://bugs.openjdk.org/browse/JDK-8303920) in the above Thanks, that makes sense! - PR Comment:

Re: RFR: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java

2023-12-07 Thread Lance Andersen
On Tue, 5 Dec 2023 15:58:14 GMT, Eirik Bjorsnos wrote: > Please review this PR which suggests we retire the ZIP test > `NoExtensionSignature` along with its `test.jar` test vector. > > The concern of a missing data descriptor signature is covered by the recently > updated

Re: RFR: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java

2023-12-07 Thread Eirik Bjorsnos
On Tue, 5 Dec 2023 15:58:14 GMT, Eirik Bjorsnos wrote: > Please review this PR which suggests we retire the ZIP test > `NoExtensionSignature` along with its `test.jar` test vector. > > The concern of a missing data descriptor signature is covered by the recently > updated

Re: RFR: 8320198: some reference processing tests don't wait long enough for reference processing to complete

2023-12-07 Thread Tom Rodriguez
On Thu, 7 Dec 2023 05:18:26 GMT, Jaikiran Pai wrote: >> This slightly increases the wait for reference processing to complete to >> accommodate long Xcomp compile times. Testing is underway. > > test/jdk/java/lang/Object/FinalizationOption.java line 89: > >> 87: static boolean

Integrated: JDK-8319413: Start of release updates for JDK 23

2023-12-07 Thread Joe Darcy
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. This pull request has now been integrated. Changeset: 519ecd35 Author:Joe Darcy Committer: Jesper Wilhelmsson URL:

RFR: 8321396: Retire test/jdk/java/util/zip/NoExtensionSignature.java

2023-12-07 Thread Eirik Bjorsnos
Please review this PR which suggests we retire the ZIP test `NoExtensionSignature` along with its `test.jar` test vector. The concern of a missing data descriptor signature is covered by the recently updated `DataDescriptorSignatureMissing` test. That test is more complete, includes more

Integrated: 8321223: Implementation of Scoped Values (Second Preview)

2023-12-07 Thread Alan Bateman
On Sun, 3 Dec 2023 08:46:07 GMT, Alan Bateman wrote: > This API is sitting out JDK 22, meaning no API/implementation changes in this > PR. Some small API changes are likely for JDK 23. > > For now, we just need to bump JEP number/title that shows up in the preview > section of the javadoc.

Integrated: 8321470: ThreadLocal.nextHashCode can be static final

2023-12-07 Thread Brett Okken
On Wed, 6 Dec 2023 00:52:48 GMT, Brett Okken wrote: > The static AtomicInteger used for the nextHashCode should be final. This pull request has now been integrated. Changeset: c42535f1 Author:Brett Okken Committer: Aleksey Shipilev URL:

Integrated: 8321467: MemorySegment.setString(long, String, Charset) throws IAE(Misaligned access)

2023-12-07 Thread Maurizio Cimadamore
On Wed, 6 Dec 2023 16:49:30 GMT, Maurizio Cimadamore wrote: > This PR fixes a couple of aligned accesses when reading/writing strings. Such > aligned accesses crept in when we optimized string read/write operations to > work in bulk. As a result, depending on the maximum alignment constraints

Re: RFR: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException [v5]

2023-12-07 Thread Maurizio Cimadamore
On Thu, 7 Dec 2023 09:00:46 GMT, Per Minborg wrote: >> This PR proposes to change the exception type for exceptions thrown for >> certain methods with a parameter of type `MemorySegment` when it is >> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException` >> was specified

Integrated: 8321270: Virtual Thread.yield consumes parking permit

2023-12-07 Thread Alan Bateman
On Mon, 4 Dec 2023 16:08:32 GMT, Alan Bateman wrote: > When a virtual thread continues after Thread.yield it currently consumes > thread's parking permit. This is an oversight, the parking permit should only > be consumed when continuing after park. > > The changes are straight-forward. The

Re: RFR: 8321468: Remove StringUTF16::equals

2023-12-07 Thread Claes Redestad
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either

RFR: 8321468: Remove StringUTF16::equals

2023-12-07 Thread Claes Redestad
https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of `StringUTF16::equals`. At the time I did some performance verification focused on x86 showing that simplifying and only using `StringLatin1::equals` was either neutral or a win. I repeated this experiment recently, adding

Re: RFR: 8321470: ThreadLocal.nextHashCode can be static final [v2]

2023-12-07 Thread Aleksey Shipilev
On Wed, 6 Dec 2023 17:42:47 GMT, Brett Okken wrote: >> The static AtomicInteger used for the nextHashCode should be final. > > Brett Okken has updated the pull request incrementally with one additional > commit since the last revision: > > Update full name @bokken, you are good to

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2023-12-07 Thread Magnus Ihse Bursie
On Thu, 7 Dec 2023 09:30:01 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2023-12-07 Thread Xiaohong Gong
> Currently the vector floating-point math APIs like > `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, > which causes large performance gap on AArch64. Note that those APIs are > optimized by C2 compiler on X86 platforms by calling Intel's SVML code [1]. > To close

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v7]

2023-12-07 Thread Xiaohong Gong
On Wed, 6 Dec 2023 11:46:03 GMT, Magnus Ihse Bursie wrote: >> Xiaohong Gong has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add "--with-libsleef-lib" and "--with-libsleef-include" options > > make/modules/jdk.incubator.vector/Lib.gmk

Integrated: JDK-8320538: Obsolete CSS styles in collection framework doc-file

2023-12-07 Thread Hannes Wallnöfer
On Wed, 6 Dec 2023 16:22:24 GMT, Hannes Wallnöfer wrote: > Please review a simple change to remove a stray inline CSS element from the > Collection Framework index doc file. The only thing the `a {font-weight: > bold;}` rule did was to make all links in the header and footer bold as [can > be

Re: RFR: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException [v5]

2023-12-07 Thread Per Minborg
> This PR proposes to change the exception type for exceptions thrown for > certain methods with a parameter of type `MemorySegment` when it is > `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException` > was specified but in some cases, in reality, an

Re: RFR: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException [v3]

2023-12-07 Thread Per Minborg
On Wed, 6 Dec 2023 15:36:57 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update throws docs fror SegmentAllocator > > src/java.base/share/classes/java/lang/foreign/SegmentAllocator.java

Re: RFR: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException [v4]

2023-12-07 Thread Per Minborg
> This PR proposes to change the exception type for exceptions thrown for > certain methods with a parameter of type `MemorySegment` when it is > `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException` > was specified but in some cases, in reality, an