On Mon, 29 Jan 2024 16:57:00 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib) has
> released Zlib 1.3.1 on January 24, 2024.
>
> There are a [small number of
On Mon, 4 Dec 2023 15:34:34 GMT, Eirik Bjørsnøs wrote:
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name
On Mon, 4 Dec 2023 15:34:34 GMT, Eirik Bjørsnøs wrote:
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name
On Mon, 29 Jan 2024 14:31:10 GMT, Andrew Dinn wrote:
> > Bytecode transformation should not be rocket science, but it progressively
> > is developing in that direction.
>
> Hmm? Bytecode transformation of the JDK runtime implementation is a lot more
> complicated than your comments seem to
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
The implementation of method `VectorSpecies::fromMemorySegment`, in
`AbstractSpecies::fromMemorySegment`, neglects to perform bounds checks on the
offset argument when the method is compiled by C2 (bounds checks are performed
when interpreted and by C1).
This is an oversight and explicit
On Fri, 26 Jan 2024 18:02:58 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request
> Currently String::translateEscapes does not support unicode escapes, reported
> as a IllegalArgumentException("Invalid escape sequence: ...").
> String::translateEscapes should translate unicode escape sequences to provide
> full coverage,
Jim Laskey has updated the pull request
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote:
>> Currently String::translateEscapes does not support unicode escapes,
>> reported as a IllegalArgumentException("Invalid escape sequence: ...").
>> String::translateEscapes should translate unicode escape sequences to
>> provide full
On Mon, 29 Jan 2024 17:22:07 GMT, Per Minborg wrote:
>> Correct. Additional logic is needed to form a correct C syntax. It would be
>> possible to provide a method that does this.
>
> We could add such a method under another issue
> (https://bugs.openjdk.org/browse/JDK-8323746) because it will
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote:
>> Currently String::translateEscapes does not support unicode escapes,
>> reported as a IllegalArgumentException("Invalid escape sequence: ...").
>> String::translateEscapes should translate unicode escape sequences to
>> provide full
On Mon, 29 Jan 2024 14:03:42 GMT, Per Minborg wrote:
>> This PR proposes to remove the snippet files in
>> `java/lang/foreign/snippet-files` from the build.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Correct path to
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote:
>> Currently String::translateEscapes does not support unicode escapes,
>> reported as a IllegalArgumentException("Invalid escape sequence: ...").
>> String::translateEscapes should translate unicode escape sequences to
>> provide full
On Mon, 29 Jan 2024 17:15:25 GMT, Alan Bateman wrote:
> @LanceAndersen Can you confirm that there are no changes to the 1.3..1.3.1
> diffs?
@AlanBateman, yes that is correct, there are no OpenJDK specific changes, it is
a straight port of the zlib 1.3.1 changes to our implementation
> This PR proposes to add an improved Improve
> `LayoutPath.PathElement::toString` method simplifying debugging.
>
> Opinions and suggestions for `static PathElement sequenceElement(long start,
> long step)` are welcome.
Per Minborg has updated the pull request with a new target base due to a
On Tue, 16 Jan 2024 09:10:04 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 958:
>>
>>> 956: return new
>>> LayoutPath.PathElementImpl(PathKind.DEREF_ELEMENT,
>>> 957: LayoutPath::derefElement,
>>> 958:
On Mon, 29 Jan 2024 16:57:00 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib) has
> released Zlib 1.3.1 on January 24, 2024.
>
> There are a [small number of
On Mon, 29 Jan 2024 16:57:00 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib) has
> released Zlib 1.3.1 on January 24, 2024.
>
> There are a [small number of
On Fri, 26 Jan 2024 16:40:32 GMT, Coleen Phillimore wrote:
> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
> native code. This didn't attempt to change NULL in comments to say null
> because nullptr is generally the right thing for the comment to say. It does
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote:
>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
>> native code. This didn't attempt to change NULL in comments to say null
>> because nullptr is generally the right thing for the comment to say. It
>>
Hi all,
Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
The [Zlib Data Compression Library](https://github.com/madler/zlib) has
released Zlib 1.3.1 on January 24, 2024.
There are a [small number of
updates](https://github.com/madler/zlib/compare/v1.3.1..v1.3) between 1.3
On Fri, 26 Jan 2024 18:02:58 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote:
>> Currently String::translateEscapes does not support unicode escapes,
>> reported as a IllegalArgumentException("Invalid escape sequence: ...").
>> String::translateEscapes should translate unicode escape sequences to
>> provide full
On Sat, 27 Jan 2024 05:11:28 GMT, Alexander Kriegisch wrote:
> Bytecode transformation should not be rocket science, but it progressively is
> developing in that direction.
Hmm? Bytecode transformation of the JDK runtime implementation is a lot more
complicated than your comments seem to
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter
wrote:
>> To allow agents the definition of auxiliary classes, an API is needed to
>> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or
>> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote:
>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
>> native code. This didn't attempt to change NULL in comments to say null
>> because nullptr is generally the right thing for the comment to say. It
>>
On Sun, 28 Jan 2024 22:33:01 GMT, Rafael Winterhalter
wrote:
> What stops people from supplying a fake instance? Wouldn't you need to "test
> run" the instance first?
Not necessarily. When the generated API implementation relies on the
capabilities of class `Instrumentation` -- such as
On Mon, 29 Jan 2024 14:09:40 GMT, Andrew Dinn wrote:
> What stops people from supplying a fake instance? Wouldn't you need to "test
> run" the instance first?
In passing, Instrumentation was a candidate to be sealed at one point as the
only implementations should be in the java.instrument
> This PR proposes to remove the snippet files in
> `java/lang/foreign/snippet-files` from the build.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Correct path to excluded directory
-
Changes:
- all:
On Mon, 15 Jan 2024 13:27:25 GMT, Magnus Ihse Bursie wrote:
>> If possible, we should simply exclude all files in directories that have `-`
>> (minus sign) in their name; this is the intentional design to prevent javac
>> from compiling those classes as package names cannot include `-`.
>
> I
> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
> native code. This didn't attempt to change NULL in comments to say null
> because nullptr is generally the right thing for the comment to say. It does
> attempt to change NULL to "null" rather than "nullptr" in
On Sun, 28 Jan 2024 00:57:24 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright year
>> - Add test for zero-out
>
> test/jdk/java/foreign/TestScope.java line 150:
>
>> 148: }
>>
33 matches
Mail list logo
