On Mon, 19 Feb 2024 05:52:22 GMT, Varada M wrote:
> DeCapo Benchmark Results (3 runs) :
>
> Before :
> = DaCapo 9.12 h2 PASSED in 281402 msec =
> = DaCapo 9.12 h2 PASSED in 269818 msec =
> = DaCapo 9.12 h2 PASSED in 279279 msec =
>
> After:
> = DaCapo 9.12 h2
On Mon, 19 Feb 2024 20:55:06 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which proposes that we officially deprecate the
>> following four methods in the `java.util.zip` package:
>>
>> * `Inflater.getTotalIn()`
>> * `Inflater.getTotalOut()`
>> * `Deflater.getTotalIn()`
>> *
On Mon, 19 Feb 2024 20:55:06 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which proposes that we officially deprecate the
>> following four methods in the `java.util.zip` package:
>>
>> * `Inflater.getTotalIn()`
>> * `Inflater.getTotalOut()`
>> * `Deflater.getTotalIn()`
>> *
On Mon, 19 Feb 2024 15:42:05 GMT, Christian Stein wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
On Wed, 14 Feb 2024 11:03:07 GMT, Christian Stein wrote:
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
>
On Mon, 19 Feb 2024 05:52:22 GMT, Varada M wrote:
> DeCapo Benchmark Results (3 runs) :
>
> Before :
> = DaCapo 9.12 h2 PASSED in 281402 msec =
> = DaCapo 9.12 h2 PASSED in 269818 msec =
> = DaCapo 9.12 h2 PASSED in 279279 msec =
>
> After:
> = DaCapo 9.12 h2
On Mon, 19 Feb 2024 15:42:05 GMT, Christian Stein wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
I hereby nominate Viktor Klang [6] to Membership in the Core Libraries Group
[4].
Viktor has been a member of the Java team in Oracle since 2022, and he is currently
a Committer on the JDK project. Viktor has led JEP 461 [1], an enhancement to the
Streams API to support new intermediate
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes wrote:
> Please reviews these manpage updates in relation to "JEP 458: Launch
> Multi-File Source-Code Programs". The manpage sources had previously been
> updated internally at Oracle under JDK-8322478, but the open troff file was
> not
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes wrote:
> Please reviews these manpage updates in relation to "JEP 458: Launch
> Multi-File Source-Code Programs". The manpage sources had previously been
> updated internally at Oracle under JDK-8322478, but the open troff file was
> not
> Please review this PR which proposes that we officially deprecate the
> following four methods in the `java.util.zip` package:
>
> * `Inflater.getTotalIn()`
> * `Inflater.getTotalOut()`
> * `Deflater.getTotalIn()`
> * `Deflater.getTotalOut()`
>
> Since these legacy methods return `int`, they
On Mon, 19 Feb 2024 18:35:58 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which proposes that we officially deprecate the
> following four methods in the `java.util.zip` package:
>
> * `Inflater.getTotalIn()`
> * `Inflater.getTotalOut()`
> * `Deflater.getTotalIn()`
> *
Please review this PR which proposes that we officially deprecate the following
four methods in the `java.util.zip` package:
* `Inflater.getTotalIn()`
* `Inflater.getTotalOut()`
* `Deflater.getTotalIn()`
* `Deflater.getTotalOut()`
Since these legacy methods return `int`, they cannot safely
On Fri, 16 Feb 2024 10:27:11 GMT, Christoph Langer wrote:
>> During analysing a customer case I figured out that we have an inconsistency
>> between documentation and actual behavior in class
>> com.sun.jndi.ldap.Connection. The [method documentation of
>>
Hi Viktor,
may I add one option to your evaluation?
@@ -1506,14 +1506,15 @@ public ConditionObject() { }
private void doSignal(ConditionNode first, boolean all) {
while (first != null) {
ConditionNode next = first.nextWaiter;
On Fri, 16 Feb 2024 10:27:11 GMT, Christoph Langer wrote:
>> During analysing a customer case I figured out that we have an inconsistency
>> between documentation and actual behavior in class
>> com.sun.jndi.ldap.Connection. The [method documentation of
>>
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
>
On Thu, 15 Feb 2024 08:53:12 GMT, Alan Bateman wrote:
>> `String jarname` is filled by the caller with the value of `String what`,
>> and therefore contains the entire path to the executable JAR file. Using
>> only `jarFile.getName()` will prevent any parent directories from being
>> noted in
On Mon, 19 Feb 2024 15:42:05 GMT, Christian Stein wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
> it hasn't to be re-opened.
Christian Stein has updated
On Mon, 15 Jan 2024 02:30:39 GMT, ExE Boss wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge branch 'master' into fix/typearg-model
>> - redundant line
>> - Fix a test in
On Mon, 19 Feb 2024 07:32:31 GMT, Jaikiran Pai wrote:
> Both the files will need a copyright year update.
Right. Updating both files.
> The JBS issue would need an appropriate noreg label too
> https://openjdk.org/guide/#noreg
Added `noreg-cleanup` to the issue.
-
PR Comment:
On Mon, 19 Feb 2024 10:41:03 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 821:
>>
>>> 819: // In LM_JAR mode, put the underlying file in the
>>> JarFile/ZipFile cache.
>>> 820: // This will avoid needing to re-parse the manifest
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests
On Tue, 14 Mar 2023 02:43:41 GMT, Chen Liang wrote:
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One
On Sun, 17 Dec 2023 23:11:10 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>>
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests
On Mon, 19 Feb 2024 08:19:58 GMT, Per Minborg wrote:
> This PR proposes to add an offset parameter for a `VarHandle` invocation in
> the Javadoc snippet for `Linker.Option.captureCallState()`. The offset
> parameter was added in 22 but it was forgotten to add it in said Javadoc.
This pull
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests
On Fri, 16 Feb 2024 10:27:11 GMT, Christoph Langer wrote:
>> During analysing a customer case I figured out that we have an inconsistency
>> between documentation and actual behavior in class
>> com.sun.jndi.ldap.Connection. The [method documentation of
>>
On Mon, 19 Feb 2024 08:19:58 GMT, Per Minborg wrote:
> This PR proposes to add an offset parameter for a `VarHandle` invocation in
> the Javadoc snippet for `Linker.Option.captureCallState()`. The offset
> parameter was added in 22 but it was forgotten to add it in said Javadoc.
Marked as
On Fri, 16 Feb 2024 10:27:11 GMT, Christoph Langer wrote:
>> During analysing a customer case I figured out that we have an inconsistency
>> between documentation and actual behavior in class
>> com.sun.jndi.ldap.Connection. The [method documentation of
>>
Hi Frank,
We'll see what the option are.
Cheers,
√
Viktor Klang
Software Architect, Java Platform Group
Oracle
From: Frank Kretschmer
Sent: Sunday, 18 February 2024 15:36
To: Jaikiran Pai ; Viktor Klang
; Java Core Libs
Subject: [External] : Re: OpenJDK
On Mon, 19 Feb 2024 10:30:24 GMT, Sean Coffey wrote:
> Nice improvement to have. would it be ok to pad out this comment a bit more ?
> I found it difficult to understand the specifics. Perhaps :
>
> ```
> // In LM_JAR mode, keep the underlying file open to retain it
> in
>
On Thu, 15 Feb 2024 06:29:24 GMT, Christian Stein wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes wrote:
> Please reviews these manpage updates in relation to "JEP 458: Launch
> Multi-File Source-Code Programs". The manpage sources had previously been
> updated internally at Oracle under JDK-8322478, but the open troff file was
> not
> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and will
> thus fall back to slower default method of `List.sort()` instead of sorting a
> range of the array in-place in its backing root `ArrayList`.
>
> This doesn't change observable behavior, so haven't added tests,
On Mon, 19 Feb 2024 09:34:12 GMT, Jaikiran Pai wrote:
> Can I get a review of this change which fixes the copyright header on
> `DeflaterDictionaryTests.java`?
Thanks for spotting this, looks good to me! Would be nice if jcheck could check
simple formatting issues like this.
-
On Mon, 19 Feb 2024 09:34:12 GMT, Jaikiran Pai wrote:
> Can I get a review of this change which fixes the copyright header on
> `DeflaterDictionaryTests.java`?
Ship it.
-
Marked as reviewed by tschatzl (Reviewer).
PR Review:
On Mon, 19 Feb 2024 09:34:12 GMT, Jaikiran Pai wrote:
> Can I get a review of this change which fixes the copyright header on
> `DeflaterDictionaryTests.java`?
Thank you Eirik and Thomas for the reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/17911#issuecomment-1952086875
On Mon, 19 Feb 2024 09:34:12 GMT, Jaikiran Pai wrote:
> Can I get a review of this change which fixes the copyright header on
> `DeflaterDictionaryTests.java`?
This pull request has now been integrated.
Changeset: b3664927
Author:Jaikiran Pai
URL:
> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and will
> thus fall back to slower default method of `List.sort()` instead of sorting a
> range of the array in-place in its backing root `ArrayList`.
>
> This doesn't change observable behavior, so haven't added tests,
On Mon, 19 Feb 2024 07:18:53 GMT, Jaikiran Pai wrote:
> Hello Eirik, the change looks OK to me.
Thanks for veryfying and adding helpful context!
I'll let this linger just a bit before integrating in case there is any
non-correctness feedback, like about the added comment to clarify the modulo
Can I get a review of this change which fixes the copyright header on
`DeflaterDictionaryTests.java`?
-
Commit messages:
- 8326152: Bad copyright header in
test/jdk/java/util/zip/DeflaterDictionaryTests.java
Changes: https://git.openjdk.org/jdk/pull/17911/files
Webrev:
On Sat, 17 Feb 2024 13:00:08 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only cleanup PR in preparation for deprecating
> `Deflater.getTotalOut()` in JDK-8326096.
>
> This PR replaces various calls
> in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to
>
On Wed, 31 Jan 2024 08:13:25 GMT, Matthias Baesken wrote:
> Can we maybe see if we can fix these tests without exclusive-accessing them?
> I find it surprising that `java/lang/StringBuilder` tests are problematic,
> but `java/lang/StringBuffer` tests are not. Which tests fail?
What do you
This PR proposes to add an offset parameter for a `VarHandle` invocation in the
Javadoc snippet for `Linker.Option.captureCallState()`. The offset parameter
was added in 22 but it was forgotten to add it in said Javadoc.
-
Commit messages:
- Add offset parameter to VarHandle
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes wrote:
> Please reviews these manpage updates in relation to "JEP 458: Launch
> Multi-File Source-Code Programs". The manpage sources had previously been
> updated internally at Oracle under JDK-8322478, but the open troff file was
> not
On Sun, 18 Feb 2024 10:56:47 GMT, Eirik Bjørsnøs wrote:
> Thanks for your review Alan!
>
> > The hazard when the format specifiers are all %s.
>
> Not sure I understand your comment since all arguments are of the same type
> (int) anyhow, I guess they would still be easy to get wrong or in
On Sun, 18 Feb 2024 10:56:03 GMT, Eirik Bjørsnøs wrote:
>> Please review this test-only cleanup PR in preparation for deprecating
>> `Deflater.getTotalOut()` in JDK-8326096.
>>
>> This PR replaces various calls
>> in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to
>>
52 matches
Mail list logo
