On Sun, 10 Mar 2024 05:50:33 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes the 19 deprecated `xxObject*` alias
> methods from `jdk.internal.misc.Unsafe`.
>
> These methods were added in JDK-8213043 (JDK 12), presumably to allow
> `jsr166.jar` to be used across JDK versions.
On Sun, 10 Mar 2024 05:50:33 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes the 19 deprecated `xxObject*` alias
> methods from `jdk.internal.misc.Unsafe`.
>
> These methods were added in JDK-8213043 (JDK 12), presumably to allow
> `jsr166.jar` to be used across JDK versions.
Please review this PR which removes the 19 deprecated `xxObject*` alias methods
from `jdk.internal.misc.Unsafe`.
These methods were added in JDK-8213043 (JDK 12), presumably to allow
`jsr166.jar` to be used across JDK versions. This was a follow-up fix after
JDK-8207146 had renamed these
The class is used in java.lang.invoke.MethodType but add is not used.
> On Mar 9, 2024, at 11:42 AM, Chen Liang wrote:
>
> On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>
>>> Currently, add is returning intern(e) == null which will always be false.
>>> The correct test is intern(e)
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request incrementally with one additional
>
> Date.toString() uses Locale.US explicitly for printing the time zone, so
> replace Locale.ROOT to Locale.US in this testcase for fix the test failure.
>
> This testcase fixed has been verified.
>
> Only change the testcase, risk is low.
SendaoYan has updated the pull request incrementally
On Fri, 8 Mar 2024 17:29:09 GMT, Naoto Sato wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the Locale.US code comment
>>
>> Signed-off-by: sendaoYan
>
>
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
src/java.base/share/classes/java/text/package-info.java line 29:
> 27: * Provides classes and interfaces for handling text, dates, numbers,
> 28: * and messages in a manner
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
Marked as reviewed by gli (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1926166255
On Fri, 8 Mar 2024 16:47:33 GMT, Magnus Ihse Bursie wrote:
> What is the rationale for introducing a special configure flag for this
> functionality? I've tried to look though all comments in this PR, and read
> the JBS issue and CSR, but I have not found any motivation for this. I'm
> sorry
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request incrementally with one additional
>
11 matches
Mail list logo
