On Wed, 13 Mar 2024 15:43:25 GMT, Joe Darcy wrote:
>> Relying on the upper bounds check of `charAt` doesn't work well with the
>> `CharArraySequence` whose `charAt` deliberately does not throw an IIOBE if
>> the array is longer than the provided length, ie, it'll look at chars beyond
>> the
On Thu, 14 Mar 2024 17:35:22 GMT, Mandy Chung wrote:
> Trivial fix. Improve the error message to print the cause of the module
> resolution failure if present.
Hello Mandy, this change to use the underlying cause of `ResolutionExcepion`
and `FindException` when reporting the error message,
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
Dan Lutker has updated the pull request incrementally with one additional
commit since the last revision:
Fix
On Tue, 13 Feb 2024 22:02:15 GMT, Roger Riggs wrote:
>> Any reason not to use
>> [exesanity_SimpleNativeLauncher](https://github.com/openjdk/jdk/blob/628cd8a489fd54db18204c3bbaf4339d7ab5e9d6/test/jdk/native_sanity/simplenativelauncher/exesanity_SimpleNativeLauncher.c)
>> or
>>
> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
Dan Lutker has updated the pull request incrementally with two additional
commits since the last revision:
-
On Thu, 7 Mar 2024 17:38:24 GMT, Christoph Langer wrote:
>> src/java.naming/share/classes/module-info.java line 42:
>>
>>> 40: * The value of this environment property specifies the
>>> fully
>>> 41: * qualified class name of the socket factory used by the LDAP
>>> provider.
> During analysing a customer case I figured out that we have an inconsistency
> between documentation and actual behavior in class
> com.sun.jndi.ldap.Connection. The [method documentation of
>
On Thu, 14 Mar 2024 20:54:32 GMT, Mandy Chung wrote:
> About the configure options,
>
> ```
> --enable-keep-packaged-modules
> enable keeping of packaged modules in jdk image
> [enabled]
> --enable-runtime-link-image
> enable producing an
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
This PR is a redesign of subtype checking.
The implementation of subtype checking in the HotSpot JVM is now twenty years
old. There have been some performance-related bugs reported, and the only way
to fix them is a redesign of the way it works.
So what's changed, so that the old design
On Wed, 13 Mar 2024 19:53:40 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes to MBeanServerFileAccessController.java
>
>
On Thu, 14 Mar 2024 14:27:47 GMT, Severin Gehwolf wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in autoconf file
>
> make/Images.gmk line 33:
>
>> 31: include Modules.gmk
>> 32: include Utils.gmk
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
Trivial fix. Improve the error message to print the cause of the module
resolution failure if present.
-
Commit messages:
- 8326979: (jdeps) improve the error message for FindException caused by
InvalidModuleDescriptorException
Changes:
On Thu, 14 Mar 2024 14:24:57 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 27 Feb 2024 22:04:47 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/autoconf/jdk-options.m4 line 596:
>
>> 594:
>>
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory
On Tue, 12 Mar 2024 14:07:32 GMT, Magnus Ihse Bursie wrote:
>> I don't see a race. The `rm` was there in the original code and is no
>> scarier in the modified version. The jdk image is constructed by a
>> combination of targets and recipes. The first one to run has to be jlink,
>> then we
On Fri, 8 Mar 2024 17:25:18 GMT, Severin Gehwolf wrote:
>> make/Images.gmk line 96:
>>
>>> 94:
>>> 95: ifeq ($(JLINK_KEEP_PACKAGED_MODULES), true)
>>> 96: ifeq ($(JLINK_PRODUCE_RUNTIME_LINK_JDK), true)
>>
>> I don't get it. Why don't you use the JDK_LINK_OUTPUT_DIR from just above?
>
>
On Tue, 27 Feb 2024 22:06:12 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/autoconf/spec.gmk.template line 904:
>
>> 902:
On Fri, 8 Mar 2024 19:49:19 GMT, Mandy Chung wrote:
>>> > @AlanBateman @mlchung I've now pushed an update of this patch which now
>>> > uses a build-time approach as discussed elsewhere. In order to produce a
>>> > linkable runtime JDK image, one needs to set --enable-runtime-link-image
>>> >
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory
> Can I please get a review of this test-only change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8328066?
>
> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
> the failure was observed on linux-86 instance on a GitHub jobs run.
>
> The commit in
On Thu, 14 Mar 2024 12:15:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8328066?
>>
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
>> the failure was observed
On Mon, 11 Mar 2024 17:46:14 GMT, Chad Rakoczy wrote:
> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>
> Updates jspawnhelper to check that JDK version and jspawnhelper version are
> the same. Updates test to include check for version. Also tested manually by
> replacing
On Wed, 13 Mar 2024 17:11:25 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>>
We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
`CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
These flag variables contain a lot of duplication.
The first step towards
On Thu, 14 Mar 2024 12:36:05 GMT, Magnus Ihse Bursie wrote:
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
> in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These
> Can I please get a review of this test-only change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8328066?
>
> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
> the failure was observed on linux-86 instance on a GitHub jobs run.
>
> The commit in
On Thu, 14 Mar 2024 04:11:14 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8328066?
>
> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
> the failure was observed on
On Thu, 14 Mar 2024 04:11:14 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8328066?
>
> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue,
> the failure was observed on
We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE is
C++. We should do this automatically in SetupJdkLibrary for C++ linking.
I also removed the superfluous `-lc` from some places where it had been added.
-
Commit messages:
- 8328146: Set LIBCXX
Allow support for both .a and .so files in AIX.
If .so file is not found, allow fallback to .a extension.
JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
-
Commit messages:
- Add support for AIX dynamic libraries in Class Loader
Changes:
On Wed, 13 Mar 2024 21:07:54 GMT, Christoph Langer wrote:
>> 4f336085d1098e7fba7b58f0a73c028179a2a13d
>> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
>> cases to test java/util/Formatter/Padding.java with huge Strings as
>> arguments. Since all possible argument
On Fri, 1 Mar 2024 15:10:30 GMT, Magnus Ihse Bursie wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix potential attribute issue
>
> Iirc, your assessment is right; the code should be ready for integration; I
>
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests
On Tue, 12 Mar 2024 18:42:48 GMT, Erik Joelsson wrote:
>> Chad Rakoczy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code cleanup
>
> I'm fine with just using VERSION_FEATURE. I think it's a simple and
> straightforward enough
On Thu, 25 Jan 2024 21:35:45 GMT, Sergey wrote:
> The feature allows to extract a private field value in a single expression,
> like so:
>
> object.getClass().getDeclaredField().setAccessible().get(object)
I'm sorry to hear this. It's done all the time in tests, by third-party
libraries. I
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Korov has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin
42 matches
Mail list logo
