> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
On Thu, 22 Feb 2024 03:15:10 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Fri, 22 Mar 2024 19:56:30 GMT, Martin Doerr wrote:
> The symbols get found and the JVM can really call into the
> `libclang.a(libclang.so.16)`. Impressive! (That doesn't mean that jextract is
> working. clang crashes the way we are calling it. Maybe because of a thread
> stack size or
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
> parsing for NumberFormat.
>
> The concrete subclasses that will utilize this leniency value are
> `DecimalFormat` and `CompactNumberFormat`. Strict leniency allows for parsing
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Fri, 22 Mar 2024 16:53:58 GMT, Martin Doerr wrote:
> In case of jextract (jdk22 branch), we would then need something like the
> following if we want AIX to behave like the other platforms?
>
> ```
> diff --git a/src/main/java/org/openjdk/jextract/clang/libclang/Index_h.java
>
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti
wrote:
> Make use of an unused local variable probably intended to replace later casts.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-1955535154
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti
wrote:
> Make use of an unused local variable probably intended to replace later casts.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-1955528280
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti
wrote:
> Make use of an unused local variable probably intended to replace later casts.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-1955519288
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti
wrote:
> Make use of an unused local variable probably intended to replace later casts.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-195551
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti
wrote:
> Make use of an unused local variable probably intended to replace later casts.
Marked as reviewed by redestad (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-1955510870
Make use of an unused local variable probably intended to replace later casts.
-
Commit messages:
- 8328700: Unused import and variable should be deleted in regex package
Changes: https://git.openjdk.org/jdk/pull/18460/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18460=00
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Tue, 27 Feb 2024 16:28:26 GMT, Nizar Benalla wrote:
> # Issue
> - JDK-8326853 Incorrect `@since` Tags for Charset Related Methods Added in
> JDK 10
>
> I changed the `@since` tags to better accurately show when the methods and
> constructors were introduced.
This pull request has now been
On Fri, 22 Mar 2024 15:18:29 GMT, Jesper Wilhelmsson
wrote:
> Updated and moved the license file.
This pull request has now been integrated.
Changeset: ce7ebaa6
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/ce7ebaa606f96fdfee66d300b56022d9903b5ae3
Stats: 4
On Fri, 22 Mar 2024 15:18:29 GMT, Jesper Wilhelmsson
wrote:
> Updated and moved the license file.
Looks good.
Lois
-
Marked as reviewed by lfoltan (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18455#pullrequestreview-1955180960
On Thu, 21 Mar 2024 16:50:31 GMT, Justin Lu wrote:
>> Thank you justin
>
> Hi @nizarbenalla , you can comment `/integrate` whenever you're ready, and we
> can sponsor the change to have it integrated.
@justin-curtis-lu I realized there is a small issue with the commit message
8326853: Missing
Updated and moved the license file.
-
Commit messages:
- 8328812: Update and move siphash license
Changes: https://git.openjdk.org/jdk/pull/18455/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18455=00
Issue: https://bugs.openjdk.org/browse/JDK-8328812
Stats: 4 lines in
On Fri, 22 Mar 2024 14:53:17 GMT, Martin Doerr wrote:
> Only the Java developer can select the right member.
Right, and I think this problem is isomporphic to the problem we have in Linux
distros of selecting between libclang.so.1 and libclang.so.2.
`System::loadLibrary` cannot do it. So, I
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Mon, 11 Mar 2024 16:55:36 GMT, Severin Gehwolf wrote:
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu
On Wed, 20 Mar 2024 18:04:50 GMT, Nizar Benalla wrote:
>> # Issue
>> - JDK-8326853 Incorrect `@since` Tags for Charset Related Methods Added in
>> JDK 10
>>
>> I changed the `@since` tags to better accurately show when the methods and
>> constructors were introduced.
>
> Nizar Benalla has
On Thu, 21 Mar 2024 22:04:28 GMT, Maurizio Cimadamore
wrote:
> This problem seems relatively similar to what happens for versioned library
> names on e.g. linux distributions - e.g. `libclang.so.2`. In such cases users
> are stuck between a rock and a hard place: using
>
Vote: Yes
On 19/03/2024 16:19, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
Per-Ake
On Thu, 21 Mar 2024 22:23:02 GMT, Maurizio Cimadamore
wrote:
> For this reason, the only thing that would make sense for `loadLibrary` to
> support is `clang` which will be expanded (by `mapLibraryName`) to
> `clang(libclang.so)`. But, even assuming this works: wouldn't we still have
> an
On Thu, 21 Mar 2024 22:23:02 GMT, Maurizio Cimadamore
wrote:
> > (I'm pessimistic)
>
> To summarize: I think that allowing version-specific names (even if
> surrounded by parenthesis) in `System::loadLibrary` would be very odd. After
> all, `System::loadLibrary` doesn't support versioned
On Thu, 21 Mar 2024 17:06:23 GMT, Jaikiran Pai wrote:
>>> But there is no actual file named libclang.a(libclang.so.16) in the
>>> filesystem.
>> So when the check is done if file exists, it fails,i.e it checks for
>> libclang.a(libclang.so.16).
>>
>> I'll let Mandy and others more
On Thu, 21 Mar 2024 20:29:16 GMT, Mandy Chung wrote:
> As @jaikiran suggests, `loadLibraryOnlyIfPresent()` should return false for
> AIX as the file does not exist. The library implementation may need to adjust
> as the current implementation uses a file path name.
Had kept it as true, as it
On Thu, 21 Mar 2024 23:38:30 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
On Fri, 22 Mar 2024 00:21:56 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/ImmutableCollections.java line 924:
>>
>>> 922: action.accept(REVERSE ? (E)e1 : e0); // implicit null
>>> check
>>> 923: action.accept(REVERSE ? e0 : (E)e1);
>>> 924:
On Fri, 22 Mar 2024 02:17:58 GMT, David Holmes wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge remote-tracking branch 'openjdk/master' into
>> JDK-8320396-verifier-extension
>> -
> ClassFile API `jdk.internal.classfile.verifier.VerifierImpl` performed only
> bytecode-level class verification.
> This patch adds `jdk.internal.classfile.verifier.ParserVerifier` with
> additional class checks inspired by
> `hotspot/share/classfile/classFileParser.cpp`.
>
> Also new
On Thu, 21 Mar 2024 14:40:37 GMT, Adam Sotona wrote:
>> ClassFile API `jdk.internal.classfile.verifier.VerifierImpl` performed only
>> bytecode-level class verification.
>> This patch adds `jdk.internal.classfile.verifier.ParserVerifier` with
>> additional class checks inspired by
>>
34 matches
Mail list logo
