Re: Overload window methods in Gatherers with step size

2024-03-25 Thread David Alayachew
I actually plan to follow through on that email. I just can't right now because of work emergencies. Literally as soon as those calm down, top of my list is to give Viktor the lost of code examples where I am using the windowBy Gatherer he gave me. On Mon, Mar 25, 2024, 6:24 PM wrote: > Hello,

Re: RFR: 8328812: Update and move siphash license

2024-03-25 Thread Bernd
On Mon, 25 Mar 2024 22:23:03 GMT, Jesper Wilhelmsson wrote: >> The problem is that the project is a joined work and has multiple variants >> of copyrights (see the readme). I don’t think it’s on the safe side to pick >> a single (non recent) copyright - especially if you change attribution

Re: RFR: 8328812: Update and move siphash license

2024-03-25 Thread Jesper Wilhelmsson
On Mon, 25 Mar 2024 20:40:50 GMT, Bernd wrote: >> That header only contains a single function declaration for an entry point >> into the implementation. >> HotSpot doesn't use that function, and doesn't have anything with a >> corresponding signature. So it's >> not in any way derived from

Overload window methods in Gatherers with step size

2024-03-25 Thread openjdk . ruwen . reddig
Hello, thanks for the amazing presentations during the Java 22 release stream. I highly appreciated the new JEP 461 (https://openjdk.org/jeps/461), especially the windowing functions windowFixed and windowSliding. I would like to propose to overload both methods, so they accept the step size

Re: RFR: 8328812: Update and move siphash license

2024-03-25 Thread Bernd
On Mon, 25 Mar 2024 20:34:06 GMT, Kim Barrett wrote: >> The header file contains more claims >> https://github.com/veorq/SipHash/blob/master/halfsiphash.h > > That header only contains a single function declaration for an entry point > into the implementation. > HotSpot doesn't use that

Re: RFR: 8328812: Update and move siphash license

2024-03-25 Thread Kim Barrett
On Mon, 25 Mar 2024 20:10:45 GMT, Bernd wrote: >> To match the license claim in the code we are using: >> https://github.com/openjdk/jdk/blob/fb8f2a0a929ebe7f65c69741712b89bbb403ade9/src/hotspot/share/classfile/altHashing.cpp#L32-L43 > > The header file contains more claims >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v16]

2024-03-25 Thread Brent Christian
On Mon, 25 Mar 2024 19:26:41 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8328812: Update and move siphash license

2024-03-25 Thread Bernd
On Mon, 25 Mar 2024 20:07:02 GMT, Kim Barrett wrote: >> src/hotspot/share/legal/siphash.md line 9: >> >>> 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson >>> 8: >>> 9:Copyright (c) 2012-2014 Daniel J. Bernstein >> >> Why would you remove a author or year range? > > To match the

Re: RFR: 8328812: Update and move siphash license

2024-03-25 Thread Kim Barrett
On Sun, 24 Mar 2024 17:24:49 GMT, Bernd wrote: >> Updated and moved the license file. > > src/hotspot/share/legal/siphash.md line 9: > >> 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson >> 8: >> 9:Copyright (c) 2012-2014 Daniel J. Bernstein > > Why would you remove a author or

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-25 Thread Mandy Chung
On Mon, 25 Mar 2024 18:56:21 GMT, Suchismith Roy wrote: > And it has been in J9 for long time for the exact same reason, which > actually brought out the issue for dcstartup in OpenJDK. dcstartup fails because it fails to load an agent library specified via `-agentlib:am_ibm_16` that was

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v15]

2024-03-25 Thread Brent Christian
On Fri, 22 Mar 2024 09:28:02 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Elaborate on 'surprising and undesirable effects' in reachabilityFence() > >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v16]

2024-03-25 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > -

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-25 Thread Suchismith Roy
On Mon, 25 Mar 2024 18:43:33 GMT, Mandy Chung wrote: > Do you expect if developers start to package shared objects in the format of > archive objects? If so, it would be reasonable to support #1 for > compatibility. Yes. I agree. We should keep this compatibility for entire flow from

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-25 Thread Mandy Chung
On Mon, 25 Mar 2024 09:46:50 GMT, Suchismith Roy wrote: >> Allow support for both .a and .so files in AIX. >> If .so file is not found, allow fallback to .a extension. >> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516) > > Suchismith Roy has updated the pull request

Re: RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket [v5]

2024-03-25 Thread Christoph Langer
On Mon, 4 Mar 2024 15:02:45 GMT, Aleksei Efimov wrote: >>> As for the test, I had a closer look now and I find it hard to separate >>> testing of [JDK-8314063](https://bugs.openjdk.org/browse/JDK-8314063) from >>> [JDK-8325579](https://bugs.openjdk.org/browse/JDK-8325579). Furthermore, >>>

Integrated: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

2024-03-25 Thread Christoph Langer
On Fri, 9 Feb 2024 21:29:28 GMT, Christoph Langer wrote: > During analysing a customer case I figured out that we have an inconsistency > between documentation and actual behavior in class > com.sun.jndi.ldap.Connection. The [method documentation of >

Re: RFR: JDK-8320448 Accelerate IndexOf using AVX2 [v15]

2024-03-25 Thread Scott Gibbons
> Re-write the IndexOf code without the use of the pcmpestri instruction, only > using AVX2 instructions. This change accelerates String.IndexOf on average > 1.3x for AVX2. The benchmark numbers: > > > BenchmarkScore > Latest

Re: RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment [v3]

2024-03-25 Thread Per Minborg
On Thu, 11 Jan 2024 16:21:38 GMT, Peter Levart wrote: >> I belive there is a bug in `AbstractMemorySegmentImpl#mismatch` method. It >> returns `-1` (meaning that regions are equal) when passing the same instance >> of MemorySegment as both `srcSegment` and `dstSegment` parameters regardless

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-25 Thread Suchismith Roy
> Allow support for both .a and .so files in AIX. > If .so file is not found, allow fallback to .a extension. > JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516) Suchismith Roy has updated the pull request incrementally with four additional commits since the last revision:

Integrated: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment

2024-03-25 Thread Per Minborg
On Thu, 21 Mar 2024 09:23:45 GMT, Per Minborg wrote: > This PR proposes to remove an old optimization check that was incorrect > making `AbstractMemorySegmentImpl::mismatch` always return `-1` if the source > and destination segment are the same (disregarding offsets). This pull request has

Integrated: 8328700: Unused import and variable should be deleted in regex package

2024-03-25 Thread Raffaello Giulietti
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti wrote: > Make use of an unused local variable probably intended to replace later casts. This pull request has now been integrated. Changeset: 19a0151a Author:Raffaello Giulietti URL: