On Fri, 12 Apr 2024 23:55:01 GMT, Joe Darcy wrote:
> Straightforward test update so it doesn't have to be trivially updated for
> each JDK version.
LGTM. Thanks for fixing this.
-
Marked as reviewed by mchung (Reviewer).
PR Review:
On Sat, 13 Apr 2024 00:40:45 GMT, Chen Liang wrote:
> Thanks for this fix. I recall that I had to add this flag because otherwise
> compileSources fails when `@enablePreview` is there. If we can drop the
> preview flag, that would be the best.
Thanks; I did a quick experiment and the test
On Fri, 12 Apr 2024 10:19:27 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
>> 1430:
>>
>>> 1428: cb.new_(STRING_BUILDER);
>>> 1429: cb.dup();
>>> 1430:
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this PR (on my MacBook, aarch64):
>
> Non-short-circuiting:
On Sat, 13 Apr 2024 09:20:17 GMT, Rémi Forax wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding additional, short-circuit-specific, cases to the FlatMap benchmark
>
> Hello, i will not pretend I fully
On Sat, 13 Apr 2024 09:04:36 GMT, Rémi Forax wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding additional, short-circuit-specific, cases to the FlatMap benchmark
>
>
On Fri, 12 Apr 2024 14:53:01 GMT, Viktor Klang wrote:
>> This PR implements Gatherer-inspired encoding of `flatMap` that shows that
>> it is both competitive performance-wise as well as improve correctness.
>>
>> Below is the performance of `Stream::flatMap` (for reference types):
>>
>>
On Fri, 12 Apr 2024 14:53:01 GMT, Viktor Klang wrote:
>> This PR implements Gatherer-inspired encoding of `flatMap` that shows that
>> it is both competitive performance-wise as well as improve correctness.
>>
>> Below is the performance of `Stream::flatMap` (for reference types):
>>
>>
On Fri, 12 Apr 2024 14:53:01 GMT, Viktor Klang wrote:
>> This PR implements Gatherer-inspired encoding of `flatMap` that shows that
>> it is both competitive performance-wise as well as improve correctness.
>>
>> Below is the performance of `Stream::flatMap` (for reference types):
>>
>>
