Can I please get a review of this copyright text only change which removes the
"Classpath" exception from the
`test/jdk/java/lang/ProcessBuilder/JspawnhelperWarnings.java` test file and
thus addresses https://bugs.openjdk.org/browse/JDK-8331514?
-
Commit messages:
- 8331514:
> API changes as discussed on the mailing list:
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-November/000419.html
>
> Additional questions:
> 1. Whether to rename `WildcardIndicator.DEFAULT` to `NONE`
Chen Liang has updated the pull request with a new target base due to a merge
On Wed, 1 May 2024 20:35:10 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
> Add two sample configuration files:
>
> jaxp-strict.properties: used to set strict configuration, stricter than
> jaxp.properties in previous versions such as JDK 22
>
> jaxp-compat.properties: used to regain compatibility from any more
> restricted configuration than previous versions
On Mon, 29 Apr 2024 11:31:23 GMT, Nizar Benalla wrote:
>> test/jdk/tools/sincechecker/SinceChecker.java line 423:
>>
>>> 421: }
>>> 422:
>>> 423: //these were preview in before the introduction of the
>>> @PreviewFeature
>>
>> Just curious: where do you find this information?
>
>
On Wed, 1 May 2024 20:53:08 GMT, Jonathan Gibbons wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release
On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote:
>> A new method on Instant to return the duration `until` another Instant is
>> suggested per the following discussion thread:
>>
>> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>>
>> A CSR has also been drafted.
>
On Wed, 1 May 2024 20:35:10 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Wed, 1 May 2024 20:27:19 GMT, Lance Andersen wrote:
>> test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 75:
>>
>>> 73: } catch (InvocationTargetException ex) {
>>> 74: Throwable rootEx = ex.getCause();
>>> 75: assertEquals(OutOfMemoryError.class,
> Please review this PR which converts _TestEncodingDecodingLength.java_ into a
> whitebox test which allows for testing to be done without memory usage issues.
>
> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
> arrays worth of memory. (2 for the initial array
On Wed, 1 May 2024 20:12:33 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 75:
>
>> 73: } catch
On Wed, 1 May 2024 18:52:06 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Wed, 1 May 2024 18:42:12 GMT, Weibing Xiao wrote:
>> nroff man page update for jar tool.
>> This update is caused by the change of
>> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
>> updated in other repos, the corresponding nroff man page was never updated
>>
On Wed, 1 May 2024 18:52:06 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Wed, 1 May 2024 16:40:31 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 47:
>
>> 45: public class
> Please review this PR which converts _TestEncodingDecodingLength.java_ into a
> whitebox test which allows for testing to be done without memory usage issues.
>
> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
> arrays worth of memory. (2 for the initial array
The issue reported a ClassCastException "cannot assign instance of
java.util.CollSer to field of type java.util.Map"
while deserializing an object referring to an immutable Map that contained a
reference to a class that was not available.
Immutable Collections such as Map utilize a serialization
On Wed, 1 May 2024 18:42:12 GMT, Weibing Xiao wrote:
>> nroff man page update for jar tool.
>> This update is caused by the change of
>> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
>> updated in other repos, the corresponding nroff man page was never updated
>>
On Tue, 30 Apr 2024 15:02:21 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class ConsoleTest {
>> public static void main(String... args) {
>> System.console().printf("Hello!");
>> }
>> }
>>
>>
>> When run as:
>>
>> $ java ConsoleTest.java >/dev/null
>>
>>
>>
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote:
> nroff man page update for jar tool.
> This update is caused by the change of
> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
> updated in other repos, the corresponding nroff man page was never updated in
>
> nroff man page update for jar tool.
> This update is caused by the change of
> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
> updated in other repos, the corresponding nroff man page was never updated in
> OpenJDK repos
Weibing Xiao has updated the pull request
On Mon, 29 Apr 2024 18:41:44 GMT, Naoto Sato wrote:
> Looks good to me. Left some minor suggestions. BTW, should we file an issue
> at the `JLine` project, not to redirect to stderr, or suggest a new config
> (sorry if it has already been taken care of)?
The code to choose the output stream
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote:
> nroff man page update for jar tool.
> This update is caused by the change of
> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
> updated in other repos, the corresponding nroff man page was never updated in
>
nroff man page update for jar tool.
This update is caused by the change of
https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
updated in other repos, the corresponding nroff man page was never updated in
OpenJDK repos
-
Commit messages:
- 8331077 : nroff
On Wed, 1 May 2024 16:10:06 GMT, Justin Lu wrote:
> Please review this PR which converts _TestEncodingDecodingLength.java_ into a
> whitebox test which allows for testing to be done without memory usage issues.
>
> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
>
On Wed, 1 May 2024 17:10:53 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/java.base/share/classes/java/io/ProxyingConsole.java line 89:
>
>> 87: @Override
>>
> A new method on Instant to return the duration `until` another Instant is
> suggested per the following discussion thread:
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>
> A CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with
On Mon, 29 Apr 2024 23:22:21 GMT, Naoto Sato wrote:
>> Proposing new overloaded methods in `java.io.Console` class that explicitly
>> take a `Locale` argument. Existing methods rely on the default locale, so
>> the users won't be able to format their prompts/outputs in a certain locale
>>
On Wed, 1 May 2024 14:54:02 GMT, Weibing Xiao wrote:
> nroff man page update for jar tool.
>
> This update is caused by the change of
> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
> updated in other repos, the corresponding nroff man page was never updated in
>
On Wed, 1 May 2024 16:15:12 GMT, Weibing Xiao wrote:
>> nroff man page update for jar tool.
>>
>> This update is caused by the change of
>> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
>> updated in other repos, the corresponding nroff man page was never updated
> nroff man page update for jar tool.
>
> This update is caused by the change of
> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
> updated in other repos, the corresponding nroff man page was never updated in
> OpenJDK repos
Weibing Xiao has updated the pull
Please review this PR which converts _TestEncodingDecodingLength.java_ into a
whitebox test which allows for testing to be done without memory usage issues.
Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte arrays
worth of memory. (2 for the initial array allocation, .75
On Tue, 30 Apr 2024 23:58:49 GMT, Alexey Semenyuk wrote:
> Rerun pandoc on updated source man page file
This pull request has now been integrated.
Changeset: e833bfc8
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/e833bfc8ac6104522d037e7eb300f5aa112688bb
Stats:
> nroff man page update for jar tool.
>
> This update is caused by the change of
> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
> updated in other repos, the corresponding nroff man page was never updated in
> OpenJDK repos
Weibing Xiao has updated the pull
nroff man page update for jar tool.
This update is caused by the change of
https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got
updated in other repos, the corresponding nroff man page was never updated in
OpenJDK repos
-
Commit messages:
- 8331077 : nroff
> Please review this trivial method rename. While this issue was originally
> spotted in [another PR], it makes sense to address it separately. Test
> results are pending; not that I expect failures, but still.
>
> [another PR]:
>
On Tue, 30 Apr 2024 14:38:11 GMT, Pavel Rappo wrote:
> Please review this trivial method rename. While this issue was originally
> spotted in [another PR], it makes sense to address it separately. Test
> results are pending; not that I expect failures, but still.
>
> [another PR]:
>
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
On Tue, 30 Apr 2024 14:38:11 GMT, Pavel Rappo wrote:
> Please review this trivial method rename. While this issue was originally
> spotted in [another PR], it makes sense to address it separately. Test
> results are pending; not that I expect failures, but still.
>
> [another PR]:
>
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
>
On Tue, 30 Apr 2024 19:41:54 GMT, Doug Lea wrote:
> The grammar rules prefer "that" because it is a restrictive clause, even
> though "which" might sound better. See for example:
> https://owl.purdue.edu/owl/general_writing/grammar/that_vs_which.html
Thanks for that link, Doug.
I understand
On Tue, 30 Apr 2024 14:38:11 GMT, Pavel Rappo wrote:
> Please review this trivial method rename. While this issue was originally
> spotted in [another PR], it makes sense to address it separately. Test
> results are pending; not that I expect failures, but still.
>
> [another PR]:
>
43 matches
Mail list logo
