On Wed, 22 May 2024 05:16:42 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change for addressing
> https://bugs.openjdk.org/browse/JDK-8332490?
>
> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
> then doesn't close the stream. This can
On Tue, 21 May 2024 21:16:52 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 78:
>>
>>> 76: String line = null;
>>> 77: synchronized (writeLock) {
>>> 78: synchronized(readLock) {
>>
>> Suggestion:
>>
>>
On Tue, 21 May 2024 15:44:18 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>>
On Tue, 19 Mar 2024 00:07:37 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
lly with one additional
> commit since the last revision:
>
> Delete extra space
>
> Co-authored-by: Andrey Turbanov
test/jdk/java/foreign/CallGeneratorHelper.java line 195:
> 193: }
> 194:
> 195: private static void generateStructDecl(PrintStream out,
&
On Tue, 12 Mar 2024 14:06:11 GMT, Aggelos Biboudis
wrote:
> In cases where the compiler needs to unbox a `long`, `float`, `double` and
> then run the exactness check, we were getting a crash. While the selector
> value is always boxed, the type (which controls the execution flow) was not,
>
On Mon, 11 Mar 2024 17:17:21 GMT, Joe Darcy wrote:
>> The atan2 and hypot cases added would fail for a particular test library
>> that has errors in the millions of ulps for those inputs, rather than the
>> small number of ulps specified for the error.
>
> Joe Darcy has updated the pull
On Wed, 6 Mar 2024 20:49:55 GMT, Joe Darcy wrote:
>> The atan2 and hypot cases added would fail for a particular test library
>> that has errors in the millions of ulps for those inputs, rather than the
>> small number of ulps specified for the error.
>
> Joe Darcy has updated the pull request
On Tue, 16 Jan 2024 10:19:44 GMT, Andrey Turbanov wrote:
> There are 3 methods in `java.util.TimeZone` which are `public static` and
> marked as `synchronized`:
> 1. getTimeZone(String)
> 2. getAvailableIDs(int)
> 3. getAvailableIDs()
>
> This means it is a bottle neck for
On Fri, 23 Feb 2024 21:24:10 GMT, Naoto Sato wrote:
> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The
> `COMPAT` locale data was introduced for applications' migratory purposes
> transitioning to `CLDR`. It is becoming a technical debt and now is the time
> to
On Thu, 15 Feb 2024 19:44:42 GMT, Justin Lu wrote:
> Please review this PR which handles an edge case pattern bug with
> ChoiceFormat.
>
>
> var d = new ChoiceFormat("0#foo|1#bar|baz|") // creates cFmt equivalent to
> "0.0#foo|1.0#bar|1.0#"
> d.format(1) // unexpectedly returns ""
>
>
>
On Tue, 13 Feb 2024 18:03:14 GMT, Dan Lutker wrote:
>> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
>> package and no coreutils executable as well as AmazonLinux 2023 that uses
>> `--enable-single-binary`
>
> Dan Lutker has updated the pull request incrementally
On Thu, 8 Feb 2024 13:18:41 GMT, Adam Sotona wrote:
> ClassFile API provides two sets of instructions implementations (bound and
> unbound).
> Unbound implementation of `IncrementInstruction::constant` returns invalid
> value.
> This bug discovered a hole in the ClassFile API test coverage.
>
On Fri, 2 Feb 2024 22:43:28 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
>> which adds MessageFormat pattern support for the following subformats:
>> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
>> intended to
On Wed, 17 Jan 2024 18:19:18 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/TimeZone.java line 629:
>>
>>> 627: */
>>> 628: public static String[] getAvailableIDs(int rawOffset) {
>>> 629: return ZoneInfo.getAvailableIDs(rawOffset);
>>
>> BTW can we call
On Tue, 16 Jan 2024 10:19:44 GMT, Andrey Turbanov wrote:
> 8291027: Some of TimeZone methods marked 'synchronized' unnecessarily
src/java.base/share/classes/java/util/TimeZone.java line 629:
> 627: */
> 628: public static String[] getAvailableIDs(int rawOffset) {
> 629:
8291027: Some of TimeZone methods marked 'synchronized' unnecessarily
-
Commit messages:
- 8291027: Some of TimeZone methods marked 'synchronized' unnecessarily
Changes: https://git.openjdk.org/jdk/pull/17441/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17441=00
Issue:
On Wed, 10 Jan 2024 13:39:52 GMT, Eirik Bjørsnøs wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data
On Thu, 11 Jan 2024 23:06:32 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Thu, 14 Dec 2023 04:00:58 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>>
On Tue, 2 Jan 2024 12:21:21 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is
On Tue, 9 Jan 2024 16:48:56 GMT, Jatin Bhateja wrote:
>> Hi,
>>
>> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2
>> only targets.
>> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
>> instruction set.
>> These are very frequently used APIs in
On Tue, 9 Jan 2024 13:30:58 GMT, Adam Sotona wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to
On Fri, 12 Jan 2024 15:06:01 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request incrementally with one additional
> commit since the last revision:
>
> timed offer
On Tue, 12 Dec 2023 15:45:47 GMT, Per Minborg wrote:
>> This PR proposes to change the specification for some methods that take
>> `long` offsets so that they will throw an `IllegalArgumentException` rather
>> than an `IndexOutOfBoundsException` for negative values.
>>
>> The PR also proposes
On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update symbol files to JDK 22 b26.
On Fri, 17 Nov 2023 18:46:57 GMT, Andrey Turbanov wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing trailing whitespace complaint
>
> src/java.base/share/classes/java/util/s
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the
A few classes in `jdk.internal.util.xml.impl` package have non-final fields
which could easily be marked `final`.
-
Commit messages:
- [PATCH] Make fields final in jdk.internal.util.xml.impl package
Changes: https://git.openjdk.org/jdk/pull/15691/files
Webrev:
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
This pull request has now been integrated.
Changeset: 6c5e15c1
Author:Andrey Turbanov
URL:
https://git.openjdk.o
On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing trailing whitespace complaint
On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing trailing whitespace complaint
On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing trailing whitespace complaint
On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing trailing whitespace complaint
On Fri, 17 Nov 2023 08:13:05 GMT, Per Minborg wrote:
>> src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java
>> line 48:
>>
>>> 46: public class CLDRCalendarDataProviderImpl extends
>>> CalendarDataProviderImpl {
>>> 47:
>>> 48: private static final Map firstDays =
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8316557: Make fields final in 'sun.util' package
"First Day&qu
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8316557: Make fields final in 'sun.util' package
rename 'fi
On Mon, 13 Nov 2023 11:40:27 GMT, Per Minborg wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316557: Make fields final in 'sun.util' package
>>
>> rename 'firstD
On Tue, 14 Nov 2023 16:35:53 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Unpacking the rethrown exceptions from
On Mon, 13 Nov 2023 07:24:24 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing further review feedback
On Mon, 13 Nov 2023 07:24:24 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing further review feedback
On Mon, 13 Nov 2023 07:24:24 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressing further review feedback
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Fri, 10 Nov 2023 07:19:42 GMT, Per Minborg wrote:
> This PR proposes to use unnamed variables now that they have become available
> in Java.
>
> There is also a cosmetic cleanup making a switch rake smaller and where
> variables are pre-calculated rather than spreading expressions around.
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
Can I get a review?
-
PR Comment: https://git.openjdk.org/jdk/pull/15736#issuecomment-1807066050
On Tue, 24 Oct 2023 15:09:57 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and
On Fri, 20 Oct 2023 02:29:15 GMT, Chen Liang wrote:
>> Please review a patch that renames `JavaLangAccess::xxNoRepl` to
>> `xxReportError` to explicitly indicate these APIs report encoding errors.
>>
>> The old "NoRepl" suffix presumably means "No Replacement", but it has been
>>
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
This pull request has now been integrated.
Changeset: 80bd22d0
Author: Andrey Turb
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
Anyone want to review? I will integrate tomorrow.
-
PR Comment: https://git.openjd
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Mon, 16 Oct 2023 05:07:42 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> Could I have a review of an enhancement that replaces the use of ASM with
>> the new Class-File API. This change only deals with bytecode that writes
>> event data into buffers. Bytecode transformations carried out by classes
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
@JoeWang-Java can I have a review, please?
-
PR Comment: https://git.openjdk.org
On Thu, 14 Sep 2023 21:30:39 GMT, Lance Andersen wrote:
>Joe is on holiday so please wait for his input as there are some additional
>constants that may also be removed.
BTW, Who is Joe?
-
PR Comment: https://git.openjdk.org/jdk/pull/15692#issuecomment-1737031055
On Mon, 25 Sep 2023 14:28:56 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 18 Sep 2023 14:41:14 GMT, Chen Liang wrote:
>> A few classes in `sun.util` package have non-final fields which could easily
>> be marked `final`.
>
> src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java line
> 71:
>
>> 69: private final class
On Wed, 20 Sep 2023 23:20:43 GMT, Justin Lu wrote:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote:
>> Please review this PR which restricts sub-classing of the internal calendar
>> system in sun.util.calendar to only the existing implementations. Drive by
>> cleanup included.
>>
>> As the implementation is long-standing and complete with
A few classes in `sun.util` package have non-final fields which could easily be
marked `final`.
-
Commit messages:
- [PATCH] Make fields final in 'sun.util' package
Changes: https://git.openjdk.org/jdk/pull/15736/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15736=00
On Fri, 15 Sep 2023 23:31:16 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanup existing typos
>
> src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java
> line 160:
>
>>
On Wed, 13 Sep 2023 20:15:09 GMT, Naoto Sato wrote:
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Consonant Break specified in
> the latest Unicode
On Mon, 21 Aug 2023 15:07:45 GMT, Andrey Turbanov wrote:
> These messages were used before
> [JDK-8248862](https://bugs.openjdk.org/browse/JDK-8248862)
This pull request has now been integrated.
Changeset: 14408bc8
Author:Andrey Turbanov
URL:
https://git.openjdk.org/jdk/
On Wed, 13 Sep 2023 20:21:20 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
On Wed, 13 Sep 2023 19:46:08 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
On Wed, 13 Sep 2023 17:52:13 GMT, Justin Lu wrote:
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale`
A field `short _Depth` in the
`jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
can be removed.
-
Commit messages:
- [PATCH] Remove unused field
jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element#_Depth
Changes:
On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen wrote:
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> -
On Mon, 11 Sep 2023 04:00:34 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess,
These messages were used before
[JDK-8248862](https://bugs.openjdk.org/browse/JDK-8248862)
-
Commit messages:
- [PATCH] Remove unused fields from ThreadLocalRandom
Changes: https://git.openjdk.org/jdk/pull/15363/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15363=00
On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung wrote:
> This reimplements
> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
> handles.
>
> This API currently generates the bytecode which fails the verification
> because `new C; invokespecial A()` where the given
On Wed, 29 Mar 2023 18:05:46 GMT, Brian Burkhalter wrote:
>> Modify the `Space` instances used for size comparison to be created with
>> total number of bytes derived from the Windows `diskFree` utility instead of
>> Cygwin’s `df`.
>
> Brian Burkhalter has updated the pull request
On Tue, 22 Aug 2023 12:22:54 GMT, Andrey Turbanov wrote:
> After [JDK-8245241](https://bugs.openjdk.org/browse/JDK-8245241), the field
> `sun.util.locale.provider.LocaleProviderAdapter#defaultLocaleProviderAdapter`
> is only written in `` and then is not used after.
> W
On Tue, 29 Aug 2023 15:31:03 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote:
>> In the JDK build we have various build tools that generate source code from
>> data files. For most of these tools, the source files are based on template
>> files, which already have copyright headers, but for some, the complete
>>
On Wed, 23 Aug 2023 16:41:23 GMT, Alan Bateman wrote:
> If yielding fails due to the pinning then VirtualThread.parkNanos parks on
> the carrier thread with the remaining time. The calculation of the remaining
> time needs to be replaced so that it obviously uses the difference between
> the
On Tue, 22 Aug 2023 06:57:23 GMT, Andrey Turbanov wrote:
> Field is unused since
> [JDK-8004698](https://bugs.openjdk.org/browse/JDK-8004698) -
> https://github.com/openjdk/jdk/commit/b29b4794613a2aca125c2a6e9f8ed1d0f01a4ce2#diff-2b6035b7134d61a89cfee1ad7bdc1bf21ce37421358375d6399de95
After [JDK-8245241](https://bugs.openjdk.org/browse/JDK-8245241), the field
`sun.util.locale.provider.LocaleProviderAdapter#defaultLocaleProviderAdapter`
is only written in `` and then is not used after.
We can remove it.
-
Commit messages:
- 8312521: Unused field
Field is unused since
[JDK-8004698](https://bugs.openjdk.org/browse/JDK-8004698) -
https://github.com/openjdk/jdk/commit/b29b4794613a2aca125c2a6e9f8ed1d0f01a4ce2#diff-2b6035b7134d61a89cfee1ad7bdc1bf21ce37421358375d6399de950c17c0c8e
-
Commit messages:
- [PATCH] Remove unused field
On Sat, 19 Aug 2023 02:15:06 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs
On Thu, 13 Jul 2023 08:57:05 GMT, Andrey Turbanov wrote:
> Made a few fields `final` in java.util.Scanner.
> Also made `digits`, `non0Digit`, `SIMPLE_GROUP_INDEX` as `static.`
This pull request has now been integrated.
Changeset: d27daf01
Author:Andrey Turbanov
URL:
On Tue, 15 Aug 2023 20:13:18 GMT, Andrey Turbanov wrote:
> A field `char mAttrIdx` in the `jdk.internal.util.xml.impl.Attrs` class is
> unused and can be removed.
This pull request has now been integrated.
Changeset: 249dc374
Author:Andrey Turbanov
URL:
https://git.openjdk.o
A field `char mAttrIdx` in the `jdk.internal.util.xml.impl.Attrs` class is
unused and can be removed.
-
Commit messages:
- [PATCH] Remove unused field jdk.internal.util.xml.impl.Attrs.mAttrIdx
Changes: https://git.openjdk.org/jdk/pull/15298/files
Webrev:
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java line 84:
> 82: Arguments.of("canonical", "%08x ", "%02x ", 16, "|", 31,
> HexPrinter.Formatters.PRINTABLE, "|" +
Made a few fields `final` in java.util.Scanner.
Also made `digits`, `non0Digit`, `SIMPLE_GROUP_INDEX` as `static.`
-
Commit messages:
- [PATHC] Make fields final in java.util.Scanner
Changes: https://git.openjdk.org/jdk/pull/14863/files
Webrev:
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math are used only once and can be replaced with
> literals `0x1p512`/`0x1p-512 `
This pull request has now been integrated.
Changeset: 41bdcded
Author:Andrey Turbanov
URL:
On Mon, 7 Aug 2023 19:44:48 GMT, Andrey Turbanov wrote:
>> Couple of static fields in Math are used only once and can be replaced with
>> literals `0x1p512`/`0x1p-512 `
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit si
On Tue, 8 Aug 2023 08:42:05 GMT, Raffaello Giulietti
wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313875: Make fields final in java.util.Math: twoToTheDoubleScaleUp,
&g
> Couple of static fields in Math are used only once and can be replaced with
> literals `0x1p512`/`0x1p-512 `
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8313875: Make fields final in java.util.Math: twoToTheDoubleS
On Mon, 7 Aug 2023 16:43:49 GMT, Raffaello Giulietti
wrote:
>> Couple of static fields in Math could be declared `final`.
>
> src/java.base/share/classes/java/lang/Math.java line 3425:
>
>> 3423: // Constants used in scalb
>> 3424: private static final double twoToTheDoubleScaleUp =
Couple of static fields in Math could be declared `final`.
-
Commit messages:
- [PATCH] Make fields final in java.util.Math: twoToTheDoubleScaleUp,
twoToTheDoubleScaleDown
Changes: https://git.openjdk.org/jdk/pull/14875/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14875=00
On Tue, 1 Aug 2023 06:29:28 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Fix typo
>
> Signed-off-by: Sidraya
On Tue, 18 Jul 2023 20:06:56 GMT, Andrey Turbanov wrote:
> Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`.
This pull request has now been integrated.
Changeset: f4ba7b21
Author: Andrey Turbanov
URL:
https://git.openjdk.org/jdk/com
Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`.
-
Commit messages:
- 8312414: Make java.util.ServiceLoader.LANG_ACCESS final
- [PATCH] Make java.util.ServiceLoader.LANG_ACCESS final
Changes: https://git.openjdk.org/jdk/pull/14926/files
Webrev:
On Thu, 13 Jul 2023 19:21:01 GMT, Doug Lea wrote:
>> This now uses Thread.isVirtual to distinguish spin vs immediate block cases,
>> enabling re-introduction of spin control from the previous version, removing
>> anomalies like this one.
>
> Doug Lea has updated the pull request with a new
On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu wrote:
> Please review this PR which refactors more java.util.Locale tests to JUnit
> with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNN to
> something more descriptive, this makes reviewing
On Sat, 3 Jun 2023 14:08:02 GMT, Doug Lea wrote:
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses
On Mon, 26 Jun 2023 13:51:25 GMT, Chen Liang wrote:
>> This patch touches java.lang.reflect and java.lang.invoke packages. It
>> replaces instanceof + cast with pattern matching and updates
>> Array.newInstance().getClass() patterns with arrayType() for obtaining array
>> types of a class.
>
On Sun, 25 Jun 2023 20:38:28 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
1 - 100 of 265 matches
Mail list logo
