Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]

2024-06-06 Thread Chris Hennick
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote: >> This provides a slightly more accurate bounding limit for >> `computeNextExponentialSoftCapped` when calling it from >> `computeNextGaussian`. This could cause the `while >> (computeNextExponentialSoftCapped(rng

Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]

2024-05-08 Thread Chris Hennick
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote: >> This provides a slightly more accurate bounding limit for >> `computeNextExponentialSoftCapped` when calling it from >> `computeNextGaussian`. This could cause the `while >> (computeNextExponentialSoftCapped(rng

Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]

2024-04-10 Thread Chris Hennick
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote: >> This provides a slightly more accurate bounding limit for >> `computeNextExponentialSoftCapped` when calling it from >> `computeNextGaussian`. This could cause the `while >> (computeNextExponentialSoftCapped(rng

Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]

2024-02-28 Thread Chris Hennick
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote: >> This provides a slightly more accurate bounding limit for >> `computeNextExponentialSoftCapped` when the computed bound is greater than >> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could ca

Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]

2024-02-21 Thread Chris Hennick
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote: >> This provides a slightly more accurate bounding limit for >> `computeNextExponentialSoftCapped` when the computed bound is greater than >> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could ca

Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results

2024-02-20 Thread Chris Hennick
On Tue, 20 Feb 2024 20:46:47 GMT, Joe Darcy wrote: >> This provides a slightly more accurate bounding limit for >> `computeNextExponentialSoftCapped` when the computed bound is greater than >> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the >> `while

Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]

2024-02-20 Thread Chris Hennick
; limit)` check in > `computeNextGaussian` on line 1402 to always be true, making the > `nextGaussian` runtime unbounded in the worst case. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Bug fix: add-exports was for wrong package -

Re: RFR: 8326227: Rounding error that may distort computeNextGaussian results [v2]

2024-02-20 Thread Chris Hennick
; limit)` check in > `computeNextGaussian` on line 1402 to always be true, making the > `nextGaussian` runtime unbounded in the worst case. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Tweak boundary cases and add unit test -

Re: RFR: 8326227: Fix a rare rounding error affecting RandomSupport::computeNextGaussian

2024-02-20 Thread Chris Hennick
On Mon, 5 Feb 2024 04:25:16 GMT, Chris Hennick wrote: > This provides a slightly more accurate bounding limit for > `computeNextExponentialSoftCapped` when the computed bound is greater than > `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the

RFR: 8326227: Fix a rare rounding error affecting RandomSupport::computeNextGaussian

2024-02-20 Thread Chris Hennick
This provides a slightly more accurate bounding limit for `computeNextExponentialSoftCapped` when the computed bound is greater than `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the `while (computeNextExponentialSoftCapped(rng, limit) < limit)` check in

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v22]

2023-07-17 Thread Chris Hennick
m going into the `nextExponential` tail twice. Chris Hennick has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits: - Merge branch 'openjdk:master' into patch-1 - Merge remote-tracking branch 'upstream/master' into patch-1 -

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v21]

2023-07-17 Thread Chris Hennick
On Fri, 14 Jul 2023 20:42:03 GMT, Joe Darcy wrote: >> @JimLaskey @jddarcy @turbanoff @rgiulietti Could this please be merged? > > @Pr0methean , please update your branch with the current contents of the > master before issuing the integrate command. Assuming that succeeds as > expected, myself

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v21]

2023-07-13 Thread Chris Hennick
On Mon, 15 May 2023 15:51:02 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v21]

2023-06-15 Thread Chris Hennick
On Mon, 15 May 2023 15:51:02 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v21]

2023-06-12 Thread Chris Hennick
On Mon, 15 May 2023 15:51:02 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v21]

2023-05-15 Thread Chris Hennick
m going into the `nextExponential` tail twice. Chris Hennick has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: - Merge remote-tracking branch 'upstream/master' into patch-1 - Merge remote-tracking branch 'origin/patch-1' i

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v19]

2023-05-12 Thread Chris Hennick
On Thu, 6 Apr 2023 18:07:29 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v20]

2023-05-12 Thread Chris Hennick
m going into the `nextExponential` tail twice. Chris Hennick has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/patch-1' into patch-1 - Optimize: move some code out of the fast path - Changes: - all

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v19]

2023-05-04 Thread Chris Hennick
On Thu, 6 Apr 2023 18:07:29 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v19]

2023-04-06 Thread Chris Hennick
m going into the `nextExponential` tail twice. Chris Hennick has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits: - Merge branch 'master' of https://git.openjdk.org/jdk into patch-1 - Merge branch 'master' of https://git.openjdk

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v18]

2023-03-31 Thread Chris Hennick
m going into the `nextExponential` tail twice. Chris Hennick has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Merge branch 'master' of https://git.openjdk.org/jdk into patch-1 - Merge branch 'master' into patch-1 - Updat

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v17]

2023-03-22 Thread Chris Hennick
m going into the `nextExponential` tail twice. Chris Hennick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last rev

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v16]

2023-03-22 Thread Chris Hennick
On Wed, 22 Mar 2023 19:23:37 GMT, Eirik Bjorsnos wrote: >> Chris Hennick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add parameter to enable/disable fixed PRNG seed > > Chris, copyrights in your new (20

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v16]

2023-03-22 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v16]

2023-02-18 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v16]

2023-01-19 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v16]

2023-01-15 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v16]

2022-12-17 Thread Chris Hennick
On Wed, 7 Dec 2022 20:25:53 GMT, Xin Liu wrote: >> It's probably just a statistical fluke involving a very large return value, >> but to know for sure I'd need a way to gather statistics about the return >> values and how they correlate with running-time outliers. > >> It's probably just a

Re: RFR: 8284493: Improve computeNextExponential tail performance and accuracy [v16]

2022-12-02 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the worst-case performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >>

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v16]

2022-12-01 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding DoubleZiggura

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v16]

2022-12-01 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding DoubleZiggura

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v16]

2022-11-29 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding DoubleZiggura

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v16]

2022-11-01 Thread Chris Hennick
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote: >> This PR improves both the performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding DoubleZiggura

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v16]

2022-10-04 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Add parameter to enable/disable fixed PRNG seed - Changes: - all: https://git.openjdk.org/jdk/pull/8131

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v15]

2022-10-04 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional comm

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v14]

2022-10-03 Thread Chris Hennick
On Sun, 19 Jun 2022 23:38:36 GMT, Chris Hennick wrote: >> This PR improves both the performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding Doub

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v14]

2022-09-19 Thread Chris Hennick
On Sun, 19 Jun 2022 23:38:36 GMT, Chris Hennick wrote: >> This PR improves both the performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding Doub

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v14]

2022-08-16 Thread Chris Hennick
On Sun, 19 Jun 2022 23:38:36 GMT, Chris Hennick wrote: >> This PR improves both the performance of `nextExponential` and >> `nextGaussian` and the distribution of output at the tails. It fixes the >> following imperfections: >> >> * Repeatedly adding Doub

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v14]

2022-06-19 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Rewrite Javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/8131/files - new: https://git.op

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v13]

2022-06-19 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Simplify Javadoc description - Changes: - all: https://git.openjdk.org/jdk/pull/8131/files - new: http

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v12]

2022-06-19 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Weaken contract of computeWinsorizedNextExponential to save max/min calls - Changes: - all: https://gi

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v10]

2022-06-18 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new c

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v9]

2022-06-18 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: More sensible benchmark-mode settings - Changes: - all: https://git.openjdk.org/jdk/pull/8131/files -

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v8]

2022-06-18 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Bugfix: need a thread-local instance for throughput test - Changes: - all: https://git.openjdk.org/jdk/

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v7]

2022-06-18 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new co

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v6]

2022-06-18 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Split out PRNG benchmarks into org.openjdk.bench.java.util.random - Changes: - all: https://gi

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v5]

2022-06-18 Thread Chris Hennick
extGaussian` suffers from *two* tail > cases of `nextExponential`. Chris Hennick has updated the pull request incrementally with one additional commit since the last revision: Add JMH - Changes: - all: https://git.openjdk.org/jdk/pull/8131/files - new: https://git.openjdk.org